René's URL Explorer Experiment


Title: Fix `bm_fastapi` benchmark failing with `httpx.PoolTimeout` under load by sendaoYan · Pull Request #509 · python/pyperformance · GitHub

Open Graph Title: Fix `bm_fastapi` benchmark failing with `httpx.PoolTimeout` under load by sendaoYan · Pull Request #509 · python/pyperformance

X Title: Fix `bm_fastapi` benchmark failing with `httpx.PoolTimeout` under load by sendaoYan · Pull Request #509 · python/pyperformance

Description: Fixes #508 Problem The fastapi benchmark (bm_fastapi) intermittently fails with httpx.PoolTimeout when the machine running the benchmark is under heavy load. The benchmark fires CONCURRENCY = 150 concurrent requests, but the httpx.AsyncClient uses httpx's default max_connections = 100. The 50 requests that exceed the pool size wait in the pool's queue for a connection to free up. httpx's default pool timeout is 5 seconds, so when the in-flight requests take longer than 5 seconds (which is exactly what happens under load), those 50 queued requests exceed the pool timeout and the benchmark dies: httpx.PoolTimeout RuntimeError: Benchmark died ERROR: Benchmark fastapi failed: Benchmark died Fix Size the connection pool to the benchmark's concurrency so that no request ever queues: - async with httpx.AsyncClient(trust_env=False) as client: + limits = httpx.Limits(max_connections=CONCURRENCY) + async with httpx.AsyncClient(limits=limits, trust_env=False) as client: With the pool sized to CONCURRENCY, all 150 requests acquire a connection immediately, so the pool timeout can never be hit regardless of server latency. This builds on the trust_env=False change from #505 and keeps it Testing Reproduced deterministically by serving the endpoint with an artificial ~6s per-request delay and firing 150 concurrent requests: Before: default pool (100 connections) → httpx.PoolTimeout after ~5.1s After: max_connections=150 → completes successfully (~7.1s) No behavior change in the common case: the benchmark's concurrency is a fixed constant, so the pool is simply sized to match it.

Open Graph Description: Fixes #508 Problem The fastapi benchmark (bm_fastapi) intermittently fails with httpx.PoolTimeout when the machine running the benchmark is under heavy load. The benchmark fires CONCURRENCY = 150 c...

X Description: Fixes #508 Problem The fastapi benchmark (bm_fastapi) intermittently fails with httpx.PoolTimeout when the machine running the benchmark is under heavy load. The benchmark fires CONCURRENCY = 150 c...

Opengraph URL: https://github.com/python/pyperformance/pull/509

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ce354fe9-38d6-fb90-b8c4-7ca56369e4a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD0E8:10531B:29D4CF7:35855BC:6B01EC62
html-safe-noncef86cfa87cd1ad0256ca064a94f58883da9b5b5a7041da8f8507b27e42f2d892d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEU4OjEwNTMxQjoyOUQ0Q0Y3OjM1ODU1QkM6NkIwMUVDNjIiLCJ2aXNpdG9yX2lkIjoiODUwNDUyMjQ5MDQ0MDE4Mjg4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbecd7147017ab5b767cc9760bc38109f5cba45ad2f544efe1e7bc8b8e399140d
hovercard-subject-tagpull_request:5220149612
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/pyperformance/pull/509/files
twitter:imagehttps://avatars.githubusercontent.com/u/24123821?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24123821?s=400&v=4
og:image:altFixes #508 Problem The fastapi benchmark (bm_fastapi) intermittently fails with httpx.PoolTimeout when the machine running the benchmark is under heavy load. The benchmark fires CONCURRENCY = 150 c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/pyperformance git https://github.com/python/pyperformance.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id65949828
octolytics-dimension-repository_nwopython/pyperformance
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id65949828
octolytics-dimension-repository_network_root_nwopython/pyperformance
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/pyperformance/pull/509/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fpyperformance%2Fpull%2F509%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fpyperformance%2Fpull%2F509%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fpyperformance
Reloadhttps://github.com/python/pyperformance/pull/509/files
Reloadhttps://github.com/python/pyperformance/pull/509/files
Reloadhttps://github.com/python/pyperformance/pull/509/files
pythonhttps://github.com/python
pyperformancehttps://github.com/python/pyperformance
Codehttps://github.com/python/pyperformance
Issues53 (53)https://github.com/python/pyperformance/issues
Pull requests34 (34)https://github.com/python/pyperformance/pulls
Actionshttps://github.com/python/pyperformance/actions
Projectshttps://github.com/python/pyperformance/projects
Security and qualityhttps://github.com/python/pyperformance/security
Insightshttps://github.com/python/pyperformance/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fpyperformance%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fpyperformance%2Fissues%2Fnew%2Fchoose
sendaoYanhttps://github.com/sendaoYan
python:mainhttps://github.com/python/pyperformance/tree/main
sendaoYan:fix-fastapi-pool-timeouthttps://github.com/sendaoYan/pyperformance-ysd/tree/fix-fastapi-pool-timeout
Conversation 3 https://github.com/python/pyperformance/pull/509
Commits 1 https://github.com/python/pyperformance/pull/509/commits
Checks 19 https://github.com/python/pyperformance/pull/509/checks
Files changed 1 https://github.com/python/pyperformance/pull/509/files
Fix bm_fastapi benchmark failing with httpx.PoolTimeout under load https://github.com/python/pyperformance/pull/509/files#top
Show all changes 1 commit https://github.com/python/pyperformance/pull/509/files
1863b12 Fix bm_fastapi benchmark failing with httpx.PoolTimeout under load sendaoYan Nov 6, 2026 https://github.com/python/pyperformance/pull/509/commits/1863b12c5aa95508b0c6c1d4e462cac970b494a9
Clear filters https://github.com/python/pyperformance/pull/509/files
Please reload this pagehttps://github.com/python/pyperformance/pull/509/files
Please reload this pagehttps://github.com/python/pyperformance/pull/509/files
pyperformance/data-files/benchmarks/bm_fastapi/run_benchmark.pyhttps://github.com/python/pyperformance/pull/509/files#diff-69929ca712583806422c053bde2bf98eef8b5a03dd9088996fc50091ac530854
View file https://github.com/python/pyperformance/blob/1863b12c5aa95508b0c6c1d4e462cac970b494a9/pyperformance/data-files/benchmarks/bm_fastapi/run_benchmark.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/pyperformance/pull/509/{{ revealButtonHref }}
https://github.com/python/pyperformance/pull/509/files#diff-69929ca712583806422c053bde2bf98eef8b5a03dd9088996fc50091ac530854
savannahostrowskihttps://github.com/savannahostrowski
Nov 21, 2026https://github.com/python/pyperformance/pull/509/files#r4653999612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/pyperformance/pull/509/files
https://github.com/python/pyperformance/pull/509/files#diff-69929ca712583806422c053bde2bf98eef8b5a03dd9088996fc50091ac530854
Please reload this pagehttps://github.com/python/pyperformance/pull/509/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.