Title: Add io_whole_file benchmark and an opt-in io group by jayzuccarelli · Pull Request #498 · python/pyperformance · GitHub
Open Graph Title: Add io_whole_file benchmark and an opt-in io group by jayzuccarelli · Pull Request #498 · python/pyperformance
X Title: Add io_whole_file benchmark and an opt-in io group by jayzuccarelli · Pull Request #498 · python/pyperformance
Description: First of three PRs for #399, one benchmark each as suggested there. This one adds the shared piece (an io group that is not part of default) together with the first benchmark that uses it. What it measures io_whole_file reads and writes a whole file in a single call, which is the pattern gh-120754 optimized: Each result measures a single API: read_bytes_{4k,1m}: open(path, "rb").read() write_bytes_{4k,1m}: open(path, "wb").write(data) read_text_1m / write_text_1m: Path.read_text() / Path.write_text(), utf-8, ASCII content read_bytes_{4k,1m}_uncached: open(path, "rb").read() with the file's pages dropped from the page cache first Path.read_bytes() / write_bytes() are thin wrappers over the same open() calls, so they are not measured separately. 8 results on Linux (6 where os.posix_fadvise is missing). 4 KiB is where per-call overhead and the number of system calls dominate; 1 MiB is where buffer allocation and copying dominate. I had an 8 MiB size too, but it scaled linearly from 1 MiB and sits closer to dirty page throttling, so I dropped it to keep the result count small. Apart from the uncached reads below, everything runs in a fresh temp dir with a warm page cache and no fsync, so it measures Python's I/O stack and syscall overhead rather than the disk. Writes always create a new file (unlinked outside the timed region): truncating and rewriting an existing file on ext4 triggers writeback on close (auto_da_alloc), which made a 16 MiB rewrite take ~490 ms +- 220 ms instead of ~30 ms. The run records io.DEFAULT_BUFFER_SIZE in the metadata. Uncached reads: read_bytes_{4k,1m}_uncached time the same open(path, "rb").read() with the file's pages dropped from the page cache before each read (os.posix_fadvise(fd, 0, 0, POSIX_FADV_DONTNEED), outside the timed region; the file is fsync'ed once in setup since DONTNEED only drops clean pages, no root needed). fincore shows 0 resident pages after every drop. On a SATA SSD (ext4, 3.14) 4 KiB goes from ~17 us cached to ~204 us uncached and 1 MiB from ~148 us to ~3.4 ms. They mostly track the storage device, so they are noisier and named apart from the cached results. They are skipped where os.posix_fadvise is missing (macOS, Windows; macOS F_NOCACHE doesn't evict already-cached pages). Writes stay cached only, since an uncached write needs an fsync in the timed region, which measures the device's flush path rather than Python. Large files are left for a follow-up. Setup allocates and frees one 8 MiB block before anything is measured. On glibc that raises malloc's dynamic mmap/trim thresholds above the 1 MiB working set; without it read_text_1m (which frees two 1 MiB blocks per call) sat right at the trim threshold and, depending on heap history, flipped between ~430 us and ~1.3 ms on the same interpreter because the heap top was handed back to the kernel and faulted in again every call. Why opt-in Per the issue, I/O benchmarks shouldn't run by default. The benchmark is tagged io, [group io] picks it up through the tag, and [group default] excludes it by name (a -io group exclusion is silently ignored by the manifest parser, so it has to name the benchmark). pyperformance list is unchanged at 100 benchmarks; -b io selects it. Sample timings (pyperformance run -b io_whole_file --fast, one untuned Linux box, ext4 /tmp) result 3.13.13 3.14.4 io_whole_file_read_bytes_4k 15.6 us 13.8 us io_whole_file_write_bytes_4k 34.0 us 34.2 us io_whole_file_read_bytes_1m 153 us 148 us io_whole_file_write_bytes_1m 912 us 916 us io_whole_file_read_text_1m 437 us 501 us io_whole_file_write_text_1m 1.15 ms 1.12 ms How to run python -m pyperformance run -b io python -m pyperformance run -b io_whole_file Tests python -m pyperformance.tests passes (it runs -b all, so the io benchmarks execute there too) pyperformance list unchanged at 100, list -b io is just io_whole_file flake8 with the tox config is clean on the new file uncached skip path checked with os.posix_fadvise removed (6 cached results, no crash) No version bump: 1.14.0 is already tagged, so the changelog line goes under a new 1.15.0 heading. Happy to bump __version__ too if you want that in the same PR, as #447 did. Part of #399. AI disclosure: I used Claude Code to write the benchmark and docs; I reviewed the code and ran it.
Open Graph Description: First of three PRs for #399, one benchmark each as suggested there. This one adds the shared piece (an io group that is not part of default) together with the first benchmark that uses it. What it ...
X Description: First of three PRs for #399, one benchmark each as suggested there. This one adds the shared piece (an io group that is not part of default) together with the first benchmark that uses it. What it ...
Opengraph URL: https://github.com/python/pyperformance/pull/498
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:43dc83a6-db2c-7081-a8c2-09b5cf60e562 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CFDC:154D88:2AA2CFA:368BE52:6B01EC5C |
| html-safe-nonce | eaebfc7300bde1a8aa365ab589d65ce1b83af0d8a8e4c4cd244289e183df8a1a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkRDOjE1NEQ4ODoyQUEyQ0ZBOjM2OEJFNTI6NkIwMUVDNUMiLCJ2aXNpdG9yX2lkIjoiNjk0Njc4NTI2NDMyNDk2MzQyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | aa183fcf5c15a7343e81c1dc7989b4b06f6075c1556f530c2df93362cb239672 |
| hovercard-subject-tag | pull_request:5033390959 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/pyperformance/pull/498/files |
| twitter:image | https://avatars.githubusercontent.com/u/11176606?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/11176606?s=400&v=4 |
| og:image:alt | First of three PRs for #399, one benchmark each as suggested there. This one adds the shared piece (an io group that is not part of default) together with the first benchmark that uses it. What it ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/pyperformance git https://github.com/python/pyperformance.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 65949828 |
| octolytics-dimension-repository_nwo | python/pyperformance |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 65949828 |
| octolytics-dimension-repository_network_root_nwo | python/pyperformance |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width