| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d312512f-d502-bc56-1a2c-cc211eceb669 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F66:215A88:4038A9:5A4F26:696A2057 |
| html-safe-nonce | 49213e70cd615d12463d9564b4a479830cdd80bff89f0c48d09b2e636e17d3b8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjY2OjIxNUE4ODo0MDM4QTk6NUE0RjI2OjY5NkEyMDU3IiwidmlzaXRvcl9pZCI6IjU0NDc2MDU5MjU5NzY1NTYzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1180c1fb68651c6476c3180cd3f5830873cfa81bf413f3546e7ebef993e64582 |
| hovercard-subject-tag | pull_request:1335558257 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/pyperformance/286/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b6be00fc47a299879146c4f01a0d51229e2f5e03c3cf53f3326176b890357798/python/pyperformance/pull/286 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b6be00fc47a299879146c4f01a0d51229e2f5e03c3cf53f3326176b890357798/python/pyperformance/pull/286 |
| og:image:alt | Work towards #282.
Adding type hints without validating them with a type checker is a bad idea, because the type hints can quickly go out of date with the source code they're describing. This P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AlexWaygood |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/pyperformance git https://github.com/python/pyperformance.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 65949828 |
| octolytics-dimension-repository_nwo | python/pyperformance |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 65949828 |
| octolytics-dimension-repository_network_root_nwo | python/pyperformance |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/pyperformance/pull/286#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fpyperformance%2Fpull%2F286 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fpyperformance%2Fpull%2F286 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fpyperformance |
| Reload | https://github.com/python/pyperformance/pull/286 |
| Reload | https://github.com/python/pyperformance/pull/286 |
| Reload | https://github.com/python/pyperformance/pull/286 |
|
python
| https://github.com/python |
| pyperformance | https://github.com/python/pyperformance |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fpyperformance |
|
Fork
200
| https://github.com/login?return_to=%2Fpython%2Fpyperformance |
|
Star
974
| https://github.com/login?return_to=%2Fpython%2Fpyperformance |
|
Code
| https://github.com/python/pyperformance |
|
Issues
45
| https://github.com/python/pyperformance/issues |
|
Pull requests
25
| https://github.com/python/pyperformance/pulls |
|
Actions
| https://github.com/python/pyperformance/actions |
|
Projects
0
| https://github.com/python/pyperformance/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/pyperformance/security |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
|
Insights
| https://github.com/python/pyperformance/pulse |
|
Code
| https://github.com/python/pyperformance |
|
Issues
| https://github.com/python/pyperformance/issues |
|
Pull requests
| https://github.com/python/pyperformance/pulls |
|
Actions
| https://github.com/python/pyperformance/actions |
|
Projects
| https://github.com/python/pyperformance/projects |
|
Security
| https://github.com/python/pyperformance/security |
|
Insights
| https://github.com/python/pyperformance/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fpyperformance%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fpyperformance%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/pyperformance/pull/286#issue-comment-box |
| AlexWaygood | https://github.com/AlexWaygood |
| python:main | https://github.com/python/pyperformance/tree/main |
| AlexWaygood:mypy | https://github.com/AlexWaygood/pyperformance/tree/mypy |
|
Add mypy config; run mypy in CI
| https://github.com/python/pyperformance/pull/286#top |
| AlexWaygood | https://github.com/AlexWaygood |
| python:main | https://github.com/python/pyperformance/tree/main |
| AlexWaygood:mypy | https://github.com/AlexWaygood/pyperformance/tree/mypy |
|
Conversation
7
| https://github.com/python/pyperformance/pull/286 |
|
Commits
2
| https://github.com/python/pyperformance/pull/286/commits |
|
Checks
0
| https://github.com/python/pyperformance/pull/286/checks |
|
Files changed
5
| https://github.com/python/pyperformance/pull/286/files |
| https://github.co/hiddenchars |
| https://github.com/python/pyperformance/pull/{{ revealButtonHref }} |
|
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| May 2, 2023 | https://github.com/python/pyperformance/pull/286#issue-1692779768 |
| #282 | https://github.com/python/pyperformance/issues/282 |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
|
| https://github.com/AlexWaygood |
| Add mypy config; run mypy in CI | https://github.com/python/pyperformance/pull/286/commits/f7a222f22c8f4a8054434bce5142854569d79b2d |
| f7a222f | https://github.com/python/pyperformance/pull/286/commits/f7a222f22c8f4a8054434bce5142854569d79b2d |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
May 2, 2023
| https://github.com/python/pyperformance/pull/286#pullrequestreview-1409522939 |
|
View reviewed changes
| https://github.com/python/pyperformance/pull/286/files/f7a222f22c8f4a8054434bce5142854569d79b2d |
| pyproject.toml | https://github.com/python/pyperformance/pull/286/files/f7a222f22c8f4a8054434bce5142854569d79b2d#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| AlexWaygood | https://github.com/AlexWaygood |
| May 2, 2023 | https://github.com/python/pyperformance/pull/286#discussion_r1182821496 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| pyproject.toml | https://github.com/python/pyperformance/pull/286/files/f7a222f22c8f4a8054434bce5142854569d79b2d#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| AlexWaygood | https://github.com/AlexWaygood |
| May 2, 2023 | https://github.com/python/pyperformance/pull/286#discussion_r1182822109 |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| pyproject.toml | https://github.com/python/pyperformance/pull/286/files/f7a222f22c8f4a8054434bce5142854569d79b2d#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| AlexWaygood | https://github.com/AlexWaygood |
| May 2, 2023 | https://github.com/python/pyperformance/pull/286#discussion_r1182823041 |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| pyproject.toml | https://github.com/python/pyperformance/pull/286/files/f7a222f22c8f4a8054434bce5142854569d79b2d#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| AlexWaygood | https://github.com/AlexWaygood |
| May 2, 2023 | https://github.com/python/pyperformance/pull/286#discussion_r1182823615 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
May 4, 2023
| https://github.com/python/pyperformance/pull/286#ref-pullrequest-1691042810 |
|
WIP: Typed Agument Clinic
erlend-aasland/cpython#44
| https://github.com/erlend-aasland/cpython/pull/44 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
May 4, 2023
| https://github.com/python/pyperformance/pull/286#pullrequestreview-1413769260 |
|
View reviewed changes
| https://github.com/python/pyperformance/pull/286/files/f7a222f22c8f4a8054434bce5142854569d79b2d |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/pyperformance/pull/286#pullrequestreview-1413769260 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://mypy.readthedocs.io/en/latest/existing_code.html#introduce-stricter-options | https://mypy.readthedocs.io/en/latest/existing_code.html#introduce-stricter-options |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| May 5, 2023 | https://github.com/python/pyperformance/pull/286#issuecomment-1536181868 |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| https://mypy.readthedocs.io/en/latest/existing_code.html#introduce-stricter-options | https://mypy.readthedocs.io/en/latest/existing_code.html#introduce-stricter-options |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
|
| https://github.com/AlexWaygood |
| Add --strict-concatenate | https://github.com/python/pyperformance/pull/286/commits/7d9b5f7bbc8257408be77fec63c86597810307af |
| 7d9b5f7 | https://github.com/python/pyperformance/pull/286/commits/7d9b5f7bbc8257408be77fec63c86597810307af |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
May 5, 2023
| https://github.com/python/pyperformance/pull/286#pullrequestreview-1414691815 |
|
View reviewed changes
| https://github.com/python/pyperformance/pull/286/files/7d9b5f7bbc8257408be77fec63c86597810307af |
| pyproject.toml | https://github.com/python/pyperformance/pull/286/files/7d9b5f7bbc8257408be77fec63c86597810307af#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| AlexWaygood | https://github.com/AlexWaygood |
| May 5, 2023 | https://github.com/python/pyperformance/pull/286#discussion_r1186032038 |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| 4bf984d | https://github.com/python/pyperformance/commit/4bf984d529a19ff3c8c82b477274960f405882d2 |
| May 10, 2023 | https://github.com/python/pyperformance/pull/286#event-9210794580 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| May 10, 2023 11:53 | https://github.com/python/pyperformance/pull/286#event-9210795133 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fpyperformance%2Fpull%2F286 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/pyperformance/pull/286/files/f7a222f22c8f4a8054434bce5142854569d79b2d |
| Please reload this page | https://github.com/python/pyperformance/pull/286 |
|
| https://github.com/AlexWaygood |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |