Title: Multiple pyperformance tests are incompatible with Python 3.9 · Issue #74 · python/pyperformance · GitHub
Open Graph Title: Multiple pyperformance tests are incompatible with Python 3.9 · Issue #74 · python/pyperformance
X Title: Multiple pyperformance tests are incompatible with Python 3.9 · Issue #74 · python/pyperformance
Description: Changes in Python 3.9 break html5lib, django_template, and tornado_http tests with this error: File "/usr/local/src/pyperf-tot-no-venv/lib/python3.9/site-packages/html5lib/_tokenizer.py", line 16, in
Open Graph Description: Changes in Python 3.9 break html5lib, django_template, and tornado_http tests with this error: File "/usr/local/src/pyperf-tot-no-venv/lib/python3.9/site-packages/html5lib/_tokenizer.py", line 16, ...
X Description: Changes in Python 3.9 break html5lib, django_template, and tornado_http tests with this error: File "/usr/local/src/pyperf-tot-no-venv/lib/python3.9/site-packages/html5lib/_tokenizer.py",...
Opengraph URL: https://github.com/python/pyperformance/issues/74
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Multiple pyperformance tests are incompatible with Python 3.9","articleBody":"Changes in Python 3.9 break html5lib, django_template, and tornado_http tests with this error:\r\n\r\n`File \"/usr/local/src/pyperf-tot-no-venv/lib/python3.9/site-packages/html5lib/_tokenizer.py\", line 16, in \u003cmodule>\r\n from ._trie import Trie\r\n File \"/usr/local/src/pyperf-tot-no-venv/lib/python3.9/site-packages/html5lib/_trie/__init__.py\", line 3, in \u003cmodule>\r\n from .py import Trie as PyTrie\r\n File \"/usr/local/src/pyperf-tot-no-venv/lib/python3.9/site-packages/html5lib/_trie/py.py\", line 6, in \u003cmodule>\r\n from ._base import Trie as ABCTrie\r\n File \"/usr/local/src/pyperf-tot-no-venv/lib/python3.9/site-packages/html5lib/_trie/_base.py\", line 3, in \u003cmodule>\r\n from collections import Mapping\r\nImportError: cannot import name 'Mapping' from 'collections' (/root/py3-tot-no/lib/python3.9/collections/__init__.py)\r\nERROR: Benchmark html5lib failed: Benchmark died`\r\n\r\n**How to reproduce the issue**\r\n\r\nI've been building Python 3 from source and encountered it through the standard build process.\r\n\r\n1. Build Python from source. I produced with git commit befa032d8869e0fab4732d910f3887642879d644 from cpython GitHub.\r\n\r\n2. Run pyperformance with one of the following parameter sets: \r\n\r\n/py3buildpath/bin/pyperformance run --python=/py3buildpath/bin/python3 --venv venvpath -b html5lib -o output.json\r\n\r\n/py3buildpath/bin/pyperformance run --python=/py3buildpath/bin/python3 --venv venvpath -b django_template -o output.json\r\n\r\n/py3buildpath/bin/pyperformance run --python=/py3buildpath/bin/python3 --venv venvpath -b tornado_http -o output.json\r\n\r\n3. Error message is shown.\r\n\r\n**What you expected to happen**\r\n\r\nI expected these pyperformance benchmark to complete successfully and produce a result (without error).\r\n\r\n**What actually happens**\r\n\r\nBenchmark dies trying to import from collections.\r\n\r\nI believe with Python 3.9 these packages need to be directly imported from collections.abc. \r\n\r\nSee this commit: [https://github.com/python/cpython/commit/ef092fe9905f61ca27889092ca1248a11aa74498](https://github.com/python/cpython/commit/ef092fe9905f61ca27889092ca1248a11aa74498)\r\n\r\nHere's a patch that was backported to the Python 3 vendored library: [https://github.com/pypa/pip/commit/ef7ca1472c1fdd085cffb8183b7ce8abbe9e2800#diff-2496ad1eedee846e323ed2916d6c2d24](https://github.com/pypa/pip/commit/ef7ca1472c1fdd085cffb8183b7ce8abbe9e2800#diff-2496ad1eedee846e323ed2916d6c2d24)\r\n\r\nThis library probably needs an official release so that the vendored patch set in Python 3 doesn't become bloated. \r\n\r\n","author":{"url":"https://github.com/TravisLazar","@type":"Person","name":"TravisLazar"},"datePublished":"2019-11-13T18:49:39Z","url":"https://github.com/python/pyperformance/issues/74"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5863485b-e348-0957-4328-28bb67ce5f53 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9B48:2AAD2E:35794A6:4757FE2:6B02095A |
| html-safe-nonce | 8c5f5eec37ae90f4a7033d0eb034818329d1a1b7257ecd9937c5517a73e4b13c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjQ4OjJBQUQyRTozNTc5NEE2OjQ3NTdGRTI6NkIwMjA5NUEiLCJ2aXNpdG9yX2lkIjoiNzg5MTEwMjE3MDE2NTE1MjA5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 18ef2f78b55e8d67ae364cfe8f91a65f339473a86d9c4228bc2362721abc08b2 |
| hovercard-subject-tag | issue:522405970 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/pyperformance/74/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bad34d239381b3c4092c2b3093ade9cab61ad0674fd170d4e867215ecc2d3197/python/pyperformance/issues/74 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bad34d239381b3c4092c2b3093ade9cab61ad0674fd170d4e867215ecc2d3197/python/pyperformance/issues/74 |
| og:image:alt | Changes in Python 3.9 break html5lib, django_template, and tornado_http tests with this error: File "/usr/local/src/pyperf-tot-no-venv/lib/python3.9/site-packages/html5lib/_tokenizer.py", line 16, ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | TravisLazar |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/pyperformance git https://github.com/python/pyperformance.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 65949828 |
| octolytics-dimension-repository_nwo | python/pyperformance |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 65949828 |
| octolytics-dimension-repository_network_root_nwo | python/pyperformance |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width