René's URL Explorer Experiment


Title: modulefinder: make -p actually handle namespace packages correctly by hauntsaninja · Pull Request #9683 · python/mypy · GitHub

Open Graph Title: modulefinder: make -p actually handle namespace packages correctly by hauntsaninja · Pull Request #9683 · python/mypy

X Title: modulefinder: make -p actually handle namespace packages correctly by hauntsaninja · Pull Request #9683 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This is what #9616 should have been. I noticed this as part of #9672. Note that this has the unfortunate side effect of causing mypy to fail when run on mypy with --namespace-packages, since typesh...

X Description: This is what #9616 should have been. I noticed this as part of #9672. Note that this has the unfortunate side effect of causing mypy to fail when run on mypy with --namespace-packages, since typesh...

Opengraph URL: https://github.com/python/mypy/pull/9683

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:a4656485-1c9e-7e43-92e3-3c4cb8c0cb23
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA64:182C25:2360A6:2FD250:6B002341
html-safe-nonced23a4f114759272df8ed05939397e9c8d5e792d5169378d30bcdaf4d8a74c3c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTY0OjE4MkMyNToyMzYwQTY6MkZEMjUwOjZCMDAyMzQxIiwidmlzaXRvcl9pZCI6IjE5MTA5MDE5MzA0MTUxMDQ4MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5aa9f4f62a89bdf809e583bbae48d39ef34fc06f6341e38a7278e24ed2831978
hovercard-subject-tagpull_request:513507400
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/9683
twitter:imagehttps://opengraph.githubassets.com/b5df310f6adad73c2cb6d6f3fdec16c603e37aada638bf54a94c4daec29662cd/python/mypy/pull/9683
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5df310f6adad73c2cb6d6f3fdec16c603e37aada638bf54a94c4daec29662cd/python/mypy/pull/9683
og:image:altThis is what #9616 should have been. I noticed this as part of #9672. Note that this has the unfortunate side effect of causing mypy to fail when run on mypy with --namespace-packages, since typesh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/9683#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9683
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9683
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/9683
Reloadhttps://github.com/python/mypy/pull/9683
Reloadhttps://github.com/python/mypy/pull/9683
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:1031modfind2https://github.com/hauntsaninja/mypy/tree/1031modfind2
Conversationhttps://github.com/python/mypy/pull/9683
Commits6 (6)https://github.com/python/mypy/pull/9683/commits
Checkshttps://github.com/python/mypy/pull/9683/checks
Files changedhttps://github.com/python/mypy/pull/9683/files
modulefinder: make -p actually handle namespace packages correctlyhttps://github.com/python/mypy/pull/9683#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:1031modfind2https://github.com/hauntsaninja/mypy/tree/1031modfind2
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Oct 31, 2020https://github.com/python/mypy/pull/9683#issue-733820604
#9616https://github.com/python/mypy/pull/9616
#9672https://github.com/python/mypy/pull/9672
#9636https://github.com/python/mypy/pull/9636
Please reload this pagehttps://github.com/python/mypy/pull/9683
October 31, 2020 15:34https://github.com/python/mypy/pull/9683#commits-pushed-361653b
cmdline: add to the testhttps://github.com/python/mypy/pull/9683/commits/361653b392cf51053dd0d64c61073f05f319907e
361653bhttps://github.com/python/mypy/pull/9683/commits/361653b392cf51053dd0d64c61073f05f319907e
modulefinder: remove unused argumenthttps://github.com/python/mypy/pull/9683/commits/35d5c69cfe44e3f13b1ebd789892da7bacb5a271
35d5c69https://github.com/python/mypy/pull/9683/commits/35d5c69cfe44e3f13b1ebd789892da7bacb5a271
python#9616https://github.com/python/mypy/pull/9616
FindModuleCache: make arguments non optionalhttps://github.com/python/mypy/pull/9683/commits/f1668e78942d6d4a3c4e9c92105b5a19d664f1e7
f1668e7https://github.com/python/mypy/pull/9683/commits/f1668e78942d6d4a3c4e9c92105b5a19d664f1e7
modulefinder: actually handle namespace packages correctlyhttps://github.com/python/mypy/pull/9683/commits/750c92e282faaaa52c2426c847d5c05b0f1451e9
750c92ehttps://github.com/python/mypy/pull/9683/commits/750c92e282faaaa52c2426c847d5c05b0f1451e9
change import in test, also use the importhttps://github.com/python/mypy/pull/9683/commits/df1487b376acb2e09dc6e85c8ebbc5fdf486371c
df1487bhttps://github.com/python/mypy/pull/9683/commits/df1487b376acb2e09dc6e85c8ebbc5fdf486371c
sort to avoid py35 test issueshttps://github.com/python/mypy/pull/9683/commits/75ca3acba25b4ab57a514ff4bcc26e6527a790cc
75ca3achttps://github.com/python/mypy/pull/9683/commits/75ca3acba25b4ab57a514ff4bcc26e6527a790cc
mypy: allow explicit specification of package roots #9632 https://github.com/python/mypy/pull/9632
[Feature Request] Option to Recurse into All Subdirectories with Namespace Packages #6385 https://github.com/python/mypy/issues/6385
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Nov 20, 2020https://github.com/python/mypy/pull/9683#issuecomment-731260499
Please reload this pagehttps://github.com/python/mypy/pull/9683
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Nov 20, 2020 https://github.com/python/mypy/pull/9683#pullrequestreview-535583257
View reviewed changes https://github.com/python/mypy/pull/9683/files/75ca3acba25b4ab57a514ff4bcc26e6527a790cc
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/9683#pullrequestreview-535583257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/9683
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Nov 20, 2020https://github.com/python/mypy/pull/9683#issuecomment-731335854
Please reload this pagehttps://github.com/python/mypy/pull/9683
Please reload this pagehttps://github.com/python/mypy/pull/9683
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
40fd841https://github.com/python/mypy/commit/40fd841a005936d95e7c351435f1b7b7b4bdd43d
Nov 20, 2020https://github.com/python/mypy/pull/9683#event-4022246379
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
November 20, 2020 18:26https://github.com/python/mypy/pull/9683#event-4022246664
hauntsaninjahttps://github.com/hauntsaninja
Jan 18, 2021 https://github.com/python/mypy/pull/9683#ref-commit-203f7e4
Document new source finding behaviourhttps://github.com/hauntsaninja/mypy/commit/203f7e4b97934e306fdbad489cfab947d0e129b0
203f7e4https://github.com/hauntsaninja/mypy/commit/203f7e4b97934e306fdbad489cfab947d0e129b0
python#9742https://github.com/python/mypy/pull/9742
python#9683https://github.com/python/mypy/pull/9683
python#9632https://github.com/python/mypy/pull/9632
python#9616https://github.com/python/mypy/pull/9616
python#9614https://github.com/python/mypy/pull/9614
python#9636https://github.com/python/mypy/pull/9636
hauntsaninjahttps://github.com/hauntsaninja
Jan 18, 2021 https://github.com/python/mypy/pull/9683#ref-commit-5902851
Document new source finding behaviourhttps://github.com/hauntsaninja/mypy/commit/59028519f2a6578da1239f1f78aeb4d0c558aeee
5902851https://github.com/hauntsaninja/mypy/commit/59028519f2a6578da1239f1f78aeb4d0c558aeee
python#9742https://github.com/python/mypy/pull/9742
python#9683https://github.com/python/mypy/pull/9683
python#9632https://github.com/python/mypy/pull/9632
python#9616https://github.com/python/mypy/pull/9616
python#9614https://github.com/python/mypy/pull/9614
python#9636https://github.com/python/mypy/pull/9636
hauntsaninjahttps://github.com/hauntsaninja
Jan 18, 2021 https://github.com/python/mypy/pull/9683#ref-commit-44fb9f5
Document new source finding behaviourhttps://github.com/hauntsaninja/mypy/commit/44fb9f56eabcd4fd69e90d6e3b4e428e47635c65
44fb9f5https://github.com/hauntsaninja/mypy/commit/44fb9f56eabcd4fd69e90d6e3b4e428e47635c65
python#9742https://github.com/python/mypy/pull/9742
python#9683https://github.com/python/mypy/pull/9683
python#9632https://github.com/python/mypy/pull/9632
python#9616https://github.com/python/mypy/pull/9616
python#9614https://github.com/python/mypy/pull/9614
python#9636https://github.com/python/mypy/pull/9636
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 18, 2021 https://github.com/python/mypy/pull/9683#ref-pullrequest-788028945
Document new source finding behaviour #9923 https://github.com/python/mypy/pull/9923
hauntsaninjahttps://github.com/hauntsaninja
Jan 19, 2021 https://github.com/python/mypy/pull/9683#ref-commit-37a107e
https://github.com/hauntsaninja
Document new source finding behaviour (https://github.com/python/mypy/commit/37a107e49a15ecde6b10643bc9b25bee1c270672
#9923https://github.com/python/mypy/pull/9923
)https://github.com/python/mypy/commit/37a107e49a15ecde6b10643bc9b25bee1c270672
37a107ehttps://github.com/python/mypy/commit/37a107e49a15ecde6b10643bc9b25bee1c270672
#9742https://github.com/python/mypy/pull/9742
#9683https://github.com/python/mypy/pull/9683
#9632https://github.com/python/mypy/pull/9632
#9616https://github.com/python/mypy/pull/9616
#9614https://github.com/python/mypy/pull/9614
#9636https://github.com/python/mypy/pull/9636
ilevkivskyihttps://github.com/ilevkivskyi
Jan 20, 2021 https://github.com/python/mypy/pull/9683#ref-commit-40e92a2
https://github.com/hauntsaninja
Document new source finding behaviour (https://github.com/python/mypy/commit/40e92a2ff49e0e8a4ec27044e60b17b0dd1a56e4
#9923https://github.com/python/mypy/pull/9923
)https://github.com/python/mypy/commit/40e92a2ff49e0e8a4ec27044e60b17b0dd1a56e4
40e92a2https://github.com/python/mypy/commit/40e92a2ff49e0e8a4ec27044e60b17b0dd1a56e4
#9742https://github.com/python/mypy/pull/9742
#9683https://github.com/python/mypy/pull/9683
#9632https://github.com/python/mypy/pull/9632
#9616https://github.com/python/mypy/pull/9616
#9614https://github.com/python/mypy/pull/9614
#9636https://github.com/python/mypy/pull/9636
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9683
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/9683/files/75ca3acba25b4ab57a514ff4bcc26e6527a790cc
Please reload this pagehttps://github.com/python/mypy/pull/9683
Please reload this pagehttps://github.com/python/mypy/pull/9683
https://github.com/hauntsaninja
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.