| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d5e9a555-85c3-7e2b-375f-90306363f41d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D9DE:34D604:1A81156:23070C4:6B002F74 |
| html-safe-nonce | 155ea1053afb695fc4d88d1a272d6fa336da0284399aa577fbf3a11a97b7e1e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOURFOjM0RDYwNDoxQTgxMTU2OjIzMDcwQzQ6NkIwMDJGNzQiLCJ2aXNpdG9yX2lkIjoiMjY2NDU5MjMzMDYzOTU1MjM3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0e6c438faa3c39a612c0a21c7833086499ef1ee6ee08a1ae73be708f60a1162f |
| hovercard-subject-tag | pull_request:475967551 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/9383/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5569f5f39f9776e39cc8d790cd73f47077b1c911cae33e3ac90dda61bf765c94/python/mypy/pull/9383 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5569f5f39f9776e39cc8d790cd73f47077b1c911cae33e3ac90dda61bf765c94/python/mypy/pull/9383 |
| og:image:alt | Description
Fixes #5744
Updates the attrs plugin. Instead of directly copying attribute type along the MRO, this first resolves typevar in the context of the subtype.
Test Plan
Added 4 new test cas... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | natemcmaster |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/9383#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9383 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9383 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/9383 |
| Reload | https://github.com/python/mypy/pull/9383 |
| Reload | https://github.com/python/mypy/pull/9383 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| natemcmaster:attr-generic | https://github.com/natemcmaster/mypy/tree/attr-generic |
| Conversation | https://github.com/python/mypy/pull/9383 |
| Commits3 (3) | https://github.com/python/mypy/pull/9383/commits |
| Checks | https://github.com/python/mypy/pull/9383/checks |
| Files changed | https://github.com/python/mypy/pull/9383/files |
| Fix generic inheritance for attrs init methods | https://github.com/python/mypy/pull/9383#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| natemcmaster:attr-generic | https://github.com/natemcmaster/mypy/tree/attr-generic |
|
| https://github.com/natemcmaster |
| natemcmaster | https://github.com/natemcmaster |
| Aug 30, 2020 | https://github.com/python/mypy/pull/9383#issue-688797273 |
| #5744 | https://github.com/python/mypy/issues/5744 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
|
[Attrs] Invalid typing of init arguments in subclasses of generics
#5744
| https://github.com/python/mypy/issues/5744 |
|
dataclass does not properly support generics
#7520
| https://github.com/python/mypy/issues/7520 |
| https://github.com/natemcmaster |
| natemcmaster | https://github.com/natemcmaster |
| August 30, 2020 21:50 | https://github.com/python/mypy/pull/9383#event-3707652909 |
|
| https://github.com/natemcmaster |
| fix: resolve typevar before generating attrs init method | https://github.com/python/mypy/pull/9383/commits/5619bfa1ce6325087f5a48db313bb59851f92e43 |
| 5619bfa | https://github.com/python/mypy/pull/9383/commits/5619bfa1ce6325087f5a48db313bb59851f92e43 |
| https://github.com/natemcmaster |
| natemcmaster | https://github.com/natemcmaster |
| force-pushed | https://github.com/python/mypy/compare/54dc7f579975df4a3eb997c3a4b37b9fd1f86e5e..5619bfa1ce6325087f5a48db313bb59851f92e43 |
| 54dc7f5 | https://github.com/python/mypy/commit/54dc7f579975df4a3eb997c3a4b37b9fd1f86e5e |
| 5619bfa | https://github.com/python/mypy/commit/5619bfa1ce6325087f5a48db313bb59851f92e43 |
|
Compare
| https://github.com/python/mypy/compare/54dc7f579975df4a3eb997c3a4b37b9fd1f86e5e..5619bfa1ce6325087f5a48db313bb59851f92e43 |
| August 30, 2020 21:52 | https://github.com/python/mypy/pull/9383#event-3707654227 |
| https://github.com/natemcmaster |
| natemcmaster | https://github.com/natemcmaster |
| Aug 31, 2020 | https://github.com/python/mypy/pull/9383#issuecomment-683885008 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Aug 31, 2020 | https://github.com/python/mypy/pull/9383#issuecomment-683903353 |
| https://mail.python.org/archives/list/python-dev@python.org/message/TJE5XWLKRC3EQUXKSHCJNA25H3WGVP5B/ | https://mail.python.org/archives/list/python-dev@python.org/message/TJE5XWLKRC3EQUXKSHCJNA25H3WGVP5B/ |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Sep 1, 2020 | https://github.com/python/mypy/pull/9383#issuecomment-684953798 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
|
| https://github.com/natemcmaster |
| Merge branch 'master' into attr-generic | https://github.com/python/mypy/pull/9383/commits/4b676e459f3357f7fc8fd0d53f08f924f112c15c |
| 4b676e4 | https://github.com/python/mypy/pull/9383/commits/4b676e459f3357f7fc8fd0d53f08f924f112c15c |
| https://github.com/natemcmaster |
| natemcmaster | https://github.com/natemcmaster |
| Sep 3, 2020 | https://github.com/python/mypy/pull/9383#issuecomment-686446801 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
| https://github.com/natemcmaster |
| natemcmaster | https://github.com/natemcmaster |
| Sep 30, 2020 | https://github.com/python/mypy/pull/9383#issuecomment-701103361 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
|
| https://github.com/natemcmaster |
| Merge branch 'master' into attr-generic | https://github.com/python/mypy/pull/9383/commits/5a85b0dae038cde59f12b3be068f4f1ae0e2a63d |
| 5a85b0d | https://github.com/python/mypy/pull/9383/commits/5a85b0dae038cde59f12b3be068f4f1ae0e2a63d |
| https://github.com/natemcmaster |
| natemcmaster | https://github.com/natemcmaster |
| Nov 13, 2020 | https://github.com/python/mypy/pull/9383#issuecomment-726884694 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Nov 28, 2020
| https://github.com/python/mypy/pull/9383#ref-pullrequest-688779192 |
|
Fix generic inheritance for dataclass init methods
#9380
| https://github.com/python/mypy/pull/9380 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| fc212ef | https://github.com/python/mypy/commit/fc212ef893a0c3e6d500be89aa4d9302c1219595 |
| Nov 28, 2020 | https://github.com/python/mypy/pull/9383#event-4047551836 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Nov 28, 2020 | https://github.com/python/mypy/pull/9383#issuecomment-735024082 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
| https://github.com/natemcmaster |
| natemcmaster | https://github.com/natemcmaster |
| November 28, 2020 02:11 | https://github.com/python/mypy/pull/9383#event-4047580402 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9383 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
|
[Attrs] Invalid typing of init arguments in subclasses of generics
| https://github.com/python/mypy/issues/5744 |
| Please reload this page | https://github.com/python/mypy/pull/9383 |
|
| https://github.com/natemcmaster |
|
| https://github.com/gvanrossum |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |