| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c813654f-54a1-24b8-c3b3-3d107a0318b9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 800E:2573D7:212A358:2D2B5D1:6B00234B |
| html-safe-nonce | fdc6ecc4b391bbf284908fb4de08e93c88759df2371cd01801b95113d657f525 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDBFOjI1NzNENzoyMTJBMzU4OjJEMkI1RDE6NkIwMDIzNEIiLCJ2aXNpdG9yX2lkIjoiNDE3NzIzMjIzNjkzODAxMTQ2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3fc2bdbc1ea55fc24dfe9b25a3ce8f74c7fc36038f896dd0ac7191e2c9fab5f1 |
| hovercard-subject-tag | pull_request:455290447 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/9192/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/eed8e87a202633336569218e8ab6a6ede3fb8683a2b197a5332fac2a65509dff/python/mypy/pull/9192 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eed8e87a202633336569218e8ab6a6ede3fb8683a2b197a5332fac2a65509dff/python/mypy/pull/9192 |
| og:image:alt | make_simplified_union no longer runs for 0.5 seconds every time it's called with a Union containing 270 literals of strings.
like I explained in #9169, this only fixes half of the problem and I... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Akuli |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/9192#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9192 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9192 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/9192 |
| Reload | https://github.com/python/mypy/pull/9192 |
| Reload | https://github.com/python/mypy/pull/9192 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| Akuli:speed_up_make_simplified_union | https://github.com/Akuli/mypy/tree/speed_up_make_simplified_union |
| Conversation | https://github.com/python/mypy/pull/9192 |
| Commits4 (4) | https://github.com/python/mypy/pull/9192/commits |
| Checks | https://github.com/python/mypy/pull/9192/checks |
| Files changed | https://github.com/python/mypy/pull/9192/files |
| Speed up make_simplified_union for Literal[string]s (issue #9169) | https://github.com/python/mypy/pull/9192#top |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| Akuli:speed_up_make_simplified_union | https://github.com/Akuli/mypy/tree/speed_up_make_simplified_union |
|
| https://github.com/Akuli |
| Akuli | https://github.com/Akuli |
| Jul 22, 2020 | https://github.com/python/mypy/pull/9192#issue-663971742 |
| #9169 | https://github.com/python/mypy/issues/9169 |
| Please reload this page | https://github.com/python/mypy/pull/9192 |
| Akuli | https://github.com/Akuli |
| July 22, 2020 21:41 | https://github.com/python/mypy/pull/9192#commits-pushed-e03fe98 |
|
| https://github.com/Akuli |
| Speed up make_simplified_union for Literal[string]s (issue | https://github.com/python/mypy/pull/9192/commits/e03fe98801671d60b5f87e76a9379b2c14ef3387 |
| python#9169 | https://github.com/python/mypy/issues/9169 |
| ) | https://github.com/python/mypy/pull/9192/commits/e03fe98801671d60b5f87e76a9379b2c14ef3387 |
| e03fe98 | https://github.com/python/mypy/pull/9192/commits/e03fe98801671d60b5f87e76a9379b2c14ef3387 |
|
| https://github.com/Akuli |
| add missing cast | https://github.com/python/mypy/pull/9192/commits/0c64e0fcfeaf91d19cda599ffd12b9230a9381cb |
| 0c64e0f | https://github.com/python/mypy/pull/9192/commits/0c64e0fcfeaf91d19cda599ffd12b9230a9381cb |
|
| https://github.com/Akuli |
| try to fix mypy self-check with asserts | https://github.com/python/mypy/pull/9192/commits/29a71d8352249e6a84ae91c0ebc4c24b2cbb5dba |
| 29a71d8 | https://github.com/python/mypy/pull/9192/commits/29a71d8352249e6a84ae91c0ebc4c24b2cbb5dba |
| https://github.com/Akuli |
| Akuli | https://github.com/Akuli |
| Jul 23, 2020 | https://github.com/python/mypy/pull/9192#issuecomment-662976650 |
| Please reload this page | https://github.com/python/mypy/pull/9192 |
|
| https://github.com/Akuli |
| try to trigger travis build to make it show correct status on github | https://github.com/python/mypy/pull/9192/commits/f5490d970d3dfc0461d5107aed4ec7e497d8875f |
| f5490d9 | https://github.com/python/mypy/pull/9192/commits/f5490d970d3dfc0461d5107aed4ec7e497d8875f |
| https://github.com/Akuli |
| Akuli | https://github.com/Akuli |
|
Jul 30, 2020
| https://github.com/python/mypy/pull/9192#ref-issue-659929668 |
|
Regression from 0.750 - Literal types cause significant slowdown
#9169
| https://github.com/python/mypy/issues/9169 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Jul 31, 2020
| https://github.com/python/mypy/pull/9192#pullrequestreview-459172110 |
|
View reviewed changes
| https://github.com/python/mypy/pull/9192/files/f5490d970d3dfc0461d5107aed4ec7e497d8875f |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/9192#pullrequestreview-459172110 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/9192 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| a32d2f4 | https://github.com/python/mypy/commit/a32d2f41304061639044eafc1a40d4fbb4ea49d4 |
| Jul 31, 2020 | https://github.com/python/mypy/pull/9192#event-3608515158 |
| https://github.com/Akuli |
| Akuli | https://github.com/Akuli |
| Jul 31, 2020 | https://github.com/python/mypy/pull/9192#issuecomment-667129825 |
| 25b1c4d | https://github.com/python/mypy/commit/25b1c4ddb349da2e79a6f1f30a38a5bc3b0f6509 |
| Please reload this page | https://github.com/python/mypy/pull/9192 |
| https://github.com/Akuli |
| Akuli | https://github.com/Akuli |
| July 31, 2020 13:52 | https://github.com/python/mypy/pull/9192#event-3608617282 |
| huguesb | https://github.com/huguesb |
|
Sep 1, 2020
| https://github.com/python/mypy/pull/9192#ref-commit-44ed83d |
|
| https://github.com/hugues-aff |
| typeops: extend make_simplified_union fast path to enums | https://github.com/huguesb/mypy/commit/44ed83d9f5325ee63d67e05a31d36275876bfa4f |
| 44ed83d | https://github.com/huguesb/mypy/commit/44ed83d9f5325ee63d67e05a31d36275876bfa4f |
| python#9192 | https://github.com/python/mypy/pull/9192 |
| python#9169 | https://github.com/python/mypy/issues/9169 |
| huguesb | https://github.com/huguesb |
|
Sep 1, 2020
| https://github.com/python/mypy/pull/9192#ref-commit-c08e7be |
|
| https://github.com/hugues-aff |
| typeops: extend make_simplified_union fast path to enums | https://github.com/huguesb/mypy/commit/c08e7be23184f503985d037b1df9bafb9bfbdae2 |
| c08e7be | https://github.com/huguesb/mypy/commit/c08e7be23184f503985d037b1df9bafb9bfbdae2 |
| python#9192 | https://github.com/python/mypy/pull/9192 |
| python#9169 | https://github.com/python/mypy/issues/9169 |
| https://github.com/huguesb |
| huguesb | https://github.com/huguesb |
|
Sep 1, 2020
| https://github.com/python/mypy/pull/9192#ref-pullrequest-690527021 |
|
typeops: extend make_simplified_union fast path to enums
#9394
| https://github.com/python/mypy/pull/9394 |
| huguesb | https://github.com/huguesb |
|
Sep 2, 2020
| https://github.com/python/mypy/pull/9192#ref-commit-15b635e |
|
| https://github.com/hugues-aff |
| typeops: extend make_simplified_union fast path to enums | https://github.com/huguesb/mypy/commit/15b635e8f753b2b6762b9a780b73ac17c43bcab5 |
| 15b635e | https://github.com/huguesb/mypy/commit/15b635e8f753b2b6762b9a780b73ac17c43bcab5 |
| python#9192 | https://github.com/python/mypy/pull/9192 |
| python#9169 | https://github.com/python/mypy/issues/9169 |
| huguesb | https://github.com/huguesb |
|
Sep 2, 2020
| https://github.com/python/mypy/pull/9192#ref-commit-547ccc9 |
|
| https://github.com/hugues-aff |
| typeops: extend make_simplified_union fast path to enums | https://github.com/huguesb/mypy/commit/547ccc940e570c5aa99897bbf095964cca9c3363 |
| 547ccc9 | https://github.com/huguesb/mypy/commit/547ccc940e570c5aa99897bbf095964cca9c3363 |
| python#9192 | https://github.com/python/mypy/pull/9192 |
| python#9169 | https://github.com/python/mypy/issues/9169 |
| huguesb | https://github.com/huguesb |
|
Sep 2, 2020
| https://github.com/python/mypy/pull/9192#ref-commit-129b2b5 |
|
| https://github.com/hugues-aff |
| typeops: extend make_simplified_union fast path to enums | https://github.com/huguesb/mypy/commit/129b2b5d0733c5e68ad6b76770f4a2278e4bed73 |
| 129b2b5 | https://github.com/huguesb/mypy/commit/129b2b5d0733c5e68ad6b76770f4a2278e4bed73 |
| python#9192 | https://github.com/python/mypy/pull/9192 |
| python#9169 | https://github.com/python/mypy/issues/9169 |
| huguesb | https://github.com/huguesb |
|
Sep 3, 2020
| https://github.com/python/mypy/pull/9192#ref-commit-57ce8eb |
|
| https://github.com/hugues-aff |
| typeops: extend make_simplified_union fast path to enums | https://github.com/huguesb/mypy/commit/57ce8ebf30634c6ef3e9f00725fb35d84dd16faa |
| 57ce8eb | https://github.com/huguesb/mypy/commit/57ce8ebf30634c6ef3e9f00725fb35d84dd16faa |
| python#9192 | https://github.com/python/mypy/pull/9192 |
| python#9169 | https://github.com/python/mypy/issues/9169 |
| huguesb | https://github.com/huguesb |
|
Sep 3, 2020
| https://github.com/python/mypy/pull/9192#ref-commit-654e179 |
|
| https://github.com/hugues-aff |
| typeops: extend make_simplified_union fast path to enums | https://github.com/huguesb/mypy/commit/654e179b74271b9c7296d5f08e2d2a6b080fc5e7 |
| 654e179 | https://github.com/huguesb/mypy/commit/654e179b74271b9c7296d5f08e2d2a6b080fc5e7 |
| python#9192 | https://github.com/python/mypy/pull/9192 |
| python#9169 | https://github.com/python/mypy/issues/9169 |
| msullivan | https://github.com/msullivan |
|
Jul 7, 2021
| https://github.com/python/mypy/pull/9192#ref-commit-fa28616 |
|
| https://github.com/hugues-aff |
| typeops: extend make_simplified_union fast path to enums ( | https://github.com/python/mypy/commit/fa28616f8bddf00d691eedeeb50459904bd42069 |
| #9394 | https://github.com/python/mypy/pull/9394 |
| ) | https://github.com/python/mypy/commit/fa28616f8bddf00d691eedeeb50459904bd42069 |
| fa28616 | https://github.com/python/mypy/commit/fa28616f8bddf00d691eedeeb50459904bd42069 |
| #9192 | https://github.com/python/mypy/pull/9192 |
| #9169 | https://github.com/python/mypy/issues/9169 |
| https://github.com/97littleleaf11 |
| 97littleleaf11 | https://github.com/97littleleaf11 |
|
Oct 5, 2021
| https://github.com/python/mypy/pull/9192#ref-issue-593433369 |
|
Get rid of make_simplified_union() except in error messages
#8624
| https://github.com/python/mypy/issues/8624 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
May 7, 2025
| https://github.com/python/mypy/pull/9192#ref-issue-3046365023 |
|
Add a benchmark involving realistic code that creates large unions
astral-sh/ty#240
| https://github.com/astral-sh/ty/issues/240 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9192 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/9192/files/f5490d970d3dfc0461d5107aed4ec7e497d8875f |
| Please reload this page | https://github.com/python/mypy/pull/9192 |
| Please reload this page | https://github.com/python/mypy/pull/9192 |
|
| https://github.com/Akuli |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |