René's URL Explorer Experiment


Title: Speed up make_simplified_union for Literal[string]s (issue #9169) by Akuli · Pull Request #9192 · python/mypy · GitHub

Open Graph Title: Speed up make_simplified_union for Literal[string]s (issue #9169) by Akuli · Pull Request #9192 · python/mypy

X Title: Speed up make_simplified_union for Literal[string]s (issue #9169) by Akuli · Pull Request #9192 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: make_simplified_union no longer runs for 0.5 seconds every time it's called with a Union containing 270 literals of strings. like I explained in #9169, this only fixes half of the problem and I...

X Description: make_simplified_union no longer runs for 0.5 seconds every time it's called with a Union containing 270 literals of strings. like I explained in #9169, this only fixes half of the problem a...

Opengraph URL: https://github.com/python/mypy/pull/9192

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c813654f-54a1-24b8-c3b3-3d107a0318b9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id800E:2573D7:212A358:2D2B5D1:6B00234B
html-safe-noncefdc6ecc4b391bbf284908fb4de08e93c88759df2371cd01801b95113d657f525
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDBFOjI1NzNENzoyMTJBMzU4OjJEMkI1RDE6NkIwMDIzNEIiLCJ2aXNpdG9yX2lkIjoiNDE3NzIzMjIzNjkzODAxMTQ2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3fc2bdbc1ea55fc24dfe9b25a3ce8f74c7fc36038f896dd0ac7191e2c9fab5f1
hovercard-subject-tagpull_request:455290447
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/9192/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eed8e87a202633336569218e8ab6a6ede3fb8683a2b197a5332fac2a65509dff/python/mypy/pull/9192
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eed8e87a202633336569218e8ab6a6ede3fb8683a2b197a5332fac2a65509dff/python/mypy/pull/9192
og:image:altmake_simplified_union no longer runs for 0.5 seconds every time it's called with a Union containing 270 literals of strings. like I explained in #9169, this only fixes half of the problem and I...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAkuli
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/9192#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9192
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9192
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/9192
Reloadhttps://github.com/python/mypy/pull/9192
Reloadhttps://github.com/python/mypy/pull/9192
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
Akuli:speed_up_make_simplified_unionhttps://github.com/Akuli/mypy/tree/speed_up_make_simplified_union
Conversationhttps://github.com/python/mypy/pull/9192
Commits4 (4)https://github.com/python/mypy/pull/9192/commits
Checkshttps://github.com/python/mypy/pull/9192/checks
Files changedhttps://github.com/python/mypy/pull/9192/files
Speed up make_simplified_union for Literal[string]s (issue #9169)https://github.com/python/mypy/pull/9192#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
Akuli:speed_up_make_simplified_unionhttps://github.com/Akuli/mypy/tree/speed_up_make_simplified_union
https://github.com/Akuli
Akulihttps://github.com/Akuli
Jul 22, 2020https://github.com/python/mypy/pull/9192#issue-663971742
#9169https://github.com/python/mypy/issues/9169
Please reload this pagehttps://github.com/python/mypy/pull/9192
Akulihttps://github.com/Akuli
July 22, 2020 21:41https://github.com/python/mypy/pull/9192#commits-pushed-e03fe98
https://github.com/Akuli
Speed up make_simplified_union for Literal[string]s (issuehttps://github.com/python/mypy/pull/9192/commits/e03fe98801671d60b5f87e76a9379b2c14ef3387
python#9169https://github.com/python/mypy/issues/9169
)https://github.com/python/mypy/pull/9192/commits/e03fe98801671d60b5f87e76a9379b2c14ef3387
e03fe98https://github.com/python/mypy/pull/9192/commits/e03fe98801671d60b5f87e76a9379b2c14ef3387
https://github.com/Akuli
add missing casthttps://github.com/python/mypy/pull/9192/commits/0c64e0fcfeaf91d19cda599ffd12b9230a9381cb
0c64e0fhttps://github.com/python/mypy/pull/9192/commits/0c64e0fcfeaf91d19cda599ffd12b9230a9381cb
https://github.com/Akuli
try to fix mypy self-check with assertshttps://github.com/python/mypy/pull/9192/commits/29a71d8352249e6a84ae91c0ebc4c24b2cbb5dba
29a71d8https://github.com/python/mypy/pull/9192/commits/29a71d8352249e6a84ae91c0ebc4c24b2cbb5dba
https://github.com/Akuli
Akulihttps://github.com/Akuli
Jul 23, 2020https://github.com/python/mypy/pull/9192#issuecomment-662976650
Please reload this pagehttps://github.com/python/mypy/pull/9192
https://github.com/Akuli
try to trigger travis build to make it show correct status on githubhttps://github.com/python/mypy/pull/9192/commits/f5490d970d3dfc0461d5107aed4ec7e497d8875f
f5490d9https://github.com/python/mypy/pull/9192/commits/f5490d970d3dfc0461d5107aed4ec7e497d8875f
https://github.com/Akuli
Akulihttps://github.com/Akuli
Jul 30, 2020 https://github.com/python/mypy/pull/9192#ref-issue-659929668
Regression from 0.750 - Literal types cause significant slowdown #9169 https://github.com/python/mypy/issues/9169
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jul 31, 2020 https://github.com/python/mypy/pull/9192#pullrequestreview-459172110
View reviewed changes https://github.com/python/mypy/pull/9192/files/f5490d970d3dfc0461d5107aed4ec7e497d8875f
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/9192#pullrequestreview-459172110
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/9192
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
a32d2f4https://github.com/python/mypy/commit/a32d2f41304061639044eafc1a40d4fbb4ea49d4
Jul 31, 2020https://github.com/python/mypy/pull/9192#event-3608515158
https://github.com/Akuli
Akulihttps://github.com/Akuli
Jul 31, 2020https://github.com/python/mypy/pull/9192#issuecomment-667129825
25b1c4dhttps://github.com/python/mypy/commit/25b1c4ddb349da2e79a6f1f30a38a5bc3b0f6509
Please reload this pagehttps://github.com/python/mypy/pull/9192
https://github.com/Akuli
Akulihttps://github.com/Akuli
July 31, 2020 13:52https://github.com/python/mypy/pull/9192#event-3608617282
huguesbhttps://github.com/huguesb
Sep 1, 2020 https://github.com/python/mypy/pull/9192#ref-commit-44ed83d
https://github.com/hugues-aff
typeops: extend make_simplified_union fast path to enumshttps://github.com/huguesb/mypy/commit/44ed83d9f5325ee63d67e05a31d36275876bfa4f
44ed83dhttps://github.com/huguesb/mypy/commit/44ed83d9f5325ee63d67e05a31d36275876bfa4f
python#9192https://github.com/python/mypy/pull/9192
python#9169https://github.com/python/mypy/issues/9169
huguesbhttps://github.com/huguesb
Sep 1, 2020 https://github.com/python/mypy/pull/9192#ref-commit-c08e7be
https://github.com/hugues-aff
typeops: extend make_simplified_union fast path to enumshttps://github.com/huguesb/mypy/commit/c08e7be23184f503985d037b1df9bafb9bfbdae2
c08e7behttps://github.com/huguesb/mypy/commit/c08e7be23184f503985d037b1df9bafb9bfbdae2
python#9192https://github.com/python/mypy/pull/9192
python#9169https://github.com/python/mypy/issues/9169
https://github.com/huguesb
huguesbhttps://github.com/huguesb
Sep 1, 2020 https://github.com/python/mypy/pull/9192#ref-pullrequest-690527021
typeops: extend make_simplified_union fast path to enums #9394 https://github.com/python/mypy/pull/9394
huguesbhttps://github.com/huguesb
Sep 2, 2020 https://github.com/python/mypy/pull/9192#ref-commit-15b635e
https://github.com/hugues-aff
typeops: extend make_simplified_union fast path to enumshttps://github.com/huguesb/mypy/commit/15b635e8f753b2b6762b9a780b73ac17c43bcab5
15b635ehttps://github.com/huguesb/mypy/commit/15b635e8f753b2b6762b9a780b73ac17c43bcab5
python#9192https://github.com/python/mypy/pull/9192
python#9169https://github.com/python/mypy/issues/9169
huguesbhttps://github.com/huguesb
Sep 2, 2020 https://github.com/python/mypy/pull/9192#ref-commit-547ccc9
https://github.com/hugues-aff
typeops: extend make_simplified_union fast path to enumshttps://github.com/huguesb/mypy/commit/547ccc940e570c5aa99897bbf095964cca9c3363
547ccc9https://github.com/huguesb/mypy/commit/547ccc940e570c5aa99897bbf095964cca9c3363
python#9192https://github.com/python/mypy/pull/9192
python#9169https://github.com/python/mypy/issues/9169
huguesbhttps://github.com/huguesb
Sep 2, 2020 https://github.com/python/mypy/pull/9192#ref-commit-129b2b5
https://github.com/hugues-aff
typeops: extend make_simplified_union fast path to enumshttps://github.com/huguesb/mypy/commit/129b2b5d0733c5e68ad6b76770f4a2278e4bed73
129b2b5https://github.com/huguesb/mypy/commit/129b2b5d0733c5e68ad6b76770f4a2278e4bed73
python#9192https://github.com/python/mypy/pull/9192
python#9169https://github.com/python/mypy/issues/9169
huguesbhttps://github.com/huguesb
Sep 3, 2020 https://github.com/python/mypy/pull/9192#ref-commit-57ce8eb
https://github.com/hugues-aff
typeops: extend make_simplified_union fast path to enumshttps://github.com/huguesb/mypy/commit/57ce8ebf30634c6ef3e9f00725fb35d84dd16faa
57ce8ebhttps://github.com/huguesb/mypy/commit/57ce8ebf30634c6ef3e9f00725fb35d84dd16faa
python#9192https://github.com/python/mypy/pull/9192
python#9169https://github.com/python/mypy/issues/9169
huguesbhttps://github.com/huguesb
Sep 3, 2020 https://github.com/python/mypy/pull/9192#ref-commit-654e179
https://github.com/hugues-aff
typeops: extend make_simplified_union fast path to enumshttps://github.com/huguesb/mypy/commit/654e179b74271b9c7296d5f08e2d2a6b080fc5e7
654e179https://github.com/huguesb/mypy/commit/654e179b74271b9c7296d5f08e2d2a6b080fc5e7
python#9192https://github.com/python/mypy/pull/9192
python#9169https://github.com/python/mypy/issues/9169
msullivanhttps://github.com/msullivan
Jul 7, 2021 https://github.com/python/mypy/pull/9192#ref-commit-fa28616
https://github.com/hugues-aff
typeops: extend make_simplified_union fast path to enums (https://github.com/python/mypy/commit/fa28616f8bddf00d691eedeeb50459904bd42069
#9394https://github.com/python/mypy/pull/9394
)https://github.com/python/mypy/commit/fa28616f8bddf00d691eedeeb50459904bd42069
fa28616https://github.com/python/mypy/commit/fa28616f8bddf00d691eedeeb50459904bd42069
#9192https://github.com/python/mypy/pull/9192
#9169https://github.com/python/mypy/issues/9169
https://github.com/97littleleaf11
97littleleaf11https://github.com/97littleleaf11
Oct 5, 2021 https://github.com/python/mypy/pull/9192#ref-issue-593433369
Get rid of make_simplified_union() except in error messages #8624 https://github.com/python/mypy/issues/8624
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 7, 2025 https://github.com/python/mypy/pull/9192#ref-issue-3046365023
Add a benchmark involving realistic code that creates large unions astral-sh/ty#240 https://github.com/astral-sh/ty/issues/240
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9192
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/9192/files/f5490d970d3dfc0461d5107aed4ec7e497d8875f
Please reload this pagehttps://github.com/python/mypy/pull/9192
Please reload this pagehttps://github.com/python/mypy/pull/9192
https://github.com/Akuli
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.