| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5e25b4e4-f53d-2d8e-0c0a-881d7806d10c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B118:1BCD46:B706E6:F55F92:6B004D30 |
| html-safe-nonce | fe5f62746b4848967cff6962b8091f8b64036248e3f6c7c5539e722b99e48c6f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTE4OjFCQ0Q0NjpCNzA2RTY6RjU1RjkyOjZCMDA0RDMwIiwidmlzaXRvcl9pZCI6IjI3Mjg0MDUxMjUwNjc0NTk4ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fdd510ccc8c7874e4584b20988c9d22babf8c1e19c596d78a15765d3b8b84762 |
| hovercard-subject-tag | pull_request:447615549 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/9125/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12340daad68a4f76b11618380a532a8d057f3bee153b2a06b02e4e028ecbf12a/python/mypy/pull/9125 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12340daad68a4f76b11618380a532a8d057f3bee153b2a06b02e4e028ecbf12a/python/mypy/pull/9125 |
| og:image:alt | There are redundant expression warnings such as "Left operand of 'or' is always false" and "Left operand of 'and' is always true" that are previously categorized... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | llchan |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/9125#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9125 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9125 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/9125 |
| Reload | https://github.com/python/mypy/pull/9125 |
| Reload | https://github.com/python/mypy/pull/9125 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| llchan:redundant-expr | https://github.com/llchan/mypy/tree/redundant-expr |
| Conversation | https://github.com/python/mypy/pull/9125 |
| Commits7 (7) | https://github.com/python/mypy/pull/9125/commits |
| Checks | https://github.com/python/mypy/pull/9125/checks |
| Files changed | https://github.com/python/mypy/pull/9125/files |
| Distinguish redundant-expr warnings from unreachable warnings | https://github.com/python/mypy/pull/9125#top |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| llchan:redundant-expr | https://github.com/llchan/mypy/tree/redundant-expr |
|
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| Jul 10, 2020 | https://github.com/python/mypy/pull/9125#issue-655000357 |
| #8711 | https://github.com/python/mypy/issues/8711 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| Jul 10, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-656864043 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Jul 22, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-662546574 |
| #8975 | https://github.com/python/mypy/issues/8975 |
| #9172 | https://github.com/python/mypy/pull/9172 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| Jul 23, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-662773215 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| llchan | https://github.com/llchan |
| August 11, 2020 19:55 | https://github.com/python/mypy/pull/9125#commits-pushed-70b10cd |
|
| https://github.com/llchan |
| Distinguish redundant-expr warnings from unreachable warnings | https://github.com/python/mypy/pull/9125/commits/70b10cdcf586c7db9b64be2c53559e27576fe2da |
| 70b10cd | https://github.com/python/mypy/pull/9125/commits/70b10cdcf586c7db9b64be2c53559e27576fe2da |
|
| https://github.com/llchan |
| Use new --enable-error-codes functionlity | https://github.com/python/mypy/pull/9125/commits/a70cca803bcfaafc0366b1ed3f1ac3195d829ae6 |
| a70cca8 | https://github.com/python/mypy/pull/9125/commits/a70cca803bcfaafc0366b1ed3f1ac3195d829ae6 |
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| force-pushed | https://github.com/python/mypy/compare/00f66c9eae54d1abb77b8b45033899566e7acbd8..a70cca803bcfaafc0366b1ed3f1ac3195d829ae6 |
| 00f66c9 | https://github.com/python/mypy/commit/00f66c9eae54d1abb77b8b45033899566e7acbd8 |
| a70cca8 | https://github.com/python/mypy/commit/a70cca803bcfaafc0366b1ed3f1ac3195d829ae6 |
|
Compare
| https://github.com/python/mypy/compare/00f66c9eae54d1abb77b8b45033899566e7acbd8..a70cca803bcfaafc0366b1ed3f1ac3195d829ae6 |
| August 12, 2020 02:56 | https://github.com/python/mypy/pull/9125#event-3645763830 |
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| Aug 12, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-672552589 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Aug 14, 2020
| https://github.com/python/mypy/pull/9125#pullrequestreview-467535353 |
|
View reviewed changes
| https://github.com/python/mypy/pull/9125/files/a70cca803bcfaafc0366b1ed3f1ac3195d829ae6 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/9125#pullrequestreview-467535353 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| test-data/unit/check-redundant-expr.test | https://github.com/python/mypy/pull/9125/files/a70cca803bcfaafc0366b1ed3f1ac3195d829ae6#diff-b250649e44797827cbce2047ed90e0f8fc2a29116e4c302796183996da8f1224 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| test-data/unit/check-redundant-expr.test | https://github.com/python/mypy/pull/9125/files/a70cca803bcfaafc0366b1ed3f1ac3195d829ae6#diff-b250649e44797827cbce2047ed90e0f8fc2a29116e4c302796183996da8f1224 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| mypy/errorcodes.py | https://github.com/python/mypy/pull/9125/files/a70cca803bcfaafc0366b1ed3f1ac3195d829ae6#diff-4d7515936862a1554e61963c53f2de825d698e3acd21ea76bd410f1b06941ce6 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| llchan | https://github.com/llchan |
| August 14, 2020 14:10 | https://github.com/python/mypy/pull/9125#commits-pushed-c21bc4d |
|
| https://github.com/llchan |
| Set redundant-expr to disabled by default | https://github.com/python/mypy/pull/9125/commits/c21bc4d412530cb198c9aeb0cd6a200d6549f27d |
| c21bc4d | https://github.com/python/mypy/pull/9125/commits/c21bc4d412530cb198c9aeb0cd6a200d6549f27d |
|
| https://github.com/llchan |
| Move redundant-expr tests to check-errorcodes.test | https://github.com/python/mypy/pull/9125/commits/5676631892d2aadb438afccfb57a4c3602eb34fa |
| 5676631 | https://github.com/python/mypy/pull/9125/commits/5676631892d2aadb438afccfb57a4c3602eb34fa |
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| Aug 14, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-674231656 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
|
| https://github.com/llchan |
| Remove reference to deleted check-redundant-expr.test | https://github.com/python/mypy/pull/9125/commits/bc5dcc815221f78a75b123c9f2ed77e2b596e9f1 |
| bc5dcc8 | https://github.com/python/mypy/pull/9125/commits/bc5dcc815221f78a75b123c9f2ed77e2b596e9f1 |
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| Sep 22, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-696558241 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 22, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-696770673 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Sep 23, 2020
| https://github.com/python/mypy/pull/9125#pullrequestreview-494754075 |
|
View reviewed changes
| https://github.com/python/mypy/pull/9125/files/bc5dcc815221f78a75b123c9f2ed77e2b596e9f1 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/9125#pullrequestreview-494754075 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/9125/files/bc5dcc815221f78a75b123c9f2ed77e2b596e9f1#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/9125/files/bc5dcc815221f78a75b123c9f2ed77e2b596e9f1#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| gvanrossum | https://github.com/gvanrossum |
| Sep 23, 2020 | https://github.com/python/mypy/pull/9125#discussion_r493664501 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| llchan | https://github.com/llchan |
| Sep 24, 2020 | https://github.com/python/mypy/pull/9125#discussion_r494604614 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 23, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-697509374 |
| @llchan | https://github.com/llchan |
| #9054 | https://github.com/python/mypy/issues/9054 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
|
| https://github.com/llchan |
| Fix typo in redundant expr comment | https://github.com/python/mypy/pull/9125/commits/da88269dfed525a6afd2b2414f2b90acc53816fb |
| da88269 | https://github.com/python/mypy/pull/9125/commits/da88269dfed525a6afd2b2414f2b90acc53816fb |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 24, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-698587120 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| Sep 24, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-698587134 |
| @llchan | https://github.com/llchan |
| #9054 | https://github.com/python/mypy/issues/9054 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/llchan |
| llchan | https://github.com/llchan |
| Sep 24, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-698588506 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 24, 2020 | https://github.com/python/mypy/pull/9125#issuecomment-698588596 |
| @llchan | https://github.com/llchan |
| #9054 | https://github.com/python/mypy/issues/9054 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
|
| https://github.com/llchan |
| Add documentation for redundant-expr | https://github.com/python/mypy/pull/9125/commits/f8ee3bd3366259d1e54d58f739adcaaf8a603c98 |
| f8ee3bd | https://github.com/python/mypy/pull/9125/commits/f8ee3bd3366259d1e54d58f739adcaaf8a603c98 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Sep 24, 2020
| https://github.com/python/mypy/pull/9125#pullrequestreview-495963897 |
|
View reviewed changes
| https://github.com/python/mypy/pull/9125/files/f8ee3bd3366259d1e54d58f739adcaaf8a603c98 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/9125#pullrequestreview-495963897 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| f2dfd91 | https://github.com/python/mypy/commit/f2dfd91940da0bdb777228dc19c2b18a42d15682 |
| Sep 24, 2020 | https://github.com/python/mypy/pull/9125#event-3805229652 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F9125 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/9125/files/a70cca803bcfaafc0366b1ed3f1ac3195d829ae6 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/9125/files/f8ee3bd3366259d1e54d58f739adcaaf8a603c98 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
|
Unreachable with always true/false operands to and/or
| https://github.com/python/mypy/issues/8711 |
| Please reload this page | https://github.com/python/mypy/pull/9125 |
|
| https://github.com/llchan |
|
| https://github.com/JukkaL |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |