René's URL Explorer Experiment


Title: Revert "mypy: remove has_member (#8438)" by msullivan · Pull Request #8500 · python/mypy · GitHub

Open Graph Title: Revert "mypy: remove has_member (#8438)" by msullivan · Pull Request #8500 · python/mypy

X Title: Revert "mypy: remove has_member (#8438)" by msullivan · Pull Request #8500 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: It turns out that the has_member check is an important (accidental?) performance optimization. Removing this caused a major (30+%?) slowdown at dropbox. There might be a better way to optimize this...

X Description: It turns out that the has_member check is an important (accidental?) performance optimization. Removing this caused a major (30+%?) slowdown at dropbox. There might be a better way to optimize this...

Opengraph URL: https://github.com/python/mypy/pull/8500

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8fd3ab18-6009-a793-312e-ce6c217e7f67
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8688:2573D7:2143E34:2D4FA74:6B0023D2
html-safe-nonce3c335db42631e79a29257ebb2c4a25a4a872397ad262178228716cfb1927234f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Njg4OjI1NzNENzoyMTQzRTM0OjJENEZBNzQ6NkIwMDIzRDIiLCJ2aXNpdG9yX2lkIjoiNTEwNzg1NzcwMTg2NjU3ODg5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9db6f553ec974dc4b9d9940c4a5b771e72a83d2c70facc2d8840b65087399115
hovercard-subject-tagpull_request:384629609
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8500/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d3bef155de379bcf39a3359d2f48b024af5d50612bf221090ad1677c5941c5cf/python/mypy/pull/8500
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d3bef155de379bcf39a3359d2f48b024af5d50612bf221090ad1677c5941c5cf/python/mypy/pull/8500
og:image:altIt turns out that the has_member check is an important (accidental?) performance optimization. Removing this caused a major (30+%?) slowdown at dropbox. There might be a better way to optimize this...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsullivan
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/8500#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8500
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8500
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/8500
Reloadhttps://github.com/python/mypy/pull/8500
Reloadhttps://github.com/python/mypy/pull/8500
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
masterhttps://github.com/python/mypy/tree/master
fix-performance-regressionhttps://github.com/python/mypy/tree/fix-performance-regression
Conversationhttps://github.com/python/mypy/pull/8500
Commits1 (1)https://github.com/python/mypy/pull/8500/commits
Checkshttps://github.com/python/mypy/pull/8500/checks
Files changedhttps://github.com/python/mypy/pull/8500/files
Revert "mypy: remove has_member (#8438)"https://github.com/python/mypy/pull/8500#top
ilevkivskyihttps://github.com/ilevkivskyi
masterhttps://github.com/python/mypy/tree/master
fix-performance-regressionhttps://github.com/python/mypy/tree/fix-performance-regression
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Mar 6, 2020https://github.com/python/mypy/pull/8500#issue-576692783
09cdab4https://github.com/python/mypy/commit/09cdab4ffd34f89cc02f512fc35fdef57cb4c267
Please reload this pagehttps://github.com/python/mypy/pull/8500
https://github.com/msullivan
Revert "mypy: remove has_member (https://github.com/python/mypy/pull/8500/commits/52af4591da11d5888e9815eb3dadece2a3de42d5
#8438https://github.com/python/mypy/pull/8438
)"https://github.com/python/mypy/pull/8500/commits/52af4591da11d5888e9815eb3dadece2a3de42d5
52af459https://github.com/python/mypy/pull/8500/commits/52af4591da11d5888e9815eb3dadece2a3de42d5
09cdab4https://github.com/python/mypy/commit/09cdab4ffd34f89cc02f512fc35fdef57cb4c267
https://github.com/msullivan
msullivanhttps://github.com/msullivan
JukkaLhttps://github.com/JukkaL
ilevkivskyihttps://github.com/ilevkivskyi
March 6, 2020 04:36https://github.com/python/mypy/pull/8500#event-3103963298
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Mar 6, 2020https://github.com/python/mypy/pull/8500#issuecomment-595605861
@hauntsaninjahttps://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/8500
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 6, 2020 https://github.com/python/mypy/pull/8500#pullrequestreview-370195408
View reviewed changes https://github.com/python/mypy/pull/8500/files/52af4591da11d5888e9815eb3dadece2a3de42d5
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
514dbfbhttps://github.com/python/mypy/commit/514dbfbd9984a58081646fcfa6d8a4e9ba979f23
Mar 6, 2020https://github.com/python/mypy/pull/8500#event-3104658775
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
March 6, 2020 09:45https://github.com/python/mypy/pull/8500#event-3104658997
msullivanhttps://github.com/msullivan
Mar 6, 2020 https://github.com/python/mypy/pull/8500#ref-commit-dc0d35f
https://github.com/msullivan
Revert "mypy: remove has_member (https://github.com/python/mypy/commit/dc0d35f043c9d1405e1aea51ca293109ae2f1eef
#8438https://github.com/python/mypy/pull/8438
)" (https://github.com/python/mypy/commit/dc0d35f043c9d1405e1aea51ca293109ae2f1eef
#8500https://github.com/python/mypy/pull/8500
)https://github.com/python/mypy/commit/dc0d35f043c9d1405e1aea51ca293109ae2f1eef
dc0d35fhttps://github.com/python/mypy/commit/dc0d35f043c9d1405e1aea51ca293109ae2f1eef
09cdab4https://github.com/python/mypy/commit/09cdab4ffd34f89cc02f512fc35fdef57cb4c267
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Mar 7, 2020 https://github.com/python/mypy/pull/8500#ref-issue-570223638
Release 0.770 planning #8437 https://github.com/python/mypy/issues/8437
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Nov 28, 2021 https://github.com/python/mypy/pull/8500#ref-pullrequest-1064944964
Fix crash with overload and callable object decorators #11630 https://github.com/python/mypy/pull/11630
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8500
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/8500/files/52af4591da11d5888e9815eb3dadece2a3de42d5
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/8500
Please reload this pagehttps://github.com/python/mypy/pull/8500
https://github.com/msullivan
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.