| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7acdc8ad-252e-da43-6722-e4d2ffbc306c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E5A0:197995:2946F23:382F1AA:6B004ADD |
| html-safe-nonce | 08ed7b9b9d573e095fe84abdbf79be06d6a4f9faded07889559b2f0472fc5f7d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUEwOjE5Nzk5NToyOTQ2RjIzOjM4MkYxQUE6NkIwMDRBREQiLCJ2aXNpdG9yX2lkIjoiMzQ3NDUyNDA5MDY1NDU0MjU1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 469791c4249ae8b4954ef6ddbeabe1b4daa36ef96d4a67098f610f9192b36447 |
| hovercard-subject-tag | pull_request:381835650 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8461/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/934da8eae0f28a224cf323c6dc4dc2d8bd9eb991569ab30d23edc75b236fab03/python/mypy/pull/8461 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/934da8eae0f28a224cf323c6dc4dc2d8bd9eb991569ab30d23edc75b236fab03/python/mypy/pull/8461 |
| og:image:alt | What is this PR about ?
This PR is related to #8166 .
@brettcannon asked to include support for platform.system() with the existing sys.platform
Things I've Changed
Renamed platform to sys_pla... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joybh98 |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/8461#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8461 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8461 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/8461 |
| Reload | https://github.com/python/mypy/pull/8461 |
| Reload | https://github.com/python/mypy/pull/8461 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests545 (545) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| joybh98 | https://github.com/joybh98 |
| python:master | https://github.com/python/mypy/tree/master |
| joybh98:recoginize-sys-platform | https://github.com/joybh98/mypy/tree/recoginize-sys-platform |
| Conversation | https://github.com/python/mypy/pull/8461 |
| Commits5 (5) | https://github.com/python/mypy/pull/8461/commits |
| Checks | https://github.com/python/mypy/pull/8461/checks |
| Files changed | https://github.com/python/mypy/pull/8461/files |
| Added support for platform.system() | https://github.com/python/mypy/pull/8461#top |
| joybh98 | https://github.com/joybh98 |
| python:master | https://github.com/python/mypy/tree/master |
| joybh98:recoginize-sys-platform | https://github.com/joybh98/mypy/tree/recoginize-sys-platform |
|
| https://github.com/joybh98 |
| joybh98 | https://github.com/joybh98 |
| Feb 29, 2020 | https://github.com/python/mypy/pull/8461#issue-573275200 |
| #8166 | https://github.com/python/mypy/issues/8166 |
| @brettcannon | https://github.com/brettcannon |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
|
| https://github.com/joybh98 |
| added supprt for platform.system() | https://github.com/python/mypy/pull/8461/commits/8eb7b7d945285a405735385b1ee7748f450482e2 |
| 8eb7b7d | https://github.com/python/mypy/pull/8461/commits/8eb7b7d945285a405735385b1ee7748f450482e2 |
| https://github.com/joybh98 |
| joybh98 | https://github.com/joybh98 |
| Feb 29, 2020 | https://github.com/python/mypy/pull/8461#event-3084660463 |
| joybh98 | https://github.com/joybh98 |
| March 4, 2020 07:50 | https://github.com/python/mypy/pull/8461#commits-pushed-dfad35a |
|
| https://github.com/joybh98 |
| added support for compar expr for platform.system() | https://github.com/python/mypy/pull/8461/commits/dfad35ae5085518fe3ca8418dcf65134efe307db |
| dfad35a | https://github.com/python/mypy/pull/8461/commits/dfad35ae5085518fe3ca8418dcf65134efe307db |
|
| https://github.com/joybh98 |
| added test | https://github.com/python/mypy/pull/8461/commits/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3 |
| 0794d77 | https://github.com/python/mypy/pull/8461/commits/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
|
Mar 7, 2020
| https://github.com/python/mypy/pull/8461#pullrequestreview-370739257 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8461/files/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3 |
| emmatyping | https://github.com/emmatyping |
| https://github.com/python/mypy/pull/8461#pullrequestreview-370739257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| mypy/options.py | https://github.com/python/mypy/pull/8461/files/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3#diff-eb09ce67c2059bc9c117d4175e0bd34b1d75bbe8a91c3b9f69a8d14a9c8bc09f |
| emmatyping | https://github.com/emmatyping |
| Mar 7, 2020 | https://github.com/python/mypy/pull/8461#discussion_r389248201 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| emmatyping | https://github.com/emmatyping |
| Mar 11, 2020 | https://github.com/python/mypy/pull/8461#discussion_r390908370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| mypy/reachability.py | https://github.com/python/mypy/pull/8461/files/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3#diff-fa97c8d6b0cb41426e40035cb1c8a3a61cd647f84da36ce21cab30cd8ced386a |
| emmatyping | https://github.com/emmatyping |
| Mar 7, 2020 | https://github.com/python/mypy/pull/8461#discussion_r389248302 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| mypy/reachability.py | https://github.com/python/mypy/pull/8461/files/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3#diff-fa97c8d6b0cb41426e40035cb1c8a3a61cd647f84da36ce21cab30cd8ced386a |
| emmatyping | https://github.com/emmatyping |
| Mar 7, 2020 | https://github.com/python/mypy/pull/8461#discussion_r389248362 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| mypy/reachability.py | https://github.com/python/mypy/pull/8461/files/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3#diff-fa97c8d6b0cb41426e40035cb1c8a3a61cd647f84da36ce21cab30cd8ced386a |
| emmatyping | https://github.com/emmatyping |
| Mar 7, 2020 | https://github.com/python/mypy/pull/8461#discussion_r389248783 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| mypy/reachability.py | https://github.com/python/mypy/pull/8461/files/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3#diff-fa97c8d6b0cb41426e40035cb1c8a3a61cd647f84da36ce21cab30cd8ced386a |
| emmatyping | https://github.com/emmatyping |
| Mar 7, 2020 | https://github.com/python/mypy/pull/8461#discussion_r389248910 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| mypy/reachability.py | https://github.com/python/mypy/pull/8461/files/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3#diff-fa97c8d6b0cb41426e40035cb1c8a3a61cd647f84da36ce21cab30cd8ced386a |
| emmatyping | https://github.com/emmatyping |
| Mar 7, 2020 | https://github.com/python/mypy/pull/8461#discussion_r389248976 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/8461/files/0794d77dcf6dbdefd32f874b5b4b2d2b20edaad3#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| emmatyping | https://github.com/emmatyping |
| Mar 7, 2020 | https://github.com/python/mypy/pull/8461#discussion_r389249035 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| https://github.com/joybh98 |
| joybh98 | https://github.com/joybh98 |
| Mar 8, 2020 | https://github.com/python/mypy/pull/8461#issuecomment-596188826 |
| @ethanhs | https://github.com/ethanhs |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
|
| https://github.com/joybh98 |
| added requested changes | https://github.com/python/mypy/pull/8461/commits/2df738ececda109f8448381cbdcfdb65d2e6c049 |
| 2df738e | https://github.com/python/mypy/pull/8461/commits/2df738ececda109f8448381cbdcfdb65d2e6c049 |
| https://github.com/joybh98 |
| joybh98 | https://github.com/joybh98 |
| Mar 11, 2020 | https://github.com/python/mypy/pull/8461#issuecomment-597418542 |
| @ethanhs | https://github.com/ethanhs |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
|
| https://github.com/joybh98 |
| fixed called variable to platform from sys_platform | https://github.com/python/mypy/pull/8461/commits/92a6aa21ae61f33081550272ae446a9e9f66cd51 |
| 92a6aa2 | https://github.com/python/mypy/pull/8461/commits/92a6aa21ae61f33081550272ae446a9e9f66cd51 |
| https://github.com/joybh98 |
| joybh98 | https://github.com/joybh98 |
| Mar 13, 2020 | https://github.com/python/mypy/pull/8461#issuecomment-598568091 |
| @ethanhs | https://github.com/ethanhs |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| Mar 13, 2020 | https://github.com/python/mypy/pull/8461#issuecomment-598641085 |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
|
Mar 16, 2020
| https://github.com/python/mypy/pull/8461#pullrequestreview-375030917 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8461/files/92a6aa21ae61f33081550272ae446a9e9f66cd51 |
| mypy/reachability.py | https://github.com/python/mypy/pull/8461/files/92a6aa21ae61f33081550272ae446a9e9f66cd51#diff-fa97c8d6b0cb41426e40035cb1c8a3a61cd647f84da36ce21cab30cd8ced386a |
| emmatyping | https://github.com/emmatyping |
| Mar 16, 2020 | https://github.com/python/mypy/pull/8461#discussion_r392878307 |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| Mar 16, 2020 | https://github.com/python/mypy/pull/8461#issuecomment-599443619 |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| @JukkaL | https://github.com/JukkaL |
| sys.platform | https://docs.python.org/3/library/sys.html#sys.platform |
| platform.system() | https://docs.python.org/3/library/platform.html#platform.system |
| https://stackoverflow.com/a/32612402 | https://stackoverflow.com/a/32612402 |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Mar 18, 2020
| https://github.com/python/mypy/pull/8461#pullrequestreview-377031434 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8461/files/92a6aa21ae61f33081550272ae446a9e9f66cd51 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/8461#pullrequestreview-377031434 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/8461/files/92a6aa21ae61f33081550272ae446a9e9f66cd51#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| JukkaL | https://github.com/JukkaL |
| Mar 18, 2020 | https://github.com/python/mypy/pull/8461#discussion_r394477929 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jul 26, 2020
| https://github.com/python/mypy/pull/8461#ref-issue-582408792 |
|
How can I make this # type: ignore platform specific?
#8547
| https://github.com/python/mypy/issues/8547 |
| https://github.com/Akuli |
| Akuli | https://github.com/Akuli |
|
Jun 21, 2021
| https://github.com/python/mypy/pull/8461#ref-pullrequest-926229658 |
|
literal return type for platform.system()
python/typeshed#5671
| https://github.com/python/typeshed/pull/5671 |
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
|
Jun 21, 2021
| https://github.com/python/mypy/pull/8461#ref-pullrequest-926538894 |
|
feat: reachability recognizes platform.system()
#10686
| https://github.com/python/mypy/pull/10686 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Aug 4, 2021 | https://github.com/python/mypy/pull/8461#issuecomment-892496940 |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Aug 4, 2021 | https://github.com/python/mypy/pull/8461#event-5109756099 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8461 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/8461/files/92a6aa21ae61f33081550272ae446a9e9f66cd51 |
|
| https://github.com/emmatyping |
|
emmatyping
| https://github.com/emmatyping |
|
| https://github.com/python/mypy/pull/8461/files/92a6aa21ae61f33081550272ae446a9e9f66cd51 |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
| Please reload this page | https://github.com/python/mypy/pull/8461 |
|
| https://github.com/joybh98 |
|
| https://github.com/emmatyping |
|
| https://github.com/hauntsaninja |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |