| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f78df576-40cb-46ca-00f3-5c21e078158f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C1B2:1F5A:68382D:94A737:6B0048F2 |
| html-safe-nonce | c8609b4f5a6097f7498154366656b25b7f7e97e86a897214869f1a5438785ccc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUIyOjFGNUE6NjgzODJEOjk0QTczNzo2QjAwNDhGMiIsInZpc2l0b3JfaWQiOiI3NDI5ODU1NDcwMzU0OTc0OTYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3a8431de96aae8f622b0cb794e6ee3f35cfd9d772d011f2600762d4c76daa94f |
| hovercard-subject-tag | pull_request:367860990 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8339/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a8ab00c9ecafad0c30a4cff1ba62ef2e44b29d520651bdf1e0492f73213caa21/python/mypy/pull/8339 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a8ab00c9ecafad0c30a4cff1ba62ef2e44b29d520651bdf1e0492f73213caa21/python/mypy/pull/8339 |
| og:image:alt | I wanted to implement dataclasses.asdict returning TypedDicts. I ran into issues supporting the recursion that it does. Does anyone have suggestions as to the problems I commented in the tests? Tha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | syastrov |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/8339#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8339 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8339 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/8339 |
| Reload | https://github.com/python/mypy/pull/8339 |
| Reload | https://github.com/python/mypy/pull/8339 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests545 (545) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| syastrov | https://github.com/syastrov |
| python:master | https://github.com/python/mypy/tree/master |
| syastrov:dataclasses-asdict | https://github.com/syastrov/mypy/tree/dataclasses-asdict |
| Conversation | https://github.com/python/mypy/pull/8339 |
| Commits10 (10) | https://github.com/python/mypy/pull/8339/commits |
| Checks | https://github.com/python/mypy/pull/8339/checks |
| Files changed | https://github.com/python/mypy/pull/8339/files |
| DRAFT: Returning TypedDict for dataclasses.asdict | https://github.com/python/mypy/pull/8339#top |
| syastrov | https://github.com/syastrov |
| python:master | https://github.com/python/mypy/tree/master |
| syastrov:dataclasses-asdict | https://github.com/syastrov/mypy/tree/dataclasses-asdict |
|
| https://github.com/syastrov |
| syastrov | https://github.com/syastrov |
| Jan 28, 2020 | https://github.com/python/mypy/pull/8339#issue-556025336 |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| https://github.com/python/mypy/pull/8339/files#diff-5b6d315f9321d8b1943195ed39e18f14R1084 | https://github.com/python/mypy/pull/8339/files#diff-5b6d315f9321d8b1943195ed39e18f14R1084 |
| #5152 | https://github.com/python/mypy/issues/5152 |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| syastrov | https://github.com/syastrov |
| January 21, 2020 16:51 | https://github.com/python/mypy/pull/8339#commits-pushed-ce446f4 |
|
| https://github.com/syastrov |
| Implement support for returning TypedDict for dataclasses.asdict | https://github.com/python/mypy/pull/8339/commits/ce446f4f286613cd72a7839a6cdda7126040e9c9 |
| ce446f4 | https://github.com/python/mypy/pull/8339/commits/ce446f4f286613cd72a7839a6cdda7126040e9c9 |
|
| https://github.com/syastrov |
| Add draft of test for recursive asdict. | https://github.com/python/mypy/pull/8339/commits/0ed29c6b57e0419c3512c29c8ad3a4ffee0eabbd |
| 0ed29c6 | https://github.com/python/mypy/pull/8339/commits/0ed29c6b57e0419c3512c29c8ad3a4ffee0eabbd |
| https://github.com/intgr |
| intgr | https://github.com/intgr |
| Jan 28, 2020 | https://github.com/python/mypy/pull/8339#issuecomment-579376146 |
| TypeScript's mapped types | https://www.typescriptlang.org/docs/handbook/advanced-types.html#mapped-types |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| https://github.com/syastrov |
| syastrov | https://github.com/syastrov |
| Jan 29, 2020 | https://github.com/python/mypy/pull/8339#issuecomment-579638820 |
| @intgr | https://github.com/intgr |
| https://github.com/python/typing/ | https://github.com/python/typing/ |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Jan 29, 2020 | https://github.com/python/mypy/pull/8339#issuecomment-580004856 |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| syastrov | https://github.com/syastrov |
| February 8, 2020 11:31 | https://github.com/python/mypy/pull/8339#commits-pushed-05a554c |
|
| https://github.com/syastrov |
| dataclasses.asdict: Handle list/tuple/dicts/namedtuples recursively. | https://github.com/python/mypy/pull/8339/commits/05a554cd3967ccac0abb8f43c765599bab3b47a4 |
| 05a554c | https://github.com/python/mypy/pull/8339/commits/05a554cd3967ccac0abb8f43c765599bab3b47a4 |
|
| https://github.com/syastrov |
| Test that List[Any] works. | https://github.com/python/mypy/pull/8339/commits/9330542129bd521ab4062ea5b5de8c4e8c7dcaed |
| 9330542 | https://github.com/python/mypy/pull/8339/commits/9330542129bd521ab4062ea5b5de8c4e8c7dcaed |
|
| https://github.com/syastrov |
| dataclasses.asdict: Handle default_factory. Work on NamedTuple test/s… | https://github.com/python/mypy/pull/8339/commits/e1c3d13facc83dbbe6d4f1dc2bcb29d1149d239e |
| e1c3d13 | https://github.com/python/mypy/pull/8339/commits/e1c3d13facc83dbbe6d4f1dc2bcb29d1149d239e |
|
| https://github.com/syastrov |
| asdict: Support unions. | https://github.com/python/mypy/pull/8339/commits/12a644fbbc2fc5cdfb683c11708e7db490ca4d12 |
| 12a644f | https://github.com/python/mypy/pull/8339/commits/12a644fbbc2fc5cdfb683c11708e7db490ca4d12 |
|
| https://github.com/syastrov |
| asdict: produce an error when recursion detected. cleanup. | https://github.com/python/mypy/pull/8339/commits/c26d6d7e44399722757db2fd047ad5bf6039fd36 |
| c26d6d7 | https://github.com/python/mypy/pull/8339/commits/c26d6d7e44399722757db2fd047ad5bf6039fd36 |
| https://github.com/syastrov |
| syastrov | https://github.com/syastrov |
| force-pushed | https://github.com/python/mypy/compare/e2daec88259fe33cd3211b9102e3f344d8db6f3d..c26d6d7e44399722757db2fd047ad5bf6039fd36 |
| e2daec8 | https://github.com/python/mypy/commit/e2daec88259fe33cd3211b9102e3f344d8db6f3d |
| c26d6d7 | https://github.com/python/mypy/commit/c26d6d7e44399722757db2fd047ad5bf6039fd36 |
|
Compare
| https://github.com/python/mypy/compare/e2daec88259fe33cd3211b9102e3f344d8db6f3d..c26d6d7e44399722757db2fd047ad5bf6039fd36 |
| February 12, 2020 14:17 | https://github.com/python/mypy/pull/8339#event-3030979577 |
|
| https://github.com/syastrov |
| asdict: Support subclasses of list/dict (test missing for dict). | https://github.com/python/mypy/pull/8339/commits/0111e3646f174246bebedc979f5785d89ef73c05 |
| 0111e36 | https://github.com/python/mypy/pull/8339/commits/0111e3646f174246bebedc979f5785d89ef73c05 |
| https://github.com/syastrov |
| syastrov | https://github.com/syastrov |
| Feb 12, 2020 | https://github.com/python/mypy/pull/8339#issuecomment-585256497 |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| @JukkaL | https://github.com/JukkaL |
| 0111e36#diff-5b6d315f9321d8b1943195ed39e18f14R1181 | https://github.com/python/mypy/commit/0111e3646f174246bebedc979f5785d89ef73c05#diff-5b6d315f9321d8b1943195ed39e18f14R1181 |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| syastrov | https://github.com/syastrov |
| February 17, 2020 07:44 | https://github.com/python/mypy/pull/8339#commits-pushed-a5bd093 |
|
| https://github.com/syastrov |
| asdict: Small cleanup | https://github.com/python/mypy/pull/8339/commits/a5bd093d0709a8074474579528ce40fc35bf7854 |
| a5bd093 | https://github.com/python/mypy/pull/8339/commits/a5bd093d0709a8074474579528ce40fc35bf7854 |
|
| https://github.com/syastrov |
| asdict: For now, handle subtypes of list/dict by converting them to i… | https://github.com/python/mypy/pull/8339/commits/139694539aaa6c179b1ffe528cacbea01ff66e68 |
| 1396945 | https://github.com/python/mypy/pull/8339/commits/139694539aaa6c179b1ffe528cacbea01ff66e68 |
| https://github.com/syastrov |
| syastrov | https://github.com/syastrov |
| Mar 24, 2020 | https://github.com/python/mypy/pull/8339#issuecomment-603542140 |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| https://github.com/syastrov |
| syastrov | https://github.com/syastrov |
| Mar 24, 2020 | https://github.com/python/mypy/pull/8339#event-3161823282 |
| https://github.com/syastrov |
| syastrov | https://github.com/syastrov |
|
Mar 26, 2020
| https://github.com/python/mypy/pull/8339#ref-pullrequest-587328934 |
|
Implement support for returning TypedDict for dataclasses.asdict
#8583
| https://github.com/python/mypy/pull/8583 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8339 |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
| Please reload this page | https://github.com/python/mypy/pull/8339 |
|
| https://github.com/syastrov |
|
| https://github.com/intgr |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |