René's URL Explorer Experiment


Title: Make isinstance/issubclass generate ad-hoc intersections by Michael0x2a · Pull Request #8305 · python/mypy · GitHub

Open Graph Title: Make isinstance/issubclass generate ad-hoc intersections by Michael0x2a · Pull Request #8305 · python/mypy

X Title: Make isinstance/issubclass generate ad-hoc intersections by Michael0x2a · Pull Request #8305 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This diff makes isinstance(...) and issubclass(...) try generating ad-hoc intersections of Instances when possible. For example, we previously concluded the if-branch is unreachable in the followin...

X Description: This diff makes isinstance(...) and issubclass(...) try generating ad-hoc intersections of Instances when possible. For example, we previously concluded the if-branch is unreachable in the followin...

Opengraph URL: https://github.com/python/mypy/pull/8305

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e5d2b664-cdf5-18aa-f107-91eaf8ae3735
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9ADE:392E27:13A602E:19DE880:6B001512
html-safe-nonce47e811131ed7168d3b5a95e3598a89f1f4bfcf2e9fe2818e2376687fa974c5c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QURFOjM5MkUyNzoxM0E2MDJFOjE5REU4ODA6NkIwMDE1MTIiLCJ2aXNpdG9yX2lkIjoiMjI2Mzc2NzAyNDU5MTE4MTA3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0692b3eabed5ccd052eee90ee492dddb1e898b0a08baa03f3ce7c27c249b5e6a
hovercard-subject-tagpull_request:364982238
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8305/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c7a9a4f4aadb151ce415bffcf5240d41e891a85e9174c0718093ff6185b66d49/python/mypy/pull/8305
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c7a9a4f4aadb151ce415bffcf5240d41e891a85e9174c0718093ff6185b66d49/python/mypy/pull/8305
og:image:altThis diff makes isinstance(...) and issubclass(...) try generating ad-hoc intersections of Instances when possible. For example, we previously concluded the if-branch is unreachable in the followin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
Nonea2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release70121d4e855ee0bb7b75cf15d061d91f8863c0f8
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/8305#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8305
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8305
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/8305
Reloadhttps://github.com/python/mypy/pull/8305
Reloadhttps://github.com/python/mypy/pull/8305
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:add-ad-hoc-intersections-v2https://github.com/Michael0x2a/mypy/tree/add-ad-hoc-intersections-v2
Conversationhttps://github.com/python/mypy/pull/8305
Commits5 (5)https://github.com/python/mypy/pull/8305/commits
Checkshttps://github.com/python/mypy/pull/8305/checks
Files changedhttps://github.com/python/mypy/pull/8305/files
Make isinstance/issubclass generate ad-hoc intersectionshttps://github.com/python/mypy/pull/8305#top
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:add-ad-hoc-intersections-v2https://github.com/Michael0x2a/mypy/tree/add-ad-hoc-intersections-v2
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jan 20, 2020https://github.com/python/mypy/pull/8305#issue-552483475
#3603 (comment)https://github.com/python/mypy/issues/3603#issuecomment-506996850
Please reload this pagehttps://github.com/python/mypy/pull/8305
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jan 20, 2020https://github.com/python/mypy/pull/8305#issuecomment-576415402
Please reload this pagehttps://github.com/python/mypy/pull/8305
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
Jan 21, 2020 https://github.com/python/mypy/pull/8305#ref-pullrequest-552576434
Pin pytest #8308 https://github.com/python/mypy/pull/8308
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
Jan 21, 2020https://github.com/python/mypy/pull/8305#issuecomment-576480277
@Michael0x2ahttps://github.com/Michael0x2a
#8308https://github.com/python/mypy/pull/8308
Please reload this pagehttps://github.com/python/mypy/pull/8305
https://github.com/Michael0x2a
Make isinstance/issubclass generate ad-hoc intersectionshttps://github.com/python/mypy/pull/8305/commits/f0d83f0278022987a5a2c01d0fa4663d4878da68
f0d83f0https://github.com/python/mypy/pull/8305/commits/f0d83f0278022987a5a2c01d0fa4663d4878da68
python#3603 (comment)https://github.com/python/mypy/issues/3603#issuecomment-506996850
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
force-pushedhttps://github.com/python/mypy/compare/658150d2e97f32910f1370970f37ce7fa7d7cb9a..f0d83f0278022987a5a2c01d0fa4663d4878da68
658150dhttps://github.com/python/mypy/commit/658150d2e97f32910f1370970f37ce7fa7d7cb9a
f0d83f0https://github.com/python/mypy/commit/f0d83f0278022987a5a2c01d0fa4663d4878da68
Compare https://github.com/python/mypy/compare/658150d2e97f32910f1370970f37ce7fa7d7cb9a..f0d83f0278022987a5a2c01d0fa4663d4878da68
January 21, 2020 03:40https://github.com/python/mypy/pull/8305#event-2964746614
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 21, 2020https://github.com/python/mypy/pull/8305#issuecomment-576750027
Please reload this pagehttps://github.com/python/mypy/pull/8305
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 21, 2020https://github.com/python/mypy/pull/8305#issuecomment-576893439
Please reload this pagehttps://github.com/python/mypy/pull/8305
Michael0x2ahttps://github.com/Michael0x2a
January 21, 2020 23:08https://github.com/python/mypy/pull/8305#commits-pushed-fa2dbb5
https://github.com/Michael0x2a
Add some incremental mode testshttps://github.com/python/mypy/pull/8305/commits/fa2dbb53eb4b18553021ed72d6891a11c77d9b59
fa2dbb5https://github.com/python/mypy/pull/8305/commits/fa2dbb53eb4b18553021ed72d6891a11c77d9b59
https://github.com/Michael0x2a
Add workaround for mypyc bughttps://github.com/python/mypy/pull/8305/commits/910135f5b78dc163bc721edd449a2eebee45019d
910135fhttps://github.com/python/mypy/pull/8305/commits/910135f5b78dc163bc721edd449a2eebee45019d
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jan 22, 2020https://github.com/python/mypy/pull/8305#issuecomment-577042866
Please reload this pagehttps://github.com/python/mypy/pull/8305
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 22, 2020https://github.com/python/mypy/pull/8305#issuecomment-577383725
Please reload this pagehttps://github.com/python/mypy/pull/8305
Please reload this pagehttps://github.com/python/mypy/pull/8305
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 22, 2020https://github.com/python/mypy/pull/8305#issuecomment-577395547
Please reload this pagehttps://github.com/python/mypy/pull/8305
msullivanhttps://github.com/msullivan
Jan 22, 2020 https://github.com/python/mypy/pull/8305#ref-commit-af2eaee
https://github.com/msullivan
Make the fine-grained mergechecker work againhttps://github.com/python/mypy/commit/af2eaee419e6b5f370e590539afbf9578e549123
af2eaeehttps://github.com/python/mypy/commit/af2eaee419e6b5f370e590539afbf9578e549123
#8305https://github.com/python/mypy/pull/8305
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 22, 2020 https://github.com/python/mypy/pull/8305#ref-pullrequest-553819973
Make the fine-grained mergechecker work again #8313 https://github.com/python/mypy/pull/8313
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 22, 2020 https://github.com/python/mypy/pull/8305#pullrequestreview-346935231
View reviewed changes https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d
mypy/checker.pyhttps://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
msullivanhttps://github.com/msullivan
Jan 22, 2020https://github.com/python/mypy/pull/8305#discussion_r369828749
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8305
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 22, 2020 https://github.com/python/mypy/pull/8305#pullrequestreview-346946757
View reviewed changes https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d
msullivanhttps://github.com/msullivan
https://github.com/python/mypy/pull/8305#pullrequestreview-346946757
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8305
mypy/checker.pyhttps://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/8305
mypy/checker.pyhttps://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/8305
Michael0x2ahttps://github.com/Michael0x2a
January 23, 2020 08:58https://github.com/python/mypy/pull/8305#commits-pushed-1810411
https://github.com/Michael0x2a
Merge branch 'master' into add-ad-hoc-intersections-v2https://github.com/python/mypy/pull/8305/commits/181041178d5e7bfe2abc19dbfb24390b11491765
1810411https://github.com/python/mypy/pull/8305/commits/181041178d5e7bfe2abc19dbfb24390b11491765
https://github.com/Michael0x2a
Respond to code review and add more commentshttps://github.com/python/mypy/pull/8305/commits/76252579524767994195e2d23e1b6ddb9188ef1b
7625257https://github.com/python/mypy/pull/8305/commits/76252579524767994195e2d23e1b6ddb9188ef1b
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
ad6c717https://github.com/python/mypy/commit/ad6c717c408c6ab6d21a488ab1f89930448ae83c
Jan 23, 2020https://github.com/python/mypy/pull/8305#event-2974904652
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
January 23, 2020 19:04https://github.com/python/mypy/pull/8305#event-2974904888
msullivanhttps://github.com/msullivan
Jan 23, 2020 https://github.com/python/mypy/pull/8305#ref-commit-9c2b8b3
https://github.com/msullivan
Make the fine-grained mergechecker work again (https://github.com/python/mypy/commit/9c2b8b3651a8ec1d063f124f90008e5324e8e450
#8313https://github.com/python/mypy/pull/8313
)https://github.com/python/mypy/commit/9c2b8b3651a8ec1d063f124f90008e5324e8e450
9c2b8b3https://github.com/python/mypy/commit/9c2b8b3651a8ec1d063f124f90008e5324e8e450
#8305https://github.com/python/mypy/pull/8305
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jan 28, 2020 https://github.com/python/mypy/pull/8305#ref-issue-204164420
assert isinstance check for a non-subtype confuses mypy #2776 https://github.com/python/mypy/issues/2776
https://github.com/pirate
piratehttps://github.com/pirate
Feb 4, 2020 https://github.com/python/mypy/pull/8305#ref-issue-285605017
Changing order of isinstance checks breaks inferred type #4422 https://github.com/python/mypy/issues/4422
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8305
https://github.com/msullivan
msullivan https://github.com/msullivan
https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d
Please reload this pagehttps://github.com/python/mypy/pull/8305
Please reload this pagehttps://github.com/python/mypy/pull/8305
https://github.com/Michael0x2a
https://github.com/emmatyping
https://github.com/ilevkivskyi
https://github.com/msullivan
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.