| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e5d2b664-cdf5-18aa-f107-91eaf8ae3735 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9ADE:392E27:13A602E:19DE880:6B001512 |
| html-safe-nonce | 47e811131ed7168d3b5a95e3598a89f1f4bfcf2e9fe2818e2376687fa974c5c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QURFOjM5MkUyNzoxM0E2MDJFOjE5REU4ODA6NkIwMDE1MTIiLCJ2aXNpdG9yX2lkIjoiMjI2Mzc2NzAyNDU5MTE4MTA3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0692b3eabed5ccd052eee90ee492dddb1e898b0a08baa03f3ce7c27c249b5e6a |
| hovercard-subject-tag | pull_request:364982238 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8305/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c7a9a4f4aadb151ce415bffcf5240d41e891a85e9174c0718093ff6185b66d49/python/mypy/pull/8305 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c7a9a4f4aadb151ce415bffcf5240d41e891a85e9174c0718093ff6185b66d49/python/mypy/pull/8305 |
| og:image:alt | This diff makes isinstance(...) and issubclass(...) try generating ad-hoc intersections of Instances when possible.
For example, we previously concluded the if-branch is unreachable in the followin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Michael0x2a |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/8305#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8305 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8305 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/8305 |
| Reload | https://github.com/python/mypy/pull/8305 |
| Reload | https://github.com/python/mypy/pull/8305 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| Michael0x2a | https://github.com/Michael0x2a |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:add-ad-hoc-intersections-v2 | https://github.com/Michael0x2a/mypy/tree/add-ad-hoc-intersections-v2 |
| Conversation | https://github.com/python/mypy/pull/8305 |
| Commits5 (5) | https://github.com/python/mypy/pull/8305/commits |
| Checks | https://github.com/python/mypy/pull/8305/checks |
| Files changed | https://github.com/python/mypy/pull/8305/files |
| Make isinstance/issubclass generate ad-hoc intersections | https://github.com/python/mypy/pull/8305#top |
| Michael0x2a | https://github.com/Michael0x2a |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:add-ad-hoc-intersections-v2 | https://github.com/Michael0x2a/mypy/tree/add-ad-hoc-intersections-v2 |
|
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Jan 20, 2020 | https://github.com/python/mypy/pull/8305#issue-552483475 |
| #3603 (comment) | https://github.com/python/mypy/issues/3603#issuecomment-506996850 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Jan 20, 2020 | https://github.com/python/mypy/pull/8305#issuecomment-576415402 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
|
Jan 21, 2020
| https://github.com/python/mypy/pull/8305#ref-pullrequest-552576434 |
|
Pin pytest
#8308
| https://github.com/python/mypy/pull/8308 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| Jan 21, 2020 | https://github.com/python/mypy/pull/8305#issuecomment-576480277 |
| @Michael0x2a | https://github.com/Michael0x2a |
| #8308 | https://github.com/python/mypy/pull/8308 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
|
| https://github.com/Michael0x2a |
| Make isinstance/issubclass generate ad-hoc intersections | https://github.com/python/mypy/pull/8305/commits/f0d83f0278022987a5a2c01d0fa4663d4878da68 |
| f0d83f0 | https://github.com/python/mypy/pull/8305/commits/f0d83f0278022987a5a2c01d0fa4663d4878da68 |
| python#3603 (comment) | https://github.com/python/mypy/issues/3603#issuecomment-506996850 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| force-pushed | https://github.com/python/mypy/compare/658150d2e97f32910f1370970f37ce7fa7d7cb9a..f0d83f0278022987a5a2c01d0fa4663d4878da68 |
| 658150d | https://github.com/python/mypy/commit/658150d2e97f32910f1370970f37ce7fa7d7cb9a |
| f0d83f0 | https://github.com/python/mypy/commit/f0d83f0278022987a5a2c01d0fa4663d4878da68 |
|
Compare
| https://github.com/python/mypy/compare/658150d2e97f32910f1370970f37ce7fa7d7cb9a..f0d83f0278022987a5a2c01d0fa4663d4878da68 |
| January 21, 2020 03:40 | https://github.com/python/mypy/pull/8305#event-2964746614 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jan 21, 2020 | https://github.com/python/mypy/pull/8305#issuecomment-576750027 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| Jan 21, 2020 | https://github.com/python/mypy/pull/8305#issuecomment-576893439 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| Michael0x2a | https://github.com/Michael0x2a |
| January 21, 2020 23:08 | https://github.com/python/mypy/pull/8305#commits-pushed-fa2dbb5 |
|
| https://github.com/Michael0x2a |
| Add some incremental mode tests | https://github.com/python/mypy/pull/8305/commits/fa2dbb53eb4b18553021ed72d6891a11c77d9b59 |
| fa2dbb5 | https://github.com/python/mypy/pull/8305/commits/fa2dbb53eb4b18553021ed72d6891a11c77d9b59 |
|
| https://github.com/Michael0x2a |
| Add workaround for mypyc bug | https://github.com/python/mypy/pull/8305/commits/910135f5b78dc163bc721edd449a2eebee45019d |
| 910135f | https://github.com/python/mypy/pull/8305/commits/910135f5b78dc163bc721edd449a2eebee45019d |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Jan 22, 2020 | https://github.com/python/mypy/pull/8305#issuecomment-577042866 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| Jan 22, 2020 | https://github.com/python/mypy/pull/8305#issuecomment-577383725 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| Jan 22, 2020 | https://github.com/python/mypy/pull/8305#issuecomment-577395547 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| msullivan | https://github.com/msullivan |
|
Jan 22, 2020
| https://github.com/python/mypy/pull/8305#ref-commit-af2eaee |
|
| https://github.com/msullivan |
| Make the fine-grained mergechecker work again | https://github.com/python/mypy/commit/af2eaee419e6b5f370e590539afbf9578e549123 |
| af2eaee | https://github.com/python/mypy/commit/af2eaee419e6b5f370e590539afbf9578e549123 |
| #8305 | https://github.com/python/mypy/pull/8305 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 22, 2020
| https://github.com/python/mypy/pull/8305#ref-pullrequest-553819973 |
|
Make the fine-grained mergechecker work again
#8313
| https://github.com/python/mypy/pull/8313 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 22, 2020
| https://github.com/python/mypy/pull/8305#pullrequestreview-346935231 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d |
| mypy/checker.py | https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| msullivan | https://github.com/msullivan |
| Jan 22, 2020 | https://github.com/python/mypy/pull/8305#discussion_r369828749 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 22, 2020
| https://github.com/python/mypy/pull/8305#pullrequestreview-346946757 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d |
| msullivan | https://github.com/msullivan |
| https://github.com/python/mypy/pull/8305#pullrequestreview-346946757 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| mypy/checker.py | https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| mypy/checker.py | https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| Michael0x2a | https://github.com/Michael0x2a |
| January 23, 2020 08:58 | https://github.com/python/mypy/pull/8305#commits-pushed-1810411 |
|
| https://github.com/Michael0x2a |
| Merge branch 'master' into add-ad-hoc-intersections-v2 | https://github.com/python/mypy/pull/8305/commits/181041178d5e7bfe2abc19dbfb24390b11491765 |
| 1810411 | https://github.com/python/mypy/pull/8305/commits/181041178d5e7bfe2abc19dbfb24390b11491765 |
|
| https://github.com/Michael0x2a |
| Respond to code review and add more comments | https://github.com/python/mypy/pull/8305/commits/76252579524767994195e2d23e1b6ddb9188ef1b |
| 7625257 | https://github.com/python/mypy/pull/8305/commits/76252579524767994195e2d23e1b6ddb9188ef1b |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| ad6c717 | https://github.com/python/mypy/commit/ad6c717c408c6ab6d21a488ab1f89930448ae83c |
| Jan 23, 2020 | https://github.com/python/mypy/pull/8305#event-2974904652 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| January 23, 2020 19:04 | https://github.com/python/mypy/pull/8305#event-2974904888 |
| msullivan | https://github.com/msullivan |
|
Jan 23, 2020
| https://github.com/python/mypy/pull/8305#ref-commit-9c2b8b3 |
|
| https://github.com/msullivan |
| Make the fine-grained mergechecker work again ( | https://github.com/python/mypy/commit/9c2b8b3651a8ec1d063f124f90008e5324e8e450 |
| #8313 | https://github.com/python/mypy/pull/8313 |
| ) | https://github.com/python/mypy/commit/9c2b8b3651a8ec1d063f124f90008e5324e8e450 |
| 9c2b8b3 | https://github.com/python/mypy/commit/9c2b8b3651a8ec1d063f124f90008e5324e8e450 |
| #8305 | https://github.com/python/mypy/pull/8305 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Jan 28, 2020
| https://github.com/python/mypy/pull/8305#ref-issue-204164420 |
|
assert isinstance check for a non-subtype confuses mypy
#2776
| https://github.com/python/mypy/issues/2776 |
| https://github.com/pirate |
| pirate | https://github.com/pirate |
|
Feb 4, 2020
| https://github.com/python/mypy/pull/8305#ref-issue-285605017 |
|
Changing order of isinstance checks breaks inferred type
#4422
| https://github.com/python/mypy/issues/4422 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8305 |
|
| https://github.com/msullivan |
|
msullivan
| https://github.com/msullivan |
|
| https://github.com/python/mypy/pull/8305/files/910135f5b78dc163bc721edd449a2eebee45019d |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
| Please reload this page | https://github.com/python/mypy/pull/8305 |
|
| https://github.com/Michael0x2a |
|
| https://github.com/emmatyping |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/msullivan |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |