| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f53be893-7db4-05a7-086f-2e3e1e1bb1df |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E90E:1A1C04:19B951C:22D21E7:6AFFFB37 |
| html-safe-nonce | 9e98be14f81309289993950cc7dcc94729df118cf25baa50da69ebb3c0fa5bb0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTBFOjFBMUMwNDoxOUI5NTFDOjIyRDIxRTc6NkFGRkZCMzciLCJ2aXNpdG9yX2lkIjoiODE3NDQxMzk0NTQ3NDM4MjY0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 79b69010e3fce0824d5fe2d8ae4899f90f3ba896549aade8a7575a5a243c4456 |
| hovercard-subject-tag | pull_request:360319006 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8259/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6e5a6c2ef3af37f7b0a3d277a05e217beefad2136e7b2a2b7fdf83f661a00630/python/mypy/pull/8259 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6e5a6c2ef3af37f7b0a3d277a05e217beefad2136e7b2a2b7fdf83f661a00630/python/mypy/pull/8259 |
| og:image:alt | Fixes #4291
This is only a partial fix. As I'm new to the codebase, I'm unaware of the way an assignment correctly works. Thus also one of the newly added tests still fail. See the inline c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | xhochy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/8259#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8259 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8259 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/8259 |
| Reload | https://github.com/python/mypy/pull/8259 |
| Reload | https://github.com/python/mypy/pull/8259 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| msullivan | https://github.com/msullivan |
| python:master | https://github.com/python/mypy/tree/master |
| xhochy:issue-4291 | https://github.com/xhochy/mypy/tree/issue-4291 |
| Conversation | https://github.com/python/mypy/pull/8259 |
| Commits4 (4) | https://github.com/python/mypy/pull/8259/commits |
| Checks | https://github.com/python/mypy/pull/8259/checks |
| Files changed | https://github.com/python/mypy/pull/8259/files |
| Fix module alias as instance attribute | https://github.com/python/mypy/pull/8259#top |
| msullivan | https://github.com/msullivan |
| python:master | https://github.com/python/mypy/tree/master |
| xhochy:issue-4291 | https://github.com/xhochy/mypy/tree/issue-4291 |
|
| https://github.com/xhochy |
| xhochy | https://github.com/xhochy |
| Jan 8, 2020 | https://github.com/python/mypy/pull/8259#issue-546690277 |
| #4291 | https://github.com/python/mypy/issues/4291 |
| Please reload this page | https://github.com/python/mypy/pull/8259 |
| https://github.com/xhochy |
| xhochy | https://github.com/xhochy |
|
Jan 8, 2020
| https://github.com/python/mypy/pull/8259#pullrequestreview-339683882 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8259/files |
| mypy/semanal.py | https://github.com/python/mypy/pull/8259/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| xhochy | https://github.com/xhochy |
| Jan 8, 2020 | https://github.com/python/mypy/pull/8259#discussion_r364093167 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8259 |
| xhochy | https://github.com/xhochy |
| Jan 8, 2020 | https://github.com/python/mypy/pull/8259#discussion_r364093547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8259 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 15, 2020
| https://github.com/python/mypy/pull/8259#pullrequestreview-343587402 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8259/files |
| msullivan | https://github.com/msullivan |
| https://github.com/python/mypy/pull/8259#pullrequestreview-343587402 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8259 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| ilevkivskyi | https://github.com/ilevkivskyi |
| January 15, 2020 23:20 | https://github.com/python/mypy/pull/8259#event-2952657757 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Jan 16, 2020
| https://github.com/python/mypy/pull/8259#pullrequestreview-343992854 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8259/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/8259#pullrequestreview-343992854 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8259 |
| xhochy | https://github.com/xhochy |
| January 21, 2020 13:21 | https://github.com/python/mypy/pull/8259#commits-pushed-dc78471 |
|
| https://github.com/xhochy |
|
| https://github.com/msullivan |
| Fix module alias as instance attribute | https://github.com/python/mypy/pull/8259/commits/dc78471a035473d9134ccdbd54cb4be075b42876 |
| dc78471 | https://github.com/python/mypy/pull/8259/commits/dc78471a035473d9134ccdbd54cb4be075b42876 |
|
| https://github.com/msullivan |
| move to testcheck | https://github.com/python/mypy/pull/8259/commits/ac9898d96f95cc16dffc5e561de6465d79895577 |
| ac9898d | https://github.com/python/mypy/pull/8259/commits/ac9898d96f95cc16dffc5e561de6465d79895577 |
|
| https://github.com/msullivan |
| fix it | https://github.com/python/mypy/pull/8259/commits/15bccc3be2979bf0996626fa944a9fad763e2d51 |
| 15bccc3 | https://github.com/python/mypy/pull/8259/commits/15bccc3be2979bf0996626fa944a9fad763e2d51 |
|
| https://github.com/msullivan |
| fix the tests | https://github.com/python/mypy/pull/8259/commits/8a8a9d33fae8c910f868eaeb32e0c1153d53190c |
| 8a8a9d3 | https://github.com/python/mypy/pull/8259/commits/8a8a9d33fae8c910f868eaeb32e0c1153d53190c |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| force-pushed | https://github.com/python/mypy/compare/21c2658d97aff828dee4d730e448c36a8dbbe1b9..8a8a9d33fae8c910f868eaeb32e0c1153d53190c |
| 21c2658 | https://github.com/python/mypy/commit/21c2658d97aff828dee4d730e448c36a8dbbe1b9 |
| 8a8a9d3 | https://github.com/python/mypy/commit/8a8a9d33fae8c910f868eaeb32e0c1153d53190c |
|
Compare
| https://github.com/python/mypy/compare/21c2658d97aff828dee4d730e448c36a8dbbe1b9..8a8a9d33fae8c910f868eaeb32e0c1153d53190c |
| January 21, 2020 21:24 | https://github.com/python/mypy/pull/8259#event-2967826478 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| 2d3a1bf | https://github.com/python/mypy/commit/2d3a1bf2da448a32bfc6be32cbfcfee31570382d |
| Jan 21, 2020 | https://github.com/python/mypy/pull/8259#event-2968033444 |
| https://github.com/xhochy |
| xhochy | https://github.com/xhochy |
| Jan 22, 2020 | https://github.com/python/mypy/pull/8259#issuecomment-577052721 |
| @msullivan | https://github.com/msullivan |
| Please reload this page | https://github.com/python/mypy/pull/8259 |
| https://github.com/xhochy |
| xhochy | https://github.com/xhochy |
| January 22, 2020 07:53 | https://github.com/python/mypy/pull/8259#event-2969013134 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8259 |
|
| https://github.com/msullivan |
|
msullivan
| https://github.com/msullivan |
|
| https://github.com/python/mypy/pull/8259/files/051d4f19776b5dc261c3cf2961330d2f2952713b |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/8259/files/21c2658d97aff828dee4d730e448c36a8dbbe1b9 |
| Please reload this page | https://github.com/python/mypy/pull/8259 |
|
Module alias as instance attribute does not work
| https://github.com/python/mypy/issues/4291 |
| Please reload this page | https://github.com/python/mypy/pull/8259 |
|
| https://github.com/xhochy |
|
| https://github.com/msullivan |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |