René's URL Explorer Experiment


Title: Fix module alias as instance attribute by xhochy · Pull Request #8259 · python/mypy · GitHub

Open Graph Title: Fix module alias as instance attribute by xhochy · Pull Request #8259 · python/mypy

X Title: Fix module alias as instance attribute by xhochy · Pull Request #8259 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #4291 This is only a partial fix. As I'm new to the codebase, I'm unaware of the way an assignment correctly works. Thus also one of the newly added tests still fail. See the inline c...

X Description: Fixes #4291 This is only a partial fix. As I'm new to the codebase, I'm unaware of the way an assignment correctly works. Thus also one of the newly added tests still fail. See the ...

Opengraph URL: https://github.com/python/mypy/pull/8259

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f53be893-7db4-05a7-086f-2e3e1e1bb1df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE90E:1A1C04:19B951C:22D21E7:6AFFFB37
html-safe-nonce9e98be14f81309289993950cc7dcc94729df118cf25baa50da69ebb3c0fa5bb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTBFOjFBMUMwNDoxOUI5NTFDOjIyRDIxRTc6NkFGRkZCMzciLCJ2aXNpdG9yX2lkIjoiODE3NDQxMzk0NTQ3NDM4MjY0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac79b69010e3fce0824d5fe2d8ae4899f90f3ba896549aade8a7575a5a243c4456
hovercard-subject-tagpull_request:360319006
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8259/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6e5a6c2ef3af37f7b0a3d277a05e217beefad2136e7b2a2b7fdf83f661a00630/python/mypy/pull/8259
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e5a6c2ef3af37f7b0a3d277a05e217beefad2136e7b2a2b7fdf83f661a00630/python/mypy/pull/8259
og:image:altFixes #4291 This is only a partial fix. As I'm new to the codebase, I'm unaware of the way an assignment correctly works. Thus also one of the newly added tests still fail. See the inline c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamexhochy
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/8259#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8259
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8259
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/8259
Reloadhttps://github.com/python/mypy/pull/8259
Reloadhttps://github.com/python/mypy/pull/8259
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
msullivanhttps://github.com/msullivan
python:masterhttps://github.com/python/mypy/tree/master
xhochy:issue-4291https://github.com/xhochy/mypy/tree/issue-4291
Conversationhttps://github.com/python/mypy/pull/8259
Commits4 (4)https://github.com/python/mypy/pull/8259/commits
Checkshttps://github.com/python/mypy/pull/8259/checks
Files changedhttps://github.com/python/mypy/pull/8259/files
Fix module alias as instance attributehttps://github.com/python/mypy/pull/8259#top
msullivanhttps://github.com/msullivan
python:masterhttps://github.com/python/mypy/tree/master
xhochy:issue-4291https://github.com/xhochy/mypy/tree/issue-4291
https://github.com/xhochy
xhochyhttps://github.com/xhochy
Jan 8, 2020https://github.com/python/mypy/pull/8259#issue-546690277
#4291https://github.com/python/mypy/issues/4291
Please reload this pagehttps://github.com/python/mypy/pull/8259
https://github.com/xhochy
xhochyhttps://github.com/xhochy
Jan 8, 2020 https://github.com/python/mypy/pull/8259#pullrequestreview-339683882
View reviewed changes https://github.com/python/mypy/pull/8259/files
mypy/semanal.pyhttps://github.com/python/mypy/pull/8259/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
xhochyhttps://github.com/xhochy
Jan 8, 2020https://github.com/python/mypy/pull/8259#discussion_r364093167
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8259
xhochyhttps://github.com/xhochy
Jan 8, 2020https://github.com/python/mypy/pull/8259#discussion_r364093547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8259
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 15, 2020 https://github.com/python/mypy/pull/8259#pullrequestreview-343587402
View reviewed changes https://github.com/python/mypy/pull/8259/files
msullivanhttps://github.com/msullivan
https://github.com/python/mypy/pull/8259#pullrequestreview-343587402
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8259
https://github.com/msullivan
msullivanhttps://github.com/msullivan
ilevkivskyihttps://github.com/ilevkivskyi
January 15, 2020 23:20https://github.com/python/mypy/pull/8259#event-2952657757
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 16, 2020 https://github.com/python/mypy/pull/8259#pullrequestreview-343992854
View reviewed changes https://github.com/python/mypy/pull/8259/files
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/8259#pullrequestreview-343992854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8259
xhochyhttps://github.com/xhochy
January 21, 2020 13:21https://github.com/python/mypy/pull/8259#commits-pushed-dc78471
https://github.com/xhochy
https://github.com/msullivan
Fix module alias as instance attributehttps://github.com/python/mypy/pull/8259/commits/dc78471a035473d9134ccdbd54cb4be075b42876
dc78471https://github.com/python/mypy/pull/8259/commits/dc78471a035473d9134ccdbd54cb4be075b42876
https://github.com/msullivan
move to testcheckhttps://github.com/python/mypy/pull/8259/commits/ac9898d96f95cc16dffc5e561de6465d79895577
ac9898dhttps://github.com/python/mypy/pull/8259/commits/ac9898d96f95cc16dffc5e561de6465d79895577
https://github.com/msullivan
fix ithttps://github.com/python/mypy/pull/8259/commits/15bccc3be2979bf0996626fa944a9fad763e2d51
15bccc3https://github.com/python/mypy/pull/8259/commits/15bccc3be2979bf0996626fa944a9fad763e2d51
https://github.com/msullivan
fix the testshttps://github.com/python/mypy/pull/8259/commits/8a8a9d33fae8c910f868eaeb32e0c1153d53190c
8a8a9d3https://github.com/python/mypy/pull/8259/commits/8a8a9d33fae8c910f868eaeb32e0c1153d53190c
https://github.com/msullivan
msullivanhttps://github.com/msullivan
force-pushedhttps://github.com/python/mypy/compare/21c2658d97aff828dee4d730e448c36a8dbbe1b9..8a8a9d33fae8c910f868eaeb32e0c1153d53190c
21c2658https://github.com/python/mypy/commit/21c2658d97aff828dee4d730e448c36a8dbbe1b9
8a8a9d3https://github.com/python/mypy/commit/8a8a9d33fae8c910f868eaeb32e0c1153d53190c
Compare https://github.com/python/mypy/compare/21c2658d97aff828dee4d730e448c36a8dbbe1b9..8a8a9d33fae8c910f868eaeb32e0c1153d53190c
January 21, 2020 21:24https://github.com/python/mypy/pull/8259#event-2967826478
https://github.com/msullivan
msullivanhttps://github.com/msullivan
2d3a1bfhttps://github.com/python/mypy/commit/2d3a1bf2da448a32bfc6be32cbfcfee31570382d
Jan 21, 2020https://github.com/python/mypy/pull/8259#event-2968033444
https://github.com/xhochy
xhochyhttps://github.com/xhochy
Jan 22, 2020https://github.com/python/mypy/pull/8259#issuecomment-577052721
@msullivanhttps://github.com/msullivan
Please reload this pagehttps://github.com/python/mypy/pull/8259
https://github.com/xhochy
xhochyhttps://github.com/xhochy
January 22, 2020 07:53https://github.com/python/mypy/pull/8259#event-2969013134
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8259
https://github.com/msullivan
msullivan https://github.com/msullivan
https://github.com/python/mypy/pull/8259/files/051d4f19776b5dc261c3cf2961330d2f2952713b
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/8259/files/21c2658d97aff828dee4d730e448c36a8dbbe1b9
Please reload this pagehttps://github.com/python/mypy/pull/8259
Module alias as instance attribute does not work https://github.com/python/mypy/issues/4291
Please reload this pagehttps://github.com/python/mypy/pull/8259
https://github.com/xhochy
https://github.com/msullivan
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.