René's URL Explorer Experiment


Title: Add support for narrowing Literals using equality by Michael0x2a · Pull Request #8151 · python/mypy · GitHub

Open Graph Title: Add support for narrowing Literals using equality by Michael0x2a · Pull Request #8151 · python/mypy

X Title: Add support for narrowing Literals using equality by Michael0x2a · Pull Request #8151 · python/mypy

Description: This pull request (finally) adds support for narrowing expressions using Literal types by equality, instead of just identity. For example, the following "tagged union" pattern is now supported: class Foo(TypedDict): key: Literal["A"] blah: int class Bar(TypedDict): key: Literal["B"] something: str x: Union[Foo, Bar] if x.key == "A": reveal_type(x) # Revealed type is 'Foo' else: reveal_type(x) # Revealed type is 'Bar' Previously, this was possible to do only with Enum Literals and the is operator, which is perhaps not very intuitive. The main limitation with this pull request is that it'll perform narrowing only if either the LHS or RHS contains an explicit Literal type somewhere. If this limitation is not present, we end up breaking a decent amount of real-world code -- mostly tests -- that do something like this: def some_test_case() -> None: worker = Worker() # Without the limitation, we narrow 'worker.state' to # Literal['ready'] in this assert... assert worker.state == 'ready' worker.start() # ...which subsequently causes this second assert to narrow # worker.state to , causing the last line to be # unreachable. assert worker.state == 'running' worker.query() I tried for several weeks to find a more intelligent way around this problem, but everything I tried ended up being either insufficient or super-hacky, so I gave up and went for this brute-force solution. The other main limitation is that we perform narrowing only if both the LHS and RHS do not define custom __eq__ or __ne__ methods, but this seems like a more reasonable one to me. Resolves #7944.

Open Graph Description: This pull request (finally) adds support for narrowing expressions using Literal types by equality, instead of just identity. For example, the following "tagged union" pattern is now supp...

X Description: This pull request (finally) adds support for narrowing expressions using Literal types by equality, instead of just identity. For example, the following "tagged union" pattern is ...

Opengraph URL: https://github.com/python/mypy/pull/8151

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fa13b20a-f159-30a3-69d2-681c89775b73
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2A4:102136:6002F2:7FFE61:6B00342A
html-safe-nonce99399ffa6861e52ecd56e4f78ea10a32684192cbab1bae9c5e7c0a3e8f385394
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkE0OjEwMjEzNjo2MDAyRjI6N0ZGRTYxOjZCMDAzNDJBIiwidmlzaXRvcl9pZCI6Ijc2MjIwOTQ0OTU2NzIxODU4OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2edaa1b6a42e54ff7e16d0a031afeb324bfaed33ff9d6232d727b460b6c1401d
hovercard-subject-tagpull_request:353343642
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/8151/files
twitter:imagehttps://avatars.githubusercontent.com/u/1424628?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1424628?s=400&v=4
og:image:altThis pull request (finally) adds support for narrowing expressions using Literal types by equality, instead of just identity. For example, the following "tagged union" pattern is now supp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/8151/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8151%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8151%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/8151/files
Reloadhttps://github.com/python/mypy/pull/8151/files
Reloadhttps://github.com/python/mypy/pull/8151/files
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:reachability-unify-equality-and-identityhttps://github.com/Michael0x2a/mypy/tree/reachability-unify-equality-and-identity
Conversation 24 https://github.com/python/mypy/pull/8151
Commits 4 https://github.com/python/mypy/pull/8151/commits
Checks 0 https://github.com/python/mypy/pull/8151/checks
Files changed https://github.com/python/mypy/pull/8151/files
Please reload this pagehttps://github.com/python/mypy/pull/8151/files
Add support for narrowing Literals using equality https://github.com/python/mypy/pull/8151/files#top
Show all changes 4 commits https://github.com/python/mypy/pull/8151/files
f82a019 Add support for narrowing Literals using equality Michael0x2a Dec 15, 2019 https://github.com/python/mypy/pull/8151/commits/f82a019e18d2810c72b9f98fb2181987ddc29fc9
96c0292 Respond to code review; remove concept of 'partial' TypeMaps Michael0x2a Jan 7, 2020 https://github.com/python/mypy/pull/8151/commits/96c0292ed8d223690ee6f94666a7380c93ba2975
7b08bd9 Remove todo about inline functions Michael0x2a Jan 8, 2020 https://github.com/python/mypy/pull/8151/commits/7b08bd995c04bb5a8529ec50854f28e6f98e26b1
e2ea84c Fix test formatting Michael0x2a Jan 8, 2020 https://github.com/python/mypy/pull/8151/commits/e2ea84c9f71eb4cf8aed5cb2eb1aa52867c9ecf7
Clear filters https://github.com/python/mypy/pull/8151/files
Please reload this pagehttps://github.com/python/mypy/pull/8151/files
Please reload this pagehttps://github.com/python/mypy/pull/8151/files
checker.py https://github.com/python/mypy/pull/8151/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
checkexpr.py https://github.com/python/mypy/pull/8151/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
checkstrformat.py https://github.com/python/mypy/pull/8151/files#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e
typeops.py https://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
check-enum.test https://github.com/python/mypy/pull/8151/files#diff-ebc735ad8fa6eb42d5390fa4fa9ef60581764c7bbfb5eafcde16f5e40c330c84
check-narrowing.test https://github.com/python/mypy/pull/8151/files#diff-0413401ad6a91bc5c66579455009ba606ee0ddfb0a78278c9e53618c83b53ed5
check-optional.test https://github.com/python/mypy/pull/8151/files#diff-a6528e88debcf57f7c356e9877b88fb63e975a876e134eb2c6fa2e733a4f27bc
mypy/checker.pyhttps://github.com/python/mypy/pull/8151/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
View file https://github.com/Michael0x2a/mypy/blob/e2ea84c9f71eb4cf8aed5cb2eb1aa52867c9ecf7/mypy/checker.py
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/mypy/pull/8151/files
mypy/checkexpr.pyhttps://github.com/python/mypy/pull/8151/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
View file https://github.com/Michael0x2a/mypy/blob/e2ea84c9f71eb4cf8aed5cb2eb1aa52867c9ecf7/mypy/checkexpr.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/8151/{{ revealButtonHref }}
https://github.com/python/mypy/pull/8151/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
https://github.com/python/mypy/pull/8151/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
https://github.com/python/mypy/pull/8151/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
https://github.com/python/mypy/pull/8151/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
https://github.com/python/mypy/pull/8151/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
https://github.com/python/mypy/pull/8151/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
mypy/checkstrformat.pyhttps://github.com/python/mypy/pull/8151/files#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e
View file https://github.com/Michael0x2a/mypy/blob/e2ea84c9f71eb4cf8aed5cb2eb1aa52867c9ecf7/mypy/checkstrformat.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/8151/{{ revealButtonHref }}
https://github.com/python/mypy/pull/8151/files#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e
https://github.com/python/mypy/pull/8151/files#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e
https://github.com/python/mypy/pull/8151/files#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e
https://github.com/python/mypy/pull/8151/files#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e
mypy/typeops.pyhttps://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
View file https://github.com/Michael0x2a/mypy/blob/e2ea84c9f71eb4cf8aed5cb2eb1aa52867c9ecf7/mypy/typeops.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/8151/{{ revealButtonHref }}
https://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
https://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
https://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
https://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
https://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
https://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
ilevkivskyihttps://github.com/ilevkivskyi
Jan 6, 2020https://github.com/python/mypy/pull/8151/files#r363338165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8151/files
https://github.com/python/mypy/pull/8151/files#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
test-data/unit/check-enum.testhttps://github.com/python/mypy/pull/8151/files#diff-ebc735ad8fa6eb42d5390fa4fa9ef60581764c7bbfb5eafcde16f5e40c330c84
View file https://github.com/Michael0x2a/mypy/blob/e2ea84c9f71eb4cf8aed5cb2eb1aa52867c9ecf7/test-data/unit/check-enum.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/8151/{{ revealButtonHref }}
https://github.com/python/mypy/pull/8151/files#diff-ebc735ad8fa6eb42d5390fa4fa9ef60581764c7bbfb5eafcde16f5e40c330c84
https://github.com/python/mypy/pull/8151/files#diff-ebc735ad8fa6eb42d5390fa4fa9ef60581764c7bbfb5eafcde16f5e40c330c84
https://github.com/python/mypy/pull/8151/files#diff-ebc735ad8fa6eb42d5390fa4fa9ef60581764c7bbfb5eafcde16f5e40c330c84
https://github.com/python/mypy/pull/8151/files#diff-ebc735ad8fa6eb42d5390fa4fa9ef60581764c7bbfb5eafcde16f5e40c330c84
Please reload this pagehttps://github.com/python/mypy/pull/8151/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.