René's URL Explorer Experiment


Title: Don't simplify out ErasedType from unions during type inference by ilevkivskyi · Pull Request #8095 · python/mypy · GitHub

Open Graph Title: Don't simplify out ErasedType from unions during type inference by ilevkivskyi · Pull Request #8095 · python/mypy

X Title: Don't simplify out ErasedType from unions during type inference by ilevkivskyi · Pull Request #8095 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #8093 The fix is kind of simple, we really need to keep all ErasedTypes intact to preserve the existing type inference logic, but it is also long because I need to thread the flag down like d...

X Description: Fixes #8093 The fix is kind of simple, we really need to keep all ErasedTypes intact to preserve the existing type inference logic, but it is also long because I need to thread the flag down like d...

Opengraph URL: https://github.com/python/mypy/pull/8095

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f6c5b140-d782-a675-630e-1b38e718cf56
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idACEA:609A0:353CDFF:4639A17:6B00358B
html-safe-nonce89bbe728dd41d81fccfd5fb242e4cb1a5e6843e65859a88361bea456ff57d64e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0VBOjYwOUEwOjM1M0NERkY6NDYzOUExNzo2QjAwMzU4QiIsInZpc2l0b3JfaWQiOiIyMzQzODAxNTUyOTkwNTA4OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4b067bbfe8f629d48da18037878177a7790eb6ba559e0dafec51ad34eaf7c438
hovercard-subject-tagpull_request:349598852
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8095/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5b21ad54e48e6b7641ab026ab3302650b99be4fda0636c44187b3e00646e5d4/python/mypy/pull/8095
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5b21ad54e48e6b7641ab026ab3302650b99be4fda0636c44187b3e00646e5d4/python/mypy/pull/8095
og:image:altFixes #8093 The fix is kind of simple, we really need to keep all ErasedTypes intact to preserve the existing type inference logic, but it is also long because I need to thread the flag down like d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/8095#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8095
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8095
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/8095
Reloadhttps://github.com/python/mypy/pull/8095
Reloadhttps://github.com/python/mypy/pull/8095
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-the-fixhttps://github.com/ilevkivskyi/mypy/tree/fix-the-fix
Conversationhttps://github.com/python/mypy/pull/8095
Commits2 (2)https://github.com/python/mypy/pull/8095/commits
Checkshttps://github.com/python/mypy/pull/8095/checks
Files changedhttps://github.com/python/mypy/pull/8095/files
Don't simplify out ErasedType from unions during type inferencehttps://github.com/python/mypy/pull/8095#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-the-fixhttps://github.com/ilevkivskyi/mypy/tree/fix-the-fix
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Dec 5, 2019https://github.com/python/mypy/pull/8095#issue-533543173
#8093https://github.com/python/mypy/issues/8093
Please reload this pagehttps://github.com/python/mypy/pull/8095
Don't simplify out ErasedType from unions during type inferencehttps://github.com/python/mypy/pull/8095/commits/44d73a335abdf1773dfa226c00b070399cbe46af
44d73a3https://github.com/python/mypy/pull/8095/commits/44d73a335abdf1773dfa226c00b070399cbe46af
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
December 5, 2019 19:17https://github.com/python/mypy/pull/8095#event-2859001102
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Dec 5, 2019 https://github.com/python/mypy/pull/8095#pullrequestreview-327794253
View reviewed changes https://github.com/python/mypy/pull/8095/files/44d73a335abdf1773dfa226c00b070399cbe46af
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/8095#pullrequestreview-327794253
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8095
test-data/unit/check-inference.testhttps://github.com/python/mypy/pull/8095/files/44d73a335abdf1773dfa226c00b070399cbe46af#diff-c3eb296f041ab0dfaba0e8ea5cf200d63c2de36b8b57da835294af221ff0de5a
JukkaLhttps://github.com/JukkaL
Dec 5, 2019https://github.com/python/mypy/pull/8095#discussion_r354502848
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/8095
Address CR; also rename a var in testhttps://github.com/python/mypy/pull/8095/commits/9eae8f97cc90fd00c21a9be9089fcdd580e4e074
9eae8f9https://github.com/python/mypy/pull/8095/commits/9eae8f97cc90fd00c21a9be9089fcdd580e4e074
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
5680f5chttps://github.com/python/mypy/commit/5680f5c5a8f506b7f8daebafaedc6d2a1514b56b
Dec 5, 2019https://github.com/python/mypy/pull/8095#event-2859157519
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
December 5, 2019 20:05https://github.com/python/mypy/pull/8095#event-2859157735
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8095
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/8095/files/44d73a335abdf1773dfa226c00b070399cbe46af
Please reload this pagehttps://github.com/python/mypy/pull/8095
Type inference regression involving filter(None, ...) https://github.com/python/mypy/issues/8093
Please reload this pagehttps://github.com/python/mypy/pull/8095
https://github.com/ilevkivskyi
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.