| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:69920e2a-129f-4815-88d8-6150ceb84721 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A118:1334EF:BAF312:F3F382:6AFFF22D |
| html-safe-nonce | d89a8f4870bc16073645cda5d8ad724b3b0388f58b558439b1b6f4dd7c300a8d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTE4OjEzMzRFRjpCQUYzMTI6RjNGMzgyOjZBRkZGMjJEIiwidmlzaXRvcl9pZCI6IjkwODU5NDY5ODM2OTIxMDQyMzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d0f91d44188a4a06533fa56782b6db9efec62593e2be1166428f1fb345eaba88 |
| hovercard-subject-tag | pull_request:346233737 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/8021/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d39433d66a3c2a9dd46bd07dc948503e371bc3643b9fe0e0cc5c08822cf54cc6/python/mypy/pull/8021 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d39433d66a3c2a9dd46bd07dc948503e371bc3643b9fe0e0cc5c08822cf54cc6/python/mypy/pull/8021 |
| og:image:alt | Fixes #8020
There is a bunch of code/logic duplication around bind_self(), mostly because of #7724. This PR makes all three main code paths consistently follow the same structure:
freshen_function... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/8021#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8021 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8021 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/8021 |
| Reload | https://github.com/python/mypy/pull/8021 |
| Reload | https://github.com/python/mypy/pull/8021 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:freshen-classmethod | https://github.com/ilevkivskyi/mypy/tree/freshen-classmethod |
| Conversation | https://github.com/python/mypy/pull/8021 |
| Commits2 (2) | https://github.com/python/mypy/pull/8021/commits |
| Checks | https://github.com/python/mypy/pull/8021/checks |
| Files changed | https://github.com/python/mypy/pull/8021/files |
| Make logic around bind_self() consistent in different code paths | https://github.com/python/mypy/pull/8021#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:freshen-classmethod | https://github.com/ilevkivskyi/mypy/tree/freshen-classmethod |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 27, 2019 | https://github.com/python/mypy/pull/8021#issue-529338950 |
| #8020 | https://github.com/python/mypy/issues/8020 |
| #7724 | https://github.com/python/mypy/issues/7724 |
| Please reload this page | https://github.com/python/mypy/pull/8021 |
| Make logic around bind_self() consistent in different code paths | https://github.com/python/mypy/pull/8021/commits/cbf9486e7f413b18380bd9700f7fc80c5842bdba |
| cbf9486 | https://github.com/python/mypy/pull/8021/commits/cbf9486e7f413b18380bd9700f7fc80c5842bdba |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| JukkaL | https://github.com/JukkaL |
| November 27, 2019 13:14 | https://github.com/python/mypy/pull/8021#event-2835596915 |
| Fix self-check | https://github.com/python/mypy/pull/8021/commits/c8044c7d47fd0919dba0006efda7ecbf9e896976 |
| c8044c7 | https://github.com/python/mypy/pull/8021/commits/c8044c7d47fd0919dba0006efda7ecbf9e896976 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 27, 2019
| https://github.com/python/mypy/pull/8021#pullrequestreview-323845481 |
|
View reviewed changes
| https://github.com/python/mypy/pull/8021/files/c8044c7d47fd0919dba0006efda7ecbf9e896976 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/8021#pullrequestreview-323845481 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/8021 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 1122fc6 | https://github.com/python/mypy/commit/1122fc6eabbbba9eb2f9912494e3e19aca8c3156 |
| Nov 27, 2019 | https://github.com/python/mypy/pull/8021#event-2836512282 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| November 27, 2019 17:42 | https://github.com/python/mypy/pull/8021#event-2836512530 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Nov 28, 2019
| https://github.com/python/mypy/pull/8021#ref-pullrequest-529911713 |
|
Apply generic class fix also to non-callable types
#8030
| https://github.com/python/mypy/pull/8030 |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Nov 29, 2019
| https://github.com/python/mypy/pull/8021#ref-commit-b5f4df9 |
|
| https://github.com/ilevkivskyi |
| Apply generic class fix also to non-callable types ( | https://github.com/python/mypy/commit/b5f4df9862f43d71029ccc6307d679953ccdfca8 |
| #8030 | https://github.com/python/mypy/pull/8030 |
| ) | https://github.com/python/mypy/commit/b5f4df9862f43d71029ccc6307d679953ccdfca8 |
| b5f4df9 | https://github.com/python/mypy/commit/b5f4df9862f43d71029ccc6307d679953ccdfca8 |
| #8021 | https://github.com/python/mypy/pull/8021 |
| #7724 | https://github.com/python/mypy/issues/7724 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Dec 4, 2019
| https://github.com/python/mypy/pull/8021#ref-issue-532739276 |
|
Regression: crash when serializing alias to generic class method
#8072
| https://github.com/python/mypy/issues/8072 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F8021 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/8021/files/c8044c7d47fd0919dba0006efda7ecbf9e896976 |
| Please reload this page | https://github.com/python/mypy/pull/8021 |
|
Detect unsupported use of self types in generic classes
| https://github.com/python/mypy/issues/8020 |
| Please reload this page | https://github.com/python/mypy/pull/8021 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |