René's URL Explorer Experiment


Title: Fix `issubclass()` to narrow down types of type variables by TH3CHARLie · Pull Request #7930 · python/mypy · GitHub

Open Graph Title: Fix `issubclass()` to narrow down types of type variables by TH3CHARLie · Pull Request #7930 · python/mypy

X Title: Fix `issubclass()` to narrow down types of type variables by TH3CHARLie · Pull Request #7930 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: resolves #7920 Currently, no testcases break so I did not look into meet.py for further investigation

X Description: resolves #7920 Currently, no testcases break so I did not look into meet.py for further investigation

Opengraph URL: https://github.com/python/mypy/pull/7930

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9316b645-04d5-1505-62a3-2aef61edd170
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD90:106F5D:DCB3F2:1284575:6B005666
html-safe-nonce6d336f76ba0e25c448abb8278e5efe8b0312af478a54a9c1d285a62ee83f0200
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDkwOjEwNkY1RDpEQ0IzRjI6MTI4NDU3NTo2QjAwNTY2NiIsInZpc2l0b3JfaWQiOiI4NTA2NDk5MTc2MTIzNjE4OTE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4e32f698c2090841c5cb4f3958a6bb83782d2fe1567a96bf9accaafcd859ce0c
hovercard-subject-tagpull_request:339688855
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/7930/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90f7b53de03ab31f1e9d61eeb692cc788879236dffc45afb558483d7101fe903/python/mypy/pull/7930
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90f7b53de03ab31f1e9d61eeb692cc788879236dffc45afb558483d7101fe903/python/mypy/pull/7930
og:image:altresolves #7920 Currently, no testcases break so I did not look into meet.py for further investigation
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTH3CHARLie
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/7930#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7930
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7930
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/7930
Reloadhttps://github.com/python/mypy/pull/7930
Reloadhttps://github.com/python/mypy/pull/7930
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Conversationhttps://github.com/python/mypy/pull/7930
Commits8 (8)https://github.com/python/mypy/pull/7930/commits
Checkshttps://github.com/python/mypy/pull/7930/checks
Files changedhttps://github.com/python/mypy/pull/7930/files
Fix issubclass() to narrow down types of type variableshttps://github.com/python/mypy/pull/7930#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
Nov 12, 2019https://github.com/python/mypy/pull/7930#issue-521279921
Please reload this pagehttps://github.com/python/mypy/pull/7930
#7920https://github.com/python/mypy/issues/7920
Please reload this pagehttps://github.com/python/mypy/pull/7930
TH3CHARLiehttps://github.com/TH3CHARLie
November 12, 2019 09:44https://github.com/python/mypy/pull/7930#commits-pushed-796f527
https://github.com/TH3CHARLie
add testcasehttps://github.com/python/mypy/pull/7930/commits/796f5274b2967abb94db1bf52e5ab9326759d3e8
796f527https://github.com/python/mypy/pull/7930/commits/796f5274b2967abb94db1bf52e5ab9326759d3e8
https://github.com/TH3CHARLie
modify find_isinstance_check in checker.py to fix bughttps://github.com/python/mypy/pull/7930/commits/238bfa8d2c2f804013e6849135e2a69c0b836def
238bfa8https://github.com/python/mypy/pull/7930/commits/238bfa8d2c2f804013e6849135e2a69c0b836def
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 12, 2019 https://github.com/python/mypy/pull/7930#pullrequestreview-315553026
View reviewed changes https://github.com/python/mypy/pull/7930/files/238bfa8d2c2f804013e6849135e2a69c0b836def
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7930#pullrequestreview-315553026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7930
mypy/checker.pyhttps://github.com/python/mypy/pull/7930/files/238bfa8d2c2f804013e6849135e2a69c0b836def#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/7930
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/7930/files/238bfa8d2c2f804013e6849135e2a69c0b836def#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
Please reload this pagehttps://github.com/python/mypy/pull/7930
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/7930/files/238bfa8d2c2f804013e6849135e2a69c0b836def#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
Please reload this pagehttps://github.com/python/mypy/pull/7930
TH3CHARLiehttps://github.com/TH3CHARLie
November 13, 2019 09:51https://github.com/python/mypy/pull/7930#commits-pushed-5b35e9d
https://github.com/TH3CHARLie
adjust branch statement in checker.py, modify testcasehttps://github.com/python/mypy/pull/7930/commits/5b35e9d8b20087652ce23f6aab54403c831711d1
5b35e9dhttps://github.com/python/mypy/pull/7930/commits/5b35e9d8b20087652ce23f6aab54403c831711d1
https://github.com/TH3CHARLie
refactor issubclass check into helper functionhttps://github.com/python/mypy/pull/7930/commits/df62cbc10529256d4aea1912236fab2509196cd0
df62cbchttps://github.com/python/mypy/pull/7930/commits/df62cbc10529256d4aea1912236fab2509196cd0
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
Nov 13, 2019https://github.com/python/mypy/pull/7930#issuecomment-553211832
df62cbchttps://github.com/python/mypy/commit/df62cbc10529256d4aea1912236fab2509196cd0
Please reload this pagehttps://github.com/python/mypy/pull/7930
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
ilevkivskyihttps://github.com/ilevkivskyi
November 13, 2019 03:26https://github.com/python/mypy/pull/7930#event-2793776146
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 13, 2019 https://github.com/python/mypy/pull/7930#pullrequestreview-316251487
View reviewed changes https://github.com/python/mypy/pull/7930/files/df62cbc10529256d4aea1912236fab2509196cd0
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7930#pullrequestreview-316251487
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7930
mypy/checker.pyhttps://github.com/python/mypy/pull/7930/files/df62cbc10529256d4aea1912236fab2509196cd0#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Nov 13, 2019https://github.com/python/mypy/pull/7930#discussion_r345764986
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7930
mypy/checker.pyhttps://github.com/python/mypy/pull/7930/files/df62cbc10529256d4aea1912236fab2509196cd0#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Nov 13, 2019https://github.com/python/mypy/pull/7930#discussion_r345765188
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7930
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/7930/files/df62cbc10529256d4aea1912236fab2509196cd0#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
ilevkivskyihttps://github.com/ilevkivskyi
Nov 13, 2019https://github.com/python/mypy/pull/7930#discussion_r345767760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7930
https://github.com/TH3CHARLie
modify test by adding new class with different upper bound, add docst…https://github.com/python/mypy/pull/7930/commits/316cca73b582dd4543b6688f1d4bb45381ff8fbb
316cca7https://github.com/python/mypy/pull/7930/commits/316cca73b582dd4543b6688f1d4bb45381ff8fbb
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
ilevkivskyihttps://github.com/ilevkivskyi
November 13, 2019 14:48https://github.com/python/mypy/pull/7930#event-2795566178
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 13, 2019 https://github.com/python/mypy/pull/7930#pullrequestreview-316307614
View reviewed changes https://github.com/python/mypy/pull/7930/files/316cca73b582dd4543b6688f1d4bb45381ff8fbb
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7930#pullrequestreview-316307614
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7930
mypy/checker.pyhttps://github.com/python/mypy/pull/7930/files/316cca73b582dd4543b6688f1d4bb45381ff8fbb#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/7930
mypy/checker.pyhttps://github.com/python/mypy/pull/7930/files/316cca73b582dd4543b6688f1d4bb45381ff8fbb#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/7930
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/7930/files/316cca73b582dd4543b6688f1d4bb45381ff8fbb#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
Please reload this pagehttps://github.com/python/mypy/pull/7930
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/7930/files/316cca73b582dd4543b6688f1d4bb45381ff8fbb#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
Please reload this pagehttps://github.com/python/mypy/pull/7930
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/7930/files/316cca73b582dd4543b6688f1d4bb45381ff8fbb#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
Please reload this pagehttps://github.com/python/mypy/pull/7930
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
Nov 13, 2019https://github.com/python/mypy/pull/7930#issuecomment-553463018
Please reload this pagehttps://github.com/python/mypy/pull/7930
Please reload this pagehttps://github.com/python/mypy/pull/7930
TH3CHARLiehttps://github.com/TH3CHARLie
November 13, 2019 23:50https://github.com/python/mypy/pull/7930#commits-pushed-e987e42
https://github.com/TH3CHARLie
modify testcase, modify helper function namehttps://github.com/python/mypy/pull/7930/commits/e987e420e6f3c17c06be289f2fedb1ae9cf27384
e987e42https://github.com/python/mypy/pull/7930/commits/e987e420e6f3c17c06be289f2fedb1ae9cf27384
https://github.com/ilevkivskyi
Remove redundant parenshttps://github.com/python/mypy/pull/7930/commits/8ab0d96b8d2d53557c65e1b60d76a8396c9dd5e7
8ab0d96https://github.com/python/mypy/pull/7930/commits/8ab0d96b8d2d53557c65e1b60d76a8396c9dd5e7
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 14, 2019 https://github.com/python/mypy/pull/7930#pullrequestreview-317008874
View reviewed changes https://github.com/python/mypy/pull/7930/files/8ab0d96b8d2d53557c65e1b60d76a8396c9dd5e7
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7930#pullrequestreview-317008874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7930
https://github.com/ilevkivskyi
Merge branch 'master' into fix-issubclasshttps://github.com/python/mypy/pull/7930/commits/fe59c0d00e37cc166372369b23286e94e9f9763e
fe59c0dhttps://github.com/python/mypy/pull/7930/commits/fe59c0d00e37cc166372369b23286e94e9f9763e
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
Nov 14, 2019https://github.com/python/mypy/pull/7930#issuecomment-553927683
Please reload this pagehttps://github.com/python/mypy/pull/7930
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
15280bfhttps://github.com/python/mypy/commit/15280bf0b18b158942ce14e6d71fa65654e3dd17
Nov 14, 2019https://github.com/python/mypy/pull/7930#event-2799481489
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7930
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7930/files/8ab0d96b8d2d53557c65e1b60d76a8396c9dd5e7
Please reload this pagehttps://github.com/python/mypy/pull/7930
issubclass() doesn't narrow down types of type variables https://github.com/python/mypy/issues/7920
Please reload this pagehttps://github.com/python/mypy/pull/7930
https://github.com/TH3CHARLie
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.