René's URL Explorer Experiment


Title: Generate an error if trying to use @final with TypedDict by TH3CHARLie · Pull Request #7865 · python/mypy · GitHub

Open Graph Title: Generate an error if trying to use @final with TypedDict by TH3CHARLie · Pull Request #7865 · python/mypy

X Title: Generate an error if trying to use @final with TypedDict by TH3CHARLie · Pull Request #7865 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #7849 This fix modifies function analyze_class in mypy/semanal.py, if the analyzer identifies a TypedDict, it then traverses all decorators and checks if @final exists, and if so, generate an...

X Description: Fixes #7849 This fix modifies function analyze_class in mypy/semanal.py, if the analyzer identifies a TypedDict, it then traverses all decorators and checks if @final exists, and if so, generate an...

Opengraph URL: https://github.com/python/mypy/pull/7865

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2114fd82-4b87-f280-2208-dda6279805f1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8166:4D1C6:2813583:36A7F08:6B0048EA
html-safe-nonceafc433276396d72506c9fb17a67048a1be17e8c2e48d03e6c6b0e193f2a354a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTY2OjREMUM2OjI4MTM1ODM6MzZBN0YwODo2QjAwNDhFQSIsInZpc2l0b3JfaWQiOiI4NzcxOTEwOTcwODUyMjY0MTcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4aa07519b47999ff3e654548d6bed0235aaca93778ee45a70973ff8cff951d4a
hovercard-subject-tagpull_request:336270981
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/7865/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/65ecfbd5bba7e8acb4571e3431fbe790e277d2d7d7f85f1c5a6143d944619fc3/python/mypy/pull/7865
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/65ecfbd5bba7e8acb4571e3431fbe790e277d2d7d7f85f1c5a6143d944619fc3/python/mypy/pull/7865
og:image:altFixes #7849 This fix modifies function analyze_class in mypy/semanal.py, if the analyzer identifies a TypedDict, it then traverses all decorators and checks if @final exists, and if so, generate an...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTH3CHARLie
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/7865#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7865
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7865
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/7865
Reloadhttps://github.com/python/mypy/pull/7865
Reloadhttps://github.com/python/mypy/pull/7865
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Conversationhttps://github.com/python/mypy/pull/7865
Commits5 (5)https://github.com/python/mypy/pull/7865/commits
Checkshttps://github.com/python/mypy/pull/7865/checks
Files changedhttps://github.com/python/mypy/pull/7865/files
Generate an error if trying to use @final with TypedDicthttps://github.com/python/mypy/pull/7865#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
Nov 4, 2019https://github.com/python/mypy/pull/7865#issue-517144974
#7849https://github.com/python/mypy/issues/7849
Please reload this pagehttps://github.com/python/mypy/pull/7865
https://github.com/TH3CHARLie
generate an error if trying to usehttps://github.com/python/mypy/pull/7865/commits/07be66c6bcfa694915542ec2eb66034f110c2fc1
@Finalhttps://github.com/Final
with TypedDicthttps://github.com/python/mypy/pull/7865/commits/07be66c6bcfa694915542ec2eb66034f110c2fc1
07be66chttps://github.com/python/mypy/pull/7865/commits/07be66c6bcfa694915542ec2eb66034f110c2fc1
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
Nov 4, 2019 https://github.com/python/mypy/pull/7865#ref-issue-516242412
Generate an error if trying to use @final with TypedDict #7849 https://github.com/python/mypy/issues/7849
https://github.com/TH3CHARLie
adjust indentation, add RefExpr checkhttps://github.com/python/mypy/pull/7865/commits/958d998419a0800fa9be9f4ff8488b6fee3a038b
958d998https://github.com/python/mypy/pull/7865/commits/958d998419a0800fa9be9f4ff8488b6fee3a038b
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 4, 2019 https://github.com/python/mypy/pull/7865#pullrequestreview-311191268
View reviewed changes https://github.com/python/mypy/pull/7865/files/958d998419a0800fa9be9f4ff8488b6fee3a038b
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7865#pullrequestreview-311191268
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7865
mypy/semanal.pyhttps://github.com/python/mypy/pull/7865/files/958d998419a0800fa9be9f4ff8488b6fee3a038b#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
Please reload this pagehttps://github.com/python/mypy/pull/7865
TH3CHARLiehttps://github.com/TH3CHARLie
November 5, 2019 00:31https://github.com/python/mypy/pull/7865#commits-pushed-a6bd4ae
https://github.com/TH3CHARLie
https://github.com/ilevkivskyi
Update spacing in mypy/semanal.pyhttps://github.com/python/mypy/pull/7865/commits/a6bd4ae6ca379eb1c0b64e782c03df51b6d24f49
a6bd4aehttps://github.com/python/mypy/pull/7865/commits/a6bd4ae6ca379eb1c0b64e782c03df51b6d24f49
https://github.com/TH3CHARLie
add test case: testCannotUseFinalDecoratorWithTypedDicthttps://github.com/python/mypy/pull/7865/commits/466627405107e911e9e2f6e7b7104b602bee3783
4666274https://github.com/python/mypy/pull/7865/commits/466627405107e911e9e2f6e7b7104b602bee3783
https://github.com/TH3CHARLie
TH3CHARLiehttps://github.com/TH3CHARLie
Nov 4, 2019https://github.com/python/mypy/pull/7865#issuecomment-549453644
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/7865
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 4, 2019 https://github.com/python/mypy/pull/7865#pullrequestreview-311224847
View reviewed changes https://github.com/python/mypy/pull/7865/files/466627405107e911e9e2f6e7b7104b602bee3783
test-data/unit/check-typeddict.testhttps://github.com/python/mypy/pull/7865/files/466627405107e911e9e2f6e7b7104b602bee3783#diff-1db589b0c06e93bf0f492fb32a043ad16c054379c19cd39da57960e98c4b8be0
ilevkivskyihttps://github.com/ilevkivskyi
Nov 4, 2019https://github.com/python/mypy/pull/7865#discussion_r342167138
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7865
https://github.com/TH3CHARLie
Add newline at end of test filehttps://github.com/python/mypy/pull/7865/commits/1fcb297130463ef97e26e5c07f5fd728c7f6e7cd
1fcb297https://github.com/python/mypy/pull/7865/commits/1fcb297130463ef97e26e5c07f5fd728c7f6e7cd
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 4, 2019 https://github.com/python/mypy/pull/7865#pullrequestreview-311246393
View reviewed changes https://github.com/python/mypy/pull/7865/files/1fcb297130463ef97e26e5c07f5fd728c7f6e7cd
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7865#pullrequestreview-311246393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7865
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
87720fehttps://github.com/python/mypy/commit/87720fe4ec57e7912ca8d58989952a99c8751bf7
Nov 4, 2019https://github.com/python/mypy/pull/7865#event-2768640973
https://github.com/crusaderky
crusaderkyhttps://github.com/crusaderky
Nov 20, 2019 https://github.com/python/mypy/pull/7865#ref-issue-525700041
final TypedDict #7981 https://github.com/python/mypy/issues/7981
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7865
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7865/files/1fcb297130463ef97e26e5c07f5fd728c7f6e7cd
Please reload this pagehttps://github.com/python/mypy/pull/7865
Generate an error if trying to use @final with TypedDict https://github.com/python/mypy/issues/7849
Please reload this pagehttps://github.com/python/mypy/pull/7865
https://github.com/TH3CHARLie
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.