| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:86bfebe2-d716-0b1d-6a0a-cd6da8a49415 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E398:24BFCE:2E0A8:3D7B9:6B00178D |
| html-safe-nonce | ad51b3575636444f51ecd7db4e02eda3aec15ad0190fbf520516b1b64881acd5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzk4OjI0QkZDRToyRTBBODozRDdCOTo2QjAwMTc4RCIsInZpc2l0b3JfaWQiOiI2MTQxOTk0NTcxNTczMjM3NjQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bacf72b4ec1ae96cb7f20f66b903da2426ed2a4368e8c7ac8193c154840bfe42 |
| hovercard-subject-tag | pull_request:311154836 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/7397/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3a2baceb6b1760bf06e77f9e67df5b3c5aae28ce49c2164da87f2fa2f8f59ac9/python/mypy/pull/7397 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3a2baceb6b1760bf06e77f9e67df5b3c5aae28ce49c2164da87f2fa2f8f59ac9/python/mypy/pull/7397 |
| og:image:alt | Currently mypy has a 47 module import cycle, which is not great.
This untangles things, leaving the following cycles:
Size 2: mypy.build, mypy.semanal_main
Size 2: mypy.plugin, mypy.interpreted_pl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | msullivan |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/7397#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7397 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7397 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/7397 |
| Reload | https://github.com/python/mypy/pull/7397 |
| Reload | https://github.com/python/mypy/pull/7397 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| msullivan | https://github.com/msullivan |
| master | https://github.com/python/mypy/tree/master |
| untangle | https://github.com/python/mypy/tree/untangle |
| Conversation | https://github.com/python/mypy/pull/7397 |
| Commits8 (8) | https://github.com/python/mypy/pull/7397/commits |
| Checks | https://github.com/python/mypy/pull/7397/checks |
| Files changed | https://github.com/python/mypy/pull/7397/files |
| Untangle most of the big import cycle | https://github.com/python/mypy/pull/7397#top |
| msullivan | https://github.com/msullivan |
| master | https://github.com/python/mypy/tree/master |
| untangle | https://github.com/python/mypy/tree/untangle |
|
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#issue-485525799 |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| msullivan | https://github.com/msullivan |
| August 26, 2019 16:36 | https://github.com/python/mypy/pull/7397#commits-pushed-b02cd86 |
|
| https://github.com/msullivan |
| Move bind_self and some friends into typeops.py | https://github.com/python/mypy/pull/7397/commits/b02cd86007102e02357ba5edcef1d70e3eaef24e |
| b02cd86 | https://github.com/python/mypy/pull/7397/commits/b02cd86007102e02357ba5edcef1d70e3eaef24e |
|
| https://github.com/msullivan |
| Move corresponding_argument to typeops | https://github.com/python/mypy/pull/7397/commits/24c1d1a92481648ac729315df0a75b7de2fa369d |
| 24c1d1a | https://github.com/python/mypy/pull/7397/commits/24c1d1a92481648ac729315df0a75b7de2fa369d |
|
| https://github.com/msullivan |
| Move make_simplified_union to typeops | https://github.com/python/mypy/pull/7397/commits/93511400cd6c27d15c29da2679a9dab97eeb5a1f |
| 9351140 | https://github.com/python/mypy/pull/7397/commits/93511400cd6c27d15c29da2679a9dab97eeb5a1f |
|
| https://github.com/msullivan |
| Move the true/false ones to typeops | https://github.com/python/mypy/pull/7397/commits/ed2bdad3c78a82d984f37668fb402f7022ee6afe |
| ed2bdad | https://github.com/python/mypy/pull/7397/commits/ed2bdad3c78a82d984f37668fb402f7022ee6afe |
|
| https://github.com/msullivan |
| last bit of untangling | https://github.com/python/mypy/pull/7397/commits/54a501b541753078d39d1cb1fafcb460c0a9d3ec |
| 54a501b | https://github.com/python/mypy/pull/7397/commits/54a501b541753078d39d1cb1fafcb460c0a9d3ec |
|
| https://github.com/msullivan |
| lint fixes | https://github.com/python/mypy/pull/7397/commits/cea19ed3d864438d1d6fda1cc3dfdc81616237a9 |
| cea19ed | https://github.com/python/mypy/pull/7397/commits/cea19ed3d864438d1d6fda1cc3dfdc81616237a9 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| JukkaL | https://github.com/JukkaL |
| gvanrossum | https://github.com/gvanrossum |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 27, 2019 01:01 | https://github.com/python/mypy/pull/7397#event-2585421457 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Aug 27, 2019
| https://github.com/python/mypy/pull/7397#pullrequestreview-279933722 |
|
View reviewed changes
| https://github.com/python/mypy/pull/7397/files/93511400cd6c27d15c29da2679a9dab97eeb5a1f |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/7397#pullrequestreview-279933722 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| mypy/typeops.py | https://github.com/python/mypy/pull/7397/files/24c1d1a92481648ac729315df0a75b7de2fa369d..93511400cd6c27d15c29da2679a9dab97eeb5a1f#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4 |
| gvanrossum | https://github.com/gvanrossum |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#discussion_r317875906 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| JukkaL | https://github.com/JukkaL |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#discussion_r318024247 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 27, 2019
| https://github.com/python/mypy/pull/7397#pullrequestreview-280117757 |
|
View reviewed changes
| https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9 |
| mypy/erasetype.py | https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9#diff-c9f0543a93a28cd330d73dd1accda2e354fe46039866a54550c0f4fe66db731b |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#discussion_r318021048 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#issuecomment-525255540 |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Aug 27, 2019
| https://github.com/python/mypy/pull/7397#pullrequestreview-280121982 |
|
View reviewed changes
| https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/7397#pullrequestreview-280121982 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| mypy/typeops.py | https://github.com/python/mypy/pull/7397/files/24c1d1a92481648ac729315df0a75b7de2fa369d..93511400cd6c27d15c29da2679a9dab97eeb5a1f#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4 |
| JukkaL | https://github.com/JukkaL |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#discussion_r318024247 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#issuecomment-525258949 |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| #6329 | https://github.com/python/mypy/issues/6329 |
| #93 | https://github.com/python/mypy/issues/93 |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| msullivan | https://github.com/msullivan |
| August 27, 2019 11:20 | https://github.com/python/mypy/pull/7397#commits-pushed-e2d4d63 |
|
| https://github.com/msullivan |
| Remove some comments | https://github.com/python/mypy/pull/7397/commits/e2d4d63d7ea3c37775e57a22b1f27292e25503c0 |
| e2d4d63 | https://github.com/python/mypy/pull/7397/commits/e2d4d63d7ea3c37775e57a22b1f27292e25503c0 |
|
| https://github.com/msullivan |
| Fix most import order dependence (except type_visitor) | https://github.com/python/mypy/pull/7397/commits/68ab6d427804ce71e17278ef7e45b8888ed0925d |
| 68ab6d4 | https://github.com/python/mypy/pull/7397/commits/68ab6d427804ce71e17278ef7e45b8888ed0925d |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#issuecomment-525432288 |
| #6329 | https://github.com/python/mypy/issues/6329 |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| 5cd1dab | https://github.com/python/mypy/commit/5cd1dabf0c0eef3acee31acbb57b51fa3d7b6b9d |
| Aug 27, 2019 | https://github.com/python/mypy/pull/7397#event-2588337605 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| August 27, 2019 20:07 | https://github.com/python/mypy/pull/7397#event-2588337837 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Aug 27, 2019
| https://github.com/python/mypy/pull/7397#ref-issue-428913165 |
|
Announcement issue for plugin API changes
#6617
| https://github.com/python/mypy/issues/6617 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 28, 2019 | https://github.com/python/mypy/pull/7397#issuecomment-525710981 |
| @msullivan | https://github.com/msullivan |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Aug 29, 2019 | https://github.com/python/mypy/pull/7397#issuecomment-526149430 |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Aug 29, 2019
| https://github.com/python/mypy/pull/7397#ref-issue-486910455 |
|
Add test that prevents increasing import cycles in the mypy implementation
#7407
| https://github.com/python/mypy/issues/7407 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7397 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/7397/files/93511400cd6c27d15c29da2679a9dab97eeb5a1f |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
| Please reload this page | https://github.com/python/mypy/pull/7397 |
|
| https://github.com/msullivan |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JukkaL |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |