René's URL Explorer Experiment


Title: Untangle most of the big import cycle by msullivan · Pull Request #7397 · python/mypy · GitHub

Open Graph Title: Untangle most of the big import cycle by msullivan · Pull Request #7397 · python/mypy

X Title: Untangle most of the big import cycle by msullivan · Pull Request #7397 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Currently mypy has a 47 module import cycle, which is not great. This untangles things, leaving the following cycles: Size 2: mypy.build, mypy.semanal_main Size 2: mypy.plugin, mypy.interpreted_pl...

X Description: Currently mypy has a 47 module import cycle, which is not great. This untangles things, leaving the following cycles: Size 2: mypy.build, mypy.semanal_main Size 2: mypy.plugin, mypy.interpreted_pl...

Opengraph URL: https://github.com/python/mypy/pull/7397

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:86bfebe2-d716-0b1d-6a0a-cd6da8a49415
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE398:24BFCE:2E0A8:3D7B9:6B00178D
html-safe-noncead51b3575636444f51ecd7db4e02eda3aec15ad0190fbf520516b1b64881acd5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzk4OjI0QkZDRToyRTBBODozRDdCOTo2QjAwMTc4RCIsInZpc2l0b3JfaWQiOiI2MTQxOTk0NTcxNTczMjM3NjQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbacf72b4ec1ae96cb7f20f66b903da2426ed2a4368e8c7ac8193c154840bfe42
hovercard-subject-tagpull_request:311154836
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/7397/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3a2baceb6b1760bf06e77f9e67df5b3c5aae28ce49c2164da87f2fa2f8f59ac9/python/mypy/pull/7397
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3a2baceb6b1760bf06e77f9e67df5b3c5aae28ce49c2164da87f2fa2f8f59ac9/python/mypy/pull/7397
og:image:altCurrently mypy has a 47 module import cycle, which is not great. This untangles things, leaving the following cycles: Size 2: mypy.build, mypy.semanal_main Size 2: mypy.plugin, mypy.interpreted_pl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsullivan
hostnamegithub.com
expected-hostnamegithub.com
Nonea2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release70121d4e855ee0bb7b75cf15d061d91f8863c0f8
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/7397#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7397
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7397
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/7397
Reloadhttps://github.com/python/mypy/pull/7397
Reloadhttps://github.com/python/mypy/pull/7397
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
msullivanhttps://github.com/msullivan
masterhttps://github.com/python/mypy/tree/master
untanglehttps://github.com/python/mypy/tree/untangle
Conversationhttps://github.com/python/mypy/pull/7397
Commits8 (8)https://github.com/python/mypy/pull/7397/commits
Checkshttps://github.com/python/mypy/pull/7397/checks
Files changedhttps://github.com/python/mypy/pull/7397/files
Untangle most of the big import cyclehttps://github.com/python/mypy/pull/7397#top
msullivanhttps://github.com/msullivan
masterhttps://github.com/python/mypy/tree/master
untanglehttps://github.com/python/mypy/tree/untangle
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Aug 27, 2019https://github.com/python/mypy/pull/7397#issue-485525799
Please reload this pagehttps://github.com/python/mypy/pull/7397
msullivanhttps://github.com/msullivan
August 26, 2019 16:36https://github.com/python/mypy/pull/7397#commits-pushed-b02cd86
https://github.com/msullivan
Move bind_self and some friends into typeops.pyhttps://github.com/python/mypy/pull/7397/commits/b02cd86007102e02357ba5edcef1d70e3eaef24e
b02cd86https://github.com/python/mypy/pull/7397/commits/b02cd86007102e02357ba5edcef1d70e3eaef24e
https://github.com/msullivan
Move corresponding_argument to typeopshttps://github.com/python/mypy/pull/7397/commits/24c1d1a92481648ac729315df0a75b7de2fa369d
24c1d1ahttps://github.com/python/mypy/pull/7397/commits/24c1d1a92481648ac729315df0a75b7de2fa369d
https://github.com/msullivan
Move make_simplified_union to typeopshttps://github.com/python/mypy/pull/7397/commits/93511400cd6c27d15c29da2679a9dab97eeb5a1f
9351140https://github.com/python/mypy/pull/7397/commits/93511400cd6c27d15c29da2679a9dab97eeb5a1f
https://github.com/msullivan
Move the true/false ones to typeopshttps://github.com/python/mypy/pull/7397/commits/ed2bdad3c78a82d984f37668fb402f7022ee6afe
ed2bdadhttps://github.com/python/mypy/pull/7397/commits/ed2bdad3c78a82d984f37668fb402f7022ee6afe
https://github.com/msullivan
last bit of untanglinghttps://github.com/python/mypy/pull/7397/commits/54a501b541753078d39d1cb1fafcb460c0a9d3ec
54a501bhttps://github.com/python/mypy/pull/7397/commits/54a501b541753078d39d1cb1fafcb460c0a9d3ec
https://github.com/msullivan
lint fixeshttps://github.com/python/mypy/pull/7397/commits/cea19ed3d864438d1d6fda1cc3dfdc81616237a9
cea19edhttps://github.com/python/mypy/pull/7397/commits/cea19ed3d864438d1d6fda1cc3dfdc81616237a9
https://github.com/msullivan
msullivanhttps://github.com/msullivan
JukkaLhttps://github.com/JukkaL
gvanrossumhttps://github.com/gvanrossum
ilevkivskyihttps://github.com/ilevkivskyi
August 27, 2019 01:01https://github.com/python/mypy/pull/7397#event-2585421457
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Aug 27, 2019 https://github.com/python/mypy/pull/7397#pullrequestreview-279933722
View reviewed changes https://github.com/python/mypy/pull/7397/files/93511400cd6c27d15c29da2679a9dab97eeb5a1f
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/7397#pullrequestreview-279933722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7397
mypy/typeops.pyhttps://github.com/python/mypy/pull/7397/files/24c1d1a92481648ac729315df0a75b7de2fa369d..93511400cd6c27d15c29da2679a9dab97eeb5a1f#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
gvanrossumhttps://github.com/gvanrossum
Aug 27, 2019https://github.com/python/mypy/pull/7397#discussion_r317875906
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7397
JukkaLhttps://github.com/JukkaL
Aug 27, 2019https://github.com/python/mypy/pull/7397#discussion_r318024247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7397
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 27, 2019 https://github.com/python/mypy/pull/7397#pullrequestreview-280117757
View reviewed changes https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9
mypy/erasetype.pyhttps://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9#diff-c9f0543a93a28cd330d73dd1accda2e354fe46039866a54550c0f4fe66db731b
ilevkivskyihttps://github.com/ilevkivskyi
Aug 27, 2019https://github.com/python/mypy/pull/7397#discussion_r318021048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7397
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 27, 2019https://github.com/python/mypy/pull/7397#issuecomment-525255540
Please reload this pagehttps://github.com/python/mypy/pull/7397
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Aug 27, 2019 https://github.com/python/mypy/pull/7397#pullrequestreview-280121982
View reviewed changes https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/7397#pullrequestreview-280121982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7397
mypy/typeops.pyhttps://github.com/python/mypy/pull/7397/files/24c1d1a92481648ac729315df0a75b7de2fa369d..93511400cd6c27d15c29da2679a9dab97eeb5a1f#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
JukkaLhttps://github.com/JukkaL
Aug 27, 2019https://github.com/python/mypy/pull/7397#discussion_r318024247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7397
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 27, 2019https://github.com/python/mypy/pull/7397#issuecomment-525258949
Please reload this pagehttps://github.com/python/mypy/pull/7397
#6329https://github.com/python/mypy/issues/6329
#93https://github.com/python/mypy/issues/93
Please reload this pagehttps://github.com/python/mypy/pull/7397
msullivanhttps://github.com/msullivan
August 27, 2019 11:20https://github.com/python/mypy/pull/7397#commits-pushed-e2d4d63
https://github.com/msullivan
Remove some commentshttps://github.com/python/mypy/pull/7397/commits/e2d4d63d7ea3c37775e57a22b1f27292e25503c0
e2d4d63https://github.com/python/mypy/pull/7397/commits/e2d4d63d7ea3c37775e57a22b1f27292e25503c0
https://github.com/msullivan
Fix most import order dependence (except type_visitor)https://github.com/python/mypy/pull/7397/commits/68ab6d427804ce71e17278ef7e45b8888ed0925d
68ab6d4https://github.com/python/mypy/pull/7397/commits/68ab6d427804ce71e17278ef7e45b8888ed0925d
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Aug 27, 2019https://github.com/python/mypy/pull/7397#issuecomment-525432288
#6329https://github.com/python/mypy/issues/6329
Please reload this pagehttps://github.com/python/mypy/pull/7397
https://github.com/msullivan
msullivanhttps://github.com/msullivan
5cd1dabhttps://github.com/python/mypy/commit/5cd1dabf0c0eef3acee31acbb57b51fa3d7b6b9d
Aug 27, 2019https://github.com/python/mypy/pull/7397#event-2588337605
https://github.com/msullivan
msullivanhttps://github.com/msullivan
August 27, 2019 20:07https://github.com/python/mypy/pull/7397#event-2588337837
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Aug 27, 2019 https://github.com/python/mypy/pull/7397#ref-issue-428913165
Announcement issue for plugin API changes #6617 https://github.com/python/mypy/issues/6617
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 28, 2019https://github.com/python/mypy/pull/7397#issuecomment-525710981
@msullivanhttps://github.com/msullivan
Please reload this pagehttps://github.com/python/mypy/pull/7397
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Aug 29, 2019https://github.com/python/mypy/pull/7397#issuecomment-526149430
Please reload this pagehttps://github.com/python/mypy/pull/7397
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Aug 29, 2019 https://github.com/python/mypy/pull/7397#ref-issue-486910455
Add test that prevents increasing import cycles in the mypy implementation #7407 https://github.com/python/mypy/issues/7407
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7397
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/7397/files/cea19ed3d864438d1d6fda1cc3dfdc81616237a9
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/7397/files/93511400cd6c27d15c29da2679a9dab97eeb5a1f
Please reload this pagehttps://github.com/python/mypy/pull/7397
Please reload this pagehttps://github.com/python/mypy/pull/7397
https://github.com/msullivan
https://github.com/ilevkivskyi
https://github.com/JukkaL
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.