René's URL Explorer Experiment


Title: Make warn-unreachable understand exception-swallowing contextmanagers by Michael0x2a · Pull Request #7317 · python/mypy · GitHub

Open Graph Title: Make warn-unreachable understand exception-swallowing contextmanagers by Michael0x2a · Pull Request #7317 · python/mypy

X Title: Make warn-unreachable understand exception-swallowing contextmanagers by Michael0x2a · Pull Request #7317 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This pull request fixes #7214: it makes mypy treat any contextmanagers where the __exit__ returns bool or Literal[True] as ones that can potentially swallow exceptions. Contextmanagers that return ...

X Description: This pull request fixes #7214: it makes mypy treat any contextmanagers where the __exit__ returns bool or Literal[True] as ones that can potentially swallow exceptions. Contextmanagers that return ...

Opengraph URL: https://github.com/python/mypy/pull/7317

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3a5bcd4f-dedd-f03b-6cfd-cfe34c80d0cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABFA:1A12A9:B9DD04:F7B0D8:6B004D22
html-safe-nonce5ce25c8ac1fffbf495153acde1087dcc21cf330bc65a9b1154b9da9aec4641e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkZBOjFBMTJBOTpCOUREMDQ6RjdCMEQ4OjZCMDA0RDIyIiwidmlzaXRvcl9pZCI6IjgwMzI4NjczNzk3Njk3ODk3MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaafa2f35f90c68fcb8f75d7fa56a60671dcbc69de04c6e1b77b6943258a3ea68
hovercard-subject-tagpull_request:306230592
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/7317/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/95872d154b2c088b33d5630e51812cafce44e20a26a99f509be3aa80b76ad1c4/python/mypy/pull/7317
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/95872d154b2c088b33d5630e51812cafce44e20a26a99f509be3aa80b76ad1c4/python/mypy/pull/7317
og:image:altThis pull request fixes #7214: it makes mypy treat any contextmanagers where the __exit__ returns bool or Literal[True] as ones that can potentially swallow exceptions. Contextmanagers that return ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/7317#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7317
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7317
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/7317
Reloadhttps://github.com/python/mypy/pull/7317
Reloadhttps://github.com/python/mypy/pull/7317
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:refine-unreachable-checks-against-withhttps://github.com/Michael0x2a/mypy/tree/refine-unreachable-checks-against-with
Conversationhttps://github.com/python/mypy/pull/7317
Commits4 (4)https://github.com/python/mypy/pull/7317/commits
Checkshttps://github.com/python/mypy/pull/7317/checks
Files changedhttps://github.com/python/mypy/pull/7317/files
Make warn-unreachable understand exception-swallowing contextmanagershttps://github.com/python/mypy/pull/7317#top
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:refine-unreachable-checks-against-withhttps://github.com/Michael0x2a/mypy/tree/refine-unreachable-checks-against-with
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 10, 2019https://github.com/python/mypy/pull/7317#issue-479294354
#7214https://github.com/python/mypy/issues/7214
python/typeshed#3179https://github.com/python/typeshed/pull/3179
Please reload this pagehttps://github.com/python/mypy/pull/7317
Michael0x2ahttps://github.com/Michael0x2a
August 10, 2019 11:13https://github.com/python/mypy/pull/7317#commits-pushed-b667bd1
https://github.com/Michael0x2a
Make warn-unreachable understand exception-swallowing contextmanagershttps://github.com/python/mypy/pull/7317/commits/b667bd1f6063b0cd134b48b2197602239b2de8a9
b667bd1https://github.com/python/mypy/pull/7317/commits/b667bd1f6063b0cd134b48b2197602239b2de8a9
python#7214https://github.com/python/mypy/issues/7214
python/typeshed#3179https://github.com/python/typeshed/pull/3179
https://github.com/ilevkivskyi
Merge branch 'master' into refine-unreachable-checks-against-withhttps://github.com/python/mypy/pull/7317/commits/24ad85feb402dfa01d3c939899b7e7bbadf730f2
24ad85fhttps://github.com/python/mypy/pull/7317/commits/24ad85feb402dfa01d3c939899b7e7bbadf730f2
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7317#issuecomment-522135507
Please reload this pagehttps://github.com/python/mypy/pull/7317
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7317#event-2563301880
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7317#event-2563302091
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 16, 2019https://github.com/python/mypy/pull/7317#issuecomment-522141139
python/typeshed#3179https://github.com/python/typeshed/pull/3179
Please reload this pagehttps://github.com/python/mypy/pull/7317
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7317#issuecomment-522160108
Please reload this pagehttps://github.com/python/mypy/pull/7317
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 16, 2019https://github.com/python/mypy/pull/7317#issuecomment-522178248
Please reload this pagehttps://github.com/python/mypy/pull/7317
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 23, 2019 https://github.com/python/mypy/pull/7317#pullrequestreview-278745105
View reviewed changes https://github.com/python/mypy/pull/7317/files
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7317#pullrequestreview-278745105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7317
test-data/unit/check-unreachable-code.testhttps://github.com/python/mypy/pull/7317/files#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2
Please reload this pagehttps://github.com/python/mypy/pull/7317
test-data/unit/pythoneval.testhttps://github.com/python/mypy/pull/7317/files#diff-8b48b1eca587106e3806bfa9e14b7f7f344e117b203ffc716ce6fef7f2e68fe6
Please reload this pagehttps://github.com/python/mypy/pull/7317
test-data/unit/check-unreachable-code.testhttps://github.com/python/mypy/pull/7317/files#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2
Please reload this pagehttps://github.com/python/mypy/pull/7317
mypy/types.pyhttps://github.com/python/mypy/pull/7317/files#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664
Please reload this pagehttps://github.com/python/mypy/pull/7317
mypy/checker.pyhttps://github.com/python/mypy/pull/7317/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/7317
mypy/checker.pyhttps://github.com/python/mypy/pull/7317/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/7317
mypy/checker.pyhttps://github.com/python/mypy/pull/7317/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Aug 23, 2019https://github.com/python/mypy/pull/7317#discussion_r316936046
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7317
Michael0x2ahttps://github.com/Michael0x2a
Aug 25, 2019https://github.com/python/mypy/pull/7317#discussion_r317405489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
conventionshttps://github.com/python/typeshed/blob/master/CONTRIBUTING.md#conventions
Protocols pagehttps://mypy.readthedocs.io/en/stable/protocols.html#context-manager-protocols
Please reload this pagehttps://github.com/python/mypy/pull/7317
https://github.com/Michael0x2a
Respond to code review; partially disable heuristics when strict-opti…https://github.com/python/mypy/pull/7317/commits/b75f886789552a3d4983390e8c9aec21c36912fa
b75f886https://github.com/python/mypy/pull/7317/commits/b75f886789552a3d4983390e8c9aec21c36912fa
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
force-pushedhttps://github.com/python/mypy/compare/4fee4b8275fd86744334ac133bd4507f6aea9376..b75f886789552a3d4983390e8c9aec21c36912fa
4fee4b8https://github.com/python/mypy/commit/4fee4b8275fd86744334ac133bd4507f6aea9376
b75f886https://github.com/python/mypy/commit/b75f886789552a3d4983390e8c9aec21c36912fa
Compare https://github.com/python/mypy/compare/4fee4b8275fd86744334ac133bd4507f6aea9376..b75f886789552a3d4983390e8c9aec21c36912fa
August 25, 2019 15:18https://github.com/python/mypy/pull/7317#event-2581984386
https://github.com/Michael0x2a
Merge branch 'master' into refine-unreachable-checks-against-withhttps://github.com/python/mypy/pull/7317/commits/73edaf8bcfc5cc7fe439b82207d454f2e8b61704
73edaf8https://github.com/python/mypy/pull/7317/commits/73edaf8bcfc5cc7fe439b82207d454f2e8b61704
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 25, 2019https://github.com/python/mypy/pull/7317#issuecomment-524644469
Please reload this pagehttps://github.com/python/mypy/pull/7317
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
f15d677https://github.com/python/mypy/commit/f15d67757c2e746d600a641d88f628aefa977ddd
Aug 25, 2019https://github.com/python/mypy/pull/7317#event-2582022080
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
August 25, 2019 16:42https://github.com/python/mypy/pull/7317#event-2582022111
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 26, 2019https://github.com/python/mypy/pull/7317#issuecomment-524828944
Protocols pagehttps://mypy.readthedocs.io/en/stable/protocols.html#context-manager-protocols
Please reload this pagehttps://github.com/python/mypy/pull/7317
https://github.com/jacobbogdanov
jacobbogdanovhttps://github.com/jacobbogdanov
Jun 27, 2020 https://github.com/python/mypy/pull/7317#ref-pullrequest-646774785
Improve type inference of context manager that swallow exceptions microsoft/pyright#771 https://github.com/microsoft/pyright/pull/771
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7317
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7317/files/32fe10272fa056baefe9983271304d0dfc694dce
Please reload this pagehttps://github.com/python/mypy/pull/7317
Bug: false positive with --warn-unreachable https://github.com/python/mypy/issues/7214
Please reload this pagehttps://github.com/python/mypy/pull/7317
https://github.com/Michael0x2a
https://github.com/ilevkivskyi
https://github.com/JelleZijlstra
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.