| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3a5bcd4f-dedd-f03b-6cfd-cfe34c80d0cb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ABFA:1A12A9:B9DD04:F7B0D8:6B004D22 |
| html-safe-nonce | 5ce25c8ac1fffbf495153acde1087dcc21cf330bc65a9b1154b9da9aec4641e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkZBOjFBMTJBOTpCOUREMDQ6RjdCMEQ4OjZCMDA0RDIyIiwidmlzaXRvcl9pZCI6IjgwMzI4NjczNzk3Njk3ODk3MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | aafa2f35f90c68fcb8f75d7fa56a60671dcbc69de04c6e1b77b6943258a3ea68 |
| hovercard-subject-tag | pull_request:306230592 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/7317/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/95872d154b2c088b33d5630e51812cafce44e20a26a99f509be3aa80b76ad1c4/python/mypy/pull/7317 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/95872d154b2c088b33d5630e51812cafce44e20a26a99f509be3aa80b76ad1c4/python/mypy/pull/7317 |
| og:image:alt | This pull request fixes #7214: it makes mypy treat any contextmanagers where the __exit__ returns bool or Literal[True] as ones that can potentially swallow exceptions.
Contextmanagers that return ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Michael0x2a |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/7317#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7317 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7317 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/7317 |
| Reload | https://github.com/python/mypy/pull/7317 |
| Reload | https://github.com/python/mypy/pull/7317 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| Michael0x2a | https://github.com/Michael0x2a |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:refine-unreachable-checks-against-with | https://github.com/Michael0x2a/mypy/tree/refine-unreachable-checks-against-with |
| Conversation | https://github.com/python/mypy/pull/7317 |
| Commits4 (4) | https://github.com/python/mypy/pull/7317/commits |
| Checks | https://github.com/python/mypy/pull/7317/checks |
| Files changed | https://github.com/python/mypy/pull/7317/files |
| Make warn-unreachable understand exception-swallowing contextmanagers | https://github.com/python/mypy/pull/7317#top |
| Michael0x2a | https://github.com/Michael0x2a |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:refine-unreachable-checks-against-with | https://github.com/Michael0x2a/mypy/tree/refine-unreachable-checks-against-with |
|
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 10, 2019 | https://github.com/python/mypy/pull/7317#issue-479294354 |
| #7214 | https://github.com/python/mypy/issues/7214 |
| python/typeshed#3179 | https://github.com/python/typeshed/pull/3179 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| Michael0x2a | https://github.com/Michael0x2a |
| August 10, 2019 11:13 | https://github.com/python/mypy/pull/7317#commits-pushed-b667bd1 |
|
| https://github.com/Michael0x2a |
| Make warn-unreachable understand exception-swallowing contextmanagers | https://github.com/python/mypy/pull/7317/commits/b667bd1f6063b0cd134b48b2197602239b2de8a9 |
| b667bd1 | https://github.com/python/mypy/pull/7317/commits/b667bd1f6063b0cd134b48b2197602239b2de8a9 |
| python#7214 | https://github.com/python/mypy/issues/7214 |
| python/typeshed#3179 | https://github.com/python/typeshed/pull/3179 |
|
| https://github.com/ilevkivskyi |
| Merge branch 'master' into refine-unreachable-checks-against-with | https://github.com/python/mypy/pull/7317/commits/24ad85feb402dfa01d3c939899b7e7bbadf730f2 |
| 24ad85f | https://github.com/python/mypy/pull/7317/commits/24ad85feb402dfa01d3c939899b7e7bbadf730f2 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7317#issuecomment-522135507 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7317#event-2563301880 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7317#event-2563302091 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7317#issuecomment-522141139 |
| python/typeshed#3179 | https://github.com/python/typeshed/pull/3179 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7317#issuecomment-522160108 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7317#issuecomment-522178248 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 23, 2019
| https://github.com/python/mypy/pull/7317#pullrequestreview-278745105 |
|
View reviewed changes
| https://github.com/python/mypy/pull/7317/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/7317#pullrequestreview-278745105 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/7317/files#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| test-data/unit/pythoneval.test | https://github.com/python/mypy/pull/7317/files#diff-8b48b1eca587106e3806bfa9e14b7f7f344e117b203ffc716ce6fef7f2e68fe6 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/7317/files#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| mypy/types.py | https://github.com/python/mypy/pull/7317/files#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| mypy/checker.py | https://github.com/python/mypy/pull/7317/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| mypy/checker.py | https://github.com/python/mypy/pull/7317/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| mypy/checker.py | https://github.com/python/mypy/pull/7317/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 23, 2019 | https://github.com/python/mypy/pull/7317#discussion_r316936046 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 25, 2019 | https://github.com/python/mypy/pull/7317#discussion_r317405489 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| conventions | https://github.com/python/typeshed/blob/master/CONTRIBUTING.md#conventions |
| Protocols page | https://mypy.readthedocs.io/en/stable/protocols.html#context-manager-protocols |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
|
| https://github.com/Michael0x2a |
| Respond to code review; partially disable heuristics when strict-opti… | https://github.com/python/mypy/pull/7317/commits/b75f886789552a3d4983390e8c9aec21c36912fa |
| b75f886 | https://github.com/python/mypy/pull/7317/commits/b75f886789552a3d4983390e8c9aec21c36912fa |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| force-pushed | https://github.com/python/mypy/compare/4fee4b8275fd86744334ac133bd4507f6aea9376..b75f886789552a3d4983390e8c9aec21c36912fa |
| 4fee4b8 | https://github.com/python/mypy/commit/4fee4b8275fd86744334ac133bd4507f6aea9376 |
| b75f886 | https://github.com/python/mypy/commit/b75f886789552a3d4983390e8c9aec21c36912fa |
|
Compare
| https://github.com/python/mypy/compare/4fee4b8275fd86744334ac133bd4507f6aea9376..b75f886789552a3d4983390e8c9aec21c36912fa |
| August 25, 2019 15:18 | https://github.com/python/mypy/pull/7317#event-2581984386 |
|
| https://github.com/Michael0x2a |
| Merge branch 'master' into refine-unreachable-checks-against-with | https://github.com/python/mypy/pull/7317/commits/73edaf8bcfc5cc7fe439b82207d454f2e8b61704 |
| 73edaf8 | https://github.com/python/mypy/pull/7317/commits/73edaf8bcfc5cc7fe439b82207d454f2e8b61704 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 25, 2019 | https://github.com/python/mypy/pull/7317#issuecomment-524644469 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| f15d677 | https://github.com/python/mypy/commit/f15d67757c2e746d600a641d88f628aefa977ddd |
| Aug 25, 2019 | https://github.com/python/mypy/pull/7317#event-2582022080 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| August 25, 2019 16:42 | https://github.com/python/mypy/pull/7317#event-2582022111 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 26, 2019 | https://github.com/python/mypy/pull/7317#issuecomment-524828944 |
| Protocols page | https://mypy.readthedocs.io/en/stable/protocols.html#context-manager-protocols |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
| https://github.com/jacobbogdanov |
| jacobbogdanov | https://github.com/jacobbogdanov |
|
Jun 27, 2020
| https://github.com/python/mypy/pull/7317#ref-pullrequest-646774785 |
|
Improve type inference of context manager that swallow exceptions
microsoft/pyright#771
| https://github.com/microsoft/pyright/pull/771 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7317 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/7317/files/32fe10272fa056baefe9983271304d0dfc694dce |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
|
Bug: false positive with --warn-unreachable
| https://github.com/python/mypy/issues/7214 |
| Please reload this page | https://github.com/python/mypy/pull/7317 |
|
| https://github.com/Michael0x2a |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JelleZijlstra |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |