| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:b518762f-487b-1d18-e672-3b322d5cb13e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B94A:2046A4:DDD577:128CF33:6B00549D |
| html-safe-nonce | 274349d2f016ae0a1b75299eeaac73ac35e03f17a8eeb29bfbad05c97456f83f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTRBOjIwNDZBNDpEREQ1Nzc6MTI4Q0YzMzo2QjAwNTQ5RCIsInZpc2l0b3JfaWQiOiI4ODAwNjY2MDE3NDE3MTU1NzQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a5e7e62ec5b77fff5b10e320d366a49b4d858b3d228016c9690608e0b6abde93 |
| hovercard-subject-tag | pull_request:306184048 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/mypy/pull/7312 |
| twitter:image | https://opengraph.githubassets.com/44d27de03e559596404972230c890ac5a26531c1738a7ce773591e1cd25c70ae/python/mypy/pull/7312 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/44d27de03e559596404972230c890ac5a26531c1738a7ce773591e1cd25c70ae/python/mypy/pull/7312 |
| og:image:alt | This pull request almost resolves #730 -- it makes all TypeVisitor and SyntheticTypeVisitor methods with the exception of TypeAliasType abstract.
This thankfully required fairly minimal changes. I ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Michael0x2a |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/7312#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7312 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7312 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/7312 |
| Reload | https://github.com/python/mypy/pull/7312 |
| Reload | https://github.com/python/mypy/pull/7312 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:make-all-type-visitor-methods-abstract | https://github.com/Michael0x2a/mypy/tree/make-all-type-visitor-methods-abstract |
| Conversation | https://github.com/python/mypy/pull/7312 |
| Commits4 (4) | https://github.com/python/mypy/pull/7312/commits |
| Checks | https://github.com/python/mypy/pull/7312/checks |
| Files changed | https://github.com/python/mypy/pull/7312/files |
| Make TypeVisitor and SyntheticTypeVisitor (almost) fully abstract | https://github.com/python/mypy/pull/7312#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:make-all-type-visitor-methods-abstract | https://github.com/Michael0x2a/mypy/tree/make-all-type-visitor-methods-abstract |
|
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 10, 2019 | https://github.com/python/mypy/pull/7312#issue-479226394 |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| #730 | https://github.com/python/mypy/issues/730 |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| Michael0x2a | https://github.com/Michael0x2a |
| August 9, 2019 21:08 | https://github.com/python/mypy/pull/7312#commits-pushed-2a550d8 |
|
| https://github.com/Michael0x2a |
| Make TypeVisitor and SyntheticTypeVisitor fully abstract | https://github.com/python/mypy/pull/7312/commits/2a550d8dcb35ce015191bb01995c680af370a788 |
| 2a550d8 | https://github.com/python/mypy/pull/7312/commits/2a550d8dcb35ce015191bb01995c680af370a788 |
| python#730 | https://github.com/python/mypy/issues/730 |
|
| https://github.com/ilevkivskyi |
| Merge branch 'master' into make-all-type-visitor-methods-abstract | https://github.com/python/mypy/pull/7312/commits/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f |
| 2edff9a | https://github.com/python/mypy/pull/7312/commits/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 16, 2019
| https://github.com/python/mypy/pull/7312#pullrequestreview-275874449 |
|
View reviewed changes
| https://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/7312#pullrequestreview-275874449 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| mypy/fixup.py | https://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-68ad7e14d14c5c769296b859d2ab8a5a38fde4e2a9ad628de1000666c5d9ed1d |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#discussion_r314661890 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| mypy/server/astmerge.py | https://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#discussion_r314662135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| mypy/server/astmerge.py | https://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#discussion_r314662513 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#discussion_r314874985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| mypy/server/deps.py | https://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#discussion_r314662618 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| mypy/typeanal.py | https://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#discussion_r314663567 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| mypy/typeanal.py | https://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#discussion_r314664407 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#event-2561940115 |
|
| https://github.com/Michael0x2a |
| Respond to code review | https://github.com/python/mypy/pull/7312/commits/d27ab28eafab44fb22fdb3ad6df53460c91c4a1c |
| d27ab28 | https://github.com/python/mypy/pull/7312/commits/d27ab28eafab44fb22fdb3ad6df53460c91c4a1c |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 16, 2019 | https://github.com/python/mypy/pull/7312#issuecomment-522138073 |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
|
| https://github.com/ilevkivskyi |
| Merge branch 'master' into make-all-type-visitor-methods-abstract | https://github.com/python/mypy/pull/7312/commits/8d576f6a35325a97aa8b77c4195eaa75882665af |
| 8d576f6 | https://github.com/python/mypy/pull/7312/commits/8d576f6a35325a97aa8b77c4195eaa75882665af |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 22, 2019
| https://github.com/python/mypy/pull/7312#pullrequestreview-278652099 |
|
View reviewed changes
| https://github.com/python/mypy/pull/7312/files/8d576f6a35325a97aa8b77c4195eaa75882665af |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/7312#pullrequestreview-278652099 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 5ebd05e | https://github.com/python/mypy/commit/5ebd05eccc1295995b8c1d6aef6710eb156255cc |
| Aug 22, 2019 | https://github.com/python/mypy/pull/7312#event-2577790403 |
| Michael0x2a | https://github.com/Michael0x2a |
|
Aug 25, 2019
| https://github.com/python/mypy/pull/7312#ref-commit-42dc938 |
|
| https://github.com/Michael0x2a |
| Make TypeVisitor and SyntheticTypeVisitor (almost) fully abstract ( | https://github.com/Michael0x2a/mypy/commit/42dc9383e8b1606800bc240b3333e55e8fa4de26 |
| py… | https://github.com/python/mypy/pull/7312 |
| 42dc938 | https://github.com/Michael0x2a/mypy/commit/42dc9383e8b1606800bc240b3333e55e8fa4de26 |
| …thon#7312 | https://github.com/python/mypy/pull/7312 |
| python#730 | https://github.com/python/mypy/issues/730 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| November 5, 2019 16:43 | https://github.com/python/mypy/pull/7312#event-2772123212 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7312 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/7312/files/8d576f6a35325a97aa8b77c4195eaa75882665af |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
|
Catch TypeVisitor subclasses with unimplemented abstract methods
| https://github.com/python/mypy/issues/730 |
| Please reload this page | https://github.com/python/mypy/pull/7312 |
|
| https://github.com/Michael0x2a |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |