René's URL Explorer Experiment


Title: Make TypeVisitor and SyntheticTypeVisitor (almost) fully abstract by Michael0x2a · Pull Request #7312 · python/mypy · GitHub

Open Graph Title: Make TypeVisitor and SyntheticTypeVisitor (almost) fully abstract by Michael0x2a · Pull Request #7312 · python/mypy

X Title: Make TypeVisitor and SyntheticTypeVisitor (almost) fully abstract by Michael0x2a · Pull Request #7312 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This pull request almost resolves #730 -- it makes all TypeVisitor and SyntheticTypeVisitor methods with the exception of TypeAliasType abstract. This thankfully required fairly minimal changes. I ...

X Description: This pull request almost resolves #730 -- it makes all TypeVisitor and SyntheticTypeVisitor methods with the exception of TypeAliasType abstract. This thankfully required fairly minimal changes. I ...

Opengraph URL: https://github.com/python/mypy/pull/7312

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:b518762f-487b-1d18-e672-3b322d5cb13e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB94A:2046A4:DDD577:128CF33:6B00549D
html-safe-nonce274349d2f016ae0a1b75299eeaac73ac35e03f17a8eeb29bfbad05c97456f83f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTRBOjIwNDZBNDpEREQ1Nzc6MTI4Q0YzMzo2QjAwNTQ5RCIsInZpc2l0b3JfaWQiOiI4ODAwNjY2MDE3NDE3MTU1NzQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca5e7e62ec5b77fff5b10e320d366a49b4d858b3d228016c9690608e0b6abde93
hovercard-subject-tagpull_request:306184048
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/7312
twitter:imagehttps://opengraph.githubassets.com/44d27de03e559596404972230c890ac5a26531c1738a7ce773591e1cd25c70ae/python/mypy/pull/7312
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/44d27de03e559596404972230c890ac5a26531c1738a7ce773591e1cd25c70ae/python/mypy/pull/7312
og:image:altThis pull request almost resolves #730 -- it makes all TypeVisitor and SyntheticTypeVisitor methods with the exception of TypeAliasType abstract. This thankfully required fairly minimal changes. I ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/7312#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7312
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7312
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/7312
Reloadhttps://github.com/python/mypy/pull/7312
Reloadhttps://github.com/python/mypy/pull/7312
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:make-all-type-visitor-methods-abstracthttps://github.com/Michael0x2a/mypy/tree/make-all-type-visitor-methods-abstract
Conversationhttps://github.com/python/mypy/pull/7312
Commits4 (4)https://github.com/python/mypy/pull/7312/commits
Checkshttps://github.com/python/mypy/pull/7312/checks
Files changedhttps://github.com/python/mypy/pull/7312/files
Make TypeVisitor and SyntheticTypeVisitor (almost) fully abstracthttps://github.com/python/mypy/pull/7312#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:make-all-type-visitor-methods-abstracthttps://github.com/Michael0x2a/mypy/tree/make-all-type-visitor-methods-abstract
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 10, 2019https://github.com/python/mypy/pull/7312#issue-479226394
Please reload this pagehttps://github.com/python/mypy/pull/7312
#730https://github.com/python/mypy/issues/730
Please reload this pagehttps://github.com/python/mypy/pull/7312
Michael0x2ahttps://github.com/Michael0x2a
August 9, 2019 21:08https://github.com/python/mypy/pull/7312#commits-pushed-2a550d8
https://github.com/Michael0x2a
Make TypeVisitor and SyntheticTypeVisitor fully abstracthttps://github.com/python/mypy/pull/7312/commits/2a550d8dcb35ce015191bb01995c680af370a788
2a550d8https://github.com/python/mypy/pull/7312/commits/2a550d8dcb35ce015191bb01995c680af370a788
python#730https://github.com/python/mypy/issues/730
https://github.com/ilevkivskyi
Merge branch 'master' into make-all-type-visitor-methods-abstracthttps://github.com/python/mypy/pull/7312/commits/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f
2edff9ahttps://github.com/python/mypy/pull/7312/commits/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019 https://github.com/python/mypy/pull/7312#pullrequestreview-275874449
View reviewed changes https://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7312#pullrequestreview-275874449
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
mypy/fixup.pyhttps://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-68ad7e14d14c5c769296b859d2ab8a5a38fde4e2a9ad628de1000666c5d9ed1d
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7312#discussion_r314661890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
mypy/server/astmerge.pyhttps://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7312#discussion_r314662135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
mypy/server/astmerge.pyhttps://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7312#discussion_r314662513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
Michael0x2ahttps://github.com/Michael0x2a
Aug 16, 2019https://github.com/python/mypy/pull/7312#discussion_r314874985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
mypy/server/deps.pyhttps://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7312#discussion_r314662618
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
mypy/typeanal.pyhttps://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7312#discussion_r314663567
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
mypy/typeanal.pyhttps://github.com/python/mypy/pull/7312/files/2edff9a732f56c9bd95daa485e049f0c9f5ecb8f#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7312#discussion_r314664407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 16, 2019https://github.com/python/mypy/pull/7312#event-2561940115
https://github.com/Michael0x2a
Respond to code reviewhttps://github.com/python/mypy/pull/7312/commits/d27ab28eafab44fb22fdb3ad6df53460c91c4a1c
d27ab28https://github.com/python/mypy/pull/7312/commits/d27ab28eafab44fb22fdb3ad6df53460c91c4a1c
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 16, 2019https://github.com/python/mypy/pull/7312#issuecomment-522138073
Please reload this pagehttps://github.com/python/mypy/pull/7312
https://github.com/ilevkivskyi
Merge branch 'master' into make-all-type-visitor-methods-abstracthttps://github.com/python/mypy/pull/7312/commits/8d576f6a35325a97aa8b77c4195eaa75882665af
8d576f6https://github.com/python/mypy/pull/7312/commits/8d576f6a35325a97aa8b77c4195eaa75882665af
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 22, 2019 https://github.com/python/mypy/pull/7312#pullrequestreview-278652099
View reviewed changes https://github.com/python/mypy/pull/7312/files/8d576f6a35325a97aa8b77c4195eaa75882665af
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7312#pullrequestreview-278652099
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/7312
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
5ebd05ehttps://github.com/python/mypy/commit/5ebd05eccc1295995b8c1d6aef6710eb156255cc
Aug 22, 2019https://github.com/python/mypy/pull/7312#event-2577790403
Michael0x2ahttps://github.com/Michael0x2a
Aug 25, 2019 https://github.com/python/mypy/pull/7312#ref-commit-42dc938
https://github.com/Michael0x2a
Make TypeVisitor and SyntheticTypeVisitor (almost) fully abstract (https://github.com/Michael0x2a/mypy/commit/42dc9383e8b1606800bc240b3333e55e8fa4de26
py…https://github.com/python/mypy/pull/7312
42dc938https://github.com/Michael0x2a/mypy/commit/42dc9383e8b1606800bc240b3333e55e8fa4de26
…thon#7312https://github.com/python/mypy/pull/7312
python#730https://github.com/python/mypy/issues/730
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
November 5, 2019 16:43https://github.com/python/mypy/pull/7312#event-2772123212
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7312
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/7312/files/8d576f6a35325a97aa8b77c4195eaa75882665af
Please reload this pagehttps://github.com/python/mypy/pull/7312
Catch TypeVisitor subclasses with unimplemented abstract methods https://github.com/python/mypy/issues/730
Please reload this pagehttps://github.com/python/mypy/pull/7312
https://github.com/Michael0x2a
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.