| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e5417f96-ecb1-c5a6-8ccd-506881c90aff |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B0BC:3CBF1A:226DC3E:2F2A6BF:6B003447 |
| html-safe-nonce | a2ac7007a1a20a717f933cb3c0a22f1872c83afd55ba1994b32b50351a625d52 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEJDOjNDQkYxQToyMjZEQzNFOjJGMkE2QkY6NkIwMDM0NDciLCJ2aXNpdG9yX2lkIjoiMzI2NTAwMTM5NTM4MzcxMDc5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 77b3da52969a0e3384aef053085c03e4504e1c27d55f9502149563554ad18f47 |
| hovercard-subject-tag | pull_request:293882929 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/mypy/pull/7136/files |
| twitter:image | https://avatars.githubusercontent.com/u/12005495?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/12005495?s=400&v=4 |
| og:image:alt | Fixes #7076
The fix is pretty straightforward. I also add a comment about missing_names being per-module, not per namespace. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/mypy/pull/7136/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7136%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7136%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/7136/files |
| Reload | https://github.com/python/mypy/pull/7136/files |
| Reload | https://github.com/python/mypy/pull/7136/files |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:fix-attrs-crash-newan | https://github.com/ilevkivskyi/mypy/tree/fix-attrs-crash-newan |
|
Conversation
7
| https://github.com/python/mypy/pull/7136 |
|
Commits
3
| https://github.com/python/mypy/pull/7136/commits |
|
Checks
0
| https://github.com/python/mypy/pull/7136/checks |
|
Files changed
| https://github.com/python/mypy/pull/7136/files |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
|
New analyser: Fix crash in plugins when star import blocks adding a symbol
| https://github.com/python/mypy/pull/7136/files#top |
|
Show all changes
3 commits
| https://github.com/python/mypy/pull/7136/files |
|
471bf15
Fix crash in plugins when star import blocks adding a symbol
ilevkivskyi Jul 2, 2019
| https://github.com/python/mypy/pull/7136/commits/471bf152c52cb237a645c30f6d05c7e37fb6c8aa |
|
df44f72
Add a comment
ilevkivskyi Jul 2, 2019
| https://github.com/python/mypy/pull/7136/commits/df44f728d9a02cc112b71c7161495048678f6e72 |
|
696e407
Address CR
ilevkivskyi Jul 3, 2019
| https://github.com/python/mypy/pull/7136/commits/696e407e27d7d08f4b25304f6ded02b161dad0f3 |
|
Clear filters
| https://github.com/python/mypy/pull/7136/files |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
|
semanal.py
| https://github.com/python/mypy/pull/7136/files#diff-959498e321dbb00f11a2172112d9b9daa723b461fbdc9f0cc9b4ec7508c3b43d |
|
attrs.py
| https://github.com/python/mypy/pull/7136/files#diff-c06d82e1af489188cdaa58e70e6460a858e2d4a993281e440a0c581947d69d81 |
|
dataclasses.py
| https://github.com/python/mypy/pull/7136/files#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4 |
|
check-attr.test
| https://github.com/python/mypy/pull/7136/files#diff-0a3b87cb7639d25b0ecf82a84593a30120970e9db3a5fc209b5ab6f678f79786 |
|
check-dataclasses.test
| https://github.com/python/mypy/pull/7136/files#diff-5379cab042a82b77ec5dffbbe846636f62f6c7482d537a998b285f7629ea1888 |
| mypy/newsemanal/semanal.py | https://github.com/python/mypy/pull/7136/files#diff-959498e321dbb00f11a2172112d9b9daa723b461fbdc9f0cc9b4ec7508c3b43d |
|
View file
| https://github.com/ilevkivskyi/mypy/blob/696e407e27d7d08f4b25304f6ded02b161dad0f3/mypy/newsemanal/semanal.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/7136/{{ revealButtonHref }} |
|
| https://github.com/python/mypy/pull/7136/files#diff-959498e321dbb00f11a2172112d9b9daa723b461fbdc9f0cc9b4ec7508c3b43d |
| JukkaL | https://github.com/JukkaL |
| Jul 3, 2019 | https://github.com/python/mypy/pull/7136/files#r299874831 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jul 3, 2019 | https://github.com/python/mypy/pull/7136/files#r299943070 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
|
| https://github.com/python/mypy/pull/7136/files#diff-959498e321dbb00f11a2172112d9b9daa723b461fbdc9f0cc9b4ec7508c3b43d |
| mypy/plugins/attrs.py | https://github.com/python/mypy/pull/7136/files#diff-c06d82e1af489188cdaa58e70e6460a858e2d4a993281e440a0c581947d69d81 |
|
View file
| https://github.com/ilevkivskyi/mypy/blob/696e407e27d7d08f4b25304f6ded02b161dad0f3/mypy/plugins/attrs.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/7136/{{ revealButtonHref }} |
|
| https://github.com/python/mypy/pull/7136/files#diff-c06d82e1af489188cdaa58e70e6460a858e2d4a993281e440a0c581947d69d81 |
| JukkaL | https://github.com/JukkaL |
| Jul 3, 2019 | https://github.com/python/mypy/pull/7136/files#r299878195 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
|
| https://github.com/python/mypy/pull/7136/files#diff-c06d82e1af489188cdaa58e70e6460a858e2d4a993281e440a0c581947d69d81 |
| mypy/plugins/dataclasses.py | https://github.com/python/mypy/pull/7136/files#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4 |
|
View file
| https://github.com/ilevkivskyi/mypy/blob/696e407e27d7d08f4b25304f6ded02b161dad0f3/mypy/plugins/dataclasses.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/7136/{{ revealButtonHref }} |
|
| https://github.com/python/mypy/pull/7136/files#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4 |
|
| https://github.com/python/mypy/pull/7136/files#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4 |
| test-data/unit/check-attr.test | https://github.com/python/mypy/pull/7136/files#diff-0a3b87cb7639d25b0ecf82a84593a30120970e9db3a5fc209b5ab6f678f79786 |
|
View file
| https://github.com/ilevkivskyi/mypy/blob/696e407e27d7d08f4b25304f6ded02b161dad0f3/test-data/unit/check-attr.test |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/7136/{{ revealButtonHref }} |
|
| https://github.com/python/mypy/pull/7136/files#diff-0a3b87cb7639d25b0ecf82a84593a30120970e9db3a5fc209b5ab6f678f79786 |
| JukkaL | https://github.com/JukkaL |
| Jul 3, 2019 | https://github.com/python/mypy/pull/7136/files#r299876106 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
| test-data/unit/check-dataclasses.test | https://github.com/python/mypy/pull/7136/files#diff-5379cab042a82b77ec5dffbbe846636f62f6c7482d537a998b285f7629ea1888 |
|
View file
| https://github.com/ilevkivskyi/mypy/blob/696e407e27d7d08f4b25304f6ded02b161dad0f3/test-data/unit/check-dataclasses.test |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/7136/{{ revealButtonHref }} |
|
| https://github.com/python/mypy/pull/7136/files#diff-5379cab042a82b77ec5dffbbe846636f62f6c7482d537a998b285f7629ea1888 |
| JukkaL | https://github.com/JukkaL |
| Jul 3, 2019 | https://github.com/python/mypy/pull/7136/files#r299876500 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jul 3, 2019 | https://github.com/python/mypy/pull/7136/files#r299954685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #7141 | https://github.com/python/mypy/issues/7141 |
| Please reload this page | https://github.com/python/mypy/pull/7136/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |