| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:74698f2c-5a15-8940-e931-3b8d4f928cf8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D44:137B3:D18426:1101B81:6AFFF517 |
| html-safe-nonce | a1326bf72350d7a4703eda8cc58a82ae057d42689e0d2a32a561cae98cd196d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDQ0OjEzN0IzOkQxODQyNjoxMTAxQjgxOjZBRkZGNTE3IiwidmlzaXRvcl9pZCI6IjM5ODczNDcwODU2MjcyMjUzNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a6c4367224e43b1ce5fe562dca070ff6087a44cf5fd495e61020e8d563454912 |
| hovercard-subject-tag | pull_request:291034991 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/7050/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/42f569395ec49fa62264e659153fbf4dd502a82267589628c22d430c88d6e3b8/python/mypy/pull/7050 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/42f569395ec49fa62264e659153fbf4dd502a82267589628c22d430c88d6e3b8/python/mypy/pull/7050 |
| og:image:alt | This diff adds a --warn-unreachable flag that reports an error if:
Any statement is inferred to be unreachable
Any subexpression in boolean expressions, inline if statements, and list/set/generato... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Michael0x2a |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/7050#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7050 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7050 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/7050 |
| Reload | https://github.com/python/mypy/pull/7050 |
| Reload | https://github.com/python/mypy/pull/7050 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:unreachability-warnings | https://github.com/Michael0x2a/mypy/tree/unreachability-warnings |
| Conversation | https://github.com/python/mypy/pull/7050 |
| Commits7 (7) | https://github.com/python/mypy/pull/7050/commits |
| Checks | https://github.com/python/mypy/pull/7050/checks |
| Files changed | https://github.com/python/mypy/pull/7050/files |
| Add flag to warn about unreachable branches and exprs | https://github.com/python/mypy/pull/7050#top |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:unreachability-warnings | https://github.com/Michael0x2a/mypy/tree/unreachability-warnings |
|
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Jun 24, 2019 | https://github.com/python/mypy/pull/7050#issue-459769768 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| Fix reachability inference with 'isinstance(Any, Any)' #7048 | https://github.com/python/mypy/pull/7048 |
| #2395 | https://github.com/python/mypy/issues/2395 |
| #7008 | https://github.com/python/mypy/issues/7008 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
|
| https://github.com/Michael0x2a |
| Add flag to warn about unreachable branches and exprs | https://github.com/python/mypy/pull/7050/commits/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2 |
| a5b3737 | https://github.com/python/mypy/pull/7050/commits/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2 |
| python#7048 | https://github.com/python/mypy/pull/7048 |
| python#2395 | https://github.com/python/mypy/issues/2395 |
| python#7008 | https://github.com/python/mypy/issues/7008 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Jun 25, 2019
| https://github.com/python/mypy/pull/7050#pullrequestreview-254115700 |
|
View reviewed changes
| https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/7050#pullrequestreview-254115700 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| mypy/main.py | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-207f26497af1585033935dce5b1b9e3a12f9b98f28a8a8d7bf7bbb1ca88375ae |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| mypy/checker.py | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| mypy/messages.py | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| JukkaL | https://github.com/JukkaL |
| Jun 25, 2019 | https://github.com/python/mypy/pull/7050#discussion_r297280991 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| Michael0x2a | https://github.com/Michael0x2a |
| Jun 26, 2019 | https://github.com/python/mypy/pull/7050#discussion_r297746556 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| mypy/messages.py | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/7050/files/a5b37377fe8ad7274ed6f8ff0e61754b1e44a2a2#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| JukkaL | https://github.com/JukkaL |
| Jun 25, 2019 | https://github.com/python/mypy/pull/7050#discussion_r297281906 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| Michael0x2a | https://github.com/Michael0x2a |
| Jun 26, 2019 | https://github.com/python/mypy/pull/7050#discussion_r297745190 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| JukkaL | https://github.com/JukkaL |
| Jun 28, 2019 | https://github.com/python/mypy/pull/7050#discussion_r298572200 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| Michael0x2a | https://github.com/Michael0x2a |
| June 25, 2019 20:38 | https://github.com/python/mypy/pull/7050#commits-pushed-615f3b2 |
|
| https://github.com/Michael0x2a |
| Rename flag to '--warn-unreachable' | https://github.com/python/mypy/pull/7050/commits/615f3b2806f574c6a964dc603263eae10e29a0dd |
| 615f3b2 | https://github.com/python/mypy/pull/7050/commits/615f3b2806f574c6a964dc603263eae10e29a0dd |
|
| https://github.com/Michael0x2a |
| Apply trivial renames | https://github.com/python/mypy/pull/7050/commits/ce8c357cb042bc6a84a7aa810162d5e921981b02 |
| ce8c357 | https://github.com/python/mypy/pull/7050/commits/ce8c357cb042bc6a84a7aa810162d5e921981b02 |
|
| https://github.com/Michael0x2a |
| Rename functions; adjust code to handle TypeVars with value restrictions | https://github.com/python/mypy/pull/7050/commits/74663e8458e20c8a76444b77499e717dff993a7a |
| 74663e8 | https://github.com/python/mypy/pull/7050/commits/74663e8458e20c8a76444b77499e717dff993a7a |
|
| https://github.com/Michael0x2a |
| Adjust help text for flag | https://github.com/python/mypy/pull/7050/commits/d16dd8e62c402a6467f491586bc68488f3f7314c |
| d16dd8e | https://github.com/python/mypy/pull/7050/commits/d16dd8e62c402a6467f491586bc68488f3f7314c |
|
| https://github.com/Michael0x2a |
| Add suggested test cases for platform and version checks | https://github.com/python/mypy/pull/7050/commits/0ccb3671e1f46a3f60fa92df11b9d8543b10804d |
| 0ccb367 | https://github.com/python/mypy/pull/7050/commits/0ccb3671e1f46a3f60fa92df11b9d8543b10804d |
|
| https://github.com/Michael0x2a |
| Add test case for statement after return | https://github.com/python/mypy/pull/7050/commits/373c6eced4493f04916c4950382743fcf52062b6 |
| 373c6ec | https://github.com/python/mypy/pull/7050/commits/373c6eced4493f04916c4950382743fcf52062b6 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Jun 26, 2019 | https://github.com/python/mypy/pull/7050#issuecomment-505946024 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| https://github.com/bluetech |
| bluetech | https://github.com/bluetech |
| Jun 28, 2019 | https://github.com/python/mypy/pull/7050#issuecomment-506709743 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| typeshed bug | https://github.com/python/typeshed/pull/3093 |
| #5818 | https://github.com/python/mypy/issues/5818 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Jun 28, 2019
| https://github.com/python/mypy/pull/7050#pullrequestreview-255739397 |
|
View reviewed changes
| https://github.com/python/mypy/pull/7050/files/373c6eced4493f04916c4950382743fcf52062b6 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/7050#pullrequestreview-255739397 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| 8030804 | https://github.com/python/mypy/commit/8030804198eb690e3398d3ae718c1d074798449d |
| Jun 28, 2019 | https://github.com/python/mypy/pull/7050#event-2447161809 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 28, 2019 | https://github.com/python/mypy/pull/7050#issuecomment-506718863 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| June 28, 2019 14:33 | https://github.com/python/mypy/pull/7050#event-2447502512 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F7050 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/7050/files/373c6eced4493f04916c4950382743fcf52062b6 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
|
Warn about always true/false isinstance tests
| https://github.com/python/mypy/issues/2395 |
| Please reload this page | https://github.com/python/mypy/pull/7050 |
|
| https://github.com/Michael0x2a |
|
| https://github.com/bluetech |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |