René's URL Explorer Experiment


Title: Fix incorrect tracking of "final" Instances by Michael0x2a · Pull Request #6763 · python/mypy · GitHub

Open Graph Title: Fix incorrect tracking of "final" Instances by Michael0x2a · Pull Request #6763 · python/mypy

X Title: Fix incorrect tracking of "final" Instances by Michael0x2a · Pull Request #6763 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This diff makes three changes: it fixes a bug where we incorrectly track "final" Instances, does some related refactoring, and finally modifies tuple indexing to be aware of literal conte...

X Description: This diff makes three changes: it fixes a bug where we incorrectly track "final" Instances, does some related refactoring, and finally modifies tuple indexing to be aware of liter...

Opengraph URL: https://github.com/python/mypy/pull/6763

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57f2383b-afb1-db4b-64da-f3355b6497a6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8012:1EE55B:1F7ED04:2B1EE6C:6B00234D
html-safe-nonceee396ca929d6aa345991204625623c54d2b4b79016a9069e545aaf6ab15fff82
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDEyOjFFRTU1QjoxRjdFRDA0OjJCMUVFNkM6NkIwMDIzNEQiLCJ2aXNpdG9yX2lkIjoiNTU0MDkyMjAxMTY5MTI2Mjc5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac379678ab29412820fdc5f5b3564324f5a9da68f4f9e1250f01a2432eae8f3cde
hovercard-subject-tagpull_request:275950351
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/6763/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/165c6dcab3157214e8bde3a119d31d32ff9c648636f87a5b6f6a610042658dda/python/mypy/pull/6763
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/165c6dcab3157214e8bde3a119d31d32ff9c648636f87a5b6f6a610042658dda/python/mypy/pull/6763
og:image:altThis diff makes three changes: it fixes a bug where we incorrectly track "final" Instances, does some related refactoring, and finally modifies tuple indexing to be aware of literal conte...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/6763#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6763
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6763
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/6763
Reloadhttps://github.com/python/mypy/pull/6763
Reloadhttps://github.com/python/mypy/pull/6763
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:adjust-literal-metadata-semanticshttps://github.com/Michael0x2a/mypy/tree/adjust-literal-metadata-semantics
Conversationhttps://github.com/python/mypy/pull/6763
Commits3 (3)https://github.com/python/mypy/pull/6763/commits
Checkshttps://github.com/python/mypy/pull/6763/checks
Files changedhttps://github.com/python/mypy/pull/6763/files
Fix incorrect tracking of "final" Instanceshttps://github.com/python/mypy/pull/6763#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:adjust-literal-metadata-semanticshttps://github.com/Michael0x2a/mypy/tree/adjust-literal-metadata-semantics
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
May 4, 2019https://github.com/python/mypy/pull/6763#issue-440373462
Please reload this pagehttps://github.com/python/mypy/pull/6763
https://github.com/Michael0x2a
Refine how Literal and Final interacthttps://github.com/python/mypy/pull/6763/commits/07cc2e323b131f175bdb494a7ef1a718b0d6515f
07cc2e3https://github.com/python/mypy/pull/6763/commits/07cc2e323b131f175bdb494a7ef1a718b0d6515f
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 7, 2019 https://github.com/python/mypy/pull/6763#pullrequestreview-234281166
View reviewed changes https://github.com/python/mypy/pull/6763/files/07cc2e323b131f175bdb494a7ef1a718b0d6515f
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/6763#pullrequestreview-234281166
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6763
Michael0x2ahttps://github.com/Michael0x2a
May 7, 2019 06:42https://github.com/python/mypy/pull/6763#commits-pushed-aa255d6
https://github.com/Michael0x2a
Rename 'final_value' field to 'last_known_value'https://github.com/python/mypy/pull/6763/commits/aa255d67712e8e01f13b96cf42daed4628d5276f
aa255d6https://github.com/python/mypy/pull/6763/commits/aa255d67712e8e01f13b96cf42daed4628d5276f
https://github.com/Michael0x2a
Adjust one existing testhttps://github.com/python/mypy/pull/6763/commits/8b5e8c64e9757c79f2119d673b6705da3e70245f
8b5e8c6https://github.com/python/mypy/pull/6763/commits/8b5e8c64e9757c79f2119d673b6705da3e70245f
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
May 7, 2019https://github.com/python/mypy/pull/6763#issuecomment-490094964
@ilevkivskyihttps://github.com/ilevkivskyi
testLiteralFinalPropagatesThroughGenericshttps://github.com/python/mypy/blob/master/test-data/unit/check-literal.test#L2570
Please reload this pagehttps://github.com/python/mypy/pull/6763
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 7, 2019https://github.com/python/mypy/pull/6763#issuecomment-490105297
Please reload this pagehttps://github.com/python/mypy/pull/6763
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 7, 2019 https://github.com/python/mypy/pull/6763#pullrequestreview-234556743
View reviewed changes https://github.com/python/mypy/pull/6763/files/8b5e8c64e9757c79f2119d673b6705da3e70245f
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
28815f1https://github.com/python/mypy/commit/28815f181692d795ee6d12d6c098ce0ad27a94a0
May 7, 2019https://github.com/python/mypy/pull/6763#event-2324429403
Michael0x2ahttps://github.com/Michael0x2a
May 7, 2019 https://github.com/python/mypy/pull/6763#ref-commit-96cfd90
https://github.com/Michael0x2a
Clean up last traces of 'final_value' fieldhttps://github.com/Michael0x2a/mypy/commit/96cfd90b6667000f118569f27a4db7c4dd966384
96cfd90https://github.com/Michael0x2a/mypy/commit/96cfd90b6667000f118569f27a4db7c4dd966384
python#6763https://github.com/python/mypy/pull/6763
python#5522https://github.com/python/mypy/pull/5522
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
May 7, 2019 https://github.com/python/mypy/pull/6763#ref-pullrequest-441316542
Clean up last traces of 'final_value' field #6791 https://github.com/python/mypy/pull/6791
ilevkivskyihttps://github.com/ilevkivskyi
May 8, 2019 https://github.com/python/mypy/pull/6763#ref-commit-285b683
https://github.com/Michael0x2a
https://github.com/ilevkivskyi
Clean up last traces of 'final_value' field (https://github.com/python/mypy/commit/285b683bc8e616bee2a2c175e3e7995d521f5190
#6791https://github.com/python/mypy/pull/6791
)https://github.com/python/mypy/commit/285b683bc8e616bee2a2c175e3e7995d521f5190
285b683https://github.com/python/mypy/commit/285b683bc8e616bee2a2c175e3e7995d521f5190
#6763https://github.com/python/mypy/pull/6763
#5522https://github.com/python/mypy/pull/5522
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6763
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/6763/files/8b5e8c64e9757c79f2119d673b6705da3e70245f
Please reload this pagehttps://github.com/python/mypy/pull/6763
Please reload this pagehttps://github.com/python/mypy/pull/6763
https://github.com/Michael0x2a
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.