René's URL Explorer Experiment


Title: Fix class/def line reporting and ignoring for 3.8+. by brandtbucher · Pull Request #6753 · python/mypy · GitHub

Open Graph Title: Fix class/def line reporting and ignoring for 3.8+. by brandtbucher · Pull Request #6753 · python/mypy

X Title: Fix class/def line reporting and ignoring for 3.8+. by brandtbucher · Pull Request #6753 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #3871. This change fixes a few things concerning class/function definition line numbers. For users running mypy with Python 3.8+: Function definitions are now reported on the correct line, r...

X Description: Fixes #3871. This change fixes a few things concerning class/function definition line numbers. For users running mypy with Python 3.8+: Function definitions are now reported on the correct line, r...

Opengraph URL: https://github.com/python/mypy/pull/6753

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c6e46927-8c64-c751-31f5-920fa695fb33
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8B4:37F8D9:1B69D56:25B6E48:6A573855
html-safe-noncef2724e3dcce872c6e967892e9155bbcee01495d442cd5d4c7aafa9af192b6b5e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEI0OjM3RjhEOToxQjY5RDU2OjI1QjZFNDg6NkE1NzM4NTUiLCJ2aXNpdG9yX2lkIjoiNzI1OTc3NDgzODQzNjczOTE1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2db047d4a9d6d7e9a88e2b60035c98824c49fa5f63a9ef72d37456cc99fa12ef
hovercard-subject-tagpull_request:275166981
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/6753/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4e7709753a1aff07ef13f00ea3f7ad8bceea532f5594b81650ab544ad75067bb/python/mypy/pull/6753
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4e7709753a1aff07ef13f00ea3f7ad8bceea532f5594b81650ab544ad75067bb/python/mypy/pull/6753
og:image:altFixes #3871. This change fixes a few things concerning class/function definition line numbers. For users running mypy with Python 3.8+: Function definitions are now reported on the correct line, r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrandtbucher
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2576d1f0198cf1588faf2edf27f1ed120903be10
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/6753#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6753
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6753
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/6753
Reloadhttps://github.com/python/mypy/pull/6753
Reloadhttps://github.com/python/mypy/pull/6753
Please reload this pagehttps://github.com/python/mypy/pull/6753
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/6753
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.2k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 464 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
Conversationhttps://github.com/python/mypy/pull/6753
Commits4 (4)https://github.com/python/mypy/pull/6753/commits
Checkshttps://github.com/python/mypy/pull/6753/checks
Files changedhttps://github.com/python/mypy/pull/6753/files
Fix class/def line reporting and ignoring for 3.8+.https://github.com/python/mypy/pull/6753#top
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 1, 2019https://github.com/python/mypy/pull/6753#issue-439338818
Please reload this pagehttps://github.com/python/mypy/pull/6753
#3871https://github.com/python/mypy/issues/3871
Expression-scoped ignores in Python 3.8. #6648https://github.com/python/mypy/pull/6648
Function line number information is not always correct #3871https://github.com/python/mypy/issues/3871
doesn't appearhttps://github.com/python/mypy/pull/6539#discussion_r265376127
Please reload this pagehttps://github.com/python/mypy/pull/6753
brandtbucherhttps://github.com/brandtbucher
May 1, 2019 14:29https://github.com/python/mypy/pull/6753#commits-pushed-974d5ae
https://github.com/brandtbucher
Fix class/def line reporting and ignoring for 3.8.https://github.com/python/mypy/pull/6753/commits/974d5aec75ee64505da9721410f8254c137d5924
974d5aehttps://github.com/python/mypy/pull/6753/commits/974d5aec75ee64505da9721410f8254c137d5924
https://github.com/brandtbucher
Avoid unnecessary line swaps and update a comment.https://github.com/python/mypy/pull/6753/commits/0cebf4b3baeb2c3e3beaa8aadfc5fa26ec301207
0cebf4bhttps://github.com/python/mypy/pull/6753/commits/0cebf4b3baeb2c3e3beaa8aadfc5fa26ec301207
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 6, 2019https://github.com/python/mypy/pull/6753#issuecomment-489737620
Please reload this pagehttps://github.com/python/mypy/pull/6753
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 6, 2019https://github.com/python/mypy/pull/6753#issuecomment-489739855
Please reload this pagehttps://github.com/python/mypy/pull/6753
https://github.com/brandtbucher
Merge branch 'master' into def-lineshttps://github.com/python/mypy/pull/6753/commits/516f7281dfad500e3fac4b29392baf2b4f6c3eb7
516f728https://github.com/python/mypy/pull/6753/commits/516f7281dfad500e3fac4b29392baf2b4f6c3eb7
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 6, 2019https://github.com/python/mypy/pull/6753#issuecomment-489757690
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/6753
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 6, 2019 https://github.com/python/mypy/pull/6753#pullrequestreview-234216150
View reviewed changes https://github.com/python/mypy/pull/6753/files/516f7281dfad500e3fac4b29392baf2b4f6c3eb7
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/6753#pullrequestreview-234216150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
mypy/fastparse.pyhttps://github.com/python/mypy/pull/6753/files/516f7281dfad500e3fac4b29392baf2b4f6c3eb7#diff-a7d2c40f4be6322cee498432ca9dbbc3a356c3cbcb61029231452f6638bb11b5
gvanrossumhttps://github.com/gvanrossum
May 6, 2019https://github.com/python/mypy/pull/6753#discussion_r281374317
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
gvanrossumhttps://github.com/gvanrossum
May 6, 2019https://github.com/python/mypy/pull/6753#discussion_r281392122
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
brandtbucherhttps://github.com/brandtbucher
May 6, 2019https://github.com/python/mypy/pull/6753#discussion_r281392257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
gvanrossumhttps://github.com/gvanrossum
May 6, 2019https://github.com/python/mypy/pull/6753#discussion_r281392607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
mypy/fastparse.pyhttps://github.com/python/mypy/pull/6753/files/516f7281dfad500e3fac4b29392baf2b4f6c3eb7#diff-a7d2c40f4be6322cee498432ca9dbbc3a356c3cbcb61029231452f6638bb11b5
gvanrossumhttps://github.com/gvanrossum
May 6, 2019https://github.com/python/mypy/pull/6753#discussion_r281374633
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
brandtbucherhttps://github.com/brandtbucher
May 6, 2019https://github.com/python/mypy/pull/6753#discussion_r281386643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
mypy/fastparse.pyhttps://github.com/python/mypy/pull/6753/files/516f7281dfad500e3fac4b29392baf2b4f6c3eb7#diff-a7d2c40f4be6322cee498432ca9dbbc3a356c3cbcb61029231452f6638bb11b5
gvanrossumhttps://github.com/gvanrossum
May 6, 2019https://github.com/python/mypy/pull/6753#discussion_r281375129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
brandtbucherhttps://github.com/brandtbucher
May 6, 2019https://github.com/python/mypy/pull/6753#discussion_r281392437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6753
test-data/unit/check-attr.testhttps://github.com/python/mypy/pull/6753/files/516f7281dfad500e3fac4b29392baf2b4f6c3eb7#diff-0a3b87cb7639d25b0ecf82a84593a30120970e9db3a5fc209b5ab6f678f79786
Please reload this pagehttps://github.com/python/mypy/pull/6753
https://github.com/brandtbucher
Code cleanup from GvR's first review.https://github.com/python/mypy/pull/6753/commits/7846effe4270136b987752bf95b9987fc182032f
7846effhttps://github.com/python/mypy/pull/6753/commits/7846effe4270136b987752bf95b9987fc182032f
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 6, 2019https://github.com/python/mypy/pull/6753#issuecomment-489819607
Please reload this pagehttps://github.com/python/mypy/pull/6753
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
2f99e09https://github.com/python/mypy/commit/2f99e09dadcddf794d7c36019e8e988b732ef190
May 7, 2019https://github.com/python/mypy/pull/6753#event-2322678313
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 7, 2019https://github.com/python/mypy/pull/6753#issuecomment-489867915
Please reload this pagehttps://github.com/python/mypy/pull/6753
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 7, 2019https://github.com/python/mypy/pull/6753#issuecomment-489868225
Please reload this pagehttps://github.com/python/mypy/pull/6753
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 7, 2019 01:16https://github.com/python/mypy/pull/6753#event-2322683153
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Aug 22, 2019 https://github.com/python/mypy/pull/6753#ref-issue-484117924
Python Triage Team Application: Brandt Bucher python/core-workflow#356 https://github.com/python/core-workflow/issues/356
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 3, 2022 https://github.com/python/mypy/pull/6753#ref-issue-252702240
Missing annotation in function passed in a click decorator #3869 https://github.com/python/mypy/issues/3869
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6753
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/6753/files/516f7281dfad500e3fac4b29392baf2b4f6c3eb7
Function line number information is not always correct https://github.com/python/mypy/issues/3871
Please reload this pagehttps://github.com/python/mypy/pull/6753
https://github.com/brandtbucher
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.