René's URL Explorer Experiment


Title: Fix interaction of isinstance() with Type[...] by ilevkivskyi · Pull Request #6419 · python/mypy · GitHub

Open Graph Title: Fix interaction of isinstance() with Type[...] by ilevkivskyi · Pull Request #6419 · python/mypy

X Title: Fix interaction of isinstance() with Type[...] by ilevkivskyi · Pull Request #6419 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #4616 Fixes #6416 Fixes #6386 Currently Type[C] is considered a subtype of metaclass of C, and I think this is right. The idea is to fix ProperSubtypeVisitor.visit_type_type() to match Subtyp...

X Description: Fixes #4616 Fixes #6416 Fixes #6386 Currently Type[C] is considered a subtype of metaclass of C, and I think this is right. The idea is to fix ProperSubtypeVisitor.visit_type_type() to match Subtyp...

Opengraph URL: https://github.com/python/mypy/pull/6419

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4f48081c-5498-4c55-d51d-5186616bbeae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8676:D33AC:683B06:8BA29B:6B0036B7
html-safe-noncec4d29b3dd1d2934c0920d7067340a6e9352e715b1d8d94847fa239269f2cc0a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Njc2OkQzM0FDOjY4M0IwNjo4QkEyOUI6NkIwMDM2QjciLCJ2aXNpdG9yX2lkIjoiNDQyNTAyMTI2NTQ1NTEwMTYyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb7c570b210ea66dc41ae4423857b171b74a80e5fd2349876dc035834d8e4c8a5
hovercard-subject-tagpull_request:253708961
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/6419/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6101b0748d0ea6c40b98ebd2d9ab271869727cd2a317c641e34d03aa0c902666/python/mypy/pull/6419
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6101b0748d0ea6c40b98ebd2d9ab271869727cd2a317c641e34d03aa0c902666/python/mypy/pull/6419
og:image:altFixes #4616 Fixes #6416 Fixes #6386 Currently Type[C] is considered a subtype of metaclass of C, and I think this is right. The idea is to fix ProperSubtypeVisitor.visit_type_type() to match Subtyp...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/6419#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6419
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6419
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/6419
Reloadhttps://github.com/python/mypy/pull/6419
Reloadhttps://github.com/python/mypy/pull/6419
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-type-meta-properhttps://github.com/ilevkivskyi/mypy/tree/fix-type-meta-proper
Conversationhttps://github.com/python/mypy/pull/6419
Commits6 (6)https://github.com/python/mypy/pull/6419/commits
Checkshttps://github.com/python/mypy/pull/6419/checks
Files changedhttps://github.com/python/mypy/pull/6419/files
Fix interaction of isinstance() with Type[...]https://github.com/python/mypy/pull/6419#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-type-meta-properhttps://github.com/ilevkivskyi/mypy/tree/fix-type-meta-proper
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2019https://github.com/python/mypy/pull/6419#issue-411183791
#4616https://github.com/python/mypy/issues/4616
#6416https://github.com/python/mypy/issues/6416
#6386https://github.com/python/mypy/issues/6386
Please reload this pagehttps://github.com/python/mypy/pull/6419
https://github.com/ilevkivskyi
Fix interaction of isinstance() with Type[...]https://github.com/python/mypy/pull/6419/commits/3249acc5b0cff344b0aac094ca3ec2867df27cb2
3249acchttps://github.com/python/mypy/pull/6419/commits/3249acc5b0cff344b0aac094ca3ec2867df27cb2
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
msullivanhttps://github.com/msullivan
February 17, 2019 12:45https://github.com/python/mypy/pull/6419#event-2144669723
https://github.com/ilevkivskyi
Fix commentshttps://github.com/python/mypy/pull/6419/commits/b51d5c4f7835f8df5da75be1c85e28430684c43f
b51d5c4https://github.com/python/mypy/pull/6419/commits/b51d5c4f7835f8df5da75be1c85e28430684c43f
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Feb 20, 2019 https://github.com/python/mypy/pull/6419#pullrequestreview-205973356
View reviewed changes https://github.com/python/mypy/pull/6419/files/b51d5c4f7835f8df5da75be1c85e28430684c43f
msullivanhttps://github.com/msullivan
https://github.com/python/mypy/pull/6419#pullrequestreview-205973356
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6419
February 21, 2019 17:51https://github.com/python/mypy/pull/6419#commits-pushed-1755f68
Fix some issueshttps://github.com/python/mypy/pull/6419/commits/1755f680946669cb757b5c9948209a25a181dc09
1755f68https://github.com/python/mypy/pull/6419/commits/1755f680946669cb757b5c9948209a25a181dc09
Merge remote-tracking branch 'upstream/master' into fix-type-meta-properhttps://github.com/python/mypy/pull/6419/commits/4c06d80db07cc9e9fdcb86b1092035288577dc4b
4c06d80https://github.com/python/mypy/pull/6419/commits/4c06d80db07cc9e9fdcb86b1092035288577dc4b
Fix meet and make it symmetrichttps://github.com/python/mypy/pull/6419/commits/2243722611288446280884e4b17de1457c68f87e
2243722https://github.com/python/mypy/pull/6419/commits/2243722611288446280884e4b17de1457c68f87e
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Feb 22, 2019 https://github.com/python/mypy/pull/6419#pullrequestreview-207036546
View reviewed changes https://github.com/python/mypy/pull/6419/files/2243722611288446280884e4b17de1457c68f87e
msullivanhttps://github.com/msullivan
https://github.com/python/mypy/pull/6419#pullrequestreview-207036546
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6419
mypy/subtypes.pyhttps://github.com/python/mypy/pull/6419/files/2243722611288446280884e4b17de1457c68f87e#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
msullivanhttps://github.com/msullivan
Feb 22, 2019https://github.com/python/mypy/pull/6419#discussion_r259517557
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6419
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2019https://github.com/python/mypy/pull/6419#issuecomment-466597830
Please reload this pagehttps://github.com/python/mypy/pull/6419
https://github.com/ilevkivskyi
Remove obsolete commenthttps://github.com/python/mypy/pull/6419/commits/a79fc87d050605d3baaf84e01ced05e63cd69c81
a79fc87https://github.com/python/mypy/pull/6419/commits/a79fc87d050605d3baaf84e01ced05e63cd69c81
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
ed0dcadhttps://github.com/python/mypy/commit/ed0dcad2adaf556085c7f692567f90f7b5ba8460
Feb 23, 2019https://github.com/python/mypy/pull/6419#event-2159324654
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
February 23, 2019 01:33https://github.com/python/mypy/pull/6419#event-2159324688
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6419
https://github.com/msullivan
msullivan https://github.com/msullivan
https://github.com/python/mypy/pull/6419/files/2243722611288446280884e4b17de1457c68f87e
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/6419
Inconsistency in metaclass/Type interaction https://github.com/python/mypy/issues/6416
Inheritance broken when testing isinstance? https://github.com/python/mypy/issues/6386
Binder doesn't work well with Type[...] https://github.com/python/mypy/issues/4616
Please reload this pagehttps://github.com/python/mypy/pull/6419
https://github.com/ilevkivskyi
https://github.com/msullivan
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.