René's URL Explorer Experiment


Title: Add star imported modules as dependencies by ilevkivskyi · Pull Request #6179 · python/mypy · GitHub

Open Graph Title: Add star imported modules as dependencies by ilevkivskyi · Pull Request #6179 · python/mypy

X Title: Add star imported modules as dependencies by ilevkivskyi · Pull Request #6179 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #6110 I tried few approaches, and this one seems the most clean to me. Essentially, we just add some more imports (dependencies) after the second pass, where the star imports are resolved.

X Description: Fixes #6110 I tried few approaches, and this one seems the most clean to me. Essentially, we just add some more imports (dependencies) after the second pass, where the star imports are resolved.

Opengraph URL: https://github.com/python/mypy/pull/6179

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8c71f522-8a54-dae7-2df1-9a0d2199ef23
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC46:115983:37720:4C572:6B001A15
html-safe-nonceb9b93bef2fb0a6239d0bddcbb6f3d7c610d1a3f2c2124bf4c9056fbd55a8955a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzQ2OjExNTk4MzozNzcyMDo0QzU3Mjo2QjAwMUExNSIsInZpc2l0b3JfaWQiOiI2NTI3MTM2NzkxNjU1MzU2OTQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac744dce80ecfd14929ef9faedcd3abe7c201de66b864fc46c56cfdb5447e606e0
hovercard-subject-tagpull_request:243790281
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/6179/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ea0742bfbdf04dc3dc29972ab894c870e09802a68be32ba9bd32c96a61208c74/python/mypy/pull/6179
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ea0742bfbdf04dc3dc29972ab894c870e09802a68be32ba9bd32c96a61208c74/python/mypy/pull/6179
og:image:altFixes #6110 I tried few approaches, and this one seems the most clean to me. Essentially, we just add some more imports (dependencies) after the second pass, where the star imports are resolved.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
Nonea2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release70121d4e855ee0bb7b75cf15d061d91f8863c0f8
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/6179#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6179
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6179
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/6179
Reloadhttps://github.com/python/mypy/pull/6179
Reloadhttps://github.com/python/mypy/pull/6179
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
msullivanhttps://github.com/msullivan
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-star-import-crashhttps://github.com/ilevkivskyi/mypy/tree/fix-star-import-crash
Conversationhttps://github.com/python/mypy/pull/6179
Commits2 (2)https://github.com/python/mypy/pull/6179/commits
Checkshttps://github.com/python/mypy/pull/6179/checks
Files changedhttps://github.com/python/mypy/pull/6179/files
Add star imported modules as dependencieshttps://github.com/python/mypy/pull/6179#top
msullivanhttps://github.com/msullivan
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-star-import-crashhttps://github.com/ilevkivskyi/mypy/tree/fix-star-import-crash
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 10, 2019https://github.com/python/mypy/pull/6179#issue-397962955
#6110https://github.com/python/mypy/issues/6110
Please reload this pagehttps://github.com/python/mypy/pull/6179
Add star imported modules as dependencieshttps://github.com/python/mypy/pull/6179/commits/f8139355bfafe9f3724f63b28d8fdb64bd6f308e
f813935https://github.com/python/mypy/pull/6179/commits/f8139355bfafe9f3724f63b28d8fdb64bd6f308e
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
gvanrossumhttps://github.com/gvanrossum
msullivanhttps://github.com/msullivan
January 10, 2019 18:42https://github.com/python/mypy/pull/6179#event-2066673095
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 10, 2019https://github.com/python/mypy/pull/6179#issuecomment-453207251
Please reload this pagehttps://github.com/python/mypy/pull/6179
Fix linthttps://github.com/python/mypy/pull/6179/commits/571066622d7d78a13ad8e9da1b7877eb7679cb5f
5710666https://github.com/python/mypy/pull/6179/commits/571066622d7d78a13ad8e9da1b7877eb7679cb5f
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 11, 2019 https://github.com/python/mypy/pull/6179#pullrequestreview-191498346
View reviewed changes https://github.com/python/mypy/pull/6179/files/571066622d7d78a13ad8e9da1b7877eb7679cb5f
msullivanhttps://github.com/msullivan
https://github.com/python/mypy/pull/6179#pullrequestreview-191498346
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6179
https://github.com/msullivan
msullivanhttps://github.com/msullivan
e6f111ahttps://github.com/python/mypy/commit/e6f111a004de6b526e85b6616ef77b511d1aa69a
Jan 11, 2019https://github.com/python/mypy/pull/6179#event-2067500850
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
January 11, 2019 08:37https://github.com/python/mypy/pull/6179#event-2067938553
Fix incremental issue with namespace packages (option 1) #18907 https://github.com/python/mypy/pull/18907
Fix incremental issue with namespace packages (option 2) #18908 https://github.com/python/mypy/pull/18908
hauntsaninjahttps://github.com/hauntsaninja
Apr 11, 2025 https://github.com/python/mypy/pull/6179#ref-commit-54975a0
https://github.com/hauntsaninja
Fix incremental issue with namespace packages (option 1) (https://github.com/python/mypy/commit/54975a008f229941c29b4df5ecd755d4f5166d71
#18907https://github.com/python/mypy/pull/18907
)https://github.com/python/mypy/commit/54975a008f229941c29b4df5ecd755d4f5166d71
54975a0https://github.com/python/mypy/commit/54975a008f229941c29b4df5ecd755d4f5166d71
#12664https://github.com/python/mypy/issues/12664
#13124https://github.com/python/mypy/pull/13124
#10937https://github.com/python/mypy/pull/10937
#18908https://github.com/python/mypy/pull/18908
#6582https://github.com/python/mypy/pull/6582
#6179https://github.com/python/mypy/pull/6179
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6179
https://github.com/msullivan
msullivan https://github.com/msullivan
https://github.com/python/mypy/pull/6179/files/571066622d7d78a13ad8e9da1b7877eb7679cb5f
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/6179
Crash with star imports and new file in the build https://github.com/python/mypy/issues/6110
Please reload this pagehttps://github.com/python/mypy/pull/6179
https://github.com/ilevkivskyi
https://github.com/msullivan
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.