René's URL Explorer Experiment


Title: Disable promotions when restricting types in isinstance checks by msullivan · Pull Request #6142 · python/mypy · GitHub

Open Graph Title: Disable promotions when restricting types in isinstance checks by msullivan · Pull Request #6142 · python/mypy

X Title: Disable promotions when restricting types in isinstance checks by msullivan · Pull Request #6142 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This fixes a bug left behind by #6114, where too much would get subtracted out of a union type after an isinstance. Fixes #6141.

X Description: This fixes a bug left behind by #6114, where too much would get subtracted out of a union type after an isinstance. Fixes #6141.

Opengraph URL: https://github.com/python/mypy/pull/6142

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3943dd07-8c0b-7c7d-745f-d01844b96e21
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBB2:3EE843:2386C5C:307ACB2:6B0035A7
html-safe-nonce25744a1e36509ea03cbddcb470bed5de29a2226eebd5dc625f318210276fcac6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkIyOjNFRTg0MzoyMzg2QzVDOjMwN0FDQjI6NkIwMDM1QTciLCJ2aXNpdG9yX2lkIjoiMjIyNTUyODcyMDMwMTUwMzkxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3a61d832ecea511945a13a1c083412821c69fbdb37ba93771be76241c3456686
hovercard-subject-tagpull_request:242383508
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/6142/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/62bb81ee693a86614890a79041d19af5a10ed91a705d471f41c835bb19219074/python/mypy/pull/6142
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/62bb81ee693a86614890a79041d19af5a10ed91a705d471f41c835bb19219074/python/mypy/pull/6142
og:image:altThis fixes a bug left behind by #6114, where too much would get subtracted out of a union type after an isinstance. Fixes #6141.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsullivan
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/6142#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6142
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6142
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/6142
Reloadhttps://github.com/python/mypy/pull/6142
Reloadhttps://github.com/python/mypy/pull/6142
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
msullivanhttps://github.com/msullivan
masterhttps://github.com/python/mypy/tree/master
promotionshttps://github.com/python/mypy/tree/promotions
Conversationhttps://github.com/python/mypy/pull/6142
Commits1 (1)https://github.com/python/mypy/pull/6142/commits
Checkshttps://github.com/python/mypy/pull/6142/checks
Files changedhttps://github.com/python/mypy/pull/6142/files
Disable promotions when restricting types in isinstance checkshttps://github.com/python/mypy/pull/6142#top
msullivanhttps://github.com/msullivan
masterhttps://github.com/python/mypy/tree/master
promotionshttps://github.com/python/mypy/tree/promotions
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 4, 2019https://github.com/python/mypy/pull/6142#issue-396081506
#6114https://github.com/python/mypy/pull/6114
#6141https://github.com/python/mypy/issues/6141
Please reload this pagehttps://github.com/python/mypy/pull/6142
https://github.com/msullivan
Disable promotions when restricting types in isinstance checkshttps://github.com/python/mypy/pull/6142/commits/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
79f14b0https://github.com/python/mypy/pull/6142/commits/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
#6114https://github.com/python/mypy/pull/6114
#6141https://github.com/python/mypy/issues/6141
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Michael0x2ahttps://github.com/Michael0x2a
January 4, 2019 21:58https://github.com/python/mypy/pull/6142#event-2055450093
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 4, 2019 https://github.com/python/mypy/pull/6142#pullrequestreview-189544097
View reviewed changes https://github.com/python/mypy/pull/6142/files/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/6142#pullrequestreview-189544097
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6142
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jan 4, 2019 https://github.com/python/mypy/pull/6142#pullrequestreview-189544310
View reviewed changes https://github.com/python/mypy/pull/6142/files/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
Michael0x2ahttps://github.com/Michael0x2a
https://github.com/python/mypy/pull/6142#pullrequestreview-189544310
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6142
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 4, 2019https://github.com/python/mypy/pull/6142#issuecomment-451584677
Please reload this pagehttps://github.com/python/mypy/pull/6142
https://github.com/msullivan
msullivanhttps://github.com/msullivan
103f5f3https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9
Jan 4, 2019https://github.com/python/mypy/pull/6142#event-2055477339
https://github.com/msullivan
msullivanhttps://github.com/msullivan
January 4, 2019 22:16https://github.com/python/mypy/pull/6142#event-2055477421
Michael0x2ahttps://github.com/Michael0x2a
Jan 11, 2019 https://github.com/python/mypy/pull/6142#ref-commit-ab7f641
https://github.com/Michael0x2a
Re-enable promtions in isinstance checkshttps://github.com/Michael0x2a/mypy/commit/ab7f6412bf958d924128d41f8f2a2290bfcd9555
ab7f641https://github.com/Michael0x2a/mypy/commit/ab7f6412bf958d924128d41f8f2a2290bfcd9555
python#6114https://github.com/python/mypy/pull/6114
python#6142https://github.com/python/mypy/pull/6142
python#6180https://github.com/python/mypy/issues/6180
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jan 11, 2019 https://github.com/python/mypy/pull/6142#ref-pullrequest-398096383
Re-enable promotions in isinstance checks #6181 https://github.com/python/mypy/pull/6181
Michael0x2ahttps://github.com/Michael0x2a
Jan 11, 2019 https://github.com/python/mypy/pull/6142#ref-commit-401a4e0
https://github.com/Michael0x2a
Re-enable promotions in isinstance checks (https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534
#6181https://github.com/python/mypy/pull/6181
)https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534
401a4e0https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534
#6114https://github.com/python/mypy/pull/6114
#6142https://github.com/python/mypy/pull/6142
#6180https://github.com/python/mypy/issues/6180
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6142
https://github.com/Michael0x2a
Michael0x2a https://github.com/Michael0x2a
https://github.com/python/mypy/pull/6142/files/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/6142/files/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
Please reload this pagehttps://github.com/python/mypy/pull/6142
Else block of isinstance check with promotable types has for type https://github.com/python/mypy/issues/6141
Please reload this pagehttps://github.com/python/mypy/pull/6142
https://github.com/msullivan
https://github.com/Michael0x2a
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.