René's URL Explorer Experiment


Title: Disable promotions in isinstance checks by Michael0x2a · Pull Request #6114 · python/mypy · GitHub

Open Graph Title: Disable promotions in isinstance checks by Michael0x2a · Pull Request #6114 · python/mypy

X Title: Disable promotions in isinstance checks by Michael0x2a · Pull Request #6114 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This pull request resolves #6060 by modifying conditional_type_map function in checker.py to ignore promotions.

X Description: This pull request resolves #6060 by modifying conditional_type_map function in checker.py to ignore promotions.

Opengraph URL: https://github.com/python/mypy/pull/6114

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cfed5436-1c44-5ec7-9168-2df347558163
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD450:3F7946:24C3BB2:3226BA7:6B0038D8
html-safe-nonce77fda26d67a85240edcdc14053a72a03d32e51df70130f5429e411e0c9190518
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDUwOjNGNzk0NjoyNEMzQkIyOjMyMjZCQTc6NkIwMDM4RDgiLCJ2aXNpdG9yX2lkIjoiMTQwNDY0MjM0MTI1NTM5NTU0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7494b25f3ff4aeb992d9db189e2ed9e815c61e117559b90b613e3774bb9c3240
hovercard-subject-tagpull_request:241415920
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/6114/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/448f6d6c1e64335132441edced20d1512096abb254ff340c68a6771c968049e0/python/mypy/pull/6114
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/448f6d6c1e64335132441edced20d1512096abb254ff340c68a6771c968049e0/python/mypy/pull/6114
og:image:altThis pull request resolves #6060 by modifying conditional_type_map function in checker.py to ignore promotions.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/6114#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6114
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6114
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/6114
Reloadhttps://github.com/python/mypy/pull/6114
Reloadhttps://github.com/python/mypy/pull/6114
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:disable-promotions-in-isinstance-checkshttps://github.com/Michael0x2a/mypy/tree/disable-promotions-in-isinstance-checks
Conversationhttps://github.com/python/mypy/pull/6114
Commits1 (1)https://github.com/python/mypy/pull/6114/commits
Checkshttps://github.com/python/mypy/pull/6114/checks
Files changedhttps://github.com/python/mypy/pull/6114/files
Disable promotions in isinstance checkshttps://github.com/python/mypy/pull/6114#top
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:disable-promotions-in-isinstance-checkshttps://github.com/Michael0x2a/mypy/tree/disable-promotions-in-isinstance-checks
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Dec 29, 2018https://github.com/python/mypy/pull/6114#issue-394746853
#6060https://github.com/python/mypy/issues/6060
Please reload this pagehttps://github.com/python/mypy/pull/6114
https://github.com/Michael0x2a
Disable promotions in isinstance checkshttps://github.com/python/mypy/pull/6114/commits/f7069cacaa55bf7163e4cb32e02c861a3bc30d26
f7069cahttps://github.com/python/mypy/pull/6114/commits/f7069cacaa55bf7163e4cb32e02c861a3bc30d26
python#6060https://github.com/python/mypy/issues/6060
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Dec 29, 2018https://github.com/python/mypy/pull/6114#issuecomment-450451294
Please reload this pagehttps://github.com/python/mypy/pull/6114
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Dec 30, 2018 https://github.com/python/mypy/pull/6114#pullrequestreview-188438950
View reviewed changes https://github.com/python/mypy/pull/6114/files/f7069cacaa55bf7163e4cb32e02c861a3bc30d26
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/6114#pullrequestreview-188438950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/6114
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
51e34fahttps://github.com/python/mypy/commit/51e34fa4e99de909940390c36120bd3bad24f142
Dec 31, 2018https://github.com/python/mypy/pull/6114#event-2048701103
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
December 31, 2018 06:21https://github.com/python/mypy/pull/6114#event-2048701143
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 4, 2019 https://github.com/python/mypy/pull/6114#ref-issue-396078940
Else block of isinstance check with promotable types has for type #6141 https://github.com/python/mypy/issues/6141
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 4, 2019https://github.com/python/mypy/pull/6114#issuecomment-451578421
#6141https://github.com/python/mypy/issues/6141
Please reload this pagehttps://github.com/python/mypy/pull/6114
msullivanhttps://github.com/msullivan
Jan 4, 2019 https://github.com/python/mypy/pull/6114#ref-commit-79f14b0
https://github.com/msullivan
Disable promotions when restricting types in isinstance checkshttps://github.com/python/mypy/commit/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
79f14b0https://github.com/python/mypy/commit/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
#6114https://github.com/python/mypy/pull/6114
#6141https://github.com/python/mypy/issues/6141
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 4, 2019 https://github.com/python/mypy/pull/6114#ref-pullrequest-396081506
Disable promotions when restricting types in isinstance checks #6142 https://github.com/python/mypy/pull/6142
msullivanhttps://github.com/msullivan
Jan 4, 2019 https://github.com/python/mypy/pull/6114#ref-commit-103f5f3
https://github.com/msullivan
Disable promotions when restricting types in isinstance checks (https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9
#6142https://github.com/python/mypy/pull/6142
)https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9
103f5f3https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9
#6114https://github.com/python/mypy/pull/6114
#6141https://github.com/python/mypy/issues/6141
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 8, 2019 https://github.com/python/mypy/pull/6114#ref-issue-397140285
Inconsistency in Union/promotion interactions #6168 https://github.com/python/mypy/issues/6168
msullivanhttps://github.com/msullivan
Jan 8, 2019 https://github.com/python/mypy/pull/6114#ref-commit-d177d6c
https://github.com/msullivan
Fix mypy_mypyc crash caused by "complex" interactionhttps://github.com/python/mypy/commit/d177d6cc18e7e14d10bfd3aa9796cc8d646e7092
d177d6chttps://github.com/python/mypy/commit/d177d6cc18e7e14d10bfd3aa9796cc8d646e7092
#6114https://github.com/python/mypy/pull/6114
#6168https://github.com/python/mypy/issues/6168
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 8, 2019 https://github.com/python/mypy/pull/6114#ref-pullrequest-397143270
Fix mypy_mypyc crash caused by "complex" interaction #6169 https://github.com/python/mypy/pull/6169
msullivanhttps://github.com/msullivan
Jan 9, 2019 https://github.com/python/mypy/pull/6114#ref-commit-307949a
https://github.com/msullivan
Fix mypy_mypyc crash caused by "complex" interaction (https://github.com/python/mypy/commit/307949ae4d7f9c19d341d3a23107d266a002df7c
#6169https://github.com/python/mypy/pull/6169
)https://github.com/python/mypy/commit/307949ae4d7f9c19d341d3a23107d266a002df7c
307949ahttps://github.com/python/mypy/commit/307949ae4d7f9c19d341d3a23107d266a002df7c
#6114https://github.com/python/mypy/pull/6114
#6168https://github.com/python/mypy/issues/6168
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Jan 11, 2019 https://github.com/python/mypy/pull/6114#ref-issue-398090694
Unintended consequences of eliminating promotions with isinstance? #6180 https://github.com/python/mypy/issues/6180
Michael0x2ahttps://github.com/Michael0x2a
Jan 11, 2019 https://github.com/python/mypy/pull/6114#ref-commit-ab7f641
https://github.com/Michael0x2a
Re-enable promtions in isinstance checkshttps://github.com/Michael0x2a/mypy/commit/ab7f6412bf958d924128d41f8f2a2290bfcd9555
ab7f641https://github.com/Michael0x2a/mypy/commit/ab7f6412bf958d924128d41f8f2a2290bfcd9555
python#6114https://github.com/python/mypy/pull/6114
python#6142https://github.com/python/mypy/pull/6142
python#6180https://github.com/python/mypy/issues/6180
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jan 11, 2019 https://github.com/python/mypy/pull/6114#ref-pullrequest-398096383
Re-enable promotions in isinstance checks #6181 https://github.com/python/mypy/pull/6181
Michael0x2ahttps://github.com/Michael0x2a
Jan 11, 2019 https://github.com/python/mypy/pull/6114#ref-commit-401a4e0
https://github.com/Michael0x2a
Re-enable promotions in isinstance checks (https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534
#6181https://github.com/python/mypy/pull/6181
)https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534
401a4e0https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534
#6114https://github.com/python/mypy/pull/6114
#6142https://github.com/python/mypy/pull/6142
#6180https://github.com/python/mypy/issues/6180
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6114
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/6114/files/f7069cacaa55bf7163e4cb32e02c861a3bc30d26
Please reload this pagehttps://github.com/python/mypy/pull/6114
mypy fails to narrow Union[float,int] to float after isinstance(x, float) https://github.com/python/mypy/issues/6060
Please reload this pagehttps://github.com/python/mypy/pull/6114
https://github.com/Michael0x2a
https://github.com/msullivan
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.