| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cfed5436-1c44-5ec7-9168-2df347558163 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D450:3F7946:24C3BB2:3226BA7:6B0038D8 |
| html-safe-nonce | 77fda26d67a85240edcdc14053a72a03d32e51df70130f5429e411e0c9190518 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDUwOjNGNzk0NjoyNEMzQkIyOjMyMjZCQTc6NkIwMDM4RDgiLCJ2aXNpdG9yX2lkIjoiMTQwNDY0MjM0MTI1NTM5NTU0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7494b25f3ff4aeb992d9db189e2ed9e815c61e117559b90b613e3774bb9c3240 |
| hovercard-subject-tag | pull_request:241415920 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/6114/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/448f6d6c1e64335132441edced20d1512096abb254ff340c68a6771c968049e0/python/mypy/pull/6114 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/448f6d6c1e64335132441edced20d1512096abb254ff340c68a6771c968049e0/python/mypy/pull/6114 |
| og:image:alt | This pull request resolves #6060 by modifying conditional_type_map function in checker.py to ignore promotions. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Michael0x2a |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/6114#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6114 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6114 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/6114 |
| Reload | https://github.com/python/mypy/pull/6114 |
| Reload | https://github.com/python/mypy/pull/6114 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests545 (545) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| Michael0x2a | https://github.com/Michael0x2a |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:disable-promotions-in-isinstance-checks | https://github.com/Michael0x2a/mypy/tree/disable-promotions-in-isinstance-checks |
| Conversation | https://github.com/python/mypy/pull/6114 |
| Commits1 (1) | https://github.com/python/mypy/pull/6114/commits |
| Checks | https://github.com/python/mypy/pull/6114/checks |
| Files changed | https://github.com/python/mypy/pull/6114/files |
| Disable promotions in isinstance checks | https://github.com/python/mypy/pull/6114#top |
| Michael0x2a | https://github.com/Michael0x2a |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:disable-promotions-in-isinstance-checks | https://github.com/Michael0x2a/mypy/tree/disable-promotions-in-isinstance-checks |
|
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Dec 29, 2018 | https://github.com/python/mypy/pull/6114#issue-394746853 |
| #6060 | https://github.com/python/mypy/issues/6060 |
| Please reload this page | https://github.com/python/mypy/pull/6114 |
|
| https://github.com/Michael0x2a |
| Disable promotions in isinstance checks | https://github.com/python/mypy/pull/6114/commits/f7069cacaa55bf7163e4cb32e02c861a3bc30d26 |
| f7069ca | https://github.com/python/mypy/pull/6114/commits/f7069cacaa55bf7163e4cb32e02c861a3bc30d26 |
| python#6060 | https://github.com/python/mypy/issues/6060 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Dec 29, 2018 | https://github.com/python/mypy/pull/6114#issuecomment-450451294 |
| Please reload this page | https://github.com/python/mypy/pull/6114 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Dec 30, 2018
| https://github.com/python/mypy/pull/6114#pullrequestreview-188438950 |
|
View reviewed changes
| https://github.com/python/mypy/pull/6114/files/f7069cacaa55bf7163e4cb32e02c861a3bc30d26 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/6114#pullrequestreview-188438950 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/6114 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| 51e34fa | https://github.com/python/mypy/commit/51e34fa4e99de909940390c36120bd3bad24f142 |
| Dec 31, 2018 | https://github.com/python/mypy/pull/6114#event-2048701103 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| December 31, 2018 06:21 | https://github.com/python/mypy/pull/6114#event-2048701143 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 4, 2019
| https://github.com/python/mypy/pull/6114#ref-issue-396078940 |
|
Else block of isinstance check with promotable types has for type
#6141
| https://github.com/python/mypy/issues/6141 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| Jan 4, 2019 | https://github.com/python/mypy/pull/6114#issuecomment-451578421 |
| #6141 | https://github.com/python/mypy/issues/6141 |
| Please reload this page | https://github.com/python/mypy/pull/6114 |
| msullivan | https://github.com/msullivan |
|
Jan 4, 2019
| https://github.com/python/mypy/pull/6114#ref-commit-79f14b0 |
|
| https://github.com/msullivan |
| Disable promotions when restricting types in isinstance checks | https://github.com/python/mypy/commit/79f14b0ada3f214089fd42578a8b6c851f3c6f9f |
| 79f14b0 | https://github.com/python/mypy/commit/79f14b0ada3f214089fd42578a8b6c851f3c6f9f |
| #6114 | https://github.com/python/mypy/pull/6114 |
| #6141 | https://github.com/python/mypy/issues/6141 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 4, 2019
| https://github.com/python/mypy/pull/6114#ref-pullrequest-396081506 |
|
Disable promotions when restricting types in isinstance checks
#6142
| https://github.com/python/mypy/pull/6142 |
| msullivan | https://github.com/msullivan |
|
Jan 4, 2019
| https://github.com/python/mypy/pull/6114#ref-commit-103f5f3 |
|
| https://github.com/msullivan |
| Disable promotions when restricting types in isinstance checks ( | https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9 |
| #6142 | https://github.com/python/mypy/pull/6142 |
| ) | https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9 |
| 103f5f3 | https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9 |
| #6114 | https://github.com/python/mypy/pull/6114 |
| #6141 | https://github.com/python/mypy/issues/6141 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 8, 2019
| https://github.com/python/mypy/pull/6114#ref-issue-397140285 |
|
Inconsistency in Union/promotion interactions
#6168
| https://github.com/python/mypy/issues/6168 |
| msullivan | https://github.com/msullivan |
|
Jan 8, 2019
| https://github.com/python/mypy/pull/6114#ref-commit-d177d6c |
|
| https://github.com/msullivan |
| Fix mypy_mypyc crash caused by "complex" interaction | https://github.com/python/mypy/commit/d177d6cc18e7e14d10bfd3aa9796cc8d646e7092 |
| d177d6c | https://github.com/python/mypy/commit/d177d6cc18e7e14d10bfd3aa9796cc8d646e7092 |
| #6114 | https://github.com/python/mypy/pull/6114 |
| #6168 | https://github.com/python/mypy/issues/6168 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 8, 2019
| https://github.com/python/mypy/pull/6114#ref-pullrequest-397143270 |
|
Fix mypy_mypyc crash caused by "complex" interaction
#6169
| https://github.com/python/mypy/pull/6169 |
| msullivan | https://github.com/msullivan |
|
Jan 9, 2019
| https://github.com/python/mypy/pull/6114#ref-commit-307949a |
|
| https://github.com/msullivan |
| Fix mypy_mypyc crash caused by "complex" interaction ( | https://github.com/python/mypy/commit/307949ae4d7f9c19d341d3a23107d266a002df7c |
| #6169 | https://github.com/python/mypy/pull/6169 |
| ) | https://github.com/python/mypy/commit/307949ae4d7f9c19d341d3a23107d266a002df7c |
| 307949a | https://github.com/python/mypy/commit/307949ae4d7f9c19d341d3a23107d266a002df7c |
| #6114 | https://github.com/python/mypy/pull/6114 |
| #6168 | https://github.com/python/mypy/issues/6168 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jan 11, 2019
| https://github.com/python/mypy/pull/6114#ref-issue-398090694 |
|
Unintended consequences of eliminating promotions with isinstance?
#6180
| https://github.com/python/mypy/issues/6180 |
| Michael0x2a | https://github.com/Michael0x2a |
|
Jan 11, 2019
| https://github.com/python/mypy/pull/6114#ref-commit-ab7f641 |
|
| https://github.com/Michael0x2a |
| Re-enable promtions in isinstance checks | https://github.com/Michael0x2a/mypy/commit/ab7f6412bf958d924128d41f8f2a2290bfcd9555 |
| ab7f641 | https://github.com/Michael0x2a/mypy/commit/ab7f6412bf958d924128d41f8f2a2290bfcd9555 |
| python#6114 | https://github.com/python/mypy/pull/6114 |
| python#6142 | https://github.com/python/mypy/pull/6142 |
| python#6180 | https://github.com/python/mypy/issues/6180 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
|
Jan 11, 2019
| https://github.com/python/mypy/pull/6114#ref-pullrequest-398096383 |
|
Re-enable promotions in isinstance checks
#6181
| https://github.com/python/mypy/pull/6181 |
| Michael0x2a | https://github.com/Michael0x2a |
|
Jan 11, 2019
| https://github.com/python/mypy/pull/6114#ref-commit-401a4e0 |
|
| https://github.com/Michael0x2a |
| Re-enable promotions in isinstance checks ( | https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534 |
| #6181 | https://github.com/python/mypy/pull/6181 |
| ) | https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534 |
| 401a4e0 | https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534 |
| #6114 | https://github.com/python/mypy/pull/6114 |
| #6142 | https://github.com/python/mypy/pull/6142 |
| #6180 | https://github.com/python/mypy/issues/6180 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F6114 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/6114/files/f7069cacaa55bf7163e4cb32e02c861a3bc30d26 |
| Please reload this page | https://github.com/python/mypy/pull/6114 |
|
mypy fails to narrow Union[float,int] to float after isinstance(x, float)
| https://github.com/python/mypy/issues/6060 |
| Please reload this page | https://github.com/python/mypy/pull/6114 |
|
| https://github.com/Michael0x2a |
|
| https://github.com/msullivan |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |