| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0543b6b6-025e-8dc9-03da-e213b49fc90a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C778:1A12A9:65B8BD:87B85F:6B003623 |
| html-safe-nonce | b83db3871e539d0b96d53fe27265c306f2ec15ba3b4bb55f24eda53e8a26e9df |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzc4OjFBMTJBOTo2NUI4QkQ6ODdCODVGOjZCMDAzNjIzIiwidmlzaXRvcl9pZCI6IjIzMDQ3MjgyMTY4NjQxNjkzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2a0446317f1734aef44fc86210adf956cfb30aca7890fa0c0689099a1fafe634 |
| hovercard-subject-tag | pull_request:232770185 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5934/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/59e0dc51bb1c2aa5b7db7119e3d89ac3562aebae17a48104fc4982ed14885729/python/mypy/pull/5934 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/59e0dc51bb1c2aa5b7db7119e3d89ac3562aebae17a48104fc4982ed14885729/python/mypy/pull/5934 |
| og:image:alt | This diff adds a 'LiteralType' class to types.py and adds a corresponding stub method to all of the type visitors.
Most of these stub methods just throw a 'NotImplementedError', tho... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Michael0x2a |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/5934#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5934 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5934 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/5934 |
| Reload | https://github.com/python/mypy/pull/5934 |
| Reload | https://github.com/python/mypy/pull/5934 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| Michael0x2a | https://github.com/Michael0x2a |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:add-literal-type-skeleton | https://github.com/Michael0x2a/mypy/tree/add-literal-type-skeleton |
| Conversation | https://github.com/python/mypy/pull/5934 |
| Commits2 (2) | https://github.com/python/mypy/pull/5934/commits |
| Checks | https://github.com/python/mypy/pull/5934/checks |
| Files changed | https://github.com/python/mypy/pull/5934/files |
| Add LiteralType and stub methods to type visitors | https://github.com/python/mypy/pull/5934#top |
| Michael0x2a | https://github.com/Michael0x2a |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:add-literal-type-skeleton | https://github.com/Michael0x2a/mypy/tree/add-literal-type-skeleton |
|
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Nov 21, 2018 | https://github.com/python/mypy/pull/5934#issue-383255934 |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| #5935 | https://github.com/python/mypy/issues/5935 |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
|
| https://github.com/Michael0x2a |
| Add LiteralType and stub methods to type visitors | https://github.com/python/mypy/pull/5934/commits/23b441efd78513d2c2ec5827574fee9f4d1aeb40 |
| 23b441e | https://github.com/python/mypy/pull/5934/commits/23b441efd78513d2c2ec5827574fee9f4d1aeb40 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| ilevkivskyi | https://github.com/ilevkivskyi |
| November 21, 2018 19:08 | https://github.com/python/mypy/pull/5934#event-1980894260 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
|
Nov 21, 2018
| https://github.com/python/mypy/pull/5934#ref-issue-383261076 |
|
Literal types tracking issue
#5935
| https://github.com/python/mypy/issues/5935 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 22, 2018
| https://github.com/python/mypy/pull/5934#pullrequestreview-177691361 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5934/files/23b441efd78513d2c2ec5827574fee9f4d1aeb40 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/5934#pullrequestreview-177691361 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| mypy/erasetype.py | https://github.com/python/mypy/pull/5934/files/23b441efd78513d2c2ec5827574fee9f4d1aeb40#diff-c9f0543a93a28cd330d73dd1accda2e354fe46039866a54550c0f4fe66db731b |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#discussion_r235752927 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| mypy/types.py | https://github.com/python/mypy/pull/5934/files/23b441efd78513d2c2ec5827574fee9f4d1aeb40#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#discussion_r235754219 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| mypy/types.py | https://github.com/python/mypy/pull/5934/files/23b441efd78513d2c2ec5827574fee9f4d1aeb40#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#discussion_r235754467 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| mypy/types.py | https://github.com/python/mypy/pull/5934/files/23b441efd78513d2c2ec5827574fee9f4d1aeb40#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#discussion_r235754733 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| mypy/types.py | https://github.com/python/mypy/pull/5934/files/23b441efd78513d2c2ec5827574fee9f4d1aeb40#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#discussion_r235754828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| mypy/types.py | https://github.com/python/mypy/pull/5934/files/23b441efd78513d2c2ec5827574fee9f4d1aeb40#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#discussion_r235755322 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
|
| https://github.com/Michael0x2a |
| Respond to code review | https://github.com/python/mypy/pull/5934/commits/4da5f3c1802f70e3ad007823fabde38c7d30df78 |
| 4da5f3c | https://github.com/python/mypy/pull/5934/commits/4da5f3c1802f70e3ad007823fabde38c7d30df78 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#issuecomment-441100017 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 22, 2018
| https://github.com/python/mypy/pull/5934#pullrequestreview-177754475 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5934/files/4da5f3c1802f70e3ad007823fabde38c7d30df78 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/5934#pullrequestreview-177754475 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#issuecomment-441101262 |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| b099496 | https://github.com/python/mypy/commit/b099496568ebb53e0a1345f470846f054562687e |
| Nov 22, 2018 | https://github.com/python/mypy/pull/5934#event-1983069354 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| November 22, 2018 18:40 | https://github.com/python/mypy/pull/5934#event-1983069434 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5934 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/5934/files/4da5f3c1802f70e3ad007823fabde38c7d30df78 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
| Please reload this page | https://github.com/python/mypy/pull/5934 |
|
| https://github.com/Michael0x2a |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |