| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9e2f9d6c-0d6e-c114-ade4-c7dc7cf74c16 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C792:CEC0A:27AFC42:340AD17:6B0004E4 |
| html-safe-nonce | 2e6bd89abd74bcda0b69441772e1119d84fb829533009380329eb23fb7716ccb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzkyOkNFQzBBOjI3QUZDNDI6MzQwQUQxNzo2QjAwMDRFNCIsInZpc2l0b3JfaWQiOiIzMjMxNTM0ODcyNzc0MzEzMTg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bfbf0e17218dcb1436310922ff283c9308df68aebcc9c310ace6133133929cd7 |
| hovercard-subject-tag | pull_request:217533988 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5662/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d22c8d47b51a13d27827f3e70b0cd485bfdb31efbf813233b9b24829324009eb/python/mypy/pull/5662 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d22c8d47b51a13d27827f3e70b0cd485bfdb31efbf813233b9b24829324009eb/python/mypy/pull/5662 |
| og:image:alt | Fixes #5425
The solution is to just prohibit overriding type aliases in subclass. In some sense they are implicitly final, because we need to know them statically (they can be used as type sin anno... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/5662#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5662 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5662 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/5662 |
| Reload | https://github.com/python/mypy/pull/5662 |
| Reload | https://github.com/python/mypy/pull/5662 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:fix-alias-over | https://github.com/ilevkivskyi/mypy/tree/fix-alias-over |
| Conversation | https://github.com/python/mypy/pull/5662 |
| Commits1 (1) | https://github.com/python/mypy/pull/5662/commits |
| Checks | https://github.com/python/mypy/pull/5662/checks |
| Files changed | https://github.com/python/mypy/pull/5662/files |
| Fix crash on overriding class level type alias | https://github.com/python/mypy/pull/5662#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:fix-alias-over | https://github.com/ilevkivskyi/mypy/tree/fix-alias-over |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 23, 2018 | https://github.com/python/mypy/pull/5662#issue-362981769 |
| #5425 | https://github.com/python/mypy/issues/5425 |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
|
| https://github.com/ilevkivskyi |
| Fix crash on overriding class level type alias | https://github.com/python/mypy/pull/5662/commits/291281cdde724e6d829aebaf363dbd4789cfb2b7 |
| 291281c | https://github.com/python/mypy/pull/5662/commits/291281cdde724e6d829aebaf363dbd4789cfb2b7 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| JukkaL | https://github.com/JukkaL |
| Michael0x2a | https://github.com/Michael0x2a |
| September 23, 2018 22:08 | https://github.com/python/mypy/pull/5662#event-1862157119 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Sep 24, 2018
| https://github.com/python/mypy/pull/5662#pullrequestreview-158077362 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/5662#pullrequestreview-158077362 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
| mypy/checker.py | https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| JukkaL | https://github.com/JukkaL |
| Sep 24, 2018 | https://github.com/python/mypy/pull/5662#discussion_r219815442 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
| mypy/checker.py | https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| JukkaL | https://github.com/JukkaL |
| Sep 24, 2018 | https://github.com/python/mypy/pull/5662#discussion_r219815901 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
| mypy/checker.py | https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| JukkaL | https://github.com/JukkaL |
| Sep 24, 2018 | https://github.com/python/mypy/pull/5662#discussion_r219817084 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
| mypy/checker.py | https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| JukkaL | https://github.com/JukkaL |
| Sep 24, 2018 | https://github.com/python/mypy/pull/5662#discussion_r219817782 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
| test-data/unit/check-type-aliases.test | https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-76a9f75952f0c89d17feb57ed74a44e185bf605c852ebede9f54eef6fd3e4599 |
| JukkaL | https://github.com/JukkaL |
| Sep 24, 2018 | https://github.com/python/mypy/pull/5662#discussion_r219819093 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 24, 2018 | https://github.com/python/mypy/pull/5662#issuecomment-423985562 |
| Multiple inheritance: Cannot determine type of "X" in base class "Y" error #2871 | https://github.com/python/mypy/issues/2871 |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 24, 2018 | https://github.com/python/mypy/pull/5662#event-1863193032 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| September 24, 2018 14:02 | https://github.com/python/mypy/pull/5662#event-1863193253 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Sep 24, 2018
| https://github.com/python/mypy/pull/5662#ref-issue-348193185 |
|
Overriding definition such as type alias in a subclass causes a crash
#5425
| https://github.com/python/mypy/issues/5425 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5662 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7 |
|
| https://github.com/Michael0x2a |
|
Michael0x2a
| https://github.com/Michael0x2a |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
|
Overriding definition such as type alias in a subclass causes a crash
| https://github.com/python/mypy/issues/5425 |
| Please reload this page | https://github.com/python/mypy/pull/5662 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |