René's URL Explorer Experiment


Title: Fix crash on overriding class level type alias by ilevkivskyi · Pull Request #5662 · python/mypy · GitHub

Open Graph Title: Fix crash on overriding class level type alias by ilevkivskyi · Pull Request #5662 · python/mypy

X Title: Fix crash on overriding class level type alias by ilevkivskyi · Pull Request #5662 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #5425 The solution is to just prohibit overriding type aliases in subclass. In some sense they are implicitly final, because we need to know them statically (they can be used as type sin anno...

X Description: Fixes #5425 The solution is to just prohibit overriding type aliases in subclass. In some sense they are implicitly final, because we need to know them statically (they can be used as type sin anno...

Opengraph URL: https://github.com/python/mypy/pull/5662

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9e2f9d6c-0d6e-c114-ade4-c7dc7cf74c16
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC792:CEC0A:27AFC42:340AD17:6B0004E4
html-safe-nonce2e6bd89abd74bcda0b69441772e1119d84fb829533009380329eb23fb7716ccb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzkyOkNFQzBBOjI3QUZDNDI6MzQwQUQxNzo2QjAwMDRFNCIsInZpc2l0b3JfaWQiOiIzMjMxNTM0ODcyNzc0MzEzMTg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbfbf0e17218dcb1436310922ff283c9308df68aebcc9c310ace6133133929cd7
hovercard-subject-tagpull_request:217533988
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5662/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d22c8d47b51a13d27827f3e70b0cd485bfdb31efbf813233b9b24829324009eb/python/mypy/pull/5662
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d22c8d47b51a13d27827f3e70b0cd485bfdb31efbf813233b9b24829324009eb/python/mypy/pull/5662
og:image:altFixes #5425 The solution is to just prohibit overriding type aliases in subclass. In some sense they are implicitly final, because we need to know them statically (they can be used as type sin anno...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5662#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5662
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5662
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5662
Reloadhttps://github.com/python/mypy/pull/5662
Reloadhttps://github.com/python/mypy/pull/5662
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-alias-overhttps://github.com/ilevkivskyi/mypy/tree/fix-alias-over
Conversationhttps://github.com/python/mypy/pull/5662
Commits1 (1)https://github.com/python/mypy/pull/5662/commits
Checkshttps://github.com/python/mypy/pull/5662/checks
Files changedhttps://github.com/python/mypy/pull/5662/files
Fix crash on overriding class level type aliashttps://github.com/python/mypy/pull/5662#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-alias-overhttps://github.com/ilevkivskyi/mypy/tree/fix-alias-over
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 23, 2018https://github.com/python/mypy/pull/5662#issue-362981769
#5425https://github.com/python/mypy/issues/5425
Please reload this pagehttps://github.com/python/mypy/pull/5662
https://github.com/ilevkivskyi
Fix crash on overriding class level type aliashttps://github.com/python/mypy/pull/5662/commits/291281cdde724e6d829aebaf363dbd4789cfb2b7
291281chttps://github.com/python/mypy/pull/5662/commits/291281cdde724e6d829aebaf363dbd4789cfb2b7
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
Michael0x2ahttps://github.com/Michael0x2a
September 23, 2018 22:08https://github.com/python/mypy/pull/5662#event-1862157119
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 24, 2018 https://github.com/python/mypy/pull/5662#pullrequestreview-158077362
View reviewed changes https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/5662#pullrequestreview-158077362
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5662
mypy/checker.pyhttps://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
JukkaLhttps://github.com/JukkaL
Sep 24, 2018https://github.com/python/mypy/pull/5662#discussion_r219815442
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5662
mypy/checker.pyhttps://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
JukkaLhttps://github.com/JukkaL
Sep 24, 2018https://github.com/python/mypy/pull/5662#discussion_r219815901
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5662
mypy/checker.pyhttps://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
JukkaLhttps://github.com/JukkaL
Sep 24, 2018https://github.com/python/mypy/pull/5662#discussion_r219817084
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5662
mypy/checker.pyhttps://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
JukkaLhttps://github.com/JukkaL
Sep 24, 2018https://github.com/python/mypy/pull/5662#discussion_r219817782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5662
test-data/unit/check-type-aliases.testhttps://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7#diff-76a9f75952f0c89d17feb57ed74a44e185bf605c852ebede9f54eef6fd3e4599
JukkaLhttps://github.com/JukkaL
Sep 24, 2018https://github.com/python/mypy/pull/5662#discussion_r219819093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5662
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 24, 2018https://github.com/python/mypy/pull/5662#issuecomment-423985562
Multiple inheritance: Cannot determine type of "X" in base class "Y" error #2871https://github.com/python/mypy/issues/2871
Please reload this pagehttps://github.com/python/mypy/pull/5662
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 24, 2018https://github.com/python/mypy/pull/5662#event-1863193032
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
September 24, 2018 14:02https://github.com/python/mypy/pull/5662#event-1863193253
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 24, 2018 https://github.com/python/mypy/pull/5662#ref-issue-348193185
Overriding definition such as type alias in a subclass causes a crash #5425 https://github.com/python/mypy/issues/5425
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5662
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/5662/files/291281cdde724e6d829aebaf363dbd4789cfb2b7
https://github.com/Michael0x2a
Michael0x2a https://github.com/Michael0x2a
Please reload this pagehttps://github.com/python/mypy/pull/5662
Overriding definition such as type alias in a subclass causes a crash https://github.com/python/mypy/issues/5425
Please reload this pagehttps://github.com/python/mypy/pull/5662
https://github.com/ilevkivskyi
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.