René's URL Explorer Experiment


Title: Make classmethod's first argument be Type[...] by msullivan · Pull Request #5646 · python/mypy · GitHub

Open Graph Title: Make classmethod's first argument be Type[...] by msullivan · Pull Request #5646 · python/mypy

X Title: Make classmethod's first argument be Type[...] by msullivan · Pull Request #5646 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Currently the first argument to __new__ and classmethods is a callable type that is constructed during semantic analysis by typechecker code (!) that looks for the __init__/__new__ methods. This ca...

X Description: Currently the first argument to __new__ and classmethods is a callable type that is constructed during semantic analysis by typechecker code (!) that looks for the __init__/__new__ methods. This ca...

Opengraph URL: https://github.com/python/mypy/pull/5646

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0f4b859d-a184-6433-a5ef-be42d27d80c8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB32:91831:4A624C:681DC2:6B00739D
html-safe-nonce669f14bb3d759585b5362b67bcd801055556eac532860c7d304a50204ff0256a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjMyOjkxODMxOjRBNjI0Qzo2ODFEQzI6NkIwMDczOUQiLCJ2aXNpdG9yX2lkIjoiNzI4NjIzODIyNzkwMjUyNjM2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac76ab1abcd879bd6d7cf88b03105c064231d9d17fe63e42df994d8eac3a3bf587
hovercard-subject-tagpull_request:216796720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5646/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d368a3a741816aac96c2c5a093723f8d5cba1e8226b601b804f3053f0fd87fd2/python/mypy/pull/5646
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d368a3a741816aac96c2c5a093723f8d5cba1e8226b601b804f3053f0fd87fd2/python/mypy/pull/5646
og:image:altCurrently the first argument to __new__ and classmethods is a callable type that is constructed during semantic analysis by typechecker code (!) that looks for the __init__/__new__ methods. This ca...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsullivan
hostnamegithub.com
expected-hostnamegithub.com
None75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84e563eb4b55f8fa102f325f117533cee9e3df4a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5646#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5646
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5646
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5646
Reloadhttps://github.com/python/mypy/pull/5646
Reloadhttps://github.com/python/mypy/pull/5646
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests543 (543)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
msullivanhttps://github.com/msullivan
masterhttps://github.com/python/mypy/tree/master
classmethod-typetypehttps://github.com/python/mypy/tree/classmethod-typetype
Conversationhttps://github.com/python/mypy/pull/5646
Commits4 (4)https://github.com/python/mypy/pull/5646/commits
Checkshttps://github.com/python/mypy/pull/5646/checks
Files changedhttps://github.com/python/mypy/pull/5646/files
Make classmethod's first argument be Type[...]https://github.com/python/mypy/pull/5646#top
msullivanhttps://github.com/msullivan
masterhttps://github.com/python/mypy/tree/master
classmethod-typetypehttps://github.com/python/mypy/tree/classmethod-typetype
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Sep 19, 2018https://github.com/python/mypy/pull/5646#issue-361953380
#4190https://github.com/python/mypy/issues/4190
#1727https://github.com/python/mypy/issues/1727
#5263https://github.com/python/mypy/issues/5263
#1727https://github.com/python/mypy/issues/1727
#4190https://github.com/python/mypy/issues/4190
#5263https://github.com/python/mypy/issues/5263
Please reload this pagehttps://github.com/python/mypy/pull/5646
https://github.com/msullivan
Make classmethod's first argument be Type[...]https://github.com/python/mypy/pull/5646/commits/ae485808c69f4c5eaf5e45f6730f7e8e646e8f68
ae48580https://github.com/python/mypy/pull/5646/commits/ae485808c69f4c5eaf5e45f6730f7e8e646e8f68
#4190https://github.com/python/mypy/issues/4190
#1727https://github.com/python/mypy/issues/1727
#5263https://github.com/python/mypy/issues/5263
#1727https://github.com/python/mypy/issues/1727
#4190https://github.com/python/mypy/issues/4190
#5263https://github.com/python/mypy/issues/5263
https://github.com/msullivan
msullivanhttps://github.com/msullivan
JukkaLhttps://github.com/JukkaL
gvanrossumhttps://github.com/gvanrossum
September 19, 2018 22:36https://github.com/python/mypy/pull/5646#event-1856300205
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 21, 2018 https://github.com/python/mypy/pull/5646#pullrequestreview-157637760
View reviewed changes https://github.com/python/mypy/pull/5646/files
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/5646#pullrequestreview-157637760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5646
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/5646/files#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
JukkaLhttps://github.com/JukkaL
Sep 21, 2018https://github.com/python/mypy/pull/5646#discussion_r219456655
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5646
msullivanhttps://github.com/msullivan
Sep 21, 2018https://github.com/python/mypy/pull/5646#discussion_r219566983
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5646
test-data/unit/check-dataclasses.testhttps://github.com/python/mypy/pull/5646/files#diff-5379cab042a82b77ec5dffbbe846636f62f6c7482d537a998b285f7629ea1888
JukkaLhttps://github.com/JukkaL
Sep 21, 2018https://github.com/python/mypy/pull/5646#discussion_r219456892
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5646
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018https://github.com/python/mypy/pull/5646#discussion_r219536329
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5646
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018https://github.com/python/mypy/pull/5646#discussion_r219536649
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5646
test-data/unit/check-dataclasses.testhttps://github.com/python/mypy/pull/5646/files#diff-5379cab042a82b77ec5dffbbe846636f62f6c7482d537a998b285f7629ea1888
JukkaLhttps://github.com/JukkaL
Sep 21, 2018https://github.com/python/mypy/pull/5646#discussion_r219456966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5646
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 21, 2018 https://github.com/python/mypy/pull/5646#ref-pullrequest-351841981
Fixes #1727: constructor after classmethod counts #5501 https://github.com/python/mypy/pull/5501
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Sep 21, 2018https://github.com/python/mypy/pull/5646#issuecomment-423562091
Please reload this pagehttps://github.com/python/mypy/pull/5646
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018 https://github.com/python/mypy/pull/5646#pullrequestreview-157743034
View reviewed changes https://github.com/python/mypy/pull/5646/files
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/5646/files#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018https://github.com/python/mypy/pull/5646#discussion_r219537140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5646
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018https://github.com/python/mypy/pull/5646#issuecomment-423574310
@msullivanhttps://github.com/msullivan
Please reload this pagehttps://github.com/python/mypy/pull/5646
msullivanhttps://github.com/msullivan
September 21, 2018 10:29https://github.com/python/mypy/pull/5646#commits-pushed-1e12404
https://github.com/msullivan
improve testshttps://github.com/python/mypy/pull/5646/commits/1e12404f8f5343df0c7d430c7bd186115b02c6ae
1e12404https://github.com/python/mypy/pull/5646/commits/1e12404f8f5343df0c7d430c7bd186115b02c6ae
https://github.com/msullivan
Merge branch 'master' into classmethod-typetypehttps://github.com/python/mypy/pull/5646/commits/3390ab514695298e05202fbf072003ccb756b3bd
3390ab5https://github.com/python/mypy/pull/5646/commits/3390ab514695298e05202fbf072003ccb756b3bd
https://github.com/msullivan
msullivanhttps://github.com/msullivan
force-pushedhttps://github.com/python/mypy/compare/0abfec03f72719761b773e69d86c1a1c79d9b581..3390ab514695298e05202fbf072003ccb756b3bd
0abfec0https://github.com/python/mypy/commit/0abfec03f72719761b773e69d86c1a1c79d9b581
3390ab5https://github.com/python/mypy/commit/3390ab514695298e05202fbf072003ccb756b3bd
Compare https://github.com/python/mypy/compare/0abfec03f72719761b773e69d86c1a1c79d9b581..3390ab514695298e05202fbf072003ccb756b3bd
September 21, 2018 17:31https://github.com/python/mypy/pull/5646#event-1860766210
https://github.com/msullivan
Merge branch 'master' into classmethod-typetypehttps://github.com/python/mypy/pull/5646/commits/7d09915a345a24e0f934e6cb84d818ce99035bf0
7d09915https://github.com/python/mypy/pull/5646/commits/7d09915a345a24e0f934e6cb84d818ce99035bf0
https://github.com/msullivan
msullivanhttps://github.com/msullivan
e2fd043https://github.com/python/mypy/commit/e2fd043e1c15c67c64027ac5cc640f64e367217b
Sep 21, 2018https://github.com/python/mypy/pull/5646#event-1861107472
https://github.com/msullivan
msullivanhttps://github.com/msullivan
September 21, 2018 20:35https://github.com/python/mypy/pull/5646#event-1861108027
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 29, 2018 https://github.com/python/mypy/pull/5646#ref-issue-385949052
Dataclass classmethods don't work #5974 https://github.com/python/mypy/issues/5974
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5646
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5646/files/0abfec03f72719761b773e69d86c1a1c79d9b581
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/5646/files/0abfec03f72719761b773e69d86c1a1c79d9b581
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/5646
Incorrect error in factory function on a dataclass https://github.com/python/mypy/issues/5263
False positive when calling object.__new__ inside __new__ with args https://github.com/python/mypy/issues/4190
Constructor defined after classmethod is considered to have no args in the classmethod https://github.com/python/mypy/issues/1727
Please reload this pagehttps://github.com/python/mypy/pull/5646
https://github.com/msullivan
https://github.com/ilevkivskyi
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.