René's URL Explorer Experiment


Title: Update imported Vars in the third pass by ilevkivskyi · Pull Request #5635 · python/mypy · GitHub

Open Graph Title: Update imported Vars in the third pass by ilevkivskyi · Pull Request #5635 · python/mypy

X Title: Update imported Vars in the third pass by ilevkivskyi · Pull Request #5635 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #5275 Fixes #4498 Fixes #4442 This is a simple band-aid fix for Invalid type in import cycles where type aliases, named tuples, or typed dicts appear. Note that this is a partial fix that onl...

X Description: Fixes #5275 Fixes #4498 Fixes #4442 This is a simple band-aid fix for Invalid type in import cycles where type aliases, named tuples, or typed dicts appear. Note that this is a partial fix that onl...

Opengraph URL: https://github.com/python/mypy/pull/5635

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:93759462-9e21-3449-2171-54e2784c3a46
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id928E:2FD3CB:60E11E:82178E:6B0035FD
html-safe-nonce621d4fbded813a0994a625873b16e7193a2a60ddce468fafdea8de5fd3b532c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjhFOjJGRDNDQjo2MEUxMUU6ODIxNzhFOjZCMDAzNUZEIiwidmlzaXRvcl9pZCI6IjE0NzMyNTgxNTM2Mzc0NTI3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac216fe0922ca4b74d7becade09b872edfdbcbca9ab801a4418687cf75335b8adc
hovercard-subject-tagpull_request:216379890
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5635/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d69e0d18e9d4ee4689763ce9be2d6893d1c55582cbd0b0b4044efb7f6085657f/python/mypy/pull/5635
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d69e0d18e9d4ee4689763ce9be2d6893d1c55582cbd0b0b4044efb7f6085657f/python/mypy/pull/5635
og:image:altFixes #5275 Fixes #4498 Fixes #4442 This is a simple band-aid fix for Invalid type in import cycles where type aliases, named tuples, or typed dicts appear. Note that this is a partial fix that onl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5635#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5635
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5635
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5635
Reloadhttps://github.com/python/mypy/pull/5635
Reloadhttps://github.com/python/mypy/pull/5635
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:try-fix-import-aliashttps://github.com/ilevkivskyi/mypy/tree/try-fix-import-alias
Conversationhttps://github.com/python/mypy/pull/5635
Commits13 (13)https://github.com/python/mypy/pull/5635/commits
Checkshttps://github.com/python/mypy/pull/5635/checks
Files changedhttps://github.com/python/mypy/pull/5635/files
Update imported Vars in the third passhttps://github.com/python/mypy/pull/5635#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:try-fix-import-aliashttps://github.com/ilevkivskyi/mypy/tree/try-fix-import-alias
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 18, 2018https://github.com/python/mypy/pull/5635#issue-361399383
Please reload this pagehttps://github.com/python/mypy/pull/5635
#5275https://github.com/python/mypy/issues/5275
#4498https://github.com/python/mypy/issues/4498
#4442https://github.com/python/mypy/issues/4442
Please reload this pagehttps://github.com/python/mypy/pull/5635
September 18, 2018 16:25https://github.com/python/mypy/pull/5635#commits-pushed-f653c14
Add testshttps://github.com/python/mypy/pull/5635/commits/f653c143e47e9f61172881bf9dab82ac1a5f25af
f653c14https://github.com/python/mypy/pull/5635/commits/f653c143e47e9f61172881bf9dab82ac1a5f25af
Update imported variables that turned into types or aliaseshttps://github.com/python/mypy/pull/5635/commits/fc0e34472e4d0c3a4a04beebab4677aba2750cfb
fc0e344https://github.com/python/mypy/pull/5635/commits/fc0e34472e4d0c3a4a04beebab4677aba2750cfb
Skip missing moduleshttps://github.com/python/mypy/pull/5635/commits/0b85239cb14859209352c463cf85c7e1acba9656
0b85239https://github.com/python/mypy/pull/5635/commits/0b85239cb14859209352c463cf85c7e1acba9656
More testshttps://github.com/python/mypy/pull/5635/commits/e1558f93df1ba460000603e395ee2673773be453
e1558f9https://github.com/python/mypy/pull/5635/commits/e1558f93df1ba460000603e395ee2673773be453
Fix self-checkhttps://github.com/python/mypy/pull/5635/commits/8588d4f79acdb6314f61598ec3fb625cfc2ee710
8588d4fhttps://github.com/python/mypy/pull/5635/commits/8588d4f79acdb6314f61598ec3fb625cfc2ee710
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
September 18, 2018 17:06https://github.com/python/mypy/pull/5635#event-1852973833
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 19, 2018 https://github.com/python/mypy/pull/5635#pullrequestreview-156951891
View reviewed changes https://github.com/python/mypy/pull/5635/files/8588d4f79acdb6314f61598ec3fb625cfc2ee710
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/5635#pullrequestreview-156951891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5635
test-data/unit/check-namedtuple.testhttps://github.com/python/mypy/pull/5635/files/8588d4f79acdb6314f61598ec3fb625cfc2ee710#diff-1e9c665830a34676d60b21b5d56768c9d545fbc3b67ba76c9e3b79a87281dd5c
JukkaLhttps://github.com/JukkaL
Sep 19, 2018https://github.com/python/mypy/pull/5635#discussion_r218907789
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5635
ilevkivskyihttps://github.com/ilevkivskyi
Sep 19, 2018https://github.com/python/mypy/pull/5635#discussion_r218955608
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5635
ilevkivskyihttps://github.com/ilevkivskyi
September 20, 2018 14:45https://github.com/python/mypy/pull/5635#commits-pushed-f7ba504
https://github.com/ilevkivskyi
Merge branch 'master' into try-fix-import-aliashttps://github.com/python/mypy/pull/5635/commits/f7ba504f746f3b85d6c9a0e1665b8e9c3753f580
f7ba504https://github.com/python/mypy/pull/5635/commits/f7ba504f746f3b85d6c9a0e1665b8e9c3753f580
Add detailed docstringhttps://github.com/python/mypy/pull/5635/commits/6f35bef0c2f24dbde17c12a75cf97b791b6e1757
6f35befhttps://github.com/python/mypy/pull/5635/commits/6f35bef0c2f24dbde17c12a75cf97b791b6e1757
Add test for runtime behaviorhttps://github.com/python/mypy/pull/5635/commits/5fbe0c6af2a4c6b0a6e71d2e60c3f6698692acb8
5fbe0c6https://github.com/python/mypy/pull/5635/commits/5fbe0c6af2a4c6b0a6e71d2e60c3f6698692acb8
Typohttps://github.com/python/mypy/pull/5635/commits/34083536418f32b72daa060c9007edfd14ee3b9c
3408353https://github.com/python/mypy/pull/5635/commits/34083536418f32b72daa060c9007edfd14ee3b9c
Merge branch 'try-fix-import-alias' ofhttps://github.com/python/mypy/pull/5635/commits/b58b38c65caa36c43c790ec24200deab51250555
https://github.com/ilevkivskyi…https://github.com/ilevkivskyi/mypy
b58b38chttps://github.com/python/mypy/pull/5635/commits/b58b38c65caa36c43c790ec24200deab51250555
…/mypyhttps://github.com/ilevkivskyi/mypy
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 20, 2018https://github.com/python/mypy/pull/5635#issuecomment-423325238
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/5635
Fix merge errorhttps://github.com/python/mypy/pull/5635/commits/dcbab2c76f610d5d250e6402f0ff172880aadd6c
dcbab2chttps://github.com/python/mypy/pull/5635/commits/dcbab2c76f610d5d250e6402f0ff172880aadd6c
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 21, 2018 https://github.com/python/mypy/pull/5635#pullrequestreview-157640269
View reviewed changes https://github.com/python/mypy/pull/5635/files/dcbab2c76f610d5d250e6402f0ff172880aadd6c
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/5635#pullrequestreview-157640269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5635
mypy/semanal_pass3.pyhttps://github.com/python/mypy/pull/5635/files/dcbab2c76f610d5d250e6402f0ff172880aadd6c#diff-b1fea670293a2b323562cb1a0679df9b8e697f036c6cebe59f9951cf046029d6
JukkaLhttps://github.com/JukkaL
Sep 21, 2018https://github.com/python/mypy/pull/5635#discussion_r219458463
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5635
mypy/semanal_pass3.pyhttps://github.com/python/mypy/pull/5635/files/dcbab2c76f610d5d250e6402f0ff172880aadd6c#diff-b1fea670293a2b323562cb1a0679df9b8e697f036c6cebe59f9951cf046029d6
JukkaLhttps://github.com/JukkaL
Sep 21, 2018https://github.com/python/mypy/pull/5635#discussion_r219458598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5635
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 21, 2018https://github.com/python/mypy/pull/5635#issuecomment-423526400
Please reload this pagehttps://github.com/python/mypy/pull/5635
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018https://github.com/python/mypy/pull/5635#issuecomment-423563417
#2015https://github.com/python/mypy/issues/2015
Please reload this pagehttps://github.com/python/mypy/pull/5635
September 21, 2018 16:43https://github.com/python/mypy/pull/5635#commits-pushed-2bec999
Fix typoshttps://github.com/python/mypy/pull/5635/commits/2bec99996d9d4b989c1437a79e8365d6d3031fb9
2bec999https://github.com/python/mypy/pull/5635/commits/2bec99996d9d4b989c1437a79e8365d6d3031fb9
Merge remote-tracking branch 'upstream/master' into try-fix-import-aliashttps://github.com/python/mypy/pull/5635/commits/c5e18f10c2c4cf910a1e6482c93ae46a251a0eea
c5e18f1https://github.com/python/mypy/pull/5635/commits/c5e18f10c2c4cf910a1e6482c93ae46a251a0eea
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018https://github.com/python/mypy/pull/5635#issuecomment-423593047
Please reload this pagehttps://github.com/python/mypy/pull/5635
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018https://github.com/python/mypy/pull/5635#issuecomment-423593360
Please reload this pagehttps://github.com/python/mypy/pull/5635
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
792bcdchttps://github.com/python/mypy/commit/792bcdce6ebf264f4a632e96646b85c1886ea529
Sep 21, 2018https://github.com/python/mypy/pull/5635#event-1860626858
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
September 21, 2018 16:24https://github.com/python/mypy/pull/5635#event-1860627032
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018 https://github.com/python/mypy/pull/5635#ref-issue-362766289
"Can't determine type" error in import cycles with named tuples and typed dicts #5658 https://github.com/python/mypy/issues/5658
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5635
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/5635/files/dcbab2c76f610d5d250e6402f0ff172880aadd6c
Please reload this pagehttps://github.com/python/mypy/pull/5635
Import cycle with type aliasing causes invalid "Invalid type" https://github.com/python/mypy/issues/5275
"Invalid type" when using type alias in import cycle https://github.com/python/mypy/issues/4498
Named tuples in import cycles still fail sometimes https://github.com/python/mypy/issues/4442
Please reload this pagehttps://github.com/python/mypy/pull/5635
https://github.com/ilevkivskyi
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.