| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:93759462-9e21-3449-2171-54e2784c3a46 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 928E:2FD3CB:60E11E:82178E:6B0035FD |
| html-safe-nonce | 621d4fbded813a0994a625873b16e7193a2a60ddce468fafdea8de5fd3b532c3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjhFOjJGRDNDQjo2MEUxMUU6ODIxNzhFOjZCMDAzNUZEIiwidmlzaXRvcl9pZCI6IjE0NzMyNTgxNTM2Mzc0NTI3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 216fe0922ca4b74d7becade09b872edfdbcbca9ab801a4418687cf75335b8adc |
| hovercard-subject-tag | pull_request:216379890 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5635/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d69e0d18e9d4ee4689763ce9be2d6893d1c55582cbd0b0b4044efb7f6085657f/python/mypy/pull/5635 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d69e0d18e9d4ee4689763ce9be2d6893d1c55582cbd0b0b4044efb7f6085657f/python/mypy/pull/5635 |
| og:image:alt | Fixes #5275
Fixes #4498
Fixes #4442
This is a simple band-aid fix for Invalid type in import cycles where type aliases, named tuples, or typed dicts appear. Note that this is a partial fix that onl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/5635#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5635 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5635 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/5635 |
| Reload | https://github.com/python/mypy/pull/5635 |
| Reload | https://github.com/python/mypy/pull/5635 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:try-fix-import-alias | https://github.com/ilevkivskyi/mypy/tree/try-fix-import-alias |
| Conversation | https://github.com/python/mypy/pull/5635 |
| Commits13 (13) | https://github.com/python/mypy/pull/5635/commits |
| Checks | https://github.com/python/mypy/pull/5635/checks |
| Files changed | https://github.com/python/mypy/pull/5635/files |
| Update imported Vars in the third pass | https://github.com/python/mypy/pull/5635#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:try-fix-import-alias | https://github.com/ilevkivskyi/mypy/tree/try-fix-import-alias |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 18, 2018 | https://github.com/python/mypy/pull/5635#issue-361399383 |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| #5275 | https://github.com/python/mypy/issues/5275 |
| #4498 | https://github.com/python/mypy/issues/4498 |
| #4442 | https://github.com/python/mypy/issues/4442 |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| September 18, 2018 16:25 | https://github.com/python/mypy/pull/5635#commits-pushed-f653c14 |
| Add tests | https://github.com/python/mypy/pull/5635/commits/f653c143e47e9f61172881bf9dab82ac1a5f25af |
| f653c14 | https://github.com/python/mypy/pull/5635/commits/f653c143e47e9f61172881bf9dab82ac1a5f25af |
| Update imported variables that turned into types or aliases | https://github.com/python/mypy/pull/5635/commits/fc0e34472e4d0c3a4a04beebab4677aba2750cfb |
| fc0e344 | https://github.com/python/mypy/pull/5635/commits/fc0e34472e4d0c3a4a04beebab4677aba2750cfb |
| Skip missing modules | https://github.com/python/mypy/pull/5635/commits/0b85239cb14859209352c463cf85c7e1acba9656 |
| 0b85239 | https://github.com/python/mypy/pull/5635/commits/0b85239cb14859209352c463cf85c7e1acba9656 |
| More tests | https://github.com/python/mypy/pull/5635/commits/e1558f93df1ba460000603e395ee2673773be453 |
| e1558f9 | https://github.com/python/mypy/pull/5635/commits/e1558f93df1ba460000603e395ee2673773be453 |
| Fix self-check | https://github.com/python/mypy/pull/5635/commits/8588d4f79acdb6314f61598ec3fb625cfc2ee710 |
| 8588d4f | https://github.com/python/mypy/pull/5635/commits/8588d4f79acdb6314f61598ec3fb625cfc2ee710 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| JukkaL | https://github.com/JukkaL |
| September 18, 2018 17:06 | https://github.com/python/mypy/pull/5635#event-1852973833 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Sep 19, 2018
| https://github.com/python/mypy/pull/5635#pullrequestreview-156951891 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5635/files/8588d4f79acdb6314f61598ec3fb625cfc2ee710 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/5635#pullrequestreview-156951891 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| test-data/unit/check-namedtuple.test | https://github.com/python/mypy/pull/5635/files/8588d4f79acdb6314f61598ec3fb625cfc2ee710#diff-1e9c665830a34676d60b21b5d56768c9d545fbc3b67ba76c9e3b79a87281dd5c |
| JukkaL | https://github.com/JukkaL |
| Sep 19, 2018 | https://github.com/python/mypy/pull/5635#discussion_r218907789 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 19, 2018 | https://github.com/python/mypy/pull/5635#discussion_r218955608 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| September 20, 2018 14:45 | https://github.com/python/mypy/pull/5635#commits-pushed-f7ba504 |
|
| https://github.com/ilevkivskyi |
| Merge branch 'master' into try-fix-import-alias | https://github.com/python/mypy/pull/5635/commits/f7ba504f746f3b85d6c9a0e1665b8e9c3753f580 |
| f7ba504 | https://github.com/python/mypy/pull/5635/commits/f7ba504f746f3b85d6c9a0e1665b8e9c3753f580 |
| Add detailed docstring | https://github.com/python/mypy/pull/5635/commits/6f35bef0c2f24dbde17c12a75cf97b791b6e1757 |
| 6f35bef | https://github.com/python/mypy/pull/5635/commits/6f35bef0c2f24dbde17c12a75cf97b791b6e1757 |
| Add test for runtime behavior | https://github.com/python/mypy/pull/5635/commits/5fbe0c6af2a4c6b0a6e71d2e60c3f6698692acb8 |
| 5fbe0c6 | https://github.com/python/mypy/pull/5635/commits/5fbe0c6af2a4c6b0a6e71d2e60c3f6698692acb8 |
| Typo | https://github.com/python/mypy/pull/5635/commits/34083536418f32b72daa060c9007edfd14ee3b9c |
| 3408353 | https://github.com/python/mypy/pull/5635/commits/34083536418f32b72daa060c9007edfd14ee3b9c |
| Merge branch 'try-fix-import-alias' of | https://github.com/python/mypy/pull/5635/commits/b58b38c65caa36c43c790ec24200deab51250555 |
| https://github.com/ilevkivskyi… | https://github.com/ilevkivskyi/mypy |
| b58b38c | https://github.com/python/mypy/pull/5635/commits/b58b38c65caa36c43c790ec24200deab51250555 |
| …/mypy | https://github.com/ilevkivskyi/mypy |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 20, 2018 | https://github.com/python/mypy/pull/5635#issuecomment-423325238 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| Fix merge error | https://github.com/python/mypy/pull/5635/commits/dcbab2c76f610d5d250e6402f0ff172880aadd6c |
| dcbab2c | https://github.com/python/mypy/pull/5635/commits/dcbab2c76f610d5d250e6402f0ff172880aadd6c |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Sep 21, 2018
| https://github.com/python/mypy/pull/5635#pullrequestreview-157640269 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5635/files/dcbab2c76f610d5d250e6402f0ff172880aadd6c |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/5635#pullrequestreview-157640269 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| mypy/semanal_pass3.py | https://github.com/python/mypy/pull/5635/files/dcbab2c76f610d5d250e6402f0ff172880aadd6c#diff-b1fea670293a2b323562cb1a0679df9b8e697f036c6cebe59f9951cf046029d6 |
| JukkaL | https://github.com/JukkaL |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5635#discussion_r219458463 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| mypy/semanal_pass3.py | https://github.com/python/mypy/pull/5635/files/dcbab2c76f610d5d250e6402f0ff172880aadd6c#diff-b1fea670293a2b323562cb1a0679df9b8e697f036c6cebe59f9951cf046029d6 |
| JukkaL | https://github.com/JukkaL |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5635#discussion_r219458598 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5635#issuecomment-423526400 |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5635#issuecomment-423563417 |
| #2015 | https://github.com/python/mypy/issues/2015 |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| September 21, 2018 16:43 | https://github.com/python/mypy/pull/5635#commits-pushed-2bec999 |
| Fix typos | https://github.com/python/mypy/pull/5635/commits/2bec99996d9d4b989c1437a79e8365d6d3031fb9 |
| 2bec999 | https://github.com/python/mypy/pull/5635/commits/2bec99996d9d4b989c1437a79e8365d6d3031fb9 |
| Merge remote-tracking branch 'upstream/master' into try-fix-import-alias | https://github.com/python/mypy/pull/5635/commits/c5e18f10c2c4cf910a1e6482c93ae46a251a0eea |
| c5e18f1 | https://github.com/python/mypy/pull/5635/commits/c5e18f10c2c4cf910a1e6482c93ae46a251a0eea |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5635#issuecomment-423593047 |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5635#issuecomment-423593360 |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 792bcdc | https://github.com/python/mypy/commit/792bcdce6ebf264f4a632e96646b85c1886ea529 |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5635#event-1860626858 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| September 21, 2018 16:24 | https://github.com/python/mypy/pull/5635#event-1860627032 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Sep 21, 2018
| https://github.com/python/mypy/pull/5635#ref-issue-362766289 |
|
"Can't determine type" error in import cycles with named tuples and typed dicts
#5658
| https://github.com/python/mypy/issues/5658 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5635 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/5635/files/dcbab2c76f610d5d250e6402f0ff172880aadd6c |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
|
Import cycle with type aliasing causes invalid "Invalid type"
| https://github.com/python/mypy/issues/5275 |
|
"Invalid type" when using type alias in import cycle
| https://github.com/python/mypy/issues/4498 |
|
Named tuples in import cycles still fail sometimes
| https://github.com/python/mypy/issues/4442 |
| Please reload this page | https://github.com/python/mypy/pull/5635 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |