René's URL Explorer Experiment


Title: Fix small regression in subtype cache performance by ilevkivskyi · Pull Request #5604 · python/mypy · GitHub

Open Graph Title: Fix small regression in subtype cache performance by ilevkivskyi · Pull Request #5604 · python/mypy

X Title: Fix small regression in subtype cache performance by ilevkivskyi · Pull Request #5604 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #5514 The root cause is that #5474 added type_parameter_checker (a function) as one of the keys of subtype kinds. This function is a nested one, so in fact a new function was created on every...

X Description: Fixes #5514 The root cause is that #5474 added type_parameter_checker (a function) as one of the keys of subtype kinds. This function is a nested one, so in fact a new function was created on every...

Opengraph URL: https://github.com/python/mypy/pull/5604

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:00b649b8-6576-8a9d-44aa-3f9095942061
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id842A:D064:1C1FFC4:25F1DAD:6B00047C
html-safe-nonce3ca741551119dd0cc7a3c6fdcb2f78a84aacab7ad93902ca0bd02ebf43317f4c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDJBOkQwNjQ6MUMxRkZDNDoyNUYxREFEOjZCMDAwNDdDIiwidmlzaXRvcl9pZCI6IjExNDUyMzU0MDA0MzI4MTMxODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca1f04c1c5027d5d425d054f4eafc475b0e6977380e138ac0f399cf704b229dd5
hovercard-subject-tagpull_request:214798344
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5604/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5da24e6f19d0668daef8a873c8b5ab2924f49d6491b0ccc9cf30d3234e094409/python/mypy/pull/5604
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5da24e6f19d0668daef8a873c8b5ab2924f49d6491b0ccc9cf30d3234e094409/python/mypy/pull/5604
og:image:altFixes #5514 The root cause is that #5474 added type_parameter_checker (a function) as one of the keys of subtype kinds. This function is a nested one, so in fact a new function was created on every...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5604#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5604
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5604
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5604
Reloadhttps://github.com/python/mypy/pull/5604
Reloadhttps://github.com/python/mypy/pull/5604
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:sub-cache-perfhttps://github.com/ilevkivskyi/mypy/tree/sub-cache-perf
Conversationhttps://github.com/python/mypy/pull/5604
Commits8 (8)https://github.com/python/mypy/pull/5604/commits
Checkshttps://github.com/python/mypy/pull/5604/checks
Files changedhttps://github.com/python/mypy/pull/5604/files
Fix small regression in subtype cache performancehttps://github.com/python/mypy/pull/5604#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:sub-cache-perfhttps://github.com/ilevkivskyi/mypy/tree/sub-cache-perf
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 11, 2018https://github.com/python/mypy/pull/5604#issue-359264494
Please reload this pagehttps://github.com/python/mypy/pull/5604
#5514https://github.com/python/mypy/issues/5514
#5474https://github.com/python/mypy/pull/5474
Please reload this pagehttps://github.com/python/mypy/pull/5604
September 11, 2018 20:12https://github.com/python/mypy/pull/5604#commits-pushed-6048a37
Re-organize subtype cacheshttps://github.com/python/mypy/pull/5604/commits/6048a379311ed8ea5d002b25dee01a275634072a
6048a37https://github.com/python/mypy/pull/5604/commits/6048a379311ed8ea5d002b25dee01a275634072a
Avoid import cyclehttps://github.com/python/mypy/pull/5604/commits/1a799d0966a037bd807d2c93d4dd61cbfbaadb1f
1a799d0https://github.com/python/mypy/pull/5604/commits/1a799d0966a037bd807d2c93d4dd61cbfbaadb1f
Use heterogeneous tuples as keyshttps://github.com/python/mypy/pull/5604/commits/301a89b69cf07788ad34d6ded1c9352d46c2eca3
301a89bhttps://github.com/python/mypy/pull/5604/commits/301a89b69cf07788ad34d6ded1c9352d46c2eca3
Refactor subtype cache kinds to use only boolean flagshttps://github.com/python/mypy/pull/5604/commits/818b9bc61483960c1b4d2dbab467549eb973b319
818b9bchttps://github.com/python/mypy/pull/5604/commits/818b9bc61483960c1b4d2dbab467549eb973b319
Remove one-linershttps://github.com/python/mypy/pull/5604/commits/a58cab396f478e1c2124e76a5c40e86935b64193
a58cab3https://github.com/python/mypy/pull/5604/commits/a58cab396f478e1c2124e76a5c40e86935b64193
Switch back the order of cacheshttps://github.com/python/mypy/pull/5604/commits/5704437ff8a4009b003de8d8f3c169002c784187
5704437https://github.com/python/mypy/pull/5604/commits/5704437ff8a4009b003de8d8f3c169002c784187
Fix whitespacehttps://github.com/python/mypy/pull/5604/commits/4c5dd0328e43e8f4175396d65fa4031e1f4830be
4c5dd03https://github.com/python/mypy/pull/5604/commits/4c5dd0328e43e8f4175396d65fa4031e1f4830be
Fix linthttps://github.com/python/mypy/pull/5604/commits/a2e772d3a01fda06ad69f3e4060234bfc62f751e
a2e772dhttps://github.com/python/mypy/pull/5604/commits/a2e772d3a01fda06ad69f3e4060234bfc62f751e
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Michael0x2ahttps://github.com/Michael0x2a
msullivanhttps://github.com/msullivan
September 11, 2018 23:49https://github.com/python/mypy/pull/5604#event-1839856531
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Sep 12, 2018 https://github.com/python/mypy/pull/5604#pullrequestreview-154443043
View reviewed changes https://github.com/python/mypy/pull/5604/files/a2e772d3a01fda06ad69f3e4060234bfc62f751e
Michael0x2ahttps://github.com/Michael0x2a
https://github.com/python/mypy/pull/5604#pullrequestreview-154443043
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5604
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 12, 2018https://github.com/python/mypy/pull/5604#issuecomment-420639826
Please reload this pagehttps://github.com/python/mypy/pull/5604
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
70767bdhttps://github.com/python/mypy/commit/70767bd65cc9865f32fd7aa2970db404eb0f17ea
Sep 12, 2018https://github.com/python/mypy/pull/5604#event-1841074539
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
September 12, 2018 13:03https://github.com/python/mypy/pull/5604#event-1841074715
ilevkivskyihttps://github.com/ilevkivskyi
Sep 12, 2018 https://github.com/python/mypy/pull/5604#ref-commit-813e098
https://github.com/ilevkivskyi
Fix small regression in subtype cache performance (https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff
#5604https://github.com/python/mypy/pull/5604
)https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff
813e098https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff
#5514https://github.com/python/mypy/issues/5514
#5474https://github.com/python/mypy/pull/5474
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5604
https://github.com/Michael0x2a
Michael0x2a https://github.com/Michael0x2a
https://github.com/python/mypy/pull/5604/files/a2e772d3a01fda06ad69f3e4060234bfc62f751e
https://github.com/msullivan
msullivan https://github.com/msullivan
Please reload this pagehttps://github.com/python/mypy/pull/5604
Please reload this pagehttps://github.com/python/mypy/pull/5604
https://github.com/ilevkivskyi
https://github.com/Michael0x2a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.