| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:00b649b8-6576-8a9d-44aa-3f9095942061 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 842A:D064:1C1FFC4:25F1DAD:6B00047C |
| html-safe-nonce | 3ca741551119dd0cc7a3c6fdcb2f78a84aacab7ad93902ca0bd02ebf43317f4c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDJBOkQwNjQ6MUMxRkZDNDoyNUYxREFEOjZCMDAwNDdDIiwidmlzaXRvcl9pZCI6IjExNDUyMzU0MDA0MzI4MTMxODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a1f04c1c5027d5d425d054f4eafc475b0e6977380e138ac0f399cf704b229dd5 |
| hovercard-subject-tag | pull_request:214798344 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5604/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5da24e6f19d0668daef8a873c8b5ab2924f49d6491b0ccc9cf30d3234e094409/python/mypy/pull/5604 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5da24e6f19d0668daef8a873c8b5ab2924f49d6491b0ccc9cf30d3234e094409/python/mypy/pull/5604 |
| og:image:alt | Fixes #5514
The root cause is that #5474 added type_parameter_checker (a function) as one of the keys of subtype kinds. This function is a nested one, so in fact a new function was created on every... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/5604#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5604 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5604 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/5604 |
| Reload | https://github.com/python/mypy/pull/5604 |
| Reload | https://github.com/python/mypy/pull/5604 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:sub-cache-perf | https://github.com/ilevkivskyi/mypy/tree/sub-cache-perf |
| Conversation | https://github.com/python/mypy/pull/5604 |
| Commits8 (8) | https://github.com/python/mypy/pull/5604/commits |
| Checks | https://github.com/python/mypy/pull/5604/checks |
| Files changed | https://github.com/python/mypy/pull/5604/files |
| Fix small regression in subtype cache performance | https://github.com/python/mypy/pull/5604#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:sub-cache-perf | https://github.com/ilevkivskyi/mypy/tree/sub-cache-perf |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 11, 2018 | https://github.com/python/mypy/pull/5604#issue-359264494 |
| Please reload this page | https://github.com/python/mypy/pull/5604 |
| #5514 | https://github.com/python/mypy/issues/5514 |
| #5474 | https://github.com/python/mypy/pull/5474 |
| Please reload this page | https://github.com/python/mypy/pull/5604 |
| September 11, 2018 20:12 | https://github.com/python/mypy/pull/5604#commits-pushed-6048a37 |
| Re-organize subtype caches | https://github.com/python/mypy/pull/5604/commits/6048a379311ed8ea5d002b25dee01a275634072a |
| 6048a37 | https://github.com/python/mypy/pull/5604/commits/6048a379311ed8ea5d002b25dee01a275634072a |
| Avoid import cycle | https://github.com/python/mypy/pull/5604/commits/1a799d0966a037bd807d2c93d4dd61cbfbaadb1f |
| 1a799d0 | https://github.com/python/mypy/pull/5604/commits/1a799d0966a037bd807d2c93d4dd61cbfbaadb1f |
| Use heterogeneous tuples as keys | https://github.com/python/mypy/pull/5604/commits/301a89b69cf07788ad34d6ded1c9352d46c2eca3 |
| 301a89b | https://github.com/python/mypy/pull/5604/commits/301a89b69cf07788ad34d6ded1c9352d46c2eca3 |
| Refactor subtype cache kinds to use only boolean flags | https://github.com/python/mypy/pull/5604/commits/818b9bc61483960c1b4d2dbab467549eb973b319 |
| 818b9bc | https://github.com/python/mypy/pull/5604/commits/818b9bc61483960c1b4d2dbab467549eb973b319 |
| Remove one-liners | https://github.com/python/mypy/pull/5604/commits/a58cab396f478e1c2124e76a5c40e86935b64193 |
| a58cab3 | https://github.com/python/mypy/pull/5604/commits/a58cab396f478e1c2124e76a5c40e86935b64193 |
| Switch back the order of caches | https://github.com/python/mypy/pull/5604/commits/5704437ff8a4009b003de8d8f3c169002c784187 |
| 5704437 | https://github.com/python/mypy/pull/5604/commits/5704437ff8a4009b003de8d8f3c169002c784187 |
| Fix whitespace | https://github.com/python/mypy/pull/5604/commits/4c5dd0328e43e8f4175396d65fa4031e1f4830be |
| 4c5dd03 | https://github.com/python/mypy/pull/5604/commits/4c5dd0328e43e8f4175396d65fa4031e1f4830be |
| Fix lint | https://github.com/python/mypy/pull/5604/commits/a2e772d3a01fda06ad69f3e4060234bfc62f751e |
| a2e772d | https://github.com/python/mypy/pull/5604/commits/a2e772d3a01fda06ad69f3e4060234bfc62f751e |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Michael0x2a | https://github.com/Michael0x2a |
| msullivan | https://github.com/msullivan |
| September 11, 2018 23:49 | https://github.com/python/mypy/pull/5604#event-1839856531 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
|
Sep 12, 2018
| https://github.com/python/mypy/pull/5604#pullrequestreview-154443043 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5604/files/a2e772d3a01fda06ad69f3e4060234bfc62f751e |
| Michael0x2a | https://github.com/Michael0x2a |
| https://github.com/python/mypy/pull/5604#pullrequestreview-154443043 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5604 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 12, 2018 | https://github.com/python/mypy/pull/5604#issuecomment-420639826 |
| Please reload this page | https://github.com/python/mypy/pull/5604 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 70767bd | https://github.com/python/mypy/commit/70767bd65cc9865f32fd7aa2970db404eb0f17ea |
| Sep 12, 2018 | https://github.com/python/mypy/pull/5604#event-1841074539 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| September 12, 2018 13:03 | https://github.com/python/mypy/pull/5604#event-1841074715 |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Sep 12, 2018
| https://github.com/python/mypy/pull/5604#ref-commit-813e098 |
|
| https://github.com/ilevkivskyi |
| Fix small regression in subtype cache performance ( | https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff |
| #5604 | https://github.com/python/mypy/pull/5604 |
| ) | https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff |
| 813e098 | https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff |
| #5514 | https://github.com/python/mypy/issues/5514 |
| #5474 | https://github.com/python/mypy/pull/5474 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5604 |
|
| https://github.com/Michael0x2a |
|
Michael0x2a
| https://github.com/Michael0x2a |
|
| https://github.com/python/mypy/pull/5604/files/a2e772d3a01fda06ad69f3e4060234bfc62f751e |
|
| https://github.com/msullivan |
|
msullivan
| https://github.com/msullivan |
| Please reload this page | https://github.com/python/mypy/pull/5604 |
| Please reload this page | https://github.com/python/mypy/pull/5604 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/Michael0x2a |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |