René's URL Explorer Experiment


Title: Support importing types from nested packages by chrisphilip322 · Pull Request #5591 · python/mypy · GitHub

Open Graph Title: Support importing types from nested packages by chrisphilip322 · Pull Request #5591 · python/mypy

X Title: Support importing types from nested packages by chrisphilip322 · Pull Request #5591 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Attempts to address problems discussed in issue #1645. I enhanced the mypy.build._find_module to search for py.typed marker files at all package levels instead of at the top level. This change curr...

X Description: Attempts to address problems discussed in issue #1645. I enhanced the mypy.build._find_module to search for py.typed marker files at all package levels instead of at the top level. This change curr...

Opengraph URL: https://github.com/python/mypy/pull/5591

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0b9e873b-6da5-0258-a9dc-19e2d0c0a18f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB380:2C0A92:3152355:412AD90:6B002D9E
html-safe-nonce5d8dff5a8e9a6a8c4414d26adb1c5a2f27838300c1e1ac3e42c0c5e1d68288f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzgwOjJDMEE5MjozMTUyMzU1OjQxMkFEOTA6NkIwMDJEOUUiLCJ2aXNpdG9yX2lkIjoiMjg1NTM2MTU2MjMxMzUwMjExMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9c85a17fda4021ac922af3794a7e756bbf093c26eff3655ec780cd0ad72ed7d0
hovercard-subject-tagpull_request:214124294
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5591/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/492423fc6ab01c86c94cb4dcf0e11111e6d0016d9e5d286c2894496443ee860b/python/mypy/pull/5591
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/492423fc6ab01c86c94cb4dcf0e11111e6d0016d9e5d286c2894496443ee860b/python/mypy/pull/5591
og:image:altAttempts to address problems discussed in issue #1645. I enhanced the mypy.build._find_module to search for py.typed marker files at all package levels instead of at the top level. This change curr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechrisphilip322
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5591#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5591
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5591
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5591
Reloadhttps://github.com/python/mypy/pull/5591
Reloadhttps://github.com/python/mypy/pull/5591
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
chrisphilip322:support-nested-importshttps://github.com/chrisphilip322/mypy/tree/support-nested-imports
Conversationhttps://github.com/python/mypy/pull/5591
Commits7 (7)https://github.com/python/mypy/pull/5591/commits
Checkshttps://github.com/python/mypy/pull/5591/checks
Files changedhttps://github.com/python/mypy/pull/5591/files
Support importing types from nested packageshttps://github.com/python/mypy/pull/5591#top
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
chrisphilip322:support-nested-importshttps://github.com/chrisphilip322/mypy/tree/support-nested-imports
https://github.com/chrisphilip322
chrisphilip322https://github.com/chrisphilip322
Sep 9, 2018https://github.com/python/mypy/pull/5591#issue-358343656
#1645https://github.com/python/mypy/issues/1645
Please reload this pagehttps://github.com/python/mypy/pull/5591
chrisphilip322https://github.com/chrisphilip322
September 8, 2018 22:29https://github.com/python/mypy/pull/5591#commits-pushed-380006a
https://github.com/chrisphilip322
support loading type hints from nested packageshttps://github.com/python/mypy/pull/5591/commits/380006adbc6eb24e4b8029460a9956aa287e4ddb
380006ahttps://github.com/python/mypy/pull/5591/commits/380006adbc6eb24e4b8029460a9956aa287e4ddb
https://github.com/chrisphilip322
remove extra print statementhttps://github.com/python/mypy/pull/5591/commits/f1566b983916dd8b9cb7475fbfbc0d4d395422df
f1566b9https://github.com/python/mypy/pull/5591/commits/f1566b983916dd8b9cb7475fbfbc0d4d395422df
https://github.com/chrisphilip322
fix flake8 warningshttps://github.com/python/mypy/pull/5591/commits/8b5c2b8c0ace8a3657683ac651812bac24ac5505
8b5c2b8https://github.com/python/mypy/pull/5591/commits/8b5c2b8c0ace8a3657683ac651812bac24ac5505
https://github.com/chrisphilip322
update tests to have more consistent names and acutally be namespace …https://github.com/python/mypy/pull/5591/commits/6f48b717c167fd7651a20577aa642895d96d359b
6f48b71https://github.com/python/mypy/pull/5591/commits/6f48b717c167fd7651a20577aa642895d96d359b
https://github.com/chrisphilip322
fix arg spreadinghttps://github.com/python/mypy/pull/5591/commits/b5dc6b7dbe57275119a0319409c0431a4dec28c5
b5dc6b7https://github.com/python/mypy/pull/5591/commits/b5dc6b7dbe57275119a0319409c0431a4dec28c5
https://github.com/chrisphilip322
chrisphilip322https://github.com/chrisphilip322
Sep 17, 2018https://github.com/python/mypy/pull/5591#issuecomment-422032224
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 17, 2018https://github.com/python/mypy/pull/5591#issuecomment-422036766
@ethanhshttps://github.com/ethanhs
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
Sep 17, 2018https://github.com/python/mypy/pull/5591#issuecomment-422189861
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/chrisphilip322
Merge branch 'master' ofhttps://github.com/python/mypy/pull/5591/commits/9e5548f59b644c51a00fd5796477b5e32528bf27
https://github.com/python/mypyhttps://github.com/python/mypy
into support-…https://github.com/python/mypy/pull/5591/commits/9e5548f59b644c51a00fd5796477b5e32528bf27
9e5548fhttps://github.com/python/mypy/pull/5591/commits/9e5548f59b644c51a00fd5796477b5e32528bf27
https://github.com/chrisphilip322
chrisphilip322https://github.com/chrisphilip322
force-pushedhttps://github.com/python/mypy/compare/5126318af22847969a45ff656d275d8d9b7964bc..9e5548f59b644c51a00fd5796477b5e32528bf27
5126318https://github.com/python/mypy/commit/5126318af22847969a45ff656d275d8d9b7964bc
9e5548fhttps://github.com/python/mypy/commit/9e5548f59b644c51a00fd5796477b5e32528bf27
Compare https://github.com/python/mypy/compare/5126318af22847969a45ff656d275d8d9b7964bc..9e5548f59b644c51a00fd5796477b5e32528bf27
September 21, 2018 18:43https://github.com/python/mypy/pull/5591#event-1860906182
https://github.com/chrisphilip322
chrisphilip322https://github.com/chrisphilip322
Sep 24, 2018https://github.com/python/mypy/pull/5591#issuecomment-424104603
@ethanhshttps://github.com/ethanhs
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 24, 2018https://github.com/python/mypy/pull/5591#event-1864221656
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 24, 2018https://github.com/python/mypy/pull/5591#issuecomment-424128648
@ethanhshttps://github.com/ethanhs
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 25, 2018 https://github.com/python/mypy/pull/5591#pullrequestreview-158333152
View reviewed changes https://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/5591#pullrequestreview-158333152
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Sep 24, 2018https://github.com/python/mypy/pull/5591#discussion_r220023174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5591
chrisphilip322https://github.com/chrisphilip322
Sep 25, 2018https://github.com/python/mypy/pull/5591#discussion_r220391240
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5591
gvanrossumhttps://github.com/gvanrossum
Sep 26, 2018https://github.com/python/mypy/pull/5591#discussion_r220664551
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/test/testpep561.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-e16f8ea19e0dad7b62fbcc967d610885d28bb2222a2baf0c9c946c5797572e4b
Please reload this pagehttps://github.com/python/mypy/pull/5591
test-data/packages/typedpkg_namespace.alpha/setup.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-fdf6e2c0b923dfa2dcfa682610bed79531795dc90996e03b56e91cff45823155
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/chrisphilip322
condense some lines; rewrite _find_module_non_stub_helper; reuse unit…https://github.com/python/mypy/pull/5591/commits/983b6eb44d27f4ea6bcf7a4091b78c748e82d9f9
983b6ebhttps://github.com/python/mypy/pull/5591/commits/983b6eb44d27f4ea6bcf7a4091b78c748e82d9f9
https://github.com/chrisphilip322
chrisphilip322https://github.com/chrisphilip322
Sep 25, 2018 https://github.com/python/mypy/pull/5591#pullrequestreview-158788689
View reviewed changes https://github.com/python/mypy/pull/5591/files/983b6eb44d27f4ea6bcf7a4091b78c748e82d9f9
chrisphilip322https://github.com/chrisphilip322
https://github.com/python/mypy/pull/5591#pullrequestreview-158788689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
chrisphilip322https://github.com/chrisphilip322
Sep 25, 2018https://github.com/python/mypy/pull/5591#discussion_r220391240
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 26, 2018 https://github.com/python/mypy/pull/5591#pullrequestreview-159125125
View reviewed changes https://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/5591#pullrequestreview-159125125
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5591
mypy/build.pyhttps://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Sep 26, 2018https://github.com/python/mypy/pull/5591#discussion_r220664551
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
2244721https://github.com/python/mypy/commit/2244721df395ea7ccb986286a12594e2d7b097e8
Sep 26, 2018https://github.com/python/mypy/pull/5591#event-1869124134
https://github.com/chrisphilip322
chrisphilip322https://github.com/chrisphilip322
Oct 9, 2018 https://github.com/python/mypy/pull/5591#ref-issue-368230147
Documentation should be updated to for new namespace pkg support #5757 https://github.com/python/mypy/issues/5757
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 9, 2018 https://github.com/python/mypy/pull/5591#ref-issue-368251690
Support namespace packages from command line #5759 https://github.com/python/mypy/issues/5759
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5591
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/5591/files/9e5548f59b644c51a00fd5796477b5e32528bf27
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/5591
https://github.com/chrisphilip322
https://github.com/JukkaL
https://github.com/emmatyping
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.