René's URL Explorer Experiment


Title: Fix untyped decorator check for class instances by izquierdo · Pull Request #5509 · python/mypy · GitHub

Open Graph Title: Fix untyped decorator check for class instances by izquierdo · Pull Request #5509 · python/mypy

X Title: Fix untyped decorator check for class instances by izquierdo · Pull Request #5509 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Running mypy --disallow-untyped-decorators when the decorator is a typed callable instance produces an error even though reveal_type shows the correct type. Related to #4191 but I'll leave that...

X Description: Running mypy --disallow-untyped-decorators when the decorator is a typed callable instance produces an error even though reveal_type shows the correct type. Related to #4191 but I'll leave ...

Opengraph URL: https://github.com/python/mypy/pull/5509

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:4d165154-54f7-a3bf-94f9-b1ddacbae8c9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB78:2AD163:2562B6C:32DFA89:6B00379E
html-safe-nonce4064b0dff0b33e2516629ac19a889860f9f899efc2d4ddf3983ff004ad414097
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjc4OjJBRDE2MzoyNTYyQjZDOjMyREZBODk6NkIwMDM3OUUiLCJ2aXNpdG9yX2lkIjoiNjA0NjYxNDA0MjM5NzY1Mjg5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac488ea6de535a59fa5cd4b795a608fa59584a129c600ababcbbd9a457c3fc913a
hovercard-subject-tagpull_request:209391711
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/5509
twitter:imagehttps://opengraph.githubassets.com/cd2924d74a4a4ece60e04c9fb476b88685ac349516cd0a4a984f0384d2a1419c/python/mypy/pull/5509
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cd2924d74a4a4ece60e04c9fb476b88685ac349516cd0a4a984f0384d2a1419c/python/mypy/pull/5509
og:image:altRunning mypy --disallow-untyped-decorators when the decorator is a typed callable instance produces an error even though reveal_type shows the correct type. Related to #4191 but I'll leave that...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameizquierdo
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5509#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5509
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5509
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5509
Reloadhttps://github.com/python/mypy/pull/5509
Reloadhttps://github.com/python/mypy/pull/5509
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
izquierdo:untyped-decoratorshttps://github.com/izquierdo/mypy/tree/untyped-decorators
Conversationhttps://github.com/python/mypy/pull/5509
Commits9 (9)https://github.com/python/mypy/pull/5509/commits
Checkshttps://github.com/python/mypy/pull/5509/checks
Files changedhttps://github.com/python/mypy/pull/5509/files
Fix untyped decorator check for class instanceshttps://github.com/python/mypy/pull/5509#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
izquierdo:untyped-decoratorshttps://github.com/izquierdo/mypy/tree/untyped-decorators
https://github.com/izquierdo
izquierdohttps://github.com/izquierdo
Aug 20, 2018https://github.com/python/mypy/pull/5509#issue-351955364
#4191https://github.com/python/mypy/issues/4191
Please reload this pagehttps://github.com/python/mypy/pull/5509
https://github.com/izquierdo
Fix untyped decorator check for class instanceshttps://github.com/python/mypy/pull/5509/commits/81cfd1c6c496e9130b59f75381073f087412bf1d
81cfd1chttps://github.com/python/mypy/pull/5509/commits/81cfd1c6c496e9130b59f75381073f087412bf1d
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 20, 2018 https://github.com/python/mypy/pull/5509#pullrequestreview-147582563
View reviewed changes https://github.com/python/mypy/pull/5509/files/81cfd1c6c496e9130b59f75381073f087412bf1d
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5509#pullrequestreview-147582563
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5509
mypy/checker.pyhttps://github.com/python/mypy/pull/5509/files/81cfd1c6c496e9130b59f75381073f087412bf1d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Aug 20, 2018https://github.com/python/mypy/pull/5509#discussion_r211211006
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5509
mypy/checker.pyhttps://github.com/python/mypy/pull/5509/files/81cfd1c6c496e9130b59f75381073f087412bf1d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Aug 20, 2018https://github.com/python/mypy/pull/5509#discussion_r211211158
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5509
mypy/checker.pyhttps://github.com/python/mypy/pull/5509/files/81cfd1c6c496e9130b59f75381073f087412bf1d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Aug 20, 2018https://github.com/python/mypy/pull/5509#discussion_r211212074
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5509
test-data/unit/check-flags.testhttps://github.com/python/mypy/pull/5509/files/81cfd1c6c496e9130b59f75381073f087412bf1d#diff-7554754ef53c99ab2fa88f631a427e23169c894e0c58ea818ab04c084a3ad650
ilevkivskyihttps://github.com/ilevkivskyi
Aug 20, 2018https://github.com/python/mypy/pull/5509#discussion_r211212838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5509
izquierdohttps://github.com/izquierdo
August 20, 2018 22:36https://github.com/python/mypy/pull/5509#commits-pushed-5ab8e77
https://github.com/izquierdo
Change if to elifhttps://github.com/python/mypy/pull/5509/commits/5ab8e77af41fe009ffc7ee54a8ef9d521a0861c3
5ab8e77https://github.com/python/mypy/pull/5509/commits/5ab8e77af41fe009ffc7ee54a8ef9d521a0861c3
https://github.com/izquierdo
Be consistent in using is_typed_callable()https://github.com/python/mypy/pull/5509/commits/8277397bd67851a3de0d797cc5aacff18628541c
8277397https://github.com/python/mypy/pull/5509/commits/8277397bd67851a3de0d797cc5aacff18628541c
https://github.com/izquierdo
Fix spurious error for Instance without __call__https://github.com/python/mypy/pull/5509/commits/ba8add5584555f7a6a6b21cababdbac0d284f5f6
ba8add5https://github.com/python/mypy/pull/5509/commits/ba8add5584555f7a6a6b21cababdbac0d284f5f6
https://github.com/izquierdo
Check untyped decorators more thoroughlyhttps://github.com/python/mypy/pull/5509/commits/c1e0ea5d51798387c15299902640ea27de232502
c1e0ea5https://github.com/python/mypy/pull/5509/commits/c1e0ea5d51798387c15299902640ea27de232502
https://github.com/izquierdo
Fix untyped decorator check for overloadshttps://github.com/python/mypy/pull/5509/commits/aeabb1531f8b49e44d02d3ef7cdf986f70b19fe8
aeabb15https://github.com/python/mypy/pull/5509/commits/aeabb1531f8b49e44d02d3ef7cdf986f70b19fe8
https://github.com/izquierdo
izquierdohttps://github.com/izquierdo
Aug 20, 2018https://github.com/python/mypy/pull/5509#issuecomment-414326565
Please reload this pagehttps://github.com/python/mypy/pull/5509
izquierdohttps://github.com/izquierdo
August 28, 2018 09:54https://github.com/python/mypy/pull/5509#commits-pushed-0277074
https://github.com/izquierdo
Merge branch 'master' into untyped-decoratorshttps://github.com/python/mypy/pull/5509/commits/02770745f5df76db7d88517c7a8c3e181485b06c
0277074https://github.com/python/mypy/pull/5509/commits/02770745f5df76db7d88517c7a8c3e181485b06c
https://github.com/izquierdo
Change if to elifhttps://github.com/python/mypy/pull/5509/commits/0d3c68a6542d8d13f4ea6bb28c8dbb30dd629507
0d3c68ahttps://github.com/python/mypy/pull/5509/commits/0d3c68a6542d8d13f4ea6bb28c8dbb30dd629507
https://github.com/izquierdo
Expand test case for overloaded decoratorhttps://github.com/python/mypy/pull/5509/commits/15461a65e68101ad153718b55c4ae5e73b777d5b
15461a6https://github.com/python/mypy/pull/5509/commits/15461a65e68101ad153718b55c4ae5e73b777d5b
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 21, 2018 https://github.com/python/mypy/pull/5509#pullrequestreview-157887464
View reviewed changes https://github.com/python/mypy/pull/5509/files/15461a65e68101ad153718b55c4ae5e73b777d5b
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5509#pullrequestreview-157887464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5509
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
5afea77https://github.com/python/mypy/commit/5afea77bbb343986309b8b5584825e960553de9e
Sep 21, 2018https://github.com/python/mypy/pull/5509#event-1861349024
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 22, 2018 https://github.com/python/mypy/pull/5509#ref-issue-270393205
Running mypy with --disallow-untyped-decorators reports an error for overloaded decorators #4191 https://github.com/python/mypy/issues/4191
https://github.com/izquierdo
izquierdohttps://github.com/izquierdo
September 25, 2018 00:19https://github.com/python/mypy/pull/5509#event-1864469257
https://github.com/bluetech
bluetechhttps://github.com/bluetech
Jul 31, 2020 https://github.com/python/mypy/pull/5509#ref-pullrequest-669606258
Fix untyped decorator overload error on decorator with __call__ overloads #9232 https://github.com/python/mypy/pull/9232
JukkaLhttps://github.com/JukkaL
Jul 31, 2020 https://github.com/python/mypy/pull/5509#ref-commit-cc46692
https://github.com/bluetech
Fix untyped decorator overload error on class decorator with __call__…https://github.com/python/mypy/commit/cc46692020ef6b672b761512095fbba281fdefc7
cc46692https://github.com/python/mypy/commit/cc46692020ef6b672b761512095fbba281fdefc7
#9232https://github.com/python/mypy/pull/9232
pytest-dev/pytest#7589https://github.com/pytest-dev/pytest/issues/7589
#5509https://github.com/python/mypy/pull/5509
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5509
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5509/files/15461a65e68101ad153718b55c4ae5e73b777d5b
Please reload this pagehttps://github.com/python/mypy/pull/5509
Please reload this pagehttps://github.com/python/mypy/pull/5509
https://github.com/izquierdo
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.