René's URL Explorer Experiment


Title: Allow overloaded overrides if they don't extend domain by ilevkivskyi · Pull Request #5505 · python/mypy · GitHub

Open Graph Title: Allow overloaded overrides if they don't extend domain by ilevkivskyi · Pull Request #5505 · python/mypy

X Title: Allow overloaded overrides if they don't extend domain by ilevkivskyi · Pull Request #5505 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #4985 Mypy previously disallowed introducing overloads for operator methods in overrides because this can interact unsafely with reverse methods. However it looks like this is safe for the si...

X Description: Fixes #4985 Mypy previously disallowed introducing overloads for operator methods in overrides because this can interact unsafely with reverse methods. However it looks like this is safe for the si...

Opengraph URL: https://github.com/python/mypy/pull/5505

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:51aa7d57-ef64-f5d4-a9dd-4d8f2752b546
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90A8:4D728:26A3E45:32568E3:6AFFFA78
html-safe-noncebc1f1fc6ae865682ba140a57ac3b620e871302646e3b2d2851b2f155f606be42
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEE4OjRENzI4OjI2QTNFNDU6MzI1NjhFMzo2QUZGRkE3OCIsInZpc2l0b3JfaWQiOiI4MDYwNTMwOTMzNDEwODIyNzc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6803a3e86a6373f41b83bb83746a679ec480476c4f489e368b9b76413370c184
hovercard-subject-tagpull_request:209339695
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5505/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ead736ab01b144b245cee7d85ad66f828bb93c6427606b99ed10ec05b33c6b64/python/mypy/pull/5505
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ead736ab01b144b245cee7d85ad66f828bb93c6427606b99ed10ec05b33c6b64/python/mypy/pull/5505
og:image:altFixes #4985 Mypy previously disallowed introducing overloads for operator methods in overrides because this can interact unsafely with reverse methods. However it looks like this is safe for the si...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5505#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5505
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5505
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5505
Reloadhttps://github.com/python/mypy/pull/5505
Reloadhttps://github.com/python/mypy/pull/5505
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:overload-overridehttps://github.com/ilevkivskyi/mypy/tree/overload-override
Conversationhttps://github.com/python/mypy/pull/5505
Commits2 (2)https://github.com/python/mypy/pull/5505/commits
Checkshttps://github.com/python/mypy/pull/5505/checks
Files changedhttps://github.com/python/mypy/pull/5505/files
Allow overloaded overrides if they don't extend domainhttps://github.com/python/mypy/pull/5505#top
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:overload-overridehttps://github.com/ilevkivskyi/mypy/tree/overload-override
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 19, 2018https://github.com/python/mypy/pull/5505#issue-351868318
#4985https://github.com/python/mypy/issues/4985
#4985 (comment)https://github.com/python/mypy/issues/4985#issuecomment-414095444
Please reload this pagehttps://github.com/python/mypy/pull/5505
Allow overloaded overrides if they don't extend domainhttps://github.com/python/mypy/pull/5505/commits/8085231d8c28d00866fe2dd38a81328a7a6f1b77
8085231https://github.com/python/mypy/pull/5505/commits/8085231d8c28d00866fe2dd38a81328a7a6f1b77
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Michael0x2ahttps://github.com/Michael0x2a
August 19, 2018 02:42https://github.com/python/mypy/pull/5505#event-1796188299
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 20, 2018 https://github.com/python/mypy/pull/5505#pullrequestreview-147512086
View reviewed changes https://github.com/python/mypy/pull/5505/files/8085231d8c28d00866fe2dd38a81328a7a6f1b77
Michael0x2ahttps://github.com/Michael0x2a
https://github.com/python/mypy/pull/5505#pullrequestreview-147512086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
mypy/checker.pyhttps://github.com/python/mypy/pull/5505/files/8085231d8c28d00866fe2dd38a81328a7a6f1b77#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Michael0x2ahttps://github.com/Michael0x2a
Aug 20, 2018https://github.com/python/mypy/pull/5505#discussion_r211150418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
ilevkivskyihttps://github.com/ilevkivskyi
Aug 23, 2018https://github.com/python/mypy/pull/5505#discussion_r212402735
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
mypy/checker.pyhttps://github.com/python/mypy/pull/5505/files/8085231d8c28d00866fe2dd38a81328a7a6f1b77#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Michael0x2ahttps://github.com/Michael0x2a
Aug 20, 2018https://github.com/python/mypy/pull/5505#discussion_r211151585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
ilevkivskyihttps://github.com/ilevkivskyi
Aug 23, 2018https://github.com/python/mypy/pull/5505#discussion_r212402826
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
test-data/unit/check-overloading.testhttps://github.com/python/mypy/pull/5505/files/8085231d8c28d00866fe2dd38a81328a7a6f1b77#diff-6c41d3376f71af2f59c5e9fdc957b8543f31f8ff5bc2ea0b49d0796958f487b0
Michael0x2ahttps://github.com/Michael0x2a
Aug 20, 2018https://github.com/python/mypy/pull/5505#discussion_r211151718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
ilevkivskyihttps://github.com/ilevkivskyi
Aug 23, 2018https://github.com/python/mypy/pull/5505#discussion_r212405182
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
ilevkivskyihttps://github.com/ilevkivskyi
Aug 23, 2018https://github.com/python/mypy/pull/5505#discussion_r212406837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
mypy/checker.pyhttps://github.com/python/mypy/pull/5505/files/8085231d8c28d00866fe2dd38a81328a7a6f1b77#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Michael0x2ahttps://github.com/Michael0x2a
Aug 20, 2018https://github.com/python/mypy/pull/5505#discussion_r211153174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
ilevkivskyihttps://github.com/ilevkivskyi
Aug 23, 2018https://github.com/python/mypy/pull/5505#discussion_r212404475
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5505
Respond to code reviewhttps://github.com/python/mypy/pull/5505/commits/ad9b72e28ac6ec712ef8da37437d8b79fd8dfbcd
ad9b72ehttps://github.com/python/mypy/pull/5505/commits/ad9b72e28ac6ec712ef8da37437d8b79fd8dfbcd
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 23, 2018https://github.com/python/mypy/pull/5505#issuecomment-415527358
@Michael0x2ahttps://github.com/Michael0x2a
Please reload this pagehttps://github.com/python/mypy/pull/5505
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 23, 2018https://github.com/python/mypy/pull/5505#issuecomment-415558994
Please reload this pagehttps://github.com/python/mypy/pull/5505
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
fec59edhttps://github.com/python/mypy/commit/fec59edd7f64ebcbaab31c63dcc841b28ddda4b0
Aug 23, 2018https://github.com/python/mypy/pull/5505#event-1806274070
https://github.com/tgpfeiffer
tgpfeifferhttps://github.com/tgpfeiffer
Apr 21, 2020 https://github.com/python/mypy/pull/5505#ref-issue-318665181
Signatures of overloaded operators are incompatible with super type #4985 https://github.com/python/mypy/issues/4985
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
April 22, 2020 06:52https://github.com/python/mypy/pull/5505#event-3259104228
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5505
https://github.com/Michael0x2a
Michael0x2a https://github.com/Michael0x2a
https://github.com/python/mypy/pull/5505/files/8085231d8c28d00866fe2dd38a81328a7a6f1b77
Please reload this pagehttps://github.com/python/mypy/pull/5505
Please reload this pagehttps://github.com/python/mypy/pull/5505
https://github.com/ilevkivskyi
https://github.com/Michael0x2a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.