| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:638e9b95-42dc-a722-1c30-5b8b856b679d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECB6:3AC32C:5EB9A5:84FF37:6B00782E |
| html-safe-nonce | ab10fc8f288c3517eca0cf232589084739d4a4eac622e21d9d171b81c1b2c050 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0I2OjNBQzMyQzo1RUI5QTU6ODRGRjM3OjZCMDA3ODJFIiwidmlzaXRvcl9pZCI6Ijg0MjM1NDQzNjA5OTc1MTczNTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | af0312b72510ef9fde7e0859e70084b6b50756cdc74a16b79fcfd135c2d8cb63 |
| hovercard-subject-tag | pull_request:209324888 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5501/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a7cde4cf837b20cf809868bd159e1b7df309e2d345139b25f62ba9da7b19b871/python/mypy/pull/5501 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a7cde4cf837b20cf809868bd159e1b7df309e2d345139b25f62ba9da7b19b871/python/mypy/pull/5501 |
| og:image:alt | This is a fix for #1727.
Instead of prepare classmethod definitions while analyzing class, let's postpone this until the class is fully analyzed.
dataclass magic creates __init__ after the clas... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | VadimPushtaev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84e563eb4b55f8fa102f325f117533cee9e3df4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/5501#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5501 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5501 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/5501 |
| Reload | https://github.com/python/mypy/pull/5501 |
| Reload | https://github.com/python/mypy/pull/5501 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests543 (543) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| VadimPushtaev | https://github.com/VadimPushtaev |
| python:master | https://github.com/python/mypy/tree/master |
| VadimPushtaev:before_init | https://github.com/VadimPushtaev/mypy/tree/before_init |
| Conversation | https://github.com/python/mypy/pull/5501 |
| Commits5 (5) | https://github.com/python/mypy/pull/5501/commits |
| Checks | https://github.com/python/mypy/pull/5501/checks |
| Files changed | https://github.com/python/mypy/pull/5501/files |
| Fixes #1727: constructor after classmethod counts | https://github.com/python/mypy/pull/5501#top |
| VadimPushtaev | https://github.com/VadimPushtaev |
| python:master | https://github.com/python/mypy/tree/master |
| VadimPushtaev:before_init | https://github.com/VadimPushtaev/mypy/tree/before_init |
|
| https://github.com/VadimPushtaev |
| VadimPushtaev | https://github.com/VadimPushtaev |
| Aug 18, 2018 | https://github.com/python/mypy/pull/5501#issue-351841981 |
| #1727 | https://github.com/python/mypy/issues/1727 |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| https://github.com/VadimPushtaev |
| VadimPushtaev | https://github.com/VadimPushtaev |
|
Aug 18, 2018
| https://github.com/python/mypy/pull/5501#ref-issue-161268288 |
|
Constructor defined after classmethod is considered to have no args in the classmethod
#1727
| https://github.com/python/mypy/issues/1727 |
| https://github.com/VadimPushtaev |
| VadimPushtaev | https://github.com/VadimPushtaev |
| Aug 18, 2018 | https://github.com/python/mypy/pull/5501#issuecomment-414078094 |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| https://github.com/VadimPushtaev |
| VadimPushtaev | https://github.com/VadimPushtaev |
| Aug 18, 2018 | https://github.com/python/mypy/pull/5501#issuecomment-414078419 |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 18, 2018
| https://github.com/python/mypy/pull/5501#pullrequestreview-147441551 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5501/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/5501#pullrequestreview-147441551 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #4575 | https://github.com/python/mypy/issues/4575 |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| test-data/unit/check-classes.test | https://github.com/python/mypy/pull/5501/files#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 18, 2018 | https://github.com/python/mypy/pull/5501#discussion_r211086124 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| mypy/semanal.py | https://github.com/python/mypy/pull/5501/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 18, 2018 | https://github.com/python/mypy/pull/5501#discussion_r211086154 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| VadimPushtaev | https://github.com/VadimPushtaev |
| Aug 19, 2018 | https://github.com/python/mypy/pull/5501#discussion_r211096573 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| https://github.com/VadimPushtaev |
| VadimPushtaev | https://github.com/VadimPushtaev |
| Aug 19, 2018 | https://github.com/python/mypy/pull/5501#issuecomment-414113773 |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
|
| https://github.com/VadimPushtaev |
| Fixes | https://github.com/python/mypy/pull/5501/commits/d5ed26a3f0e08d9653343f9ee7c42ea44dc4f11c |
| python#1727 | https://github.com/python/mypy/issues/1727 |
| : constructor after classmethod counts | https://github.com/python/mypy/pull/5501/commits/d5ed26a3f0e08d9653343f9ee7c42ea44dc4f11c |
| d5ed26a | https://github.com/python/mypy/pull/5501/commits/d5ed26a3f0e08d9653343f9ee7c42ea44dc4f11c |
| https://github.com/VadimPushtaev |
| VadimPushtaev | https://github.com/VadimPushtaev |
| force-pushed | https://github.com/python/mypy/compare/b39eb0fd0bdfbf1607456c6fe7964f5cf8b420fa..d5ed26a3f0e08d9653343f9ee7c42ea44dc4f11c |
| b39eb0f | https://github.com/python/mypy/commit/b39eb0fd0bdfbf1607456c6fe7964f5cf8b420fa |
| d5ed26a | https://github.com/python/mypy/commit/d5ed26a3f0e08d9653343f9ee7c42ea44dc4f11c |
|
Compare
| https://github.com/python/mypy/compare/b39eb0fd0bdfbf1607456c6fe7964f5cf8b420fa..d5ed26a3f0e08d9653343f9ee7c42ea44dc4f11c |
| August 19, 2018 08:59 | https://github.com/python/mypy/pull/5501#event-1796270079 |
| VadimPushtaev | https://github.com/VadimPushtaev |
| August 20, 2018 22:29 | https://github.com/python/mypy/pull/5501#commits-pushed-05b8dff |
|
| https://github.com/VadimPushtaev |
| python#1727 | https://github.com/python/mypy/issues/1727 |
| : deps.test for classmethod | https://github.com/python/mypy/pull/5501/commits/05b8dffe6fbff9ad4f76b5d0d149b24ad0311e9a |
| 05b8dff | https://github.com/python/mypy/pull/5501/commits/05b8dffe6fbff9ad4f76b5d0d149b24ad0311e9a |
|
| https://github.com/VadimPushtaev |
| python#1727 | https://github.com/python/mypy/issues/1727 |
| : fine-grained.test for classmethod | https://github.com/python/mypy/pull/5501/commits/b0f7a24a0a990e857a038eb9cca5759a9e675d5f |
| b0f7a24 | https://github.com/python/mypy/pull/5501/commits/b0f7a24a0a990e857a038eb9cca5759a9e675d5f |
|
| https://github.com/VadimPushtaev |
| python#1727 | https://github.com/python/mypy/issues/1727 |
| : more unit tests | https://github.com/python/mypy/pull/5501/commits/9b0723937d9426a436a948f764e6423eeea7b2c6 |
| 9b07239 | https://github.com/python/mypy/pull/5501/commits/9b0723937d9426a436a948f764e6423eeea7b2c6 |
|
| https://github.com/VadimPushtaev |
| python#1727 | https://github.com/python/mypy/issues/1727 |
| : test classmethod in nested class | https://github.com/python/mypy/pull/5501/commits/60ca4718a0f47ddee1b646028037f4599f990178 |
| 60ca471 | https://github.com/python/mypy/pull/5501/commits/60ca4718a0f47ddee1b646028037f4599f990178 |
| https://github.com/VadimPushtaev |
| VadimPushtaev | https://github.com/VadimPushtaev |
| Aug 20, 2018 | https://github.com/python/mypy/pull/5501#issuecomment-414471817 |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5501#issuecomment-423495444 |
| #5646 | https://github.com/python/mypy/pull/5646 |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5501#issuecomment-423580143 |
| #5646 | https://github.com/python/mypy/pull/5646 |
| @VadimPushtaev | https://github.com/VadimPushtaev |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 21, 2018 | https://github.com/python/mypy/pull/5501#event-1860536198 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5501 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/5501/files/b39eb0fd0bdfbf1607456c6fe7964f5cf8b420fa |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
| Please reload this page | https://github.com/python/mypy/pull/5501 |
|
| https://github.com/VadimPushtaev |
|
| https://github.com/JukkaL |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |