| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0420df3c-0c66-4318-8c36-a91a6359be28 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9328:1A6297:CA8290:108A7D7:6AFFF78F |
| html-safe-nonce | f4a89b3cda4a69266bd91b6c233a498edb4a816a29a9354ea374e30b4504e228 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzI4OjFBNjI5NzpDQTgyOTA6MTA4QTdENzo2QUZGRjc4RiIsInZpc2l0b3JfaWQiOiI2ODAwOTMxOTk2NDUwMTM5MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 24bde3c6038d9f405ec6bfcbb2a38fa36102957b8f07b059c47ed586791cdca3 |
| hovercard-subject-tag | pull_request:208173772 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5474/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dcfeec00a8df9cd1e66a3dcdd7956b2b34457f13eb353cc2ce7041c895e36cf5/python/mypy/pull/5474 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dcfeec00a8df9cd1e66a3dcdd7956b2b34457f13eb353cc2ce7041c895e36cf5/python/mypy/pull/5474 |
| og:image:alt | Currently, the typestate module keeps track of two separate subtype caches: one for regular subtypes, and another for proper subtypes.
This pattern unfortunately does not generalize well: for examp... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Michael0x2a |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/5474#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5474 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5474 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/5474 |
| Reload | https://github.com/python/mypy/pull/5474 |
| Reload | https://github.com/python/mypy/pull/5474 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:generalize-subtype-cache | https://github.com/Michael0x2a/mypy/tree/generalize-subtype-cache |
| Conversation | https://github.com/python/mypy/pull/5474 |
| Commits3 (3) | https://github.com/python/mypy/pull/5474/commits |
| Checks | https://github.com/python/mypy/pull/5474/checks |
| Files changed | https://github.com/python/mypy/pull/5474/files |
| Generalize subtype caches | https://github.com/python/mypy/pull/5474#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| Michael0x2a:generalize-subtype-cache | https://github.com/Michael0x2a/mypy/tree/generalize-subtype-cache |
|
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#issue-350287329 |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
|
| https://github.com/Michael0x2a |
| Generalize subtype caches | https://github.com/python/mypy/pull/5474/commits/b64d687a6b1db9589b4f8125ccee87227c3b283d |
| b64d687 | https://github.com/python/mypy/pull/5474/commits/b64d687a6b1db9589b4f8125ccee87227c3b283d |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 14, 2018 05:40 | https://github.com/python/mypy/pull/5474#event-1786942741 |
| Michael0x2a | https://github.com/Michael0x2a |
|
Aug 14, 2018
| https://github.com/python/mypy/pull/5474#ref-commit-4b6c58a |
|
| https://github.com/Michael0x2a |
| Add support for partially overlapping types | https://github.com/Michael0x2a/mypy/commit/4b6c58acdb3285f46eb4c95b5b1fd9c727614c45 |
| 4b6c58a | https://github.com/Michael0x2a/mypy/commit/4b6c58acdb3285f46eb4c95b5b1fd9c727614c45 |
| python#5474 | https://github.com/python/mypy/pull/5474 |
| python#5475 | https://github.com/python/mypy/pull/5475 |
| python#5475 | https://github.com/python/mypy/pull/5475 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
|
Aug 14, 2018
| https://github.com/python/mypy/pull/5474#ref-pullrequest-350301059 |
|
Add partial overload checks
#5476
| https://github.com/python/mypy/pull/5476 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 14, 2018
| https://github.com/python/mypy/pull/5474#pullrequestreview-146114949 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5474/files/b64d687a6b1db9589b4f8125ccee87227c3b283d |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/5474#pullrequestreview-146114949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
| mypy/subtypes.py | https://github.com/python/mypy/pull/5474/files/b64d687a6b1db9589b4f8125ccee87227c3b283d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#discussion_r209992322 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#discussion_r210069531 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
| mypy/subtypes.py | https://github.com/python/mypy/pull/5474/files/b64d687a6b1db9589b4f8125ccee87227c3b283d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#discussion_r209994554 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#discussion_r210069998 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
| mypy/subtypes.py | https://github.com/python/mypy/pull/5474/files/b64d687a6b1db9589b4f8125ccee87227c3b283d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#discussion_r209996217 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#discussion_r210070060 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
|
| https://github.com/Michael0x2a |
| Respond to code review | https://github.com/python/mypy/pull/5474/commits/753b5a0b03a8d6d3bc1a0e81dc7823430ad44fa8 |
| 753b5a0 | https://github.com/python/mypy/pull/5474/commits/753b5a0b03a8d6d3bc1a0e81dc7823430ad44fa8 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#issuecomment-412983224 |
| #5476 | https://github.com/python/mypy/pull/5476 |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
|
| https://github.com/Michael0x2a |
| Merge branch 'master' into generalize-subtype-cache | https://github.com/python/mypy/pull/5474/commits/a30c76d0b1d11f5bfe2c3c358aeb6be255179998 |
| a30c76d | https://github.com/python/mypy/pull/5474/commits/a30c76d0b1d11f5bfe2c3c358aeb6be255179998 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#issuecomment-413006311 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| a2ffde9 | https://github.com/python/mypy/commit/a2ffde90635baf05e264f8d899f5705c52b27c2a |
| Aug 14, 2018 | https://github.com/python/mypy/pull/5474#event-1788835097 |
| Michael0x2a | https://github.com/Michael0x2a |
|
Aug 14, 2018
| https://github.com/python/mypy/pull/5474#ref-commit-b9c8d22 |
|
| https://github.com/Michael0x2a |
| Add support for partially overlapping types | https://github.com/Michael0x2a/mypy/commit/b9c8d224a2b833b1eb0ec1e7645fe9d1722c7e6d |
| b9c8d22 | https://github.com/Michael0x2a/mypy/commit/b9c8d224a2b833b1eb0ec1e7645fe9d1722c7e6d |
| python#5474 | https://github.com/python/mypy/pull/5474 |
| python#5475 | https://github.com/python/mypy/pull/5475 |
| python#5475 | https://github.com/python/mypy/pull/5475 |
| Michael0x2a | https://github.com/Michael0x2a |
|
Aug 16, 2018
| https://github.com/python/mypy/pull/5474#ref-commit-af2109c |
|
| https://github.com/Michael0x2a |
| Add support for partially overlapping types | https://github.com/Michael0x2a/mypy/commit/af2109c4d23077f18847296ce24558b3d2125703 |
| af2109c | https://github.com/Michael0x2a/mypy/commit/af2109c4d23077f18847296ce24558b3d2125703 |
| python#5474 | https://github.com/python/mypy/pull/5474 |
| python#5475 | https://github.com/python/mypy/pull/5475 |
| python#5475 | https://github.com/python/mypy/pull/5475 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Aug 20, 2018
| https://github.com/python/mypy/pull/5474#ref-issue-352334448 |
|
Perf regression caused by #5474
#5514
| https://github.com/python/mypy/issues/5514 |
| https://github.com/Michael0x2a |
| Michael0x2a | https://github.com/Michael0x2a |
| August 27, 2018 05:46 | https://github.com/python/mypy/pull/5474#event-1809807462 |
| Michael0x2a | https://github.com/Michael0x2a |
|
Aug 27, 2018
| https://github.com/python/mypy/pull/5474#ref-commit-dd70710 |
|
| https://github.com/Michael0x2a |
| Add partial overload checks ( | https://github.com/python/mypy/commit/dd70710081fcd8cbc139db3c669f8251f90dc70a |
| #5476 | https://github.com/python/mypy/pull/5476 |
| ) | https://github.com/python/mypy/commit/dd70710081fcd8cbc139db3c669f8251f90dc70a |
| dd70710 | https://github.com/python/mypy/commit/dd70710081fcd8cbc139db3c669f8251f90dc70a |
| #5474 | https://github.com/python/mypy/pull/5474 |
| #5475 | https://github.com/python/mypy/pull/5475 |
| #5475 | https://github.com/python/mypy/pull/5475 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Sep 11, 2018
| https://github.com/python/mypy/pull/5474#ref-pullrequest-359264494 |
|
Fix small regression in subtype cache performance
#5604
| https://github.com/python/mypy/pull/5604 |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Sep 12, 2018
| https://github.com/python/mypy/pull/5474#ref-commit-70767bd |
|
| https://github.com/ilevkivskyi |
| Fix small regression in subtype cache performance ( | https://github.com/python/mypy/commit/70767bd65cc9865f32fd7aa2970db404eb0f17ea |
| #5604 | https://github.com/python/mypy/pull/5604 |
| ) | https://github.com/python/mypy/commit/70767bd65cc9865f32fd7aa2970db404eb0f17ea |
| 70767bd | https://github.com/python/mypy/commit/70767bd65cc9865f32fd7aa2970db404eb0f17ea |
| #5514 | https://github.com/python/mypy/issues/5514 |
| #5474 | https://github.com/python/mypy/pull/5474 |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Sep 12, 2018
| https://github.com/python/mypy/pull/5474#ref-commit-813e098 |
|
| https://github.com/ilevkivskyi |
| Fix small regression in subtype cache performance ( | https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff |
| #5604 | https://github.com/python/mypy/pull/5604 |
| ) | https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff |
| 813e098 | https://github.com/python/mypy/commit/813e098466daa5b218680f0158a5648a17edf3ff |
| #5514 | https://github.com/python/mypy/issues/5514 |
| #5474 | https://github.com/python/mypy/pull/5474 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5474 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/5474/files/b64d687a6b1db9589b4f8125ccee87227c3b283d |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
| Please reload this page | https://github.com/python/mypy/pull/5474 |
|
| https://github.com/Michael0x2a |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |