René's URL Explorer Experiment


Title: Don't treat functions with reversible dunder names as such by srittau · Pull Request #5421 · python/mypy · GitHub

Open Graph Title: Don't treat functions with reversible dunder names as such by srittau · Pull Request #5421 · python/mypy

X Title: Don't treat functions with reversible dunder names as such by srittau · Pull Request #5421 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Previously, functions that had the same name as a reversible dunder method (for example, __rpow__) were checked as if they were such a method. This could lead to crashes and false positives. Closes...

X Description: Previously, functions that had the same name as a reversible dunder method (for example, __rpow__) were checked as if they were such a method. This could lead to crashes and false positives. Closes...

Opengraph URL: https://github.com/python/mypy/pull/5421

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7cfb3382-2177-18d3-61d1-7cc339172a8a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE890:2EC689:23C9154:309822D:6B002F87
html-safe-nonce72a24721076ec352b587a53f43146ee7c9ce97b366a00643fdb777458f448c74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODkwOjJFQzY4OToyM0M5MTU0OjMwOTgyMkQ6NkIwMDJGODciLCJ2aXNpdG9yX2lkIjoiNDk3MjIwODEyNDM0MjE1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc47f527f2748ccd9bb6fc64921e7a47be87db191e738025147ac983e819967af
hovercard-subject-tagpull_request:206242926
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5421/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/735730a9a8ef7e818e74ae40781055bdd12bd611d331b42affabad842f8281e9/python/mypy/pull/5421
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/735730a9a8ef7e818e74ae40781055bdd12bd611d331b42affabad842f8281e9/python/mypy/pull/5421
og:image:altPreviously, functions that had the same name as a reversible dunder method (for example, __rpow__) were checked as if they were such a method. This could lead to crashes and false positives. Closes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesrittau
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5421#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5421
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5421
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5421
Reloadhttps://github.com/python/mypy/pull/5421
Reloadhttps://github.com/python/mypy/pull/5421
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
srittau:fix-5419https://github.com/srittau/mypy/tree/fix-5419
Conversationhttps://github.com/python/mypy/pull/5421
Commits6 (6)https://github.com/python/mypy/pull/5421/commits
Checkshttps://github.com/python/mypy/pull/5421/checks
Files changedhttps://github.com/python/mypy/pull/5421/files
Don't treat functions with reversible dunder names as suchhttps://github.com/python/mypy/pull/5421#top
Michael0x2ahttps://github.com/Michael0x2a
python:masterhttps://github.com/python/mypy/tree/master
srittau:fix-5419https://github.com/srittau/mypy/tree/fix-5419
https://github.com/srittau
srittauhttps://github.com/srittau
Aug 5, 2018https://github.com/python/mypy/pull/5421#issue-347705300
#5419https://github.com/python/mypy/issues/5419
Please reload this pagehttps://github.com/python/mypy/pull/5421
srittauhttps://github.com/srittau
August 5, 2018 17:00https://github.com/python/mypy/pull/5421#commits-pushed-52e9a2b
https://github.com/srittau
Add a test case exposinghttps://github.com/python/mypy/pull/5421/commits/52e9a2bf3b6d233e0296bb33b43fa43735e830dd
python#5419https://github.com/python/mypy/issues/5419
52e9a2bhttps://github.com/python/mypy/pull/5421/commits/52e9a2bf3b6d233e0296bb33b43fa43735e830dd
https://github.com/srittau
Add an assertion to operator_method_signatures_overlap()https://github.com/python/mypy/pull/5421/commits/5b1977f5ac38dd2adda6cc15a0d1dd43ac8918c5
5b1977fhttps://github.com/python/mypy/pull/5421/commits/5b1977f5ac38dd2adda6cc15a0d1dd43ac8918c5
https://github.com/srittau
Add an assertion to check_reverse_op_method()https://github.com/python/mypy/pull/5421/commits/3eae0a967df8204310564070febb56e79964803f
3eae0a9https://github.com/python/mypy/pull/5421/commits/3eae0a967df8204310564070febb56e79964803f
https://github.com/srittau
Don't treat functions with reversible dunder names as suchhttps://github.com/python/mypy/pull/5421/commits/01bd1a27a6456434274625e76118bb7f95eb2170
01bd1a2https://github.com/python/mypy/pull/5421/commits/01bd1a27a6456434274625e76118bb7f95eb2170
python#5419https://github.com/python/mypy/issues/5419
https://github.com/srittau
srittauhttps://github.com/srittau
Aug 5, 2018 https://github.com/python/mypy/pull/5421#ref-issue-347675005
specially crafted __rpow__ signature causes mypy to terminate with an "Internal Error" #5419 https://github.com/python/mypy/issues/5419
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 5, 2018 https://github.com/python/mypy/pull/5421#pullrequestreview-143415351
View reviewed changes https://github.com/python/mypy/pull/5421/files/01bd1a27a6456434274625e76118bb7f95eb2170
Michael0x2ahttps://github.com/Michael0x2a
https://github.com/python/mypy/pull/5421#pullrequestreview-143415351
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5421
mypy/messages.pyhttps://github.com/python/mypy/pull/5421/files/01bd1a27a6456434274625e76118bb7f95eb2170#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0
Michael0x2ahttps://github.com/Michael0x2a
Aug 5, 2018https://github.com/python/mypy/pull/5421#discussion_r207741232
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
this casthttps://github.com/python/mypy/blob/master/mypy/nodes.py#L401
Please reload this pagehttps://github.com/python/mypy/pull/5421
test-data/unit/check-modules.testhttps://github.com/python/mypy/pull/5421/files/01bd1a27a6456434274625e76118bb7f95eb2170#diff-841b50838a13f5f73aa1699d00dbae63f0e4144cb0be0b8345af10acdb42e55f
Michael0x2ahttps://github.com/Michael0x2a
Aug 5, 2018https://github.com/python/mypy/pull/5421#discussion_r207741730
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5421
srittauhttps://github.com/srittau
Aug 5, 2018https://github.com/python/mypy/pull/5421#discussion_r207745091
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5421
srittauhttps://github.com/srittau
August 5, 2018 20:17https://github.com/python/mypy/pull/5421#commits-pushed-7070276
https://github.com/srittau
Remove superfluous overloadhttps://github.com/python/mypy/pull/5421/commits/70702768059bc1a4993b288ecabff6c979e42406
7070276https://github.com/python/mypy/pull/5421/commits/70702768059bc1a4993b288ecabff6c979e42406
https://github.com/srittau
Add more dunder names as function testshttps://github.com/python/mypy/pull/5421/commits/2164997c193ab15a87c1b2ae485e75cfe4ffb49a
2164997https://github.com/python/mypy/pull/5421/commits/2164997c193ab15a87c1b2ae485e75cfe4ffb49a
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
Aug 5, 2018 https://github.com/python/mypy/pull/5421#pullrequestreview-143422044
View reviewed changes https://github.com/python/mypy/pull/5421/files/2164997c193ab15a87c1b2ae485e75cfe4ffb49a
emmatypinghttps://github.com/emmatyping
https://github.com/python/mypy/pull/5421#pullrequestreview-143422044
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5421
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
1222c96https://github.com/python/mypy/commit/1222c9637b673bcca6218a943cd4b88b8749b0ad
Aug 5, 2018https://github.com/python/mypy/pull/5421#event-1771744488
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 5, 2018https://github.com/python/mypy/pull/5421#issuecomment-410547551
Please reload this pagehttps://github.com/python/mypy/pull/5421
https://github.com/srittau
srittauhttps://github.com/srittau
August 5, 2018 22:26https://github.com/python/mypy/pull/5421#event-1771771219
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5421
https://github.com/Michael0x2a
Michael0x2a https://github.com/Michael0x2a
https://github.com/python/mypy/pull/5421/files/01bd1a27a6456434274625e76118bb7f95eb2170
https://github.com/emmatyping
emmatyping https://github.com/emmatyping
https://github.com/python/mypy/pull/5421/files/2164997c193ab15a87c1b2ae485e75cfe4ffb49a
Please reload this pagehttps://github.com/python/mypy/pull/5421
Please reload this pagehttps://github.com/python/mypy/pull/5421
https://github.com/srittau
https://github.com/Michael0x2a
https://github.com/emmatyping
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.