René's URL Explorer Experiment


Title: Remove and refactor old overload selection logic by Michael0x2a · Pull Request #5321 · python/mypy · GitHub

Open Graph Title: Remove and refactor old overload selection logic by Michael0x2a · Pull Request #5321 · python/mypy

X Title: Remove and refactor old overload selection logic by Michael0x2a · Pull Request #5321 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This commit removes a few remnants of the old overload selection algorithm in checkexpr. Specifically, this commit: Modifies erased_signature_similarity so it returns a bool instead of an int. ...

X Description: This commit removes a few remnants of the old overload selection algorithm in checkexpr. Specifically, this commit: Modifies erased_signature_similarity so it returns a bool instead of an int. ...

Opengraph URL: https://github.com/python/mypy/pull/5321

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:74cf78fc-da81-5b70-a034-e2be98bca5e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94C2:16605A:13416B0:194F86B:6B00089E
html-safe-nonce79eca2469062a608bd5c63391fbf50b1cb96354fae64f4a3b97e988dfdaecdb5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEMyOjE2NjA1QToxMzQxNkIwOjE5NEY4NkI6NkIwMDA4OUUiLCJ2aXNpdG9yX2lkIjoiMzUzOTMyNzQxMTkxNTA2NTUwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8bd01536c4001515c5525c4e89d9f7f256b4b3cbdbcefdd50294e7f13469e637
hovercard-subject-tagpull_request:199316068
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5321/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/778b6e45b801420e6a8a756b52e5047469e2db3cc7fefd39c197068b1551df1c/python/mypy/pull/5321
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/778b6e45b801420e6a8a756b52e5047469e2db3cc7fefd39c197068b1551df1c/python/mypy/pull/5321
og:image:altThis commit removes a few remnants of the old overload selection algorithm in checkexpr. Specifically, this commit: Modifies erased_signature_similarity so it returns a bool instead of an int. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5321#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5321
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5321
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5321
Reloadhttps://github.com/python/mypy/pull/5321
Reloadhttps://github.com/python/mypy/pull/5321
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:remove-old-overload-selection-algohttps://github.com/Michael0x2a/mypy/tree/remove-old-overload-selection-algo
Conversationhttps://github.com/python/mypy/pull/5321
Commits4 (4)https://github.com/python/mypy/pull/5321/commits
Checkshttps://github.com/python/mypy/pull/5321/checks
Files changedhttps://github.com/python/mypy/pull/5321/files
Remove and refactor old overload selection logichttps://github.com/python/mypy/pull/5321#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:remove-old-overload-selection-algohttps://github.com/Michael0x2a/mypy/tree/remove-old-overload-selection-algo
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jul 4, 2018https://github.com/python/mypy/pull/5321#issue-338364835
Please reload this pagehttps://github.com/python/mypy/pull/5321
https://github.com/Michael0x2a
Remove and refactor old overload selection logichttps://github.com/python/mypy/pull/5321/commits/b8845ac56ada4c17350b497c7ac71b98ed048731
b8845achttps://github.com/python/mypy/pull/5321/commits/b8845ac56ada4c17350b497c7ac71b98ed048731
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
force-pushedhttps://github.com/python/mypy/compare/3b88e61e54c0b034e54e8754f6956ca3df9e4883..b8845ac56ada4c17350b497c7ac71b98ed048731
3b88e61https://github.com/python/mypy/commit/3b88e61e54c0b034e54e8754f6956ca3df9e4883
b8845achttps://github.com/python/mypy/commit/b8845ac56ada4c17350b497c7ac71b98ed048731
Compare https://github.com/python/mypy/compare/3b88e61e54c0b034e54e8754f6956ca3df9e4883..b8845ac56ada4c17350b497c7ac71b98ed048731
August 4, 2018 13:57https://github.com/python/mypy/pull/5321#event-1771263125
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
ilevkivskyihttps://github.com/ilevkivskyi
August 14, 2018 06:50https://github.com/python/mypy/pull/5321#event-1787026214
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 14, 2018https://github.com/python/mypy/pull/5321#issuecomment-412772366
Please reload this pagehttps://github.com/python/mypy/pull/5321
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 14, 2018 https://github.com/python/mypy/pull/5321#ref-pullrequest-350301059
Add partial overload checks #5476 https://github.com/python/mypy/pull/5476
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 14, 2018 https://github.com/python/mypy/pull/5321#pullrequestreview-146189472
View reviewed changes https://github.com/python/mypy/pull/5321/files/b8845ac56ada4c17350b497c7ac71b98ed048731
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5321#pullrequestreview-146189472
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5321
mypy/checkexpr.pyhttps://github.com/python/mypy/pull/5321/files/b8845ac56ada4c17350b497c7ac71b98ed048731#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
ilevkivskyihttps://github.com/ilevkivskyi
Aug 14, 2018https://github.com/python/mypy/pull/5321#discussion_r210053102
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5321
Michael0x2ahttps://github.com/Michael0x2a
Aug 27, 2018https://github.com/python/mypy/pull/5321#discussion_r212874037
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5321
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/5321/files/b8845ac56ada4c17350b497c7ac71b98ed048731#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
ilevkivskyihttps://github.com/ilevkivskyi
Aug 14, 2018https://github.com/python/mypy/pull/5321#discussion_r210075361
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5321
Michael0x2ahttps://github.com/Michael0x2a
Aug 27, 2018https://github.com/python/mypy/pull/5321#discussion_r212874578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5321
ilevkivskyihttps://github.com/ilevkivskyi
Aug 27, 2018https://github.com/python/mypy/pull/5321#discussion_r212979593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5321
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/5321/files/b8845ac56ada4c17350b497c7ac71b98ed048731#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
ilevkivskyihttps://github.com/ilevkivskyi
Aug 14, 2018https://github.com/python/mypy/pull/5321#discussion_r210075560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5321
Michael0x2ahttps://github.com/Michael0x2a
August 26, 2018 22:50https://github.com/python/mypy/pull/5321#commits-pushed-5aa8f4c
https://github.com/Michael0x2a
Merge branch 'master' into remove-old-overload-selection-algohttps://github.com/python/mypy/pull/5321/commits/5aa8f4cfb1574c0c7f2fa33944764b5fd09e180d
5aa8f4chttps://github.com/python/mypy/pull/5321/commits/5aa8f4cfb1574c0c7f2fa33944764b5fd09e180d
https://github.com/Michael0x2a
Add test case for error messageshttps://github.com/python/mypy/pull/5321/commits/133097306cbc98ad72fe60ee00bc07a67101d6cc
1330973https://github.com/python/mypy/pull/5321/commits/133097306cbc98ad72fe60ee00bc07a67101d6cc
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Aug 27, 2018https://github.com/python/mypy/pull/5321#issuecomment-416125573
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/5321
https://github.com/Michael0x2a
Fix typoshttps://github.com/python/mypy/pull/5321/commits/857aaf85551721c114b83d32bbcabb6975c13e68
857aaf8https://github.com/python/mypy/pull/5321/commits/857aaf85551721c114b83d32bbcabb6975c13e68
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 27, 2018 https://github.com/python/mypy/pull/5321#pullrequestreview-149716881
View reviewed changes https://github.com/python/mypy/pull/5321/files/857aaf85551721c114b83d32bbcabb6975c13e68
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5321#pullrequestreview-149716881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5321
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
4e6d753https://github.com/python/mypy/commit/4e6d75312664f4d901e952110b092fe7afb7a9bc
Aug 27, 2018https://github.com/python/mypy/pull/5321#event-1810636877
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
August 27, 2018 15:33https://github.com/python/mypy/pull/5321#event-1810899786
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5321
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5321/files/857aaf85551721c114b83d32bbcabb6975c13e68
Please reload this pagehttps://github.com/python/mypy/pull/5321
Please reload this pagehttps://github.com/python/mypy/pull/5321
https://github.com/Michael0x2a
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.