| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2ef86399-04d0-dfb4-ec63-8d1cbf33605e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AA9E:3A13A0:25108AB:3253844:6B0035D1 |
| html-safe-nonce | a2a66a4da20dda2e689786867592198352b03fd55bb7ca9dcef2524db9099b71 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTlFOjNBMTNBMDoyNTEwOEFCOjMyNTM4NDQ6NkIwMDM1RDEiLCJ2aXNpdG9yX2lkIjoiMzgwNDM2OTIzODE2MDg0ODMzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7ec05d4315657f169fa15857a71f554c38740b9138cf24eeccde47a167579691 |
| hovercard-subject-tag | pull_request:198430291 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5301/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c7093a1d7ed913dced2bf56b68389ae3fc1b8203a7e49300f1198618f163a548/python/mypy/pull/5301 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c7093a1d7ed913dced2bf56b68389ae3fc1b8203a7e49300f1198618f163a548/python/mypy/pull/5301 |
| og:image:alt | With my refactoring in #5256, I realized that it would be pretty straightforward to give some nicer warnings if site-packages were in any of the PATHs. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | emmatyping |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/5301#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5301 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5301 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/5301 |
| Reload | https://github.com/python/mypy/pull/5301 |
| Reload | https://github.com/python/mypy/pull/5301 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| emmatyping:clean-site | https://github.com/emmatyping/mypy/tree/clean-site |
| Conversation | https://github.com/python/mypy/pull/5301 |
| Commits3 (3) | https://github.com/python/mypy/pull/5301/commits |
| Checks | https://github.com/python/mypy/pull/5301/checks |
| Files changed | https://github.com/python/mypy/pull/5301/files |
| Fail fast if site-packages are in the path | https://github.com/python/mypy/pull/5301#top |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| emmatyping:clean-site | https://github.com/emmatyping/mypy/tree/clean-site |
|
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| Jun 29, 2018 | https://github.com/python/mypy/pull/5301#issue-337144753 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| #5256 | https://github.com/python/mypy/pull/5256 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
|
| https://github.com/emmatyping |
| Fail fast if site-packages are in the path | https://github.com/python/mypy/pull/5301/commits/783faad1c4022948d75b10921e8d8bcbd0c42264 |
| 783faad | https://github.com/python/mypy/pull/5301/commits/783faad1c4022948d75b10921e8d8bcbd0c42264 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Jun 29, 2018
| https://github.com/python/mypy/pull/5301#pullrequestreview-133386822 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5301/files/783faad1c4022948d75b10921e8d8bcbd0c42264 |
| mypy/build.py | https://github.com/python/mypy/pull/5301/files/783faad1c4022948d75b10921e8d8bcbd0c42264#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Jun 29, 2018 | https://github.com/python/mypy/pull/5301#discussion_r199287573 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| mypy/build.py | https://github.com/python/mypy/pull/5301/files/783faad1c4022948d75b10921e8d8bcbd0c42264#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Jun 29, 2018 | https://github.com/python/mypy/pull/5301#discussion_r199287843 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| emmatyping | https://github.com/emmatyping |
| Jun 29, 2018 | https://github.com/python/mypy/pull/5301#discussion_r199293792 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
|
| https://github.com/emmatyping |
| Respond to feedback | https://github.com/python/mypy/pull/5301/commits/01a6f4bc6fb0d190e408a9a6ddd9dce9f0cd6113 |
| 01a6f4b | https://github.com/python/mypy/pull/5301/commits/01a6f4bc6fb0d190e408a9a6ddd9dce9f0cd6113 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Jun 30, 2018
| https://github.com/python/mypy/pull/5301#pullrequestreview-133415606 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5301/files/01a6f4bc6fb0d190e408a9a6ddd9dce9f0cd6113 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/5301#pullrequestreview-133415606 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| mypy/build.py | https://github.com/python/mypy/pull/5301/files/01a6f4bc6fb0d190e408a9a6ddd9dce9f0cd6113#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Jun 30, 2018 | https://github.com/python/mypy/pull/5301#discussion_r199312947 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| mypy/build.py | https://github.com/python/mypy/pull/5301/files/01a6f4bc6fb0d190e408a9a6ddd9dce9f0cd6113#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Jun 30, 2018 | https://github.com/python/mypy/pull/5301#discussion_r199313000 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| mypy/build.py | https://github.com/python/mypy/pull/5301/files/01a6f4bc6fb0d190e408a9a6ddd9dce9f0cd6113#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Jun 30, 2018 | https://github.com/python/mypy/pull/5301#discussion_r199313017 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| emmatyping | https://github.com/emmatyping |
| Jun 30, 2018 | https://github.com/python/mypy/pull/5301#discussion_r199316009 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
|
| https://github.com/emmatyping |
| Make code cleaner | https://github.com/python/mypy/pull/5301/commits/df344738dd261846523d431e8d28a9db2d88b528 |
| df34473 | https://github.com/python/mypy/pull/5301/commits/df344738dd261846523d431e8d28a9db2d88b528 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| force-pushed | https://github.com/python/mypy/compare/90706daa49c75a2001a49d083e05654e853da1ce..df344738dd261846523d431e8d28a9db2d88b528 |
| 90706da | https://github.com/python/mypy/commit/90706daa49c75a2001a49d083e05654e853da1ce |
| df34473 | https://github.com/python/mypy/commit/df344738dd261846523d431e8d28a9db2d88b528 |
|
Compare
| https://github.com/python/mypy/compare/90706daa49c75a2001a49d083e05654e853da1ce..df344738dd261846523d431e8d28a9db2d88b528 |
| June 30, 2018 07:34 | https://github.com/python/mypy/pull/5301#event-1709858395 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| Jun 30, 2018 | https://github.com/python/mypy/pull/5301#issuecomment-401524213 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Jun 30, 2018
| https://github.com/python/mypy/pull/5301#pullrequestreview-133435699 |
|
View reviewed changes
| https://github.com/python/mypy/pull/5301/files/df344738dd261846523d431e8d28a9db2d88b528 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/5301#pullrequestreview-133435699 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| 047c2c3 | https://github.com/python/mypy/commit/047c2c3f963dff22dca47c65342544f734c4a2e3 |
| Jun 30, 2018 | https://github.com/python/mypy/pull/5301#event-1710069772 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
|
Jul 5, 2018
| https://github.com/python/mypy/pull/5301#ref-pullrequest-338342655 |
|
Fix running mypy from editable install directory
#5318
| https://github.com/python/mypy/pull/5318 |
| https://github.com/sbrunner |
| sbrunner | https://github.com/sbrunner |
| Jul 16, 2018 | https://github.com/python/mypy/pull/5301#issuecomment-405283385 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jul 16, 2018 | https://github.com/python/mypy/pull/5301#issuecomment-405290843 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| https://github.com/sbrunner |
| sbrunner | https://github.com/sbrunner |
| Jul 17, 2018 | https://github.com/python/mypy/pull/5301#issuecomment-405464775 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| July 17, 2018 05:40 | https://github.com/python/mypy/pull/5301#event-1736819366 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| Jul 17, 2018 | https://github.com/python/mypy/pull/5301#issuecomment-405466068 |
| https://mypy.readthedocs.io/en/latest/installed_packages.html | https://mypy.readthedocs.io/en/latest/installed_packages.html |
| Gitter chat | https://gitter.im/python/typing?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| https://github.com/sbrunner |
| sbrunner | https://github.com/sbrunner |
| Jul 17, 2018 | https://github.com/python/mypy/pull/5301#issuecomment-405470040 |
| @ethanhs | https://github.com/ethanhs |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
|
Aug 21, 2018
| https://github.com/python/mypy/pull/5301#ref-issue-243516888 |
|
Fail fast when attempting to typecheck typing.py
#3725
| https://github.com/python/mypy/issues/3725 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5301 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/5301/files/df344738dd261846523d431e8d28a9db2d88b528 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
| Please reload this page | https://github.com/python/mypy/pull/5301 |
|
| https://github.com/emmatyping |
|
| https://github.com/sbrunner |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |