René's URL Explorer Experiment


Title: Make overload impl checks correctly handle TypeVars and untyped impls by Michael0x2a · Pull Request #5236 · python/mypy · GitHub

Open Graph Title: Make overload impl checks correctly handle TypeVars and untyped impls by Michael0x2a · Pull Request #5236 · python/mypy

X Title: Make overload impl checks correctly handle TypeVars and untyped impls by Michael0x2a · Pull Request #5236 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This pull request fixes #4619 as well as an unrelated bug where if the overload implementation was untyped, we only check to see if there are unsafe overlaps between the first overload alternative ...

X Description: This pull request fixes #4619 as well as an unrelated bug where if the overload implementation was untyped, we only check to see if there are unsafe overlaps between the first overload alternative ...

Opengraph URL: https://github.com/python/mypy/pull/5236

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b062f054-6aa2-d954-7bc0-d3fb22dee361
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9AA:2D8919:6614C9:88E2DD:6B0035EF
html-safe-nonce1da088d75fc835aad82036aa4bee2f18f5b3bbfb10409e40af2779bc3b92c4a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUFBOjJEODkxOTo2NjE0Qzk6ODhFMkREOjZCMDAzNUVGIiwidmlzaXRvcl9pZCI6IjkwMTc4MDgyNzY3Mjg4NTM5OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac280b21807f064c29ec255f9318704994886a70e0508006e819b9be2e5a55248b
hovercard-subject-tagpull_request:195704572
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/5236/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/614e85b554475b92eeefd175525b06b6f82f61c5d360ad3eb602ccc39d3d34fd/python/mypy/pull/5236
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/614e85b554475b92eeefd175525b06b6f82f61c5d360ad3eb602ccc39d3d34fd/python/mypy/pull/5236
og:image:altThis pull request fixes #4619 as well as an unrelated bug where if the overload implementation was untyped, we only check to see if there are unsafe overlaps between the first overload alternative ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/5236#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5236
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5236
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5236
Reloadhttps://github.com/python/mypy/pull/5236
Reloadhttps://github.com/python/mypy/pull/5236
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:fix-overloads-impl-checkshttps://github.com/Michael0x2a/mypy/tree/fix-overloads-impl-checks
Conversationhttps://github.com/python/mypy/pull/5236
Commits2 (2)https://github.com/python/mypy/pull/5236/commits
Checkshttps://github.com/python/mypy/pull/5236/checks
Files changedhttps://github.com/python/mypy/pull/5236/files
Make overload impl checks correctly handle TypeVars and untyped implshttps://github.com/python/mypy/pull/5236#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:fix-overloads-impl-checkshttps://github.com/Michael0x2a/mypy/tree/fix-overloads-impl-checks
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jun 19, 2018https://github.com/python/mypy/pull/5236#issue-333509225
#4619https://github.com/python/mypy/issues/4619
Please reload this pagehttps://github.com/python/mypy/pull/5236
https://github.com/Michael0x2a
Make overload impl checks correctly handle TypeVars and untyped implshttps://github.com/python/mypy/pull/5236/commits/2d604fa9dec8d3a4924feef0d35fbc402f652301
2d604fahttps://github.com/python/mypy/pull/5236/commits/2d604fa9dec8d3a4924feef0d35fbc402f652301
python#4619https://github.com/python/mypy/issues/4619
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
force-pushedhttps://github.com/python/mypy/compare/69b06a5d159e6b8daac5724b32578258aff22a81..2d604fa9dec8d3a4924feef0d35fbc402f652301
69b06a5https://github.com/python/mypy/commit/69b06a5d159e6b8daac5724b32578258aff22a81
2d604fahttps://github.com/python/mypy/commit/2d604fa9dec8d3a4924feef0d35fbc402f652301
Compare https://github.com/python/mypy/compare/69b06a5d159e6b8daac5724b32578258aff22a81..2d604fa9dec8d3a4924feef0d35fbc402f652301
June 21, 2018 20:13https://github.com/python/mypy/pull/5236#event-1694563798
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
ilevkivskyihttps://github.com/ilevkivskyi
June 21, 2018 20:50https://github.com/python/mypy/pull/5236#event-1694637179
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jun 21, 2018https://github.com/python/mypy/pull/5236#event-1694816595
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jun 25, 2018 https://github.com/python/mypy/pull/5236#pullrequestreview-131531538
View reviewed changes https://github.com/python/mypy/pull/5236/files/2d604fa9dec8d3a4924feef0d35fbc402f652301
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5236#pullrequestreview-131531538
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5236
mypy/checker.pyhttps://github.com/python/mypy/pull/5236/files/2d604fa9dec8d3a4924feef0d35fbc402f652301#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Jun 25, 2018https://github.com/python/mypy/pull/5236#discussion_r197732918
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5236
Michael0x2ahttps://github.com/Michael0x2a
Jun 25, 2018https://github.com/python/mypy/pull/5236#discussion_r197901559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5236
https://github.com/Michael0x2a
Remove unify_generics parameterhttps://github.com/python/mypy/pull/5236/commits/3ddaa6638562e308c6fafb88b900e3b2012c25f8
3ddaa66https://github.com/python/mypy/pull/5236/commits/3ddaa6638562e308c6fafb88b900e3b2012c25f8
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jun 25, 2018 https://github.com/python/mypy/pull/5236#pullrequestreview-131784424
View reviewed changes https://github.com/python/mypy/pull/5236/files/3ddaa6638562e308c6fafb88b900e3b2012c25f8
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5236#pullrequestreview-131784424
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/5236
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
c5de2fdhttps://github.com/python/mypy/commit/c5de2fd7caaebd0f4b79008586c49de0243e3ca0
Jun 25, 2018https://github.com/python/mypy/pull/5236#event-1699971315
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
June 26, 2018 06:42https://github.com/python/mypy/pull/5236#event-1700573704
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5236
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/5236/files/3ddaa6638562e308c6fafb88b900e3b2012c25f8
Please reload this pagehttps://github.com/python/mypy/pull/5236
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
Errors when using overloaded functions and type variables https://github.com/python/mypy/issues/4619
Please reload this pagehttps://github.com/python/mypy/pull/5236
https://github.com/Michael0x2a
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.