Title: Fix crash in astdiff.py related to ec11a500f. by whiten · Pull Request #5126 · python/mypy · GitHub
Open Graph Title: Fix crash in astdiff.py related to ec11a500f. by whiten · Pull Request #5126 · python/mypy
X Title: Fix crash in astdiff.py related to ec11a500f. by whiten · Pull Request #5126 · python/mypy
Description: I had been seeing the same crash that patch aimed to fix running against Quip's codebase, but have been unable to reduce it to a test case. With this patch, we're now able to use dmypy. Traceback from crash after ec11a50: File "/usr/local/lib/python3.6/site-packages/mypy/server/update.py", line 760, in propagate_changes_using_dependencies triggered |= reprocess_nodes(manager, graph, id, nodes, deps) File "/usr/local/lib/python3.6/site-packages/mypy/server/update.py", line 920, in reprocess_nodes new_symbols_snapshot = snapshot_symbol_table(file_node.fullname(), file_node.names) File "/usr/local/lib/python3.6/site-packages/mypy/server/astdiff.py", line 159, in snapshot_symbol_table result[name] = snapshot_definition(node, common) File "/usr/local/lib/python3.6/site-packages/mypy/server/astdiff.py", line 214, in snapshot_definition symbol_table = snapshot_symbol_table(prefix, node.names) File "/usr/local/lib/python3.6/site-packages/mypy/server/astdiff.py", line 154, in snapshot_symbol_table assert symbol.kind != UNBOUND_IMPORTED
Open Graph Description: I had been seeing the same crash that patch aimed to fix running against Quip's codebase, but have been unable to reduce it to a test case. With this patch, we're now able to use dmypy. Tra...
X Description: I had been seeing the same crash that patch aimed to fix running against Quip's codebase, but have been unable to reduce it to a test case. With this patch, we're now able to use dm...
Opengraph URL: https://github.com/python/mypy/pull/5126
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5569b451-6f2f-1683-209b-bd5409c96386 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B4A4:106F5D:F3BF1:14906B:6B001DA4 |
| html-safe-nonce | a98a3b167706067cf6c9b2c725230c55e6376eeb1b6cf840a9888a610530cc71 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEE0OjEwNkY1RDpGM0JGMToxNDkwNkI6NkIwMDFEQTQiLCJ2aXNpdG9yX2lkIjoiMjkxNzUyMzgzNTE2OTI4MzQ5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bee1ae90e500685a1788873df9615885bf8a4d581852da003519f888b0d1b8ef |
| hovercard-subject-tag | pull_request:191613994 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/mypy/pull/5126/files |
| twitter:image | https://avatars.githubusercontent.com/u/162028?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/162028?s=400&v=4 |
| og:image:alt | I had been seeing the same crash that patch aimed to fix running against Quip's codebase, but have been unable to reduce it to a test case. With this patch, we're now able to use dmypy. Tra... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width