René's URL Explorer Experiment


Title: Fix crash in astdiff.py related to ec11a500f. by whiten · Pull Request #5126 · python/mypy · GitHub

Open Graph Title: Fix crash in astdiff.py related to ec11a500f. by whiten · Pull Request #5126 · python/mypy

X Title: Fix crash in astdiff.py related to ec11a500f. by whiten · Pull Request #5126 · python/mypy

Description: I had been seeing the same crash that patch aimed to fix running against Quip's codebase, but have been unable to reduce it to a test case. With this patch, we're now able to use dmypy. Traceback from crash after ec11a50: File "/usr/local/lib/python3.6/site-packages/mypy/server/update.py", line 760, in propagate_changes_using_dependencies triggered |= reprocess_nodes(manager, graph, id, nodes, deps) File "/usr/local/lib/python3.6/site-packages/mypy/server/update.py", line 920, in reprocess_nodes new_symbols_snapshot = snapshot_symbol_table(file_node.fullname(), file_node.names) File "/usr/local/lib/python3.6/site-packages/mypy/server/astdiff.py", line 159, in snapshot_symbol_table result[name] = snapshot_definition(node, common) File "/usr/local/lib/python3.6/site-packages/mypy/server/astdiff.py", line 214, in snapshot_definition symbol_table = snapshot_symbol_table(prefix, node.names) File "/usr/local/lib/python3.6/site-packages/mypy/server/astdiff.py", line 154, in snapshot_symbol_table assert symbol.kind != UNBOUND_IMPORTED

Open Graph Description: I had been seeing the same crash that patch aimed to fix running against Quip's codebase, but have been unable to reduce it to a test case. With this patch, we're now able to use dmypy. Tra...

X Description: I had been seeing the same crash that patch aimed to fix running against Quip's codebase, but have been unable to reduce it to a test case. With this patch, we're now able to use dm...

Opengraph URL: https://github.com/python/mypy/pull/5126

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5569b451-6f2f-1683-209b-bd5409c96386
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4A4:106F5D:F3BF1:14906B:6B001DA4
html-safe-noncea98a3b167706067cf6c9b2c725230c55e6376eeb1b6cf840a9888a610530cc71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEE0OjEwNkY1RDpGM0JGMToxNDkwNkI6NkIwMDFEQTQiLCJ2aXNpdG9yX2lkIjoiMjkxNzUyMzgzNTE2OTI4MzQ5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbee1ae90e500685a1788873df9615885bf8a4d581852da003519f888b0d1b8ef
hovercard-subject-tagpull_request:191613994
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/5126/files
twitter:imagehttps://avatars.githubusercontent.com/u/162028?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/162028?s=400&v=4
og:image:altI had been seeing the same crash that patch aimed to fix running against Quip's codebase, but have been unable to reduce it to a test case. With this patch, we're now able to use dmypy. Tra...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/5126/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5126%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F5126%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/5126/files
Reloadhttps://github.com/python/mypy/pull/5126/files
Reloadhttps://github.com/python/mypy/pull/5126/files
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
msullivanhttps://github.com/msullivan
python:masterhttps://github.com/python/mypy/tree/master
whiten:astdiff-crashhttps://github.com/whiten/mypy/tree/astdiff-crash
Conversation 2 https://github.com/python/mypy/pull/5126
Commits 1 https://github.com/python/mypy/pull/5126/commits
Checks 0 https://github.com/python/mypy/pull/5126/checks
Files changed https://github.com/python/mypy/pull/5126/files
Please reload this pagehttps://github.com/python/mypy/pull/5126/files
Fix crash in astdiff.py related to ec11a500f. https://github.com/python/mypy/pull/5126/files#top
Show all changes 1 commit https://github.com/python/mypy/pull/5126/files
0712de0 Fix crash in astdiff.py related to ec11a500f. May 31, 2018 https://github.com/python/mypy/pull/5126/commits/0712de0ff1cef1f7312a94c5e5625d8c6696528e
Clear filters https://github.com/python/mypy/pull/5126/files
Please reload this pagehttps://github.com/python/mypy/pull/5126/files
Please reload this pagehttps://github.com/python/mypy/pull/5126/files
mypy/server/aststrip.pyhttps://github.com/python/mypy/pull/5126/files#diff-358456e557f2d89682e2d5eac6620eac78128785f28c23f4cc7d2f35e9da8a66
View file https://github.com/whiten/mypy/blob/0712de0ff1cef1f7312a94c5e5625d8c6696528e/mypy/server/aststrip.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/5126/{{ revealButtonHref }}
https://github.com/python/mypy/pull/5126/files#diff-358456e557f2d89682e2d5eac6620eac78128785f28c23f4cc7d2f35e9da8a66
https://github.com/python/mypy/pull/5126/files#diff-358456e557f2d89682e2d5eac6620eac78128785f28c23f4cc7d2f35e9da8a66
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.