René's URL Explorer Experiment


Title: Refactor import diagnostics, fix diagnostics in some fine-grained cases by msullivan · Pull Request #4840 · python/mypy · GitHub

Open Graph Title: Refactor import diagnostics, fix diagnostics in some fine-grained cases by msullivan · Pull Request #4840 · python/mypy

X Title: Refactor import diagnostics, fix diagnostics in some fine-grained cases by msullivan · Pull Request #4840 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Refactor all of the import diagnostics so that they can be used outside of State's __init__ method. Then use that to fix some problems with import diagnostics in fine-grained mode. Fixes #4798....

X Description: Refactor all of the import diagnostics so that they can be used outside of State's __init__ method. Then use that to fix some problems with import diagnostics in fine-grained mode. Fixes #4...

Opengraph URL: https://github.com/python/mypy/pull/4840

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a510c160-ad9a-4a9c-a067-bd411f76701d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE77A:2A087:5A5D85:78C961:6B00339B
html-safe-noncea1b9db0b8184fe87e32541c47c063cb793203b3cded7dc16a433620f6f5a8a01
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzdBOjJBMDg3OjVBNUQ4NTo3OEM5NjE6NkIwMDMzOUIiLCJ2aXNpdG9yX2lkIjoiNjQ5NTIxMDUwMDE1Mjg5ODQ1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3ebd9a7f01fab252202f3fd58533d1665c0ac66eef91226c70ddc6f734f2f3cf
hovercard-subject-tagpull_request:178945273
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4840/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/43dfccb99e60174b1d2258ffb8e9892ccd9ac09aac9099bc52be8ebcb6ae8812/python/mypy/pull/4840
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43dfccb99e60174b1d2258ffb8e9892ccd9ac09aac9099bc52be8ebcb6ae8812/python/mypy/pull/4840
og:image:altRefactor all of the import diagnostics so that they can be used outside of State's __init__ method. Then use that to fix some problems with import diagnostics in fine-grained mode. Fixes #4798....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsullivan
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/4840#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4840
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4840
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/4840
Reloadhttps://github.com/python/mypy/pull/4840
Reloadhttps://github.com/python/mypy/pull/4840
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
msullivanhttps://github.com/msullivan
masterhttps://github.com/python/mypy/tree/master
module-loadinghttps://github.com/python/mypy/tree/module-loading
Conversationhttps://github.com/python/mypy/pull/4840
Commits4 (4)https://github.com/python/mypy/pull/4840/commits
Checkshttps://github.com/python/mypy/pull/4840/checks
Files changedhttps://github.com/python/mypy/pull/4840/files
Refactor import diagnostics, fix diagnostics in some fine-grained caseshttps://github.com/python/mypy/pull/4840#top
msullivanhttps://github.com/msullivan
masterhttps://github.com/python/mypy/tree/master
module-loadinghttps://github.com/python/mypy/tree/module-loading
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Apr 2, 2018https://github.com/python/mypy/pull/4840#issue-310627324
#4798https://github.com/python/mypy/issues/4798
Please reload this pagehttps://github.com/python/mypy/pull/4840
msullivanhttps://github.com/msullivan
April 2, 2018 13:59https://github.com/python/mypy/pull/4840#commits-pushed-37677b3
https://github.com/msullivan
Pull missing module diagnostic messages out of BuildManager and Statehttps://github.com/python/mypy/pull/4840/commits/37677b39f7fd8c7f91dc809a5e2217eda9983eb0
37677b3https://github.com/python/mypy/pull/4840/commits/37677b39f7fd8c7f91dc809a5e2217eda9983eb0
https://github.com/msullivan
Refactor most of the import following logic out of State's __init__https://github.com/python/mypy/pull/4840/commits/4fb532ecbcdb2abbdd42c17caec31dc061aa7cb7
4fb532ehttps://github.com/python/mypy/pull/4840/commits/4fb532ecbcdb2abbdd42c17caec31dc061aa7cb7
https://github.com/msullivan
Fix some fine-grained module error message bugshttps://github.com/python/mypy/pull/4840/commits/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30
63ba7d9https://github.com/python/mypy/pull/4840/commits/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30
https://github.com/msullivan
msullivanhttps://github.com/msullivan
JukkaLhttps://github.com/JukkaL
gvanrossumhttps://github.com/gvanrossum
April 2, 2018 22:06https://github.com/python/mypy/pull/4840#event-1552848840
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Apr 2, 2018 https://github.com/python/mypy/pull/4840#ref-pullrequest-310632574
Don't produce spurious unused type ignore messages in incremental mode #4841 https://github.com/python/mypy/pull/4841
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 3, 2018 https://github.com/python/mypy/pull/4840#ref-issue-310623728
Release 0.590 planning #4839 https://github.com/python/mypy/issues/4839
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Apr 3, 2018 https://github.com/python/mypy/pull/4840#pullrequestreview-108986451
View reviewed changes https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/4840#pullrequestreview-108986451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
JukkaLhttps://github.com/JukkaL
Apr 3, 2018https://github.com/python/mypy/pull/4840#discussion_r178855606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
JukkaLhttps://github.com/JukkaL
Apr 3, 2018https://github.com/python/mypy/pull/4840#discussion_r178858574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
JukkaLhttps://github.com/JukkaL
Apr 3, 2018https://github.com/python/mypy/pull/4840#discussion_r178858690
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
JukkaLhttps://github.com/JukkaL
Apr 3, 2018https://github.com/python/mypy/pull/4840#discussion_r178861477
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
test-data/unit/fine-grained-modules.testhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-d9b66311ef91ac316443c7260ef1bd797213e887adfbc47ed56691a4333ef7a4
JukkaLhttps://github.com/JukkaL
Apr 3, 2018https://github.com/python/mypy/pull/4840#discussion_r178862711
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
test-data/unit/fine-grained-modules.testhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-d9b66311ef91ac316443c7260ef1bd797213e887adfbc47ed56691a4333ef7a4
JukkaLhttps://github.com/JukkaL
Apr 3, 2018https://github.com/python/mypy/pull/4840#discussion_r178863296
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
test-data/unit/fine-grained-modules.testhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-d9b66311ef91ac316443c7260ef1bd797213e887adfbc47ed56691a4333ef7a4
JukkaLhttps://github.com/JukkaL
Apr 3, 2018https://github.com/python/mypy/pull/4840#discussion_r178863623
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 3, 2018 https://github.com/python/mypy/pull/4840#pullrequestreview-108762636
View reviewed changes https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/4840#pullrequestreview-108762636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Apr 2, 2018https://github.com/python/mypy/pull/4840#discussion_r178667338
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Apr 2, 2018https://github.com/python/mypy/pull/4840#discussion_r178667578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Apr 2, 2018https://github.com/python/mypy/pull/4840#discussion_r178667621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Apr 2, 2018https://github.com/python/mypy/pull/4840#discussion_r178669209
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
msullivanhttps://github.com/msullivan
Apr 3, 2018https://github.com/python/mypy/pull/4840#discussion_r178935161
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Apr 2, 2018https://github.com/python/mypy/pull/4840#discussion_r178669920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
mypy/build.pyhttps://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Apr 2, 2018https://github.com/python/mypy/pull/4840#discussion_r178672759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4840
https://github.com/msullivan
address commentshttps://github.com/python/mypy/pull/4840/commits/6c5755088ef0a423576a5164321c657b86897d52
6c57550https://github.com/python/mypy/pull/4840/commits/6c5755088ef0a423576a5164321c657b86897d52
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 3, 2018 https://github.com/python/mypy/pull/4840#pullrequestreview-109127629
View reviewed changes https://github.com/python/mypy/pull/4840/files/6c5755088ef0a423576a5164321c657b86897d52
https://github.com/msullivan
msullivanhttps://github.com/msullivan
db02926https://github.com/python/mypy/commit/db02926e5a1f4e58ba8fff60568d36da57b9c0a5
Apr 3, 2018https://github.com/python/mypy/pull/4840#event-1555209765
https://github.com/msullivan
msullivanhttps://github.com/msullivan
April 4, 2018 00:06https://github.com/python/mypy/pull/4840#event-1555350150
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4840
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/4840/files/6c5755088ef0a423576a5164321c657b86897d52
Please reload this pagehttps://github.com/python/mypy/pull/4840
Fine-grained mode doesn't properly respect --follow-imports settings when producing error messages https://github.com/python/mypy/issues/4798
Please reload this pagehttps://github.com/python/mypy/pull/4840
https://github.com/msullivan
https://github.com/JukkaL
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.