| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a510c160-ad9a-4a9c-a067-bd411f76701d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E77A:2A087:5A5D85:78C961:6B00339B |
| html-safe-nonce | a1b9db0b8184fe87e32541c47c063cb793203b3cded7dc16a433620f6f5a8a01 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzdBOjJBMDg3OjVBNUQ4NTo3OEM5NjE6NkIwMDMzOUIiLCJ2aXNpdG9yX2lkIjoiNjQ5NTIxMDUwMDE1Mjg5ODQ1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3ebd9a7f01fab252202f3fd58533d1665c0ac66eef91226c70ddc6f734f2f3cf |
| hovercard-subject-tag | pull_request:178945273 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4840/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/43dfccb99e60174b1d2258ffb8e9892ccd9ac09aac9099bc52be8ebcb6ae8812/python/mypy/pull/4840 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43dfccb99e60174b1d2258ffb8e9892ccd9ac09aac9099bc52be8ebcb6ae8812/python/mypy/pull/4840 |
| og:image:alt | Refactor all of the import diagnostics so that they can be used
outside of State's __init__ method.
Then use that to fix some problems with import diagnostics in fine-grained mode.
Fixes #4798.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | msullivan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/4840#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4840 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4840 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/4840 |
| Reload | https://github.com/python/mypy/pull/4840 |
| Reload | https://github.com/python/mypy/pull/4840 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| msullivan | https://github.com/msullivan |
| master | https://github.com/python/mypy/tree/master |
| module-loading | https://github.com/python/mypy/tree/module-loading |
| Conversation | https://github.com/python/mypy/pull/4840 |
| Commits4 (4) | https://github.com/python/mypy/pull/4840/commits |
| Checks | https://github.com/python/mypy/pull/4840/checks |
| Files changed | https://github.com/python/mypy/pull/4840/files |
| Refactor import diagnostics, fix diagnostics in some fine-grained cases | https://github.com/python/mypy/pull/4840#top |
| msullivan | https://github.com/msullivan |
| master | https://github.com/python/mypy/tree/master |
| module-loading | https://github.com/python/mypy/tree/module-loading |
|
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| Apr 2, 2018 | https://github.com/python/mypy/pull/4840#issue-310627324 |
| #4798 | https://github.com/python/mypy/issues/4798 |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| msullivan | https://github.com/msullivan |
| April 2, 2018 13:59 | https://github.com/python/mypy/pull/4840#commits-pushed-37677b3 |
|
| https://github.com/msullivan |
| Pull missing module diagnostic messages out of BuildManager and State | https://github.com/python/mypy/pull/4840/commits/37677b39f7fd8c7f91dc809a5e2217eda9983eb0 |
| 37677b3 | https://github.com/python/mypy/pull/4840/commits/37677b39f7fd8c7f91dc809a5e2217eda9983eb0 |
|
| https://github.com/msullivan |
| Refactor most of the import following logic out of State's __init__ | https://github.com/python/mypy/pull/4840/commits/4fb532ecbcdb2abbdd42c17caec31dc061aa7cb7 |
| 4fb532e | https://github.com/python/mypy/pull/4840/commits/4fb532ecbcdb2abbdd42c17caec31dc061aa7cb7 |
|
| https://github.com/msullivan |
| Fix some fine-grained module error message bugs | https://github.com/python/mypy/pull/4840/commits/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30 |
| 63ba7d9 | https://github.com/python/mypy/pull/4840/commits/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| JukkaL | https://github.com/JukkaL |
| gvanrossum | https://github.com/gvanrossum |
| April 2, 2018 22:06 | https://github.com/python/mypy/pull/4840#event-1552848840 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Apr 2, 2018
| https://github.com/python/mypy/pull/4840#ref-pullrequest-310632574 |
|
Don't produce spurious unused type ignore messages in incremental mode
#4841
| https://github.com/python/mypy/pull/4841 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Apr 3, 2018
| https://github.com/python/mypy/pull/4840#ref-issue-310623728 |
|
Release 0.590 planning
#4839
| https://github.com/python/mypy/issues/4839 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Apr 3, 2018
| https://github.com/python/mypy/pull/4840#pullrequestreview-108986451 |
|
View reviewed changes
| https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/4840#pullrequestreview-108986451 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| JukkaL | https://github.com/JukkaL |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178855606 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| JukkaL | https://github.com/JukkaL |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178858574 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| JukkaL | https://github.com/JukkaL |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178858690 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| JukkaL | https://github.com/JukkaL |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178861477 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| test-data/unit/fine-grained-modules.test | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-d9b66311ef91ac316443c7260ef1bd797213e887adfbc47ed56691a4333ef7a4 |
| JukkaL | https://github.com/JukkaL |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178862711 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| test-data/unit/fine-grained-modules.test | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-d9b66311ef91ac316443c7260ef1bd797213e887adfbc47ed56691a4333ef7a4 |
| JukkaL | https://github.com/JukkaL |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178863296 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| test-data/unit/fine-grained-modules.test | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-d9b66311ef91ac316443c7260ef1bd797213e887adfbc47ed56691a4333ef7a4 |
| JukkaL | https://github.com/JukkaL |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178863623 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Apr 3, 2018
| https://github.com/python/mypy/pull/4840#pullrequestreview-108762636 |
|
View reviewed changes
| https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/4840#pullrequestreview-108762636 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Apr 2, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178667338 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Apr 2, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178667578 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Apr 2, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178667621 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Apr 2, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178669209 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| msullivan | https://github.com/msullivan |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178935161 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Apr 2, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178669920 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
| mypy/build.py | https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Apr 2, 2018 | https://github.com/python/mypy/pull/4840#discussion_r178672759 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
|
| https://github.com/msullivan |
| address comments | https://github.com/python/mypy/pull/4840/commits/6c5755088ef0a423576a5164321c657b86897d52 |
| 6c57550 | https://github.com/python/mypy/pull/4840/commits/6c5755088ef0a423576a5164321c657b86897d52 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Apr 3, 2018
| https://github.com/python/mypy/pull/4840#pullrequestreview-109127629 |
|
View reviewed changes
| https://github.com/python/mypy/pull/4840/files/6c5755088ef0a423576a5164321c657b86897d52 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| db02926 | https://github.com/python/mypy/commit/db02926e5a1f4e58ba8fff60568d36da57b9c0a5 |
| Apr 3, 2018 | https://github.com/python/mypy/pull/4840#event-1555209765 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| April 4, 2018 00:06 | https://github.com/python/mypy/pull/4840#event-1555350150 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4840 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/4840/files/63ba7d975b4fc8fefc8bd535b0fbd86a2f338e30 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/4840/files/6c5755088ef0a423576a5164321c657b86897d52 |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
|
Fine-grained mode doesn't properly respect --follow-imports settings when producing error messages
| https://github.com/python/mypy/issues/4798 |
| Please reload this page | https://github.com/python/mypy/pull/4840 |
|
| https://github.com/msullivan |
|
| https://github.com/JukkaL |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |