René's URL Explorer Experiment


Title: Fix issues related to indirect imports in import cycles by JukkaL · Pull Request #4695 · python/mypy · GitHub

Open Graph Title: Fix issues related to indirect imports in import cycles by JukkaL · Pull Request #4695 · python/mypy

X Title: Fix issues related to indirect imports in import cycles by JukkaL · Pull Request #4695 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This adds supports for some cases of importing an imported name within an import cycle. Originally they could result in false positives or false negatives. The idea is to use a new node type Import...

X Description: This adds supports for some cases of importing an imported name within an import cycle. Originally they could result in false positives or false negatives. The idea is to use a new node type Import...

Opengraph URL: https://github.com/python/mypy/pull/4695

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:65e8593b-d57b-6212-9f49-fb2f89581a4d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD39E:2A087:693026:8C8190:6B0037E4
html-safe-nonce9edc1bc4bf22e161fb0cf54b9358f3d4fce7021de8d065bb0eec3df6c72f1e27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzlFOjJBMDg3OjY5MzAyNjo4QzgxOTA6NkIwMDM3RTQiLCJ2aXNpdG9yX2lkIjoiMjQ3ODk0MjUyNzE2MDQ2MzA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac120b92f47474889ba006e205c3415e04c10fcea68044fc973092b189cdd6b7e9
hovercard-subject-tagpull_request:173500242
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4695/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c283b61821d144eba9d679c0a962bd7f70332815d5df56f50bdf5b9e0952bc0d/python/mypy/pull/4695
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c283b61821d144eba9d679c0a962bd7f70332815d5df56f50bdf5b9e0952bc0d/python/mypy/pull/4695
og:image:altThis adds supports for some cases of importing an imported name within an import cycle. Originally they could result in false positives or false negatives. The idea is to use a new node type Import...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJukkaL
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/4695#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4695
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4695
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/4695
Reloadhttps://github.com/python/mypy/pull/4695
Reloadhttps://github.com/python/mypy/pull/4695
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
imports-in-cycleshttps://github.com/python/mypy/tree/imports-in-cycles
Conversationhttps://github.com/python/mypy/pull/4695
Commits14 (14)https://github.com/python/mypy/pull/4695/commits
Checkshttps://github.com/python/mypy/pull/4695/checks
Files changedhttps://github.com/python/mypy/pull/4695/files
Fix issues related to indirect imports in import cycleshttps://github.com/python/mypy/pull/4695#top
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
imports-in-cycleshttps://github.com/python/mypy/tree/imports-in-cycles
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 7, 2018https://github.com/python/mypy/pull/4695#issue-303162277
Please reload this pagehttps://github.com/python/mypy/pull/4695
#4049https://github.com/python/mypy/issues/4049
#4429https://github.com/python/mypy/issues/4429
#4682https://github.com/python/mypy/issues/4682
#4495https://github.com/python/mypy/pull/4495
@carljmhttps://github.com/carljm
#4495https://github.com/python/mypy/pull/4495
#4495https://github.com/python/mypy/pull/4495
Please reload this pagehttps://github.com/python/mypy/pull/4695
JukkaLhttps://github.com/JukkaL
March 5, 2018 17:19https://github.com/python/mypy/pull/4695#commits-pushed-d29e316
https://github.com/JukkaL
Resolve more precise types for some imports in import cycleshttps://github.com/python/mypy/pull/4695/commits/d29e316043cc1a5ac404a1ad5bbebb3d3d9d280e
d29e316https://github.com/python/mypy/pull/4695/commits/d29e316043cc1a5ac404a1ad5bbebb3d3d9d280e
https://github.com/JukkaL
Fix crash on ignored __init__.py and add test caseshttps://github.com/python/mypy/pull/4695/commits/80b9e2052b07f92ce095e95680380e923722b596
80b9e20https://github.com/python/mypy/pull/4695/commits/80b9e2052b07f92ce095e95680380e923722b596
https://github.com/JukkaL
Fix type forward references in propertieshttps://github.com/python/mypy/pull/4695/commits/92d7cfc92d32ad08b3adfbd418d3cf9bdd883cfe
92d7cfchttps://github.com/python/mypy/pull/4695/commits/92d7cfc92d32ad08b3adfbd418d3cf9bdd883cfe
https://github.com/JukkaL
Refactoring: use abstract class instead of passing multiple callbackshttps://github.com/python/mypy/pull/4695/commits/e14578c20befaf3dce5f5215c5723037d7796ce3
e14578chttps://github.com/python/mypy/pull/4695/commits/e14578c20befaf3dce5f5215c5723037d7796ce3
https://github.com/JukkaL
Fix forward reference to typing alias importhttps://github.com/python/mypy/pull/4695/commits/de24b3c1e5d9fed448bcb0c53eb059fe77478126
de24b3chttps://github.com/python/mypy/pull/4695/commits/de24b3c1e5d9fed448bcb0c53eb059fe77478126
https://github.com/JukkaL
Also handle "from m import *"https://github.com/python/mypy/pull/4695/commits/c1b362904f674579ecb2225d2ac1f15cb6cab53c
c1b3629https://github.com/python/mypy/pull/4695/commits/c1b362904f674579ecb2225d2ac1f15cb6cab53c
https://github.com/JukkaL
Remove type forward reference handling to maintain backward compatibi…https://github.com/python/mypy/pull/4695/commits/68736fd3c22fb966fd39ebd7fee3e9a3450310b4
68736fdhttps://github.com/python/mypy/pull/4695/commits/68736fd3c22fb966fd39ebd7fee3e9a3450310b4
https://github.com/JukkaL
Add dereferencing on module attribute references like m.xhttps://github.com/python/mypy/pull/4695/commits/d138ec8318766d35bc29c1987b74ff4e6abb72ec
d138ec8https://github.com/python/mypy/pull/4695/commits/d138ec8318766d35bc29c1987b74ff4e6abb72ec
https://github.com/JukkaL
Handle more indirect references in type annotations and add testshttps://github.com/python/mypy/pull/4695/commits/aedd22054e98550b7ad25e1ef85fcc487cfb6935
aedd220https://github.com/python/mypy/pull/4695/commits/aedd22054e98550b7ad25e1ef85fcc487cfb6935
https://github.com/JukkaL
Update AST striphttps://github.com/python/mypy/pull/4695/commits/1625832ae4aac15b33936fa5acda462fb0b51ded
1625832https://github.com/python/mypy/pull/4695/commits/1625832ae4aac15b33936fa5acda462fb0b51ded
https://github.com/JukkaL
Fix type checkhttps://github.com/python/mypy/pull/4695/commits/ef7681f199d02fd7d29a528ace61bd6fc532b363
ef7681fhttps://github.com/python/mypy/pull/4695/commits/ef7681f199d02fd7d29a528ace61bd6fc532b363
https://github.com/JukkaL
Fix str() of ImportedNamehttps://github.com/python/mypy/pull/4695/commits/80917241d8351286ef1c9080b199a45bf981ef69
8091724https://github.com/python/mypy/pull/4695/commits/80917241d8351286ef1c9080b199a45bf981ef69
https://github.com/JukkaL
Alsohttps://github.com/python/mypy/pull/4695/commits/85129b110fe4b5e6eb10e07f49638deaa6e1111c
fixhttps://github.com/python/mypy/pull/4695/commits/85129b110fe4b5e6eb10e07f49638deaa6e1111c
#4429https://github.com/python/mypy/issues/4429
85129b1https://github.com/python/mypy/pull/4695/commits/85129b110fe4b5e6eb10e07f49638deaa6e1111c
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 7, 2018 https://github.com/python/mypy/pull/4695#ref-pullrequest-290169659
Don't error on re-exported imports in cycles. Fixes #4049. #4495 https://github.com/python/mypy/pull/4495
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 7, 2018 https://github.com/python/mypy/pull/4695#pullrequestreview-102066886
View reviewed changes https://github.com/python/mypy/pull/4695/files/85129b110fe4b5e6eb10e07f49638deaa6e1111c
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/4695#pullrequestreview-102066886
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
mypy/semanal.pyhttps://github.com/python/mypy/pull/4695/files/85129b110fe4b5e6eb10e07f49638deaa6e1111c#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
ilevkivskyihttps://github.com/ilevkivskyi
Mar 7, 2018https://github.com/python/mypy/pull/4695#discussion_r172959275
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
mypy/semanal.pyhttps://github.com/python/mypy/pull/4695/files/85129b110fe4b5e6eb10e07f49638deaa6e1111c#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
ilevkivskyihttps://github.com/ilevkivskyi
Mar 7, 2018https://github.com/python/mypy/pull/4695#discussion_r172960754
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
JukkaLhttps://github.com/JukkaL
Mar 8, 2018https://github.com/python/mypy/pull/4695#discussion_r173116352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
ilevkivskyihttps://github.com/ilevkivskyi
Mar 8, 2018https://github.com/python/mypy/pull/4695#discussion_r173117606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
mypy/semanal_pass3.pyhttps://github.com/python/mypy/pull/4695/files/85129b110fe4b5e6eb10e07f49638deaa6e1111c#diff-b1fea670293a2b323562cb1a0679df9b8e697f036c6cebe59f9951cf046029d6
ilevkivskyihttps://github.com/ilevkivskyi
Mar 7, 2018https://github.com/python/mypy/pull/4695#discussion_r172962326
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
JukkaLhttps://github.com/JukkaL
Mar 8, 2018https://github.com/python/mypy/pull/4695#discussion_r173120722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
mypy/types.pyhttps://github.com/python/mypy/pull/4695/files/85129b110fe4b5e6eb10e07f49638deaa6e1111c#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664
ilevkivskyihttps://github.com/ilevkivskyi
Mar 7, 2018https://github.com/python/mypy/pull/4695#discussion_r172963069
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
test-data/unit/check-modules.testhttps://github.com/python/mypy/pull/4695/files/85129b110fe4b5e6eb10e07f49638deaa6e1111c#diff-841b50838a13f5f73aa1699d00dbae63f0e4144cb0be0b8345af10acdb42e55f
ilevkivskyihttps://github.com/ilevkivskyi
Mar 7, 2018https://github.com/python/mypy/pull/4695#discussion_r172963992
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
JukkaLhttps://github.com/JukkaL
Mar 8, 2018https://github.com/python/mypy/pull/4695#discussion_r173121000
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 7, 2018https://github.com/python/mypy/pull/4695#issuecomment-371263363
#4682https://github.com/python/mypy/issues/4682
Please reload this pagehttps://github.com/python/mypy/pull/4695
https://github.com/JukkaL
Update based on feedbackhttps://github.com/python/mypy/pull/4695/commits/842b1c74325b9c61ec43a47806035034aefaddc9
842b1c7https://github.com/python/mypy/pull/4695/commits/842b1c74325b9c61ec43a47806035034aefaddc9
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 8, 2018 https://github.com/python/mypy/pull/4695#pullrequestreview-102264391
View reviewed changes https://github.com/python/mypy/pull/4695/files/842b1c74325b9c61ec43a47806035034aefaddc9
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/4695#pullrequestreview-102264391
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4695
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
0b7597chttps://github.com/python/mypy/commit/0b7597cebcfdbe038f02c1c123c164712ab47cd1
Mar 8, 2018https://github.com/python/mypy/pull/4695#event-1510935052
https://github.com/carljm
carljmhttps://github.com/carljm
Mar 8, 2018https://github.com/python/mypy/pull/4695#issuecomment-371567728
@JukkaLhttps://github.com/JukkaL
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/4695
Any type inferred for circular reference due to import cycle #3277 https://github.com/python/mypy/issues/3277
Unexpected Any for complex import structure #4110 https://github.com/python/mypy/issues/4110
Named tuples in import cycles still fail sometimes #4442 https://github.com/python/mypy/issues/4442
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
March 15, 2018 03:50https://github.com/python/mypy/pull/4695#event-1522429204
yedpodtrzitkohttps://github.com/yedpodtrzitko
Mar 15, 2018 https://github.com/python/mypy/pull/4695#ref-commit-e410bff
https://github.com/JukkaL
https://github.com/yedpodtrzitko
Fix issues related to indirect imports in import cycles (https://github.com/kiwicom/mypy/commit/e410bff096a3a0075cace933f93a2c9d7093cd4f
python#4695https://github.com/python/mypy/pull/4695
)https://github.com/kiwicom/mypy/commit/e410bff096a3a0075cace933f93a2c9d7093cd4f
e410bffhttps://github.com/kiwicom/mypy/commit/e410bff096a3a0075cace933f93a2c9d7093cd4f
python#4049https://github.com/python/mypy/issues/4049
python#4429https://github.com/python/mypy/issues/4429
python#4682https://github.com/python/mypy/issues/4682
python#4495https://github.com/python/mypy/pull/4495
@carljmhttps://github.com/carljm
python#4495https://github.com/python/mypy/pull/4495
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4695
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/4695/files/842b1c74325b9c61ec43a47806035034aefaddc9
Please reload this pagehttps://github.com/python/mypy/pull/4695
Crash when serializing property with forward reference https://github.com/python/mypy/issues/4682
Legal Python circular imports result in loss of type information https://github.com/python/mypy/issues/4429
Circular import + reexport = "error: Module '...' has no attribute '..."? https://github.com/python/mypy/issues/4049
Please reload this pagehttps://github.com/python/mypy/pull/4695
https://github.com/JukkaL
https://github.com/ilevkivskyi
https://github.com/carljm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.