René's URL Explorer Experiment


Title: Fine-grained: Support NewType and reset subtype caches by JukkaL · Pull Request #4656 · python/mypy · GitHub

Open Graph Title: Fine-grained: Support NewType and reset subtype caches by JukkaL · Pull Request #4656 · python/mypy

X Title: Fine-grained: Support NewType and reset subtype caches by JukkaL · Pull Request #4656 · python/mypy

Description: NewType work highlighted an issue with subtype caches with stale information leaking, and this fixes that issue as well. We reset the subtype cache in two places: When calculating the MRO; we reset caches of all base classes as well. When merging a new version of a TypeInfo, which may have a different MRO; we reset all caches of base classes in the old MRO, as they might no longer be supertypes.

Open Graph Description: NewType work highlighted an issue with subtype caches with stale information leaking, and this fixes that issue as well. We reset the subtype cache in two places: When calculating the MRO; we res...

X Description: NewType work highlighted an issue with subtype caches with stale information leaking, and this fixes that issue as well. We reset the subtype cache in two places: When calculating the MRO; we res...

Opengraph URL: https://github.com/python/mypy/pull/4656

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a31a13bc-77da-483e-93af-48b61f83e52b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABCE:30CC09:261AE81:339822F:6B0032EE
html-safe-nonced446d00d3fd407b4674a0f6b4ffa530dcf22814fd6feea7beba3cf072cd7c041
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkNFOjMwQ0MwOToyNjFBRTgxOjMzOTgyMkY6NkIwMDMyRUUiLCJ2aXNpdG9yX2lkIjoiMjQzNTE1NjI3MjkwMzg5Mzc0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6059533e20d029a6f16c5f66a8081bd321fb21c3ab40dac10e4ea22017421cca
hovercard-subject-tagpull_request:172234229
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/4656/files
twitter:imagehttps://avatars.githubusercontent.com/u/1107911?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1107911?s=400&v=4
og:image:altNewType work highlighted an issue with subtype caches with stale information leaking, and this fixes that issue as well. We reset the subtype cache in two places: When calculating the MRO; we res...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/4656/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4656%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4656%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/4656/files
Reloadhttps://github.com/python/mypy/pull/4656/files
Reloadhttps://github.com/python/mypy/pull/4656/files
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
fg-newtypehttps://github.com/python/mypy/tree/fg-newtype
Conversation 3 https://github.com/python/mypy/pull/4656
Commits 2 https://github.com/python/mypy/pull/4656/commits
Checks 0 https://github.com/python/mypy/pull/4656/checks
Files changed https://github.com/python/mypy/pull/4656/files
Please reload this pagehttps://github.com/python/mypy/pull/4656/files
Fine-grained: Support NewType and reset subtype caches https://github.com/python/mypy/pull/4656/files#top
Show all changes 2 commits https://github.com/python/mypy/pull/4656/files
8c6df2c Fine-grained: Support NewType and reset subtype caches JukkaL Mar 1, 2018 https://github.com/python/mypy/pull/4656/commits/8c6df2cb311d145c31d881a2c389359674237aed
a7c1fb0 Merge branch 'master' into fg-newtype JukkaL Mar 2, 2018 https://github.com/python/mypy/pull/4656/commits/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3
Clear filters https://github.com/python/mypy/pull/4656/files
Please reload this pagehttps://github.com/python/mypy/pull/4656/files
Please reload this pagehttps://github.com/python/mypy/pull/4656/files
checker.py https://github.com/python/mypy/pull/4656/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
nodes.py https://github.com/python/mypy/pull/4656/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
semanal.py https://github.com/python/mypy/pull/4656/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
astmerge.py https://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
deps.py https://github.com/python/mypy/pull/4656/files#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62
deps-statements.test https://github.com/python/mypy/pull/4656/files#diff-c04023415920ff9776919233ab94858697b1c9b01a1e660c2735eaa49405feef
diff.test https://github.com/python/mypy/pull/4656/files#diff-ec1b167c05d9b1e278ec94b42d4c972173cdeff2e33cc086270cf8026001431b
fine-grained.test https://github.com/python/mypy/pull/4656/files#diff-e165eb7aed9dca0a5ebd93985c8cd263a6462d36ac185f9461348dc5a1396d76
mypy/checker.pyhttps://github.com/python/mypy/pull/4656/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
View file https://github.com/python/mypy/blob/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3/mypy/checker.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/4656/{{ revealButtonHref }}
https://github.com/python/mypy/pull/4656/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
https://github.com/python/mypy/pull/4656/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
mypy/nodes.pyhttps://github.com/python/mypy/pull/4656/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
View file https://github.com/python/mypy/blob/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3/mypy/nodes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/4656/{{ revealButtonHref }}
https://github.com/python/mypy/pull/4656/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
https://github.com/python/mypy/pull/4656/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
https://github.com/python/mypy/pull/4656/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
msullivanhttps://github.com/msullivan
Mar 1, 2018https://github.com/python/mypy/pull/4656/files#r171690046
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4656/files
JukkaLhttps://github.com/JukkaL
Mar 2, 2018https://github.com/python/mypy/pull/4656/files#r171825785
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4656/files
https://github.com/python/mypy/pull/4656/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
mypy/semanal.pyhttps://github.com/python/mypy/pull/4656/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
View file https://github.com/python/mypy/blob/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3/mypy/semanal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/4656/{{ revealButtonHref }}
https://github.com/python/mypy/pull/4656/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
https://github.com/python/mypy/pull/4656/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
mypy/server/astmerge.pyhttps://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
View file https://github.com/python/mypy/blob/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3/mypy/server/astmerge.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/4656/{{ revealButtonHref }}
https://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
https://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
https://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
https://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
https://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
https://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
https://github.com/python/mypy/pull/4656/files#diff-c60c3b9f0d5e348d72dcd8b93e088cd0d503328de8141d6e9741e804ddccddfd
mypy/server/deps.pyhttps://github.com/python/mypy/pull/4656/files#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62
View file https://github.com/python/mypy/blob/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3/mypy/server/deps.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/4656/{{ revealButtonHref }}
https://github.com/python/mypy/pull/4656/files#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62
https://github.com/python/mypy/pull/4656/files#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62
https://github.com/python/mypy/pull/4656/files#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62
https://github.com/python/mypy/pull/4656/files#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62
https://github.com/python/mypy/pull/4656/files#diff-b8cc7d5fe51bcab020f102a3bfb493feb185665323e5c575e9e3708fc9591b62
test-data/unit/deps-statements.testhttps://github.com/python/mypy/pull/4656/files#diff-c04023415920ff9776919233ab94858697b1c9b01a1e660c2735eaa49405feef
View file https://github.com/python/mypy/blob/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3/test-data/unit/deps-statements.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/4656/{{ revealButtonHref }}
https://github.com/python/mypy/pull/4656/files#diff-c04023415920ff9776919233ab94858697b1c9b01a1e660c2735eaa49405feef
test-data/unit/diff.testhttps://github.com/python/mypy/pull/4656/files#diff-ec1b167c05d9b1e278ec94b42d4c972173cdeff2e33cc086270cf8026001431b
View file https://github.com/python/mypy/blob/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3/test-data/unit/diff.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/4656/{{ revealButtonHref }}
https://github.com/python/mypy/pull/4656/files#diff-ec1b167c05d9b1e278ec94b42d4c972173cdeff2e33cc086270cf8026001431b
https://github.com/python/mypy/pull/4656/files#diff-ec1b167c05d9b1e278ec94b42d4c972173cdeff2e33cc086270cf8026001431b
test-data/unit/fine-grained.testhttps://github.com/python/mypy/pull/4656/files#diff-e165eb7aed9dca0a5ebd93985c8cd263a6462d36ac185f9461348dc5a1396d76
View file https://github.com/python/mypy/blob/a7c1fb077e5ecd100c21be286fcb4112ef3ceca3/test-data/unit/fine-grained.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/4656/{{ revealButtonHref }}
https://github.com/python/mypy/pull/4656/files#diff-e165eb7aed9dca0a5ebd93985c8cd263a6462d36ac185f9461348dc5a1396d76
https://github.com/python/mypy/pull/4656/files#diff-e165eb7aed9dca0a5ebd93985c8cd263a6462d36ac185f9461348dc5a1396d76
https://github.com/python/mypy/pull/4656/files#diff-e165eb7aed9dca0a5ebd93985c8cd263a6462d36ac185f9461348dc5a1396d76
https://github.com/python/mypy/pull/4656/files#diff-e165eb7aed9dca0a5ebd93985c8cd263a6462d36ac185f9461348dc5a1396d76
https://github.com/python/mypy/pull/4656/files#diff-e165eb7aed9dca0a5ebd93985c8cd263a6462d36ac185f9461348dc5a1396d76
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.