René's URL Explorer Experiment


Title: Fine-grained: Fix AST merge issues by JukkaL · Pull Request #4652 · python/mypy · GitHub

Open Graph Title: Fine-grained: Fix AST merge issues by JukkaL · Pull Request #4652 · python/mypy

X Title: Fine-grained: Fix AST merge issues by JukkaL · Pull Request #4652 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This fixes all but one AST merge checker test failures. The remaining one seems tricky to fix so I'll leave it for later. I decided not to add tests for things that can be caught using the merg...

X Description: This fixes all but one AST merge checker test failures. The remaining one seems tricky to fix so I'll leave it for later. I decided not to add tests for things that can be caught using the ...

Opengraph URL: https://github.com/python/mypy/pull/4652

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3bbc413a-6c98-92ef-0d70-adfdbe11a087
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A98:2261EB:DFAAA1:122833E:6AFFED6D
html-safe-noncec3ddd6611dd55fd1319c7dc475e55a1295aa2a6ebed95884f2b268a306acd0ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTk4OjIyNjFFQjpERkFBQTE6MTIyODMzRTo2QUZGRUQ2RCIsInZpc2l0b3JfaWQiOiI4MDA5NjAwMzk1MTcxMDY1MTk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac11f42241f290364c1989f65695bf36b56aea969216293881769a7914ba7a3d59
hovercard-subject-tagpull_request:171971490
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4652/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fdf812fce97ab152ba195bb7c4e12c5b57d34f245cd7aa61e36e71319317ed2f/python/mypy/pull/4652
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fdf812fce97ab152ba195bb7c4e12c5b57d34f245cd7aa61e36e71319317ed2f/python/mypy/pull/4652
og:image:altThis fixes all but one AST merge checker test failures. The remaining one seems tricky to fix so I'll leave it for later. I decided not to add tests for things that can be caught using the merg...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJukkaL
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/4652#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4652
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4652
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/4652
Reloadhttps://github.com/python/mypy/pull/4652
Reloadhttps://github.com/python/mypy/pull/4652
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
fg-merge-fixeshttps://github.com/python/mypy/tree/fg-merge-fixes
Conversationhttps://github.com/python/mypy/pull/4652
Commits23 (23)https://github.com/python/mypy/pull/4652/commits
Checkshttps://github.com/python/mypy/pull/4652/checks
Files changedhttps://github.com/python/mypy/pull/4652/files
Fine-grained: Fix AST merge issueshttps://github.com/python/mypy/pull/4652#top
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
fg-merge-fixeshttps://github.com/python/mypy/tree/fg-merge-fixes
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Feb 28, 2018https://github.com/python/mypy/pull/4652#issue-301048068
Please reload this pagehttps://github.com/python/mypy/pull/4652
JukkaLhttps://github.com/JukkaL
February 28, 2018 10:28https://github.com/python/mypy/pull/4652#commits-pushed-f51cad0
https://github.com/JukkaL
Merge unanalyzed_type attribute of FuncDefshttps://github.com/python/mypy/pull/4652/commits/f51cad039c8e4d59616925baa390c1bf798854ff
f51cad0https://github.com/python/mypy/pull/4652/commits/f51cad039c8e4d59616925baa390c1bf798854ff
https://github.com/JukkaL
Fix merge of Var info attributes inside TypeInfoshttps://github.com/python/mypy/pull/4652/commits/1da9ba393c0cc4d5aa0d062d20670a958f98ad4e
1da9ba3https://github.com/python/mypy/pull/4652/commits/1da9ba393c0cc4d5aa0d062d20670a958f98ad4e
https://github.com/JukkaL
Fix TypeList types in AST mergehttps://github.com/python/mypy/pull/4652/commits/823445216fe93554cf5d13600a4b4e53343fa401
8234452https://github.com/python/mypy/pull/4652/commits/823445216fe93554cf5d13600a4b4e53343fa401
https://github.com/JukkaL
Fix AST merge of TypeAliasExpr nodeshttps://github.com/python/mypy/pull/4652/commits/4d51e0cbd30c7341052f39d61177d3fa90e5ee58
4d51e0chttps://github.com/python/mypy/pull/4652/commits/4d51e0cbd30c7341052f39d61177d3fa90e5ee58
https://github.com/JukkaL
Fix AST merge of NewType nodeshttps://github.com/python/mypy/pull/4652/commits/0f95792a2662cd5c6daea4ba301eb97153607387
0f95792https://github.com/python/mypy/pull/4652/commits/0f95792a2662cd5c6daea4ba301eb97153607387
https://github.com/JukkaL
Fix leak of old MypyFile objects in AST mergehttps://github.com/python/mypy/pull/4652/commits/49ea762c46cfc69521e81b7f68720a2c1453ee1f
49ea762https://github.com/python/mypy/pull/4652/commits/49ea762c46cfc69521e81b7f68720a2c1453ee1f
https://github.com/JukkaL
Fix merge of TypeVarExprhttps://github.com/python/mypy/pull/4652/commits/c71dff952f0668bad09a310041b96e64451995c8
c71dff9https://github.com/python/mypy/pull/4652/commits/c71dff952f0668bad09a310041b96e64451995c8
https://github.com/JukkaL
Fix AST merge of newtypeshttps://github.com/python/mypy/pull/4652/commits/a170a98db29294961f2c6fbdf113ee048d199aa5
a170a98https://github.com/python/mypy/pull/4652/commits/a170a98db29294961f2c6fbdf113ee048d199aa5
https://github.com/JukkaL
Fix AST merge of NamedTupleExprhttps://github.com/python/mypy/pull/4652/commits/ebf131a4a8b2e0b030ee1e8a295f848549a29583
ebf131ahttps://github.com/python/mypy/pull/4652/commits/ebf131a4a8b2e0b030ee1e8a295f848549a29583
https://github.com/JukkaL
Fix AST traverser special case (ClassDef.analyzed)https://github.com/python/mypy/pull/4652/commits/3d6a9c6e5dfe5cf65d072fe61a93db93cbb4d8f6
3d6a9c6https://github.com/python/mypy/pull/4652/commits/3d6a9c6e5dfe5cf65d072fe61a93db93cbb4d8f6
https://github.com/JukkaL
Fixes to AST merge of named tuples and typed dictshttps://github.com/python/mypy/pull/4652/commits/0f4902faf3670d9e2e9b300d804f4f50769ec7ee
0f4902fhttps://github.com/python/mypy/pull/4652/commits/0f4902faf3670d9e2e9b300d804f4f50769ec7ee
https://github.com/JukkaL
Don't retain stale AST nodes in semantic analyzerhttps://github.com/python/mypy/pull/4652/commits/6aa24611d8df6788d8cb7db7924daefed8bd2f2d
6aa2461https://github.com/python/mypy/pull/4652/commits/6aa24611d8df6788d8cb7db7924daefed8bd2f2d
https://github.com/JukkaL
Remove no longer needed attribute blacklist itemshttps://github.com/python/mypy/pull/4652/commits/d97486e5e134a525e2f836bb9fd0e800456cbd04
d97486ehttps://github.com/python/mypy/pull/4652/commits/d97486e5e134a525e2f836bb9fd0e800456cbd04
https://github.com/JukkaL
Don't collect all types in fine-grained incremental testshttps://github.com/python/mypy/pull/4652/commits/8acdf48a54f0a2d6fff4c2204aaa703959f4f7b4
8acdf48https://github.com/python/mypy/pull/4652/commits/8acdf48a54f0a2d6fff4c2204aaa703959f4f7b4
https://github.com/JukkaL
Add another AST merge fixuphttps://github.com/python/mypy/pull/4652/commits/aa98711abf558e432c71b02475e68a6f83b42a1e
aa98711https://github.com/python/mypy/pull/4652/commits/aa98711abf558e432c71b02475e68a6f83b42a1e
https://github.com/JukkaL
Fixes to AST merge; some refactoringhttps://github.com/python/mypy/pull/4652/commits/6638d77a81d6f50d6b309d5df5eab0590c200c61
6638d77https://github.com/python/mypy/pull/4652/commits/6638d77a81d6f50d6b309d5df5eab0590c200c61
https://github.com/JukkaL
Remove debug codehttps://github.com/python/mypy/pull/4652/commits/fe7672a6c71d02ebb57ba644d3ebc3d0139b1535
fe7672ahttps://github.com/python/mypy/pull/4652/commits/fe7672a6c71d02ebb57ba644d3ebc3d0139b1535
https://github.com/JukkaL
Fix merge test caseshttps://github.com/python/mypy/pull/4652/commits/ee7afa95e5ce0db31d7dc4d708ce9476f4770f4b
ee7afa9https://github.com/python/mypy/pull/4652/commits/ee7afa95e5ce0db31d7dc4d708ce9476f4770f4b
https://github.com/JukkaL
Fix type checkhttps://github.com/python/mypy/pull/4652/commits/7cb8a90ef4113b66c9648ea16234c1dd5760e8e7
7cb8a90https://github.com/python/mypy/pull/4652/commits/7cb8a90ef4113b66c9648ea16234c1dd5760e8e7
https://github.com/JukkaL
Remove redundant fixupshttps://github.com/python/mypy/pull/4652/commits/9757374968810a5d87235ec9d1fbc6c96ce8544b
9757374https://github.com/python/mypy/pull/4652/commits/9757374968810a5d87235ec9d1fbc6c96ce8544b
https://github.com/JukkaL
Merge additional TypeInfo attributes; minor refactoringhttps://github.com/python/mypy/pull/4652/commits/992317803a00040c3de53d2756fa285c3efd95de
9923178https://github.com/python/mypy/pull/4652/commits/992317803a00040c3de53d2756fa285c3efd95de
https://github.com/JukkaL
Fix test failurehttps://github.com/python/mypy/pull/4652/commits/008a9a80188425d0ec00042c1933a9f9f9d4ee79
008a9a8https://github.com/python/mypy/pull/4652/commits/008a9a80188425d0ec00042c1933a9f9f9d4ee79
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
msullivanhttps://github.com/msullivan
February 28, 2018 14:38https://github.com/python/mypy/pull/4652#event-1496848160
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Mar 1, 2018 https://github.com/python/mypy/pull/4652#pullrequestreview-100289407
View reviewed changes https://github.com/python/mypy/pull/4652/files/008a9a80188425d0ec00042c1933a9f9f9d4ee79
msullivanhttps://github.com/msullivan
https://github.com/python/mypy/pull/4652#pullrequestreview-100289407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4652
mypy/types.pyhttps://github.com/python/mypy/pull/4652/files/008a9a80188425d0ec00042c1933a9f9f9d4ee79#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664
msullivanhttps://github.com/msullivan
Mar 1, 2018https://github.com/python/mypy/pull/4652#discussion_r171437802
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4652
mypy/types.pyhttps://github.com/python/mypy/pull/4652/files/008a9a80188425d0ec00042c1933a9f9f9d4ee79#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664
msullivanhttps://github.com/msullivan
Mar 1, 2018https://github.com/python/mypy/pull/4652#discussion_r171438108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4652
JukkaLhttps://github.com/JukkaL
Mar 1, 2018https://github.com/python/mypy/pull/4652#discussion_r171521332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4652
https://github.com/JukkaL
Fix typohttps://github.com/python/mypy/pull/4652/commits/e76119711d45c9a66ff057e6797a80a5eac6d572
e761197https://github.com/python/mypy/pull/4652/commits/e76119711d45c9a66ff057e6797a80a5eac6d572
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 1, 2018https://github.com/python/mypy/pull/4652#issuecomment-369553408
Please reload this pagehttps://github.com/python/mypy/pull/4652
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
7264ae5https://github.com/python/mypy/commit/7264ae5ea58f5874ebf5471a696889c8f047c176
Mar 1, 2018https://github.com/python/mypy/pull/4652#event-1498754498
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
March 1, 2018 15:36https://github.com/python/mypy/pull/4652#event-1499271642
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Mar 2, 2018 https://github.com/python/mypy/pull/4652#ref-issue-301651987
Refreshing synthetic types causes fine-grained crash #4665 https://github.com/python/mypy/issues/4665
carljmhttps://github.com/carljm
Mar 6, 2018 https://github.com/python/mypy/pull/4652#ref-commit-8a222da
https://github.com/carljm
Merge branch 'master' into import-cyclehttps://github.com/carljm/mypy/commit/8a222da4b29743b7f89063af8dcd692c00c6d24b
8a222dahttps://github.com/carljm/mypy/commit/8a222da4b29743b7f89063af8dcd692c00c6d24b
python#4669https://github.com/python/mypy/pull/4669
python#4662https://github.com/python/mypy/pull/4662
python#4667https://github.com/python/mypy/pull/4667
python#4656https://github.com/python/mypy/pull/4656
python#4659https://github.com/python/mypy/pull/4659
python#4658https://github.com/python/mypy/pull/4658
python#4622https://github.com/python/mypy/pull/4622
python#4017https://github.com/python/mypy/pull/4017
python#4652https://github.com/python/mypy/pull/4652
python#4647https://github.com/python/mypy/pull/4647
yedpodtrzitkohttps://github.com/yedpodtrzitko
Mar 15, 2018 https://github.com/python/mypy/pull/4652#ref-commit-29139fe
https://github.com/JukkaL
https://github.com/yedpodtrzitko
Fine-grained: Fix AST merge issues (https://github.com/kiwicom/mypy/commit/29139fe68772e93e99f808cbab419615ab8c5dc7
python#4652https://github.com/python/mypy/pull/4652
)https://github.com/kiwicom/mypy/commit/29139fe68772e93e99f808cbab419615ab8c5dc7
29139fehttps://github.com/kiwicom/mypy/commit/29139fe68772e93e99f808cbab419615ab8c5dc7
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4652
https://github.com/msullivan
msullivan https://github.com/msullivan
https://github.com/python/mypy/pull/4652/files/008a9a80188425d0ec00042c1933a9f9f9d4ee79
Please reload this pagehttps://github.com/python/mypy/pull/4652
Please reload this pagehttps://github.com/python/mypy/pull/4652
https://github.com/JukkaL
https://github.com/msullivan
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.