| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3bbc413a-6c98-92ef-0d70-adfdbe11a087 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A98:2261EB:DFAAA1:122833E:6AFFED6D |
| html-safe-nonce | c3ddd6611dd55fd1319c7dc475e55a1295aa2a6ebed95884f2b268a306acd0ba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTk4OjIyNjFFQjpERkFBQTE6MTIyODMzRTo2QUZGRUQ2RCIsInZpc2l0b3JfaWQiOiI4MDA5NjAwMzk1MTcxMDY1MTk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 11f42241f290364c1989f65695bf36b56aea969216293881769a7914ba7a3d59 |
| hovercard-subject-tag | pull_request:171971490 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4652/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fdf812fce97ab152ba195bb7c4e12c5b57d34f245cd7aa61e36e71319317ed2f/python/mypy/pull/4652 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fdf812fce97ab152ba195bb7c4e12c5b57d34f245cd7aa61e36e71319317ed2f/python/mypy/pull/4652 |
| og:image:alt | This fixes all but one AST merge checker test failures. The remaining
one seems tricky to fix so I'll leave it for later.
I decided not to add tests for things that can be caught using the
merg... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JukkaL |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/4652#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4652 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4652 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/4652 |
| Reload | https://github.com/python/mypy/pull/4652 |
| Reload | https://github.com/python/mypy/pull/4652 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| master | https://github.com/python/mypy/tree/master |
| fg-merge-fixes | https://github.com/python/mypy/tree/fg-merge-fixes |
| Conversation | https://github.com/python/mypy/pull/4652 |
| Commits23 (23) | https://github.com/python/mypy/pull/4652/commits |
| Checks | https://github.com/python/mypy/pull/4652/checks |
| Files changed | https://github.com/python/mypy/pull/4652/files |
| Fine-grained: Fix AST merge issues | https://github.com/python/mypy/pull/4652#top |
| JukkaL | https://github.com/JukkaL |
| master | https://github.com/python/mypy/tree/master |
| fg-merge-fixes | https://github.com/python/mypy/tree/fg-merge-fixes |
|
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Feb 28, 2018 | https://github.com/python/mypy/pull/4652#issue-301048068 |
| Please reload this page | https://github.com/python/mypy/pull/4652 |
| JukkaL | https://github.com/JukkaL |
| February 28, 2018 10:28 | https://github.com/python/mypy/pull/4652#commits-pushed-f51cad0 |
|
| https://github.com/JukkaL |
| Merge unanalyzed_type attribute of FuncDefs | https://github.com/python/mypy/pull/4652/commits/f51cad039c8e4d59616925baa390c1bf798854ff |
| f51cad0 | https://github.com/python/mypy/pull/4652/commits/f51cad039c8e4d59616925baa390c1bf798854ff |
|
| https://github.com/JukkaL |
| Fix merge of Var info attributes inside TypeInfos | https://github.com/python/mypy/pull/4652/commits/1da9ba393c0cc4d5aa0d062d20670a958f98ad4e |
| 1da9ba3 | https://github.com/python/mypy/pull/4652/commits/1da9ba393c0cc4d5aa0d062d20670a958f98ad4e |
|
| https://github.com/JukkaL |
| Fix TypeList types in AST merge | https://github.com/python/mypy/pull/4652/commits/823445216fe93554cf5d13600a4b4e53343fa401 |
| 8234452 | https://github.com/python/mypy/pull/4652/commits/823445216fe93554cf5d13600a4b4e53343fa401 |
|
| https://github.com/JukkaL |
| Fix AST merge of TypeAliasExpr nodes | https://github.com/python/mypy/pull/4652/commits/4d51e0cbd30c7341052f39d61177d3fa90e5ee58 |
| 4d51e0c | https://github.com/python/mypy/pull/4652/commits/4d51e0cbd30c7341052f39d61177d3fa90e5ee58 |
|
| https://github.com/JukkaL |
| Fix AST merge of NewType nodes | https://github.com/python/mypy/pull/4652/commits/0f95792a2662cd5c6daea4ba301eb97153607387 |
| 0f95792 | https://github.com/python/mypy/pull/4652/commits/0f95792a2662cd5c6daea4ba301eb97153607387 |
|
| https://github.com/JukkaL |
| Fix leak of old MypyFile objects in AST merge | https://github.com/python/mypy/pull/4652/commits/49ea762c46cfc69521e81b7f68720a2c1453ee1f |
| 49ea762 | https://github.com/python/mypy/pull/4652/commits/49ea762c46cfc69521e81b7f68720a2c1453ee1f |
|
| https://github.com/JukkaL |
| Fix merge of TypeVarExpr | https://github.com/python/mypy/pull/4652/commits/c71dff952f0668bad09a310041b96e64451995c8 |
| c71dff9 | https://github.com/python/mypy/pull/4652/commits/c71dff952f0668bad09a310041b96e64451995c8 |
|
| https://github.com/JukkaL |
| Fix AST merge of newtypes | https://github.com/python/mypy/pull/4652/commits/a170a98db29294961f2c6fbdf113ee048d199aa5 |
| a170a98 | https://github.com/python/mypy/pull/4652/commits/a170a98db29294961f2c6fbdf113ee048d199aa5 |
|
| https://github.com/JukkaL |
| Fix AST merge of NamedTupleExpr | https://github.com/python/mypy/pull/4652/commits/ebf131a4a8b2e0b030ee1e8a295f848549a29583 |
| ebf131a | https://github.com/python/mypy/pull/4652/commits/ebf131a4a8b2e0b030ee1e8a295f848549a29583 |
|
| https://github.com/JukkaL |
| Fix AST traverser special case (ClassDef.analyzed) | https://github.com/python/mypy/pull/4652/commits/3d6a9c6e5dfe5cf65d072fe61a93db93cbb4d8f6 |
| 3d6a9c6 | https://github.com/python/mypy/pull/4652/commits/3d6a9c6e5dfe5cf65d072fe61a93db93cbb4d8f6 |
|
| https://github.com/JukkaL |
| Fixes to AST merge of named tuples and typed dicts | https://github.com/python/mypy/pull/4652/commits/0f4902faf3670d9e2e9b300d804f4f50769ec7ee |
| 0f4902f | https://github.com/python/mypy/pull/4652/commits/0f4902faf3670d9e2e9b300d804f4f50769ec7ee |
|
| https://github.com/JukkaL |
| Don't retain stale AST nodes in semantic analyzer | https://github.com/python/mypy/pull/4652/commits/6aa24611d8df6788d8cb7db7924daefed8bd2f2d |
| 6aa2461 | https://github.com/python/mypy/pull/4652/commits/6aa24611d8df6788d8cb7db7924daefed8bd2f2d |
|
| https://github.com/JukkaL |
| Remove no longer needed attribute blacklist items | https://github.com/python/mypy/pull/4652/commits/d97486e5e134a525e2f836bb9fd0e800456cbd04 |
| d97486e | https://github.com/python/mypy/pull/4652/commits/d97486e5e134a525e2f836bb9fd0e800456cbd04 |
|
| https://github.com/JukkaL |
| Don't collect all types in fine-grained incremental tests | https://github.com/python/mypy/pull/4652/commits/8acdf48a54f0a2d6fff4c2204aaa703959f4f7b4 |
| 8acdf48 | https://github.com/python/mypy/pull/4652/commits/8acdf48a54f0a2d6fff4c2204aaa703959f4f7b4 |
|
| https://github.com/JukkaL |
| Add another AST merge fixup | https://github.com/python/mypy/pull/4652/commits/aa98711abf558e432c71b02475e68a6f83b42a1e |
| aa98711 | https://github.com/python/mypy/pull/4652/commits/aa98711abf558e432c71b02475e68a6f83b42a1e |
|
| https://github.com/JukkaL |
| Fixes to AST merge; some refactoring | https://github.com/python/mypy/pull/4652/commits/6638d77a81d6f50d6b309d5df5eab0590c200c61 |
| 6638d77 | https://github.com/python/mypy/pull/4652/commits/6638d77a81d6f50d6b309d5df5eab0590c200c61 |
|
| https://github.com/JukkaL |
| Remove debug code | https://github.com/python/mypy/pull/4652/commits/fe7672a6c71d02ebb57ba644d3ebc3d0139b1535 |
| fe7672a | https://github.com/python/mypy/pull/4652/commits/fe7672a6c71d02ebb57ba644d3ebc3d0139b1535 |
|
| https://github.com/JukkaL |
| Fix merge test cases | https://github.com/python/mypy/pull/4652/commits/ee7afa95e5ce0db31d7dc4d708ce9476f4770f4b |
| ee7afa9 | https://github.com/python/mypy/pull/4652/commits/ee7afa95e5ce0db31d7dc4d708ce9476f4770f4b |
|
| https://github.com/JukkaL |
| Fix type check | https://github.com/python/mypy/pull/4652/commits/7cb8a90ef4113b66c9648ea16234c1dd5760e8e7 |
| 7cb8a90 | https://github.com/python/mypy/pull/4652/commits/7cb8a90ef4113b66c9648ea16234c1dd5760e8e7 |
|
| https://github.com/JukkaL |
| Remove redundant fixups | https://github.com/python/mypy/pull/4652/commits/9757374968810a5d87235ec9d1fbc6c96ce8544b |
| 9757374 | https://github.com/python/mypy/pull/4652/commits/9757374968810a5d87235ec9d1fbc6c96ce8544b |
|
| https://github.com/JukkaL |
| Merge additional TypeInfo attributes; minor refactoring | https://github.com/python/mypy/pull/4652/commits/992317803a00040c3de53d2756fa285c3efd95de |
| 9923178 | https://github.com/python/mypy/pull/4652/commits/992317803a00040c3de53d2756fa285c3efd95de |
|
| https://github.com/JukkaL |
| Fix test failure | https://github.com/python/mypy/pull/4652/commits/008a9a80188425d0ec00042c1933a9f9f9d4ee79 |
| 008a9a8 | https://github.com/python/mypy/pull/4652/commits/008a9a80188425d0ec00042c1933a9f9f9d4ee79 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| msullivan | https://github.com/msullivan |
| February 28, 2018 14:38 | https://github.com/python/mypy/pull/4652#event-1496848160 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Mar 1, 2018
| https://github.com/python/mypy/pull/4652#pullrequestreview-100289407 |
|
View reviewed changes
| https://github.com/python/mypy/pull/4652/files/008a9a80188425d0ec00042c1933a9f9f9d4ee79 |
| msullivan | https://github.com/msullivan |
| https://github.com/python/mypy/pull/4652#pullrequestreview-100289407 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4652 |
| mypy/types.py | https://github.com/python/mypy/pull/4652/files/008a9a80188425d0ec00042c1933a9f9f9d4ee79#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| msullivan | https://github.com/msullivan |
| Mar 1, 2018 | https://github.com/python/mypy/pull/4652#discussion_r171437802 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4652 |
| mypy/types.py | https://github.com/python/mypy/pull/4652/files/008a9a80188425d0ec00042c1933a9f9f9d4ee79#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| msullivan | https://github.com/msullivan |
| Mar 1, 2018 | https://github.com/python/mypy/pull/4652#discussion_r171438108 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4652 |
| JukkaL | https://github.com/JukkaL |
| Mar 1, 2018 | https://github.com/python/mypy/pull/4652#discussion_r171521332 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4652 |
|
| https://github.com/JukkaL |
| Fix typo | https://github.com/python/mypy/pull/4652/commits/e76119711d45c9a66ff057e6797a80a5eac6d572 |
| e761197 | https://github.com/python/mypy/pull/4652/commits/e76119711d45c9a66ff057e6797a80a5eac6d572 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Mar 1, 2018 | https://github.com/python/mypy/pull/4652#issuecomment-369553408 |
| Please reload this page | https://github.com/python/mypy/pull/4652 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| 7264ae5 | https://github.com/python/mypy/commit/7264ae5ea58f5874ebf5471a696889c8f047c176 |
| Mar 1, 2018 | https://github.com/python/mypy/pull/4652#event-1498754498 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| March 1, 2018 15:36 | https://github.com/python/mypy/pull/4652#event-1499271642 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Mar 2, 2018
| https://github.com/python/mypy/pull/4652#ref-issue-301651987 |
|
Refreshing synthetic types causes fine-grained crash
#4665
| https://github.com/python/mypy/issues/4665 |
| carljm | https://github.com/carljm |
|
Mar 6, 2018
| https://github.com/python/mypy/pull/4652#ref-commit-8a222da |
|
| https://github.com/carljm |
| Merge branch 'master' into import-cycle | https://github.com/carljm/mypy/commit/8a222da4b29743b7f89063af8dcd692c00c6d24b |
| 8a222da | https://github.com/carljm/mypy/commit/8a222da4b29743b7f89063af8dcd692c00c6d24b |
| python#4669 | https://github.com/python/mypy/pull/4669 |
| python#4662 | https://github.com/python/mypy/pull/4662 |
| python#4667 | https://github.com/python/mypy/pull/4667 |
| python#4656 | https://github.com/python/mypy/pull/4656 |
| python#4659 | https://github.com/python/mypy/pull/4659 |
| python#4658 | https://github.com/python/mypy/pull/4658 |
| python#4622 | https://github.com/python/mypy/pull/4622 |
| python#4017 | https://github.com/python/mypy/pull/4017 |
| python#4652 | https://github.com/python/mypy/pull/4652 |
| python#4647 | https://github.com/python/mypy/pull/4647 |
| yedpodtrzitko | https://github.com/yedpodtrzitko |
|
Mar 15, 2018
| https://github.com/python/mypy/pull/4652#ref-commit-29139fe |
|
| https://github.com/JukkaL |
|
| https://github.com/yedpodtrzitko |
| Fine-grained: Fix AST merge issues ( | https://github.com/kiwicom/mypy/commit/29139fe68772e93e99f808cbab419615ab8c5dc7 |
| python#4652 | https://github.com/python/mypy/pull/4652 |
| ) | https://github.com/kiwicom/mypy/commit/29139fe68772e93e99f808cbab419615ab8c5dc7 |
| 29139fe | https://github.com/kiwicom/mypy/commit/29139fe68772e93e99f808cbab419615ab8c5dc7 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4652 |
|
| https://github.com/msullivan |
|
msullivan
| https://github.com/msullivan |
|
| https://github.com/python/mypy/pull/4652/files/008a9a80188425d0ec00042c1933a9f9f9d4ee79 |
| Please reload this page | https://github.com/python/mypy/pull/4652 |
| Please reload this page | https://github.com/python/mypy/pull/4652 |
|
| https://github.com/JukkaL |
|
| https://github.com/msullivan |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |