| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:67d52c7e-e90a-430a-c7a0-522806ab3e2e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ABB2:30E5B0:32D9829:4354ABE:6B00355C |
| html-safe-nonce | 440ca7d27fa5676397c4d0278a55b2555d78ab1e297db6630a26b67eb070a0b1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkIyOjMwRTVCMDozMkQ5ODI5OjQzNTRBQkU6NkIwMDM1NUMiLCJ2aXNpdG9yX2lkIjoiMzU0NjU2NTcwNzQxNDEyMzg2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | abcb49cf9780ffe1545fdc2831cd37d169fd6194f394a074de5a994ca4cc6bf7 |
| hovercard-subject-tag | pull_request:170346241 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4607/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2d95114ab7e350737c346a1da4ef88663ebb6bf703a9241278130672ec6144ea/python/mypy/pull/4607 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2d95114ab7e350737c346a1da4ef88663ebb6bf703a9241278130672ec6144ea/python/mypy/pull/4607 |
| og:image:alt | My first pass at this only supported converters that were reachable
from the root. With this code the converter can be a local function
too.
Also now when we can't detect the type of the conve... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | euresti |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/4607#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4607 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4607 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/4607 |
| Reload | https://github.com/python/mypy/pull/4607 |
| Reload | https://github.com/python/mypy/pull/4607 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| euresti:fix_attr_right | https://github.com/euresti/mypy/tree/fix_attr_right |
| Conversation | https://github.com/python/mypy/pull/4607 |
| Commits3 (3) | https://github.com/python/mypy/pull/4607/commits |
| Checks | https://github.com/python/mypy/pull/4607/checks |
| Files changed | https://github.com/python/mypy/pull/4607/files |
| Better support for converter in attrs plugin. | https://github.com/python/mypy/pull/4607#top |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| euresti:fix_attr_right | https://github.com/euresti/mypy/tree/fix_attr_right |
|
| https://github.com/euresti |
| euresti | https://github.com/euresti |
| Feb 21, 2018 | https://github.com/python/mypy/pull/4607#issue-298798787 |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| #4583 | https://github.com/python/mypy/pull/4583 |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| euresti | https://github.com/euresti |
| February 16, 2018 16:14 | https://github.com/python/mypy/pull/4607#commits-pushed-cb16545 |
|
| https://github.com/euresti |
| Fix crash in attrs_plugin when using a converter | https://github.com/python/mypy/pull/4607/commits/cb1654555f7484148c0da5e0240636981cf98bee |
| cb16545 | https://github.com/python/mypy/pull/4607/commits/cb1654555f7484148c0da5e0240636981cf98bee |
|
| https://github.com/euresti |
| Better support for converter in attrs plugin. | https://github.com/python/mypy/pull/4607/commits/632107374beb708a5d4df90066678c91f5d7eee8 |
| 6321073 | https://github.com/python/mypy/pull/4607/commits/632107374beb708a5d4df90066678c91f5d7eee8 |
|
| https://github.com/euresti |
| Merge branch 'master' into fix_attr_right | https://github.com/python/mypy/pull/4607/commits/e226f3e01f46f2e013ee386f46e017297c423d47 |
| e226f3e | https://github.com/python/mypy/pull/4607/commits/e226f3e01f46f2e013ee386f46e017297c423d47 |
| https://github.com/euresti |
| euresti | https://github.com/euresti |
|
Feb 23, 2018
| https://github.com/python/mypy/pull/4607#ref-pullrequest-297958288 |
|
Fix crash in attrs_plugin when using a converter
#4583
| https://github.com/python/mypy/pull/4583 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| f384df8 | https://github.com/python/mypy/commit/f384df8a56b319a50d60ae31ba8159c2ae3ababe |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#event-1489635992 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Feb 23, 2018
| https://github.com/python/mypy/pull/4607#pullrequestreview-98993585 |
|
View reviewed changes
| https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/4607#pullrequestreview-98993585 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| mypy/plugin.py | https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-6d2a87e2b0fdefc2766ed8e178d16253286bc574ee6798df140f081941bc5746 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170318120 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| mypy/plugins/attrs.py | https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-c06d82e1af489188cdaa58e70e6460a858e2d4a993281e440a0c581947d69d81 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170318932 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| mypy/plugins/attrs.py | https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-c06d82e1af489188cdaa58e70e6460a858e2d4a993281e440a0c581947d69d81 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170318999 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| test-data/unit/check-attr.test | https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-0a3b87cb7639d25b0ecf82a84593a30120970e9db3a5fc209b5ab6f678f79786 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170322940 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| euresti | https://github.com/euresti |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170333971 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170335757 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| test-data/unit/check-incremental.test | https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-9d27bf05ef2e69475128ad073eb20b12cd347361fef9982761aa1776ed1964a8 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170323490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| euresti | https://github.com/euresti |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170332261 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170336297 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| test-data/unit/check-incremental.test | https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-9d27bf05ef2e69475128ad073eb20b12cd347361fef9982761aa1776ed1964a8 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170324690 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| euresti | https://github.com/euresti |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#discussion_r170333779 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 23, 2018 | https://github.com/python/mypy/pull/4607#issuecomment-368092993 |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Feb 23, 2018
| https://github.com/python/mypy/pull/4607#ref-commit-d0adb05 |
|
| https://github.com/ilevkivskyi |
| Revert "Better support for converter in attrs plugin. ( | https://github.com/python/mypy/commit/d0adb05b5f1884f09e9454643abe549dda303469 |
| #4607 | https://github.com/python/mypy/pull/4607 |
| )" | https://github.com/python/mypy/commit/d0adb05b5f1884f09e9454643abe549dda303469 |
| d0adb05 | https://github.com/python/mypy/commit/d0adb05b5f1884f09e9454643abe549dda303469 |
| f384df8 | https://github.com/python/mypy/commit/f384df8a56b319a50d60ae31ba8159c2ae3ababe |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Feb 23, 2018
| https://github.com/python/mypy/pull/4607#ref-pullrequest-299803021 |
|
Revert "Better support for converter in attrs plugin."
#4627
| https://github.com/python/mypy/pull/4627 |
| https://github.com/euresti |
| euresti | https://github.com/euresti |
|
Feb 23, 2018
| https://github.com/python/mypy/pull/4607#ref-pullrequest-299820194 |
|
Fix issues with attr code.
#4628
| https://github.com/python/mypy/pull/4628 |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Feb 23, 2018
| https://github.com/python/mypy/pull/4607#ref-commit-029b6e5 |
|
| https://github.com/euresti |
|
| https://github.com/ilevkivskyi |
| Fix issues with attr code. ( | https://github.com/python/mypy/commit/029b6e5148b4c4c50b2d977e03c7e0852134b26c |
| #4628 | https://github.com/python/mypy/pull/4628 |
| ) | https://github.com/python/mypy/commit/029b6e5148b4c4c50b2d977e03c7e0852134b26c |
| 029b6e5 | https://github.com/python/mypy/commit/029b6e5148b4c4c50b2d977e03c7e0852134b26c |
| #4607 | https://github.com/python/mypy/pull/4607 |
| carljm | https://github.com/carljm |
|
Feb 28, 2018
| https://github.com/python/mypy/pull/4607#ref-commit-2a37e80 |
|
| https://github.com/carljm |
| Merge branch 'master' into import-cycle | https://github.com/carljm/mypy/commit/2a37e80f4ce52e3ef8253089371c823ac392b4b9 |
| 2a37e80 | https://github.com/carljm/mypy/commit/2a37e80f4ce52e3ef8253089371c823ac392b4b9 |
| python#4642 | https://github.com/python/mypy/pull/4642 |
| python#4641 | https://github.com/python/mypy/pull/4641 |
| python#4611 | https://github.com/python/mypy/pull/4611 |
| python#4634 | https://github.com/python/mypy/pull/4634 |
| python#3765 | https://github.com/python/mypy/pull/3765 |
| python#4632 | https://github.com/python/mypy/pull/4632 |
| python#3790 | https://github.com/python/mypy/pull/3790 |
| python#4631 | https://github.com/python/mypy/pull/4631 |
| python#4629 | https://github.com/python/mypy/pull/4629 |
| python#4628 | https://github.com/python/mypy/pull/4628 |
| python#4607 | https://github.com/python/mypy/pull/4607 |
| python#4626 | https://github.com/python/mypy/pull/4626 |
| python#4525 | https://github.com/python/mypy/pull/4525 |
| python#4613 | https://github.com/python/mypy/pull/4613 |
| python#4585 | https://github.com/python/mypy/pull/4585 |
| python#4605 | https://github.com/python/mypy/pull/4605 |
| python#4553 | https://github.com/python/mypy/pull/4553 |
| python#4598 | https://github.com/python/mypy/pull/4598 |
| python#4486 | https://github.com/python/mypy/pull/4486 |
| yedpodtrzitko | https://github.com/yedpodtrzitko |
|
Mar 15, 2018
| https://github.com/python/mypy/pull/4607#ref-commit-e27f014 |
|
| https://github.com/euresti |
|
| https://github.com/yedpodtrzitko |
| Better support for converter in attrs plugin. ( | https://github.com/kiwicom/mypy/commit/e27f014e0642029436464e7e190ebda0f98974d7 |
| python#4607 | https://github.com/python/mypy/pull/4607 |
| ) | https://github.com/kiwicom/mypy/commit/e27f014e0642029436464e7e190ebda0f98974d7 |
| e27f014 | https://github.com/kiwicom/mypy/commit/e27f014e0642029436464e7e190ebda0f98974d7 |
| python#4583 | https://github.com/python/mypy/pull/4583 |
| yedpodtrzitko | https://github.com/yedpodtrzitko |
|
Mar 15, 2018
| https://github.com/python/mypy/pull/4607#ref-commit-08aeea9 |
|
| https://github.com/euresti |
|
| https://github.com/yedpodtrzitko |
| Fix issues with attr code. ( | https://github.com/kiwicom/mypy/commit/08aeea9dc704491dd7d0ebb8e425251f532ce03c |
| python#4628 | https://github.com/python/mypy/pull/4628 |
| ) | https://github.com/kiwicom/mypy/commit/08aeea9dc704491dd7d0ebb8e425251f532ce03c |
| 08aeea9 | https://github.com/kiwicom/mypy/commit/08aeea9dc704491dd7d0ebb8e425251f532ce03c |
| python#4607 | https://github.com/python/mypy/pull/4607 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4607 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47 |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
| Please reload this page | https://github.com/python/mypy/pull/4607 |
|
| https://github.com/euresti |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |