René's URL Explorer Experiment


Title: Better support for converter in attrs plugin. by euresti · Pull Request #4607 · python/mypy · GitHub

Open Graph Title: Better support for converter in attrs plugin. by euresti · Pull Request #4607 · python/mypy

X Title: Better support for converter in attrs plugin. by euresti · Pull Request #4607 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: My first pass at this only supported converters that were reachable from the root. With this code the converter can be a local function too. Also now when we can't detect the type of the conve...

X Description: My first pass at this only supported converters that were reachable from the root. With this code the converter can be a local function too. Also now when we can't detect the type of the c...

Opengraph URL: https://github.com/python/mypy/pull/4607

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:67d52c7e-e90a-430a-c7a0-522806ab3e2e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABB2:30E5B0:32D9829:4354ABE:6B00355C
html-safe-nonce440ca7d27fa5676397c4d0278a55b2555d78ab1e297db6630a26b67eb070a0b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkIyOjMwRTVCMDozMkQ5ODI5OjQzNTRBQkU6NkIwMDM1NUMiLCJ2aXNpdG9yX2lkIjoiMzU0NjU2NTcwNzQxNDEyMzg2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacabcb49cf9780ffe1545fdc2831cd37d169fd6194f394a074de5a994ca4cc6bf7
hovercard-subject-tagpull_request:170346241
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4607/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d95114ab7e350737c346a1da4ef88663ebb6bf703a9241278130672ec6144ea/python/mypy/pull/4607
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d95114ab7e350737c346a1da4ef88663ebb6bf703a9241278130672ec6144ea/python/mypy/pull/4607
og:image:altMy first pass at this only supported converters that were reachable from the root. With this code the converter can be a local function too. Also now when we can't detect the type of the conve...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeuresti
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/4607#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4607
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4607
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/4607
Reloadhttps://github.com/python/mypy/pull/4607
Reloadhttps://github.com/python/mypy/pull/4607
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
euresti:fix_attr_righthttps://github.com/euresti/mypy/tree/fix_attr_right
Conversationhttps://github.com/python/mypy/pull/4607
Commits3 (3)https://github.com/python/mypy/pull/4607/commits
Checkshttps://github.com/python/mypy/pull/4607/checks
Files changedhttps://github.com/python/mypy/pull/4607/files
Better support for converter in attrs plugin.https://github.com/python/mypy/pull/4607#top
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
euresti:fix_attr_righthttps://github.com/euresti/mypy/tree/fix_attr_right
https://github.com/euresti
eurestihttps://github.com/euresti
Feb 21, 2018https://github.com/python/mypy/pull/4607#issue-298798787
Please reload this pagehttps://github.com/python/mypy/pull/4607
#4583https://github.com/python/mypy/pull/4583
Please reload this pagehttps://github.com/python/mypy/pull/4607
eurestihttps://github.com/euresti
February 16, 2018 16:14https://github.com/python/mypy/pull/4607#commits-pushed-cb16545
https://github.com/euresti
Fix crash in attrs_plugin when using a converterhttps://github.com/python/mypy/pull/4607/commits/cb1654555f7484148c0da5e0240636981cf98bee
cb16545https://github.com/python/mypy/pull/4607/commits/cb1654555f7484148c0da5e0240636981cf98bee
https://github.com/euresti
Better support for converter in attrs plugin.https://github.com/python/mypy/pull/4607/commits/632107374beb708a5d4df90066678c91f5d7eee8
6321073https://github.com/python/mypy/pull/4607/commits/632107374beb708a5d4df90066678c91f5d7eee8
https://github.com/euresti
Merge branch 'master' into fix_attr_righthttps://github.com/python/mypy/pull/4607/commits/e226f3e01f46f2e013ee386f46e017297c423d47
e226f3ehttps://github.com/python/mypy/pull/4607/commits/e226f3e01f46f2e013ee386f46e017297c423d47
https://github.com/euresti
eurestihttps://github.com/euresti
Feb 23, 2018 https://github.com/python/mypy/pull/4607#ref-pullrequest-297958288
Fix crash in attrs_plugin when using a converter #4583 https://github.com/python/mypy/pull/4583
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
f384df8https://github.com/python/mypy/commit/f384df8a56b319a50d60ae31ba8159c2ae3ababe
Feb 23, 2018https://github.com/python/mypy/pull/4607#event-1489635992
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018 https://github.com/python/mypy/pull/4607#pullrequestreview-98993585
View reviewed changes https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/4607#pullrequestreview-98993585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
mypy/plugin.pyhttps://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-6d2a87e2b0fdefc2766ed8e178d16253286bc574ee6798df140f081941bc5746
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170318120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
mypy/plugins/attrs.pyhttps://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-c06d82e1af489188cdaa58e70e6460a858e2d4a993281e440a0c581947d69d81
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170318932
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
mypy/plugins/attrs.pyhttps://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-c06d82e1af489188cdaa58e70e6460a858e2d4a993281e440a0c581947d69d81
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170318999
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
test-data/unit/check-attr.testhttps://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-0a3b87cb7639d25b0ecf82a84593a30120970e9db3a5fc209b5ab6f678f79786
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170322940
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
eurestihttps://github.com/euresti
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170333971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170335757
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
test-data/unit/check-incremental.testhttps://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-9d27bf05ef2e69475128ad073eb20b12cd347361fef9982761aa1776ed1964a8
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170323490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
eurestihttps://github.com/euresti
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170332261
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170336297
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
test-data/unit/check-incremental.testhttps://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47#diff-9d27bf05ef2e69475128ad073eb20b12cd347361fef9982761aa1776ed1964a8
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170324690
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
eurestihttps://github.com/euresti
Feb 23, 2018https://github.com/python/mypy/pull/4607#discussion_r170333779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4607
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018https://github.com/python/mypy/pull/4607#issuecomment-368092993
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/4607
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018 https://github.com/python/mypy/pull/4607#ref-commit-d0adb05
https://github.com/ilevkivskyi
Revert "Better support for converter in attrs plugin. (https://github.com/python/mypy/commit/d0adb05b5f1884f09e9454643abe549dda303469
#4607https://github.com/python/mypy/pull/4607
)"https://github.com/python/mypy/commit/d0adb05b5f1884f09e9454643abe549dda303469
d0adb05https://github.com/python/mypy/commit/d0adb05b5f1884f09e9454643abe549dda303469
f384df8https://github.com/python/mypy/commit/f384df8a56b319a50d60ae31ba8159c2ae3ababe
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018 https://github.com/python/mypy/pull/4607#ref-pullrequest-299803021
Revert "Better support for converter in attrs plugin." #4627 https://github.com/python/mypy/pull/4627
https://github.com/euresti
eurestihttps://github.com/euresti
Feb 23, 2018 https://github.com/python/mypy/pull/4607#ref-pullrequest-299820194
Fix issues with attr code. #4628 https://github.com/python/mypy/pull/4628
ilevkivskyihttps://github.com/ilevkivskyi
Feb 23, 2018 https://github.com/python/mypy/pull/4607#ref-commit-029b6e5
https://github.com/euresti
https://github.com/ilevkivskyi
Fix issues with attr code. (https://github.com/python/mypy/commit/029b6e5148b4c4c50b2d977e03c7e0852134b26c
#4628https://github.com/python/mypy/pull/4628
)https://github.com/python/mypy/commit/029b6e5148b4c4c50b2d977e03c7e0852134b26c
029b6e5https://github.com/python/mypy/commit/029b6e5148b4c4c50b2d977e03c7e0852134b26c
#4607https://github.com/python/mypy/pull/4607
carljmhttps://github.com/carljm
Feb 28, 2018 https://github.com/python/mypy/pull/4607#ref-commit-2a37e80
https://github.com/carljm
Merge branch 'master' into import-cyclehttps://github.com/carljm/mypy/commit/2a37e80f4ce52e3ef8253089371c823ac392b4b9
2a37e80https://github.com/carljm/mypy/commit/2a37e80f4ce52e3ef8253089371c823ac392b4b9
python#4642https://github.com/python/mypy/pull/4642
python#4641https://github.com/python/mypy/pull/4641
python#4611https://github.com/python/mypy/pull/4611
python#4634https://github.com/python/mypy/pull/4634
python#3765https://github.com/python/mypy/pull/3765
python#4632https://github.com/python/mypy/pull/4632
python#3790https://github.com/python/mypy/pull/3790
python#4631https://github.com/python/mypy/pull/4631
python#4629https://github.com/python/mypy/pull/4629
python#4628https://github.com/python/mypy/pull/4628
python#4607https://github.com/python/mypy/pull/4607
python#4626https://github.com/python/mypy/pull/4626
python#4525https://github.com/python/mypy/pull/4525
python#4613https://github.com/python/mypy/pull/4613
python#4585https://github.com/python/mypy/pull/4585
python#4605https://github.com/python/mypy/pull/4605
python#4553https://github.com/python/mypy/pull/4553
python#4598https://github.com/python/mypy/pull/4598
python#4486https://github.com/python/mypy/pull/4486
yedpodtrzitkohttps://github.com/yedpodtrzitko
Mar 15, 2018 https://github.com/python/mypy/pull/4607#ref-commit-e27f014
https://github.com/euresti
https://github.com/yedpodtrzitko
Better support for converter in attrs plugin. (https://github.com/kiwicom/mypy/commit/e27f014e0642029436464e7e190ebda0f98974d7
python#4607https://github.com/python/mypy/pull/4607
)https://github.com/kiwicom/mypy/commit/e27f014e0642029436464e7e190ebda0f98974d7
e27f014https://github.com/kiwicom/mypy/commit/e27f014e0642029436464e7e190ebda0f98974d7
python#4583https://github.com/python/mypy/pull/4583
yedpodtrzitkohttps://github.com/yedpodtrzitko
Mar 15, 2018 https://github.com/python/mypy/pull/4607#ref-commit-08aeea9
https://github.com/euresti
https://github.com/yedpodtrzitko
Fix issues with attr code. (https://github.com/kiwicom/mypy/commit/08aeea9dc704491dd7d0ebb8e425251f532ce03c
python#4628https://github.com/python/mypy/pull/4628
)https://github.com/kiwicom/mypy/commit/08aeea9dc704491dd7d0ebb8e425251f532ce03c
08aeea9https://github.com/kiwicom/mypy/commit/08aeea9dc704491dd7d0ebb8e425251f532ce03c
python#4607https://github.com/python/mypy/pull/4607
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4607
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/4607/files/e226f3e01f46f2e013ee386f46e017297c423d47
Please reload this pagehttps://github.com/python/mypy/pull/4607
Please reload this pagehttps://github.com/python/mypy/pull/4607
https://github.com/euresti
https://github.com/ilevkivskyi
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.