René's URL Explorer Experiment


Title: Fine-grained: Don't infer partial types from multiple targets by JukkaL · Pull Request #4553 · python/mypy · GitHub

Open Graph Title: Fine-grained: Don't infer partial types from multiple targets by JukkaL · Pull Request #4553 · python/mypy

X Title: Fine-grained: Don't infer partial types from multiple targets by JukkaL · Pull Request #4553 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Previously if partial types were inferred from assignments in multiple scopes, like in the example below, fine-grained incremental mode could display bogus messages, since only one of the scopes co...

X Description: Previously if partial types were inferred from assignments in multiple scopes, like in the example below, fine-grained incremental mode could display bogus messages, since only one of the scopes co...

Opengraph URL: https://github.com/python/mypy/pull/4553

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d24c5416-5f00-bcda-427f-14fb9c27825c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECBE:3430F7:B6D17C:F509A7:6B004B0D
html-safe-nonce7692170d5d87679ceeac14aec5dd9636e5f0af42a0bf2990389c5e3352cb65f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0JFOjM0MzBGNzpCNkQxN0M6RjUwOUE3OjZCMDA0QjBEIiwidmlzaXRvcl9pZCI6IjM4MjQ1OTQ4NzA1MTc5MTAyODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac62ed82de557d0737cbea79f17b07a4b817571bc4acea8aa0720c2886767bd158
hovercard-subject-tagpull_request:168005485
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4553/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ff3035b7de6804bce3e521e28fbf515736042e98df479f33c66c0a1202c9c1a4/python/mypy/pull/4553
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ff3035b7de6804bce3e521e28fbf515736042e98df479f33c66c0a1202c9c1a4/python/mypy/pull/4553
og:image:altPreviously if partial types were inferred from assignments in multiple scopes, like in the example below, fine-grained incremental mode could display bogus messages, since only one of the scopes co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJukkaL
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/4553#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4553
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4553
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/4553
Reloadhttps://github.com/python/mypy/pull/4553
Reloadhttps://github.com/python/mypy/pull/4553
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
fine-grained-partial-scopehttps://github.com/python/mypy/tree/fine-grained-partial-scope
Conversationhttps://github.com/python/mypy/pull/4553
Commits13 (13)https://github.com/python/mypy/pull/4553/commits
Checkshttps://github.com/python/mypy/pull/4553/checks
Files changedhttps://github.com/python/mypy/pull/4553/files
Fine-grained: Don't infer partial types from multiple targetshttps://github.com/python/mypy/pull/4553#top
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
fine-grained-partial-scopehttps://github.com/python/mypy/tree/fine-grained-partial-scope
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Feb 8, 2018https://github.com/python/mypy/pull/4553#issue-295556973
#4492https://github.com/python/mypy/issues/4492
Please reload this pagehttps://github.com/python/mypy/pull/4553
JukkaLhttps://github.com/JukkaL
February 8, 2018 15:26https://github.com/python/mypy/pull/4553#commits-pushed-0c58fef
https://github.com/JukkaL
Initial implementation of requiring "local" partial typeshttps://github.com/python/mypy/pull/4553/commits/0c58fefb93b7b3ad565507dbe41e7142ecf69ac5
0c58fefhttps://github.com/python/mypy/pull/4553/commits/0c58fefb93b7b3ad565507dbe41e7142ecf69ac5
https://github.com/JukkaL
Hide local partial types behind an optionhttps://github.com/python/mypy/pull/4553/commits/3e62fdec23533484d95f35582c1ee77fb5048f27
3e62fdehttps://github.com/python/mypy/pull/4553/commits/3e62fdec23533484d95f35582c1ee77fb5048f27
https://github.com/JukkaL
Set local_partial_types correctlyhttps://github.com/python/mypy/pull/4553/commits/9059894a3debf95173c5a78f4cf5e21bc15490a7
9059894https://github.com/python/mypy/pull/4553/commits/9059894a3debf95173c5a78f4cf5e21bc15490a7
https://github.com/JukkaL
Some refactoringhttps://github.com/python/mypy/pull/4553/commits/9d242db7d8fbd2f1f3f115f9a3d6aec9978594fc
9d242dbhttps://github.com/python/mypy/pull/4553/commits/9d242db7d8fbd2f1f3f115f9a3d6aec9978594fc
https://github.com/JukkaL
Add two failing test caseshttps://github.com/python/mypy/pull/4553/commits/20a5c54a71613d78e13884e25fa3e7407a46ce8d
20a5c54https://github.com/python/mypy/pull/4553/commits/20a5c54a71613d78e13884e25fa3e7407a46ce8d
https://github.com/JukkaL
Fix special caseshttps://github.com/python/mypy/pull/4553/commits/07599a8c9f898e5b01ef2fae708421cfa6d93134
07599a8https://github.com/python/mypy/pull/4553/commits/07599a8c9f898e5b01ef2fae708421cfa6d93134
https://github.com/JukkaL
Fix crashhttps://github.com/python/mypy/pull/4553/commits/3f57aae4e45e2ebaa14c7bc9f1e9e6a48465dabd
3f57aaehttps://github.com/python/mypy/pull/4553/commits/3f57aae4e45e2ebaa14c7bc9f1e9e6a48465dabd
https://github.com/JukkaL
Avoid generating multiple messages from a single errorhttps://github.com/python/mypy/pull/4553/commits/3cc3ce4ac1dc05cc2414a388298f1d954a19460e
3cc3ce4https://github.com/python/mypy/pull/4553/commits/3cc3ce4ac1dc05cc2414a388298f1d954a19460e
https://github.com/JukkaL
Minor tweakshttps://github.com/python/mypy/pull/4553/commits/b165730fc71080504f5821d8b095dc300ec0cdbd
b165730https://github.com/python/mypy/pull/4553/commits/b165730fc71080504f5821d8b095dc300ec0cdbd
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Feb 8, 2018https://github.com/python/mypy/pull/4553#issuecomment-364149441
Please reload this pagehttps://github.com/python/mypy/pull/4553
JukkaLhttps://github.com/JukkaL
February 8, 2018 16:33https://github.com/python/mypy/pull/4553#commits-pushed-bf0a9a1
https://github.com/JukkaL
Add test caseshttps://github.com/python/mypy/pull/4553/commits/bf0a9a1dcae73061eb148fed31c30e42af5bcc96
bf0a9a1https://github.com/python/mypy/pull/4553/commits/bf0a9a1dcae73061eb148fed31c30e42af5bcc96
https://github.com/JukkaL
Minor test updateshttps://github.com/python/mypy/pull/4553/commits/1763a8c398544199515483790928c9bfde10e21b
1763a8chttps://github.com/python/mypy/pull/4553/commits/1763a8c398544199515483790928c9bfde10e21b
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 9, 2018 https://github.com/python/mypy/pull/4553#pullrequestreview-95468367
View reviewed changes https://github.com/python/mypy/pull/4553/files/1763a8c398544199515483790928c9bfde10e21b
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/4553#pullrequestreview-95468367
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
mypy/checker.pyhttps://github.com/python/mypy/pull/4553/files/1763a8c398544199515483790928c9bfde10e21b#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Feb 9, 2018https://github.com/python/mypy/pull/4553#discussion_r167267766
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
JukkaLhttps://github.com/JukkaL
Feb 19, 2018https://github.com/python/mypy/pull/4553#discussion_r169144003
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
ilevkivskyihttps://github.com/ilevkivskyi
Feb 19, 2018https://github.com/python/mypy/pull/4553#discussion_r169150944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
JukkaLhttps://github.com/JukkaL
Feb 20, 2018https://github.com/python/mypy/pull/4553#discussion_r169321128
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
ilevkivskyihttps://github.com/ilevkivskyi
Feb 20, 2018https://github.com/python/mypy/pull/4553#discussion_r169371322
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
mypy/checker.pyhttps://github.com/python/mypy/pull/4553/files/1763a8c398544199515483790928c9bfde10e21b#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Feb 9, 2018https://github.com/python/mypy/pull/4553#discussion_r167268150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
mypy/checker.pyhttps://github.com/python/mypy/pull/4553/files/1763a8c398544199515483790928c9bfde10e21b#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Feb 9, 2018https://github.com/python/mypy/pull/4553#discussion_r167270108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
test-data/unit/check-inference.testhttps://github.com/python/mypy/pull/4553/files/1763a8c398544199515483790928c9bfde10e21b#diff-c3eb296f041ab0dfaba0e8ea5cf200d63c2de36b8b57da835294af221ff0de5a
ilevkivskyihttps://github.com/ilevkivskyi
Feb 9, 2018https://github.com/python/mypy/pull/4553#discussion_r167274535
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
JukkaLhttps://github.com/JukkaL
Feb 19, 2018https://github.com/python/mypy/pull/4553#discussion_r169144020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
test-data/unit/fine-grained.testhttps://github.com/python/mypy/pull/4553/files/1763a8c398544199515483790928c9bfde10e21b#diff-e165eb7aed9dca0a5ebd93985c8cd263a6462d36ac185f9461348dc5a1396d76
ilevkivskyihttps://github.com/ilevkivskyi
Feb 9, 2018https://github.com/python/mypy/pull/4553#discussion_r167276568
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
JukkaLhttps://github.com/JukkaL
Feb 19, 2018https://github.com/python/mypy/pull/4553#discussion_r169144071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/4553
JukkaLhttps://github.com/JukkaL
February 19, 2018 12:08https://github.com/python/mypy/pull/4553#commits-pushed-681f1df
https://github.com/JukkaL
Merge branch 'master' into fine-grained-partial-scopehttps://github.com/python/mypy/pull/4553/commits/681f1df369aded28e314532af83e9fc37d5aefb0
681f1dfhttps://github.com/python/mypy/pull/4553/commits/681f1df369aded28e314532af83e9fc37d5aefb0
https://github.com/JukkaL
Update based on feedbackhttps://github.com/python/mypy/pull/4553/commits/3f3e4f06cd3cce12032cb6c8e62de7a65afc12f1
3f3e4f0https://github.com/python/mypy/pull/4553/commits/3f3e4f06cd3cce12032cb6c8e62de7a65afc12f1
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Feb 20, 2018https://github.com/python/mypy/pull/4553#issuecomment-366981262
Please reload this pagehttps://github.com/python/mypy/pull/4553
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 20, 2018 https://github.com/python/mypy/pull/4553#pullrequestreview-97886720
View reviewed changes https://github.com/python/mypy/pull/4553/files/3f3e4f06cd3cce12032cb6c8e62de7a65afc12f1
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
0c12b21https://github.com/python/mypy/commit/0c12b21e9e9280710a258e04b14ac04e1d96d564
Feb 20, 2018https://github.com/python/mypy/pull/4553#event-1482945457
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
February 21, 2018 16:16https://github.com/python/mypy/pull/4553#event-1485038182
carljmhttps://github.com/carljm
Feb 28, 2018 https://github.com/python/mypy/pull/4553#ref-commit-2a37e80
https://github.com/carljm
Merge branch 'master' into import-cyclehttps://github.com/carljm/mypy/commit/2a37e80f4ce52e3ef8253089371c823ac392b4b9
2a37e80https://github.com/carljm/mypy/commit/2a37e80f4ce52e3ef8253089371c823ac392b4b9
python#4642https://github.com/python/mypy/pull/4642
python#4641https://github.com/python/mypy/pull/4641
python#4611https://github.com/python/mypy/pull/4611
python#4634https://github.com/python/mypy/pull/4634
python#3765https://github.com/python/mypy/pull/3765
python#4632https://github.com/python/mypy/pull/4632
python#3790https://github.com/python/mypy/pull/3790
python#4631https://github.com/python/mypy/pull/4631
python#4629https://github.com/python/mypy/pull/4629
python#4628https://github.com/python/mypy/pull/4628
python#4607https://github.com/python/mypy/pull/4607
python#4626https://github.com/python/mypy/pull/4626
python#4525https://github.com/python/mypy/pull/4525
python#4613https://github.com/python/mypy/pull/4613
python#4585https://github.com/python/mypy/pull/4585
python#4605https://github.com/python/mypy/pull/4605
python#4553https://github.com/python/mypy/pull/4553
python#4598https://github.com/python/mypy/pull/4598
python#4486https://github.com/python/mypy/pull/4486
Suggest type annotations for partial types spanning multiple scopes #4703 https://github.com/python/mypy/issues/4703
What to do about inferring types from multiple scopes? #4492 https://github.com/python/mypy/issues/4492
yedpodtrzitkohttps://github.com/yedpodtrzitko
Mar 15, 2018 https://github.com/python/mypy/pull/4553#ref-commit-10686dd
https://github.com/JukkaL
https://github.com/yedpodtrzitko
Fine-grained: Don't infer partial types from multiple targets (https://github.com/kiwicom/mypy/commit/10686ddb7dece205898d09dd98aa980818e84d8e
python…https://github.com/python/mypy/pull/4553
10686ddhttps://github.com/kiwicom/mypy/commit/10686ddb7dece205898d09dd98aa980818e84d8e
…#4553https://github.com/python/mypy/pull/4553
python#4492https://github.com/python/mypy/issues/4492
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4553
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/4553/files/3f3e4f06cd3cce12032cb6c8e62de7a65afc12f1
Please reload this pagehttps://github.com/python/mypy/pull/4553
Please reload this pagehttps://github.com/python/mypy/pull/4553
https://github.com/JukkaL
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.